Revision 89c10241
ID | 89c1024146bf56dd93f45423f9fb905794e2936a |
Parent | 401b773e |
Child | 066f16b0 |
hotplug: Call each qemu commmand with an own socat
Previously we issued one socat command with two "\n" separated
actions (e.g. netdev_add ...\ndevice_add...)
After having observed a strange monitor behavior [1] splitting
those commands and introducing a sleep time in between, may reduce
any race possibilities. Additionally it will be a step forward
parsing monitor output of each command and decide whether to
modify runtime files or raise a HotplugError.
This patch simply changes _CallHotplugCommand() to take a
list of commands and issue them separately. Introduces one second
sleep after each command and removes sleep from HotModDevice().
[1] https://groups.google.com/d/msg/ganeti-devel/hCQnmuqKtU0/UWGnw251cskJ
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Signed-off-by: Thomas Thrainer <thomasth@google.com>
Reviewed-by: Thomas Thrainer <thomasth@google.com>
Files
- added
- modified
- copied
- renamed
- deleted