root / autotools / check-python-code @ a295eb80
History | View | Annotate | Download (2.1 kB)
1 | eed5c5df | Michael Hanselmann | #!/bin/bash |
---|---|---|---|
2 | eed5c5df | Michael Hanselmann | # |
3 | eed5c5df | Michael Hanselmann | |
4 | db859c7d | Michael Hanselmann | # Copyright (C) 2009, 2011 Google Inc. |
5 | eed5c5df | Michael Hanselmann | # |
6 | eed5c5df | Michael Hanselmann | # This program is free software; you can redistribute it and/or modify |
7 | eed5c5df | Michael Hanselmann | # it under the terms of the GNU General Public License as published by |
8 | eed5c5df | Michael Hanselmann | # the Free Software Foundation; either version 2 of the License, or |
9 | eed5c5df | Michael Hanselmann | # (at your option) any later version. |
10 | eed5c5df | Michael Hanselmann | # |
11 | eed5c5df | Michael Hanselmann | # This program is distributed in the hope that it will be useful, but |
12 | eed5c5df | Michael Hanselmann | # WITHOUT ANY WARRANTY; without even the implied warranty of |
13 | eed5c5df | Michael Hanselmann | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
14 | eed5c5df | Michael Hanselmann | # General Public License for more details. |
15 | eed5c5df | Michael Hanselmann | # |
16 | eed5c5df | Michael Hanselmann | # You should have received a copy of the GNU General Public License |
17 | eed5c5df | Michael Hanselmann | # along with this program; if not, write to the Free Software |
18 | eed5c5df | Michael Hanselmann | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA |
19 | eed5c5df | Michael Hanselmann | # 02110-1301, USA. |
20 | eed5c5df | Michael Hanselmann | |
21 | bdba4757 | Michael Hanselmann | set -e |
22 | bdba4757 | Michael Hanselmann | |
23 | db859c7d | Michael Hanselmann | # Ensure the checks always use the same locale |
24 | db859c7d | Michael Hanselmann | export LC_ALL=C |
25 | db859c7d | Michael Hanselmann | |
26 | 674711de | Michael Hanselmann | readonly maxlinelen=$(for ((i=0; i<81; ++i)); do echo -n .; done) |
27 | 674711de | Michael Hanselmann | |
28 | 674711de | Michael Hanselmann | if [[ "${#maxlinelen}" != 81 ]]; then |
29 | 674711de | Michael Hanselmann | echo "Internal error: Check for line length is incorrect" >&2 |
30 | 674711de | Michael Hanselmann | exit 1 |
31 | 674711de | Michael Hanselmann | fi |
32 | 674711de | Michael Hanselmann | |
33 | bdba4757 | Michael Hanselmann | # "[...] If the last ARG evaluates to 0, let returns 1; 0 is returned |
34 | bdba4757 | Michael Hanselmann | # otherwise.", hence ignoring the return value. |
35 | bdba4757 | Michael Hanselmann | let problems=0 || : |
36 | eed5c5df | Michael Hanselmann | |
37 | eed5c5df | Michael Hanselmann | for script; do |
38 | 9648f1b4 | Michael Hanselmann | if grep -n -H -F $'\t' "$script"; then |
39 | eed5c5df | Michael Hanselmann | let ++problems |
40 | eed5c5df | Michael Hanselmann | echo "Found tabs in $script" >&2 |
41 | eed5c5df | Michael Hanselmann | fi |
42 | b757f830 | Michael Hanselmann | |
43 | 9648f1b4 | Michael Hanselmann | if grep -n -H -E '[[:space:]]$' "$script"; then |
44 | b757f830 | Michael Hanselmann | let ++problems |
45 | b757f830 | Michael Hanselmann | echo "Found end-of-line-whitespace in $script" >&2 |
46 | b757f830 | Michael Hanselmann | fi |
47 | b757f830 | Michael Hanselmann | |
48 | 11c684bf | Michael Hanselmann | # FIXME: This will also match "foo.xrange(...)" |
49 | 11c684bf | Michael Hanselmann | if grep -n -H -E '^[^#]*\<xrange\>' "$script"; then |
50 | 11c684bf | Michael Hanselmann | let ++problems |
51 | 11c684bf | Michael Hanselmann | echo "Forbidden function 'xrange' used in $script" >&2 |
52 | 11c684bf | Michael Hanselmann | fi |
53 | 11c684bf | Michael Hanselmann | |
54 | 42f539ee | Michael Hanselmann | if grep -n -H -E -i '#[[:space:]]*(vim|Local[[:space:]]+Variables):' "$script" |
55 | 42f539ee | Michael Hanselmann | then |
56 | 42f539ee | Michael Hanselmann | let ++problems |
57 | 42f539ee | Michael Hanselmann | echo "Found editor-specific settings in $script" >&2 |
58 | 42f539ee | Michael Hanselmann | fi |
59 | 42f539ee | Michael Hanselmann | |
60 | 674711de | Michael Hanselmann | if grep -n -H "^$maxlinelen" "$script"; then |
61 | eed5c5df | Michael Hanselmann | let ++problems |
62 | eed5c5df | Michael Hanselmann | echo "Longest line in $script is longer than 80 characters" >&2 |
63 | eed5c5df | Michael Hanselmann | fi |
64 | db859c7d | Michael Hanselmann | |
65 | db859c7d | Michael Hanselmann | if grep -n -H -E -i \ |
66 | db859c7d | Michael Hanselmann | '#.*\bpylint[[:space:]]*:[[:space:]]*disable-msg\b' "$script" |
67 | db859c7d | Michael Hanselmann | then |
68 | db859c7d | Michael Hanselmann | let ++problems |
69 | db859c7d | Michael Hanselmann | echo "Found old-style pylint disable pragma in $script" >&2 |
70 | db859c7d | Michael Hanselmann | fi |
71 | eed5c5df | Michael Hanselmann | done |
72 | eed5c5df | Michael Hanselmann | |
73 | eed5c5df | Michael Hanselmann | if [[ "$problems" -gt 0 ]]; then |
74 | b757f830 | Michael Hanselmann | echo "Found $problems problem(s) while checking code." >&2 |
75 | eed5c5df | Michael Hanselmann | exit 1 |
76 | eed5c5df | Michael Hanselmann | fi |