« Previous | Next » 

Revision 0745eb1e

ID0745eb1e4336bf665a911754d18ddd63794b352d

Added by Markus Armbruster over 14 years ago

Fix recently introduced bugs in -usbdevice host

Commit 26a9e82a has the following flaws:

  • It enabled DEBUG.
  • It referenced two properties by the wrong name in
    usb_host_device_open(), which crashes with "qdev_prop_set: property
    "USB Host Device.bus" not found".
  • It broke "-usbdevice host:auto:..." by calling parse_filter()
    incorrectly.
  • It broke parsing of "-usbdevice host:BUS.ADDR" and "-usbdevice
    host:VID:PRID" with a trivial pasto.
  • It broke wildcards in "-usbdevice host:auto:...". Before, the four
    filter components were stored as int, and the wildcard was encoded
    as -1. The faulty commit changed storage to uint32_t, and the
    wildcard encoding to 0. But it failed to update parse_filter()
    accordingly.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Anthony Liguori <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences