monitor: Fix do_commit() argument type
Currently do_commit() argument type is 's' (string), but itshould be 'B' (block), this way 'commit' gets command completion.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Don't redefine NULL, please
Compiled (on linux) all the targets, and it compiled as expected.What platform needs this redefinition?
Later, Juan.
Signed-off-by: Juan Quintela <quintela@redhat.com>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Fix coding style issue
Replace:
if (-1 foo())
with:
if (foo() -1)
While this coding style is not in direct contravention of our currentlyratified CODING_STYLE treaty, it could be argued that the Article 3 ofthe European Convention on Human Rights (prohibiting torture and "inhuman...
Remove PARAMS macro
Only two disassemblers (alpha and sh4) were still using it. Just remove itsuse there, and its aparations in dis-asm.h
Signed-off-by: Juan Quintela <quintela@redhat.com>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
__thread should be before real type
gcc wants 1st static and then const
Bring two last users of K&R definitions to ANSI c89
static and inline should came before the type of the functions
Use proper typedef syntax
Why this ever compiled is a mistery to me.
Revert "This files are compiled in libqemu.a now"
This reverts commit fe6549dfd76c278dbcd788b3c15c5e6e5ed32190.
tcg-runtime and host-utils are needed on 32 bit host and they are not partof libqemu.a.
Thanks to Stefan Weil for reporting.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
fix use after free
We are using the vs structure when it was just freed. Classic use after free,fix it.
Signed-off-by: Glauber Costa <glommer@redhat.com>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
unbreak usb pass-through on linux.
Changes: * Re-add the 'dev->fd = fd;' line which the qdev patches dropped by mistake. * call qdev_init() so the newly created usb device is plugged into a usb port and thus actually visible to the guest.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>...
clean: remove ide/*.o files on clean
ARM host: fix generated blocks linking
This patch fixes the linking of generated blocks on an ARM host.No need to say this brings a very nice speedup :-)
Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Fix spelling in comment
replace Convery -> Convert
Cc: Paul Brook <paul@codesourcery.com>Signed-off-by: Stefan Weil <weil@mail.berlios.de>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Suppress some variants of English in comments
Replace surpress, supress by suppress.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
sparc64-8bit-asi
Sparc64 alternate space load/store helpers expect 8 bit ASI value,while wrasi implementation sign-extends ASI operand causingfor example 0x80 to appear as 0xFFFFFF80. Resulting value fallsout of switch in helpers and causes obscure load/store faults....
exec-all.h: increase MAX_OP_PER_INSTR to 96 from 64
The x86_64 ror instruction on a 32-bit host can generate up to 77 TCGops. Some more space should be left for opc that are added at the endof the translation.
Thanks to Laurent Desnogues for the debugging help....
exec-all.h: increase OPC_BUF_SIZE
Increase OPC_BUF_SIZE to compensate the MAX_OP_PER_INSTR's increase.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
target-mips: remove MAX_OP_PER_INSTR workaround
Now that MAX_OP_PER_INSTR has been increased to a safer value, removedthe target-mips specific workaround.
This files are compiled in libqemu.a now
This fixes compilation of linux-user with today qemu, please apply.
Fix device tree compile broken by ca20cf32ab3d945155141ef737f5d08ebb373e1d
Fix Sparse warning about invalid access past the end of 'mode'
Fix Sparse warning about obsolete struct initializer
Export tables properly to avoid a Sparse warning
Add 'static' to please Sparse
Fix Sparse warnings about using plain integer as NULL pointer
Fix user targets broken by 96e132e24ee5a693069e83b6a981693588b088c1
Compile host-utils only once
See also facd2857783d58387885ad7cb1e4a8386f241738 and34005a0060c176b3025a9e7c5d064615a9f80325.
Compile TCG runtime library only once
registrs -> registers
Signed-off-by: Stefan Weil <weil@mail.berlios.de>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Compile ne2000 only once
ioports: remove unused env parameter and compile only once
The CPU state parameter is not used, remove it and adjust callers. Now wecan compile ioport.c once for all targets.
Compile msix only once
Get page size in device init.
Compile loader only once
Callers must pass ELF machine, byte swapping and symbol LSB clearinginformation to ELF loader. A.out loader needs page size information, passthat too as a parameter.
Extract prototypes to a separate file. Move loader.[ch] and elf_ops.h under hw....
Compile qemu-config only once
Compile wdt_i6300esb only once
Fix mingw32 compile
Probe for fdatasync()
PPC: make system bus parent of PCI bus
Fix indentation
ESP: convert to VMState
target-alpha: fix extlh instruction
The extlh instruction on Alpha currently doesn't work properly.It's a combination of a cut/paste bug (16 where it should be 32) as wellas a "shift by 64" bug.
Signed-off-by: Vince Weaver <vince@csl.cornell.edu>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
target-ppc: optimize slw/srw/sld/srd
Remove a temp local variable and a jump by computing a mask with shifts.
coreaudio: fix sloppy "posixification" by 1ea879e5580f63414693655fcf0328559cdce138
Signed-off-by: malc <av1474@comtv.ru>
audio: use muldiv64 where it makes sense
audio: introduce audio_pcm_hw_clip_out helper function
alsa: use audio_pcm_hw_clip_out
oss: use audio_pcm_hw_clip_out
sdlaudio: use correct function names in sdl_XXX calls
audio: internal API change
pcm_ops.run_out now takes number of live samples (which will be alwaysgreater than zero) as a second argument, every driver was callingaudio_pcm_hw_get_live_out anyway with exception of fmod which usedaudio_pcm_hw_get_live_out2 for no good reason....
audio: use correct email address
tcg: fix size of local variables in tcg_gen_bswap64_i64
t0, t1 must be 64 bit values, not 32 bit.
qemu serial: lost tx irqs (affecting FreeBSD's new uart(4) driver)
Well one problem seems to be the rx condition, ... if ((s->ier & UART_IER_RDI) && (s->lsr & UART_LSR_DR))is not enough to trigger an irq, yet still causes the followingconditions not to be checked anymore at all....
fix typo in configure --help
Signed-off-by: Andre Przywara <andre.przywara@amd.com>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
escc: fix IRQ routing, broken by 6c319c82223a1766c5d64a20051e5c6ab7b53951
The logic of Zilog makes channel B the first device and channel A thesecond one.
ide/isa: convert to qdev.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
ide/pci: convert to qdev.
With this patch applied ide drives (when attached to a pci adapter) canbe created via -device, like this:
-drive if=none,id=mydisk,file=/path/to/disk.img -device ide-drive,drive=mydisk,bus=ide.0,unit=0
Note that creating a master on ide1 doesn't work that way. That is a...
ide/pci: fix indention
ide/qdev: add ide bus.
split away drive init from ide_init2()
This allows the ide bus being initialized without drives attachedand the drives being attached and initialization later on asseparate step.
support media=cdrom for if=none
qdev/pci: add pci_create_noinit()
Like pci_create_simple() but doesn't call qdev_init(), so one canset properties before initializing the device.
mips malta: ensure that the serial ports are associated with a device
The serial ports should be present even if associated with a null deviceas some firmware wants to initialize them.
hw/serial: don't create a char device if none is specified
When creating null devices, there is no way to ensure the unicity ofthe labels. Bail out with an error message instead.
curses: save 250MB of memory
Don't call curses_resize() at the end of curses_display_init() as heightand width are not yet defined. It will be called later by code fromvl.c.
This save 250MB of memory when using -curses.
Revert "Open chr device for all serial ports"
This reverts commit 55338f1dd4648d78ee130d83a92f1059ff1f3887.
Fix breakage by f80237d45032fbc429aba3b597175fb544a11378 for ISA-less targets
Move ISA bus to HW library.
target-mips: fix single-stepping
Single-stepping branches on MIPS didn't work right, because thegeneration of EXCP_DEBUG happened after the generation of the code toexit the current TB. That is, given the code:
bne v0,v1,target nop ... target:...
Open chr device for all serial ports
Now that labels must be unique, the chr devices can't be opened anymorewithin the serial port code (in case they are not already opened invl.c), as they end up with the same label. Instead opened sonon-assigned one directly in vl.c, with a different label....
unbreak ppc/prep
Changes: * added isa bus, hooked up to the system bus. Not sure this is correct, but 'info pci' lists lists no pci-isa bridge in the machine ...). * switches the default cpu to one which actually works.
Add an ISA bus version of m48t59
Many thanks to Gerd Hoffmann for finding and fixing a bug in the initialversion.
Fix Linux task preemption on Versatile board
Recent versions of the Linux kernel will not preempt CPU-intensivetasks unless the clock used by sched_clock() works. On -M versatilepbthat's the 24MHz timer in the system controller. It's a very simpletimer, so implement it....
pflash_cfi01: Correct debug build, no functional changes.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
ne2000-isa: Do not free memory owned by qdev
alsa/oss: Remove fd transfer handlers before closing oss/alsa fd/handle
alsa: Use proper value when testing returned events in alsa_poll_handler
configure: change "found" to "find"
Change "ERROR: configure was not able to found it" to"ERROR: configure was not able to find it".
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Revert "Fix Sparc/Linux host breakage by df70204db53e3611af986f434e74a882bce190ca"
This reverts commit 91b40c5be84a478e98c0416325844a7f66d0efae.
Fix sparc.ld
Makes 91b40c5be84a478e98c0416325844a7f66d0efae unnecessary.
Acked-by: Kirill A. Shutemov <kirill@shutemov.name>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
audio: Fix typo that broke QEMU_AUDIO_ADC_TRY_POLL
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>Signed-off-by: malc <av1474@comtv.ru>
Fix Sparc/Linux host breakage by df70204db53e3611af986f434e74a882bce190ca
While i386, x86_64 and Sparc64/OpenBSD still worked afterdf70204db53e3611af986f434e74a882bce190ca, Sparc32 and Sparc64 Linux hostsbroke.
Partially revert the commit: make the restored code conditional to...
Sparc64: make system bus parent of PCI bus
x86: move a declaration to header
x86: add 'const'
oss: OSS v4 support
a. Use SNDCTL_DSP_POLICY instead of SNDCTL_DSP_SETFRAGMENTb. Add ability to open device in exclusive mode, thus bypassing vmix
oss: Simplify mmap code
i386: Drop redundant kvm_enabled test
cpu_synchronize_state already does this.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Make string arrays used to convert numbers to strings when DEBUG_EEPRO100 is enabled const.
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Fix xen build after sys-queue renaming
Add configure option to compile user targets as PIE
Build uset targers as true PIE if user want to keep qemuself-virtualizable.
v5: - Split into to patches: drop link hack and add PIE support - do not build PIE by default and drop toolchain check
v4:...
Fix text relocations in linux-user targets
There is a link hack in linux-user which produces an executable thatlooks like PIE, but always has text relocations since all object filesisn't position-independent (compiled without -fpic/-fpie). Dynamic loader...
Do not link usermode targets with libhw*.a
Usermode targets are hardware-independed.
Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>Acked-by: Juan Quintela <quintela@redhat.com>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Work around OpenSolaris sys/regset.h namespace pollution
Fix signedness warnings on OpenSolaris
Add #defines needed by OpenSolaris, fix breakage by the #defines
We need to define XOPEN_SOURCE and EXTENSIONS macros in order to getCMSG and TIOCWIN macros defined. But then _POSIX_C_SOURCE gets defined, whichis (incorrectly) used as an indicator for existence of posix_memalign() in osdep.c....
Fix OpenSolaris build breaking typos
Add 'static'
Fix a Sparse warning about redefinition of offsetof()
Fix sys-queue.h conflict for good
Problem: Our file sys-queue.h is a copy of the BSD file, but there aresome additions and it's not entirely compatible. Because of that, there havebeen conflicts with system headers on BSD systems. Some hacks have beenintroduced in the commits 15cc9235840a22c289edbe064a9b3c19c5f49896,...