Statistics
| Branch: | Revision:

root @ 0e61400c

# Date Author Comment
0e61400c 04/24/2013 11:47 am Alon Levy

ccid-card-passthru: add atr check

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
a26dfd95 04/24/2013 11:47 am Alon Levy

libcacard: change default ATR

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
693e4773 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: reuse usb.h definitions

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
c5cd7c87 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: support windows guest

By not advertising USB wakeup support (which we don't).

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
47bf53af 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: remove aborts (never triggered, but just in case)

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
7e1ac5ab 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: nicer debug messages

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
4543d43c 04/24/2013 11:47 am Alon Levy

dev-smartcard-reader: white space fixes

Signed-off-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
ad2181f2 04/24/2013 11:47 am Marc-André Lureau

libcacard: remove default libcoolkey loading

Use only the modules defined in the NSS database.

Signed-off-by: Marc-André Lureau <>
Reviewed-by: Alon Levy <>
667e0b4b 04/24/2013 11:47 am Marc-André Lureau

libcacard: remove sql: prefix

For some reason, with sql:/ prefix, the PKCS11 modules are not loaded.

This patch goes on top of Alon smartcard series.

Signed-off-by: Marc-André Lureau <>
Reviewed-by: Alon Levy <>
c9495ee9 04/24/2013 11:47 am Marc-André Lureau

libcacard: teach vscclient to use GMainLoop for portability

This version handles non-blocking sending and receiving from the
socket.

Signed-off-by: Marc-André Lureau <>
Reviewed-by: Alon Levy <>
930c8ad4 04/24/2013 11:47 am Marc-André Lureau

libcacard: vscclient to use QemuThread for portability

Signed-off-by: Marc-André Lureau <>
Reviewed-by: Alon Levy <>
a50b831a 04/24/2013 11:47 am Marc-André Lureau

libcacard: split vscclient main() from socket reading

Signed-off-by: Marc-André Lureau <>
Reviewed-by: Alon Levy <>
5354e4d2 04/24/2013 11:47 am Marc-André Lureau

libcacard: fix mingw64 cross-compilation

Compile and link with version.lo

Signed-off-by: Marc-André Lureau <>
Reviewed-by: Alon Levy <>
37746c5e 04/24/2013 11:47 am Marc-André Lureau

build-sys: must link with -fstack-protector

It is needed to give that flag to the linker as well, but latest
libtool 2.4.2 still swallows that argument, so let's pass it with
libtool -Wc argument.

qemu-1.4.0/stubs/arch-query-cpu-def.c:6: undefined reference to `__stack_chk_guard'...
d3bf825e 04/24/2013 11:47 am Marc-André Lureau

util: move socket_init() to osdep.c

vscclient needs to call socket_init() for portability.
Moving to osdep.c since it has no internal dependency.

Signed-off-by: Marc-André Lureau <>
Reviewed-by: Alon Levy <>
e2d9c5e7 04/24/2013 11:47 am Marc-André Lureau

libcacard: use system config directory for nss db on win32

It's a bit nicer to look for default database under
CSIDL_COMMON_APPDATA\pki\nss rather that /etc/pki/nss.

Signed-off-by: Marc-André Lureau <>
Reviewed-by: Alon Levy <>
da000a48 04/24/2013 11:47 am Jim Meyering

ccid: declare DEFAULT_ATR table to be "static const"

Signed-off-by: Jim Meyering <>
Reviewed-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
d18c7117 04/24/2013 11:47 am Jim Meyering

ccid: make backend_enum_table "static const" and adjust users

Signed-off-by: Jim Meyering <>
Reviewed-by: Alon Levy <>
Reviewed-by: Marc-André Lureau <>
d0ebd788 04/24/2013 11:47 am Marc-André Lureau

ccid-card-emul: do not crash if backend is not provided

Program received signal SIGSEGV, Segmentation fault.
__strcmp_sse42 () at ../sysdeps/x86_64/multiarch/strcmp-sse42.S:164
164 movdqu (%rsi), %xmm2
(gdb) bt
at /home/elmarco/320g/src/qemu/hw/ccid-card-emulated.c:477...
e2fd2115 04/24/2013 11:47 am Marc-André Lureau

libcacard: correct T0 historical bytes size

The VCARD_ATR_PREFIX macro adds a prefix of 6 characters only.

pcsc_scan was complaining before the patch:

+ Historical bytes: 56 43 41 52 44 5F 4E 53 53
ERROR! ATR is truncated: 2 byte(s) is/are missing

Signed-off-by: Marc-André Lureau <>...
bb716238 04/23/2013 06:40 pm Stefan Berger

Move TPM passthrough specific command line options to backend structure

Move the TPM passthrough specific command line options to the passthrough
backend implementation and attach them to the backend's interface structure.

Add code to tpm.c for validating the TPM command line options....
e7303c43 04/23/2013 06:37 pm KONRAD Frederic

virtio-9p: add the virtio-9p device.

Create virtio-9p-device which extends virtio-device, so it can be connected on
virtio-bus.

Signed-off-by: KONRAD Frederic <>
Message-id: ...
234a336f 04/23/2013 06:37 pm KONRAD Frederic

virtio-9p-pci: switch to the new API.

Here the virtio-9p-pci is modified for the new API. The device
virtio-9p-pci extends virtio-pci. It creates and connects a
virtio-9p-device during the init. The properties are not changed.

Signed-off-by: KONRAD Frederic <>...
e8111e50 04/23/2013 06:37 pm KONRAD Frederic

virtio-9p: cleanup: init function.

This remove old init function as it is no longer needed.

Signed-off-by: KONRAD Frederic <>
Message-id:
Signed-off-by: Anthony Liguori <>
13daf6ca 04/23/2013 06:37 pm KONRAD Frederic

virtio-9p: cleanup: QOM casts.

As the virtio-9p-pci is switched to the new API, we can use QOM casts.

Signed-off-by: KONRAD Frederic <>
Message-id:
Signed-off-by: Anthony Liguori <>
93b971c4 04/23/2013 06:37 pm Ozan Çağlayan

ui/gtk: Add Turkish translations

Signed-off-by: Ozan Çağlayan <>
Message-id:
Signed-off-by: Anthony Liguori <>
571253d4 04/23/2013 06:37 pm Ozan Çağlayan

ui/gtk: Use gtk_widget_get_window() to support both gtk2 and gtk3

This fixes build with gtk+-3.0.

Signed-off-by: Ozan Çağlayan <>
Message-id:
Signed-off-by: Anthony Liguori <>
2cfd5cc0 04/23/2013 06:33 pm Anthony Liguori

Merge remote-tracking branch 'kraxel/usb.81' into staging

  1. By Gerd Hoffmann (3) and Hans de Goede (1)
  2. Via Gerd Hoffmann
    • kraxel/usb.81:
      usb-host: raise libusbx minimum version to 1.0.13
      usb: better speed mismatch error reporting
      ehci_free_packet: Discard finished packets when the queue is halted...
7d04c2b7 04/23/2013 09:43 am Gerd Hoffmann

xhci: remove XHCIRing->base (unused)

Signed-off-by: Gerd Hoffmann <>
e449f26b 04/23/2013 09:43 am Hans de Goede

ehci_free_packet: Discard finished packets when the queue is halted

With pipelining it is possible to encounter a finished packet when cleaning
the queue due to a halt. This happens when a non stall error happens while
talking to a real device. In this case the queue on the usb-host side will...
3b7e759a 04/23/2013 09:43 am Gerd Hoffmann

usb: better speed mismatch error reporting

Report the supported speeds for device and port in the error message.
Also add the speeds to the tracepoint. And while being at it drop
the redundant error message in usb_desc_attach, usb_device_attach will
report the error anyway....
3f5cc97e 04/23/2013 09:43 am Gerd Hoffmann

usb-host: raise libusbx minimum version to 1.0.13

Allows to remove one FIXME. Makes LIBUSB_LOG_LEVEL_WARNING build errors
go away. And starting with that version libusb has a LIBUSBX_API_VERSION
define which allows to easily #ifdef version dependencies should that...
45673671 04/22/2013 07:31 pm Kevin Wolf

block: Fix build with tracing enabled

filename was still uninitialised when it's used as a parameter to a
tracing function, so let's move the initialisation. Also, commit c2ad1b0c
forgot to add a NULL check, which this patch adds while we're at it.

Signed-off-by: Kevin Wolf <>...
8e36d6ca 04/22/2013 05:30 pm Stefan Berger

tpm: Simplify creation of cancel path

Simplify the creation of the cancel path given the TPM's device path.
Given the path /dev/tpm0 build the path /sys/class/misc/tpm0/device/cancel.

Signed-off-by: Stefan Berger <>
Reviewed-by: Eric Blake <>...
56863d4f 04/22/2013 05:11 pm Peter Maydell

qtest: Handle addresses and values for {in, out}[bwl] as unsigned

Handle the addresses and values for {in,out}[bwl] as unsigned (ie
with strtoul), as per the protocol specification comment. This fixes
a test failure in test_i440fx_defaults on 32-bit hosts where the test...
888a6bc6 04/22/2013 04:52 pm Satoru Moriya

Add option to mlock qemu and guest memory

In certain scenario, latency induced by paging is significant and
memory locking is needed. Also, in the scenario with untrusted
guests, latency improvement due to mlock is desired.

This patch introduces a following new option to mlock guest and...
2b316774 04/22/2013 04:52 pm Paolo Bonzini

qemu-char: do not operate on sources from finalize callbacks

Due to a glib bug, the finalize callback is called with the GMainContext
lock held. Thus, any operation on the context from the callback will
cause recursive locking and a deadlock. This happens, for example,...
910b6368 04/22/2013 04:52 pm Paolo Bonzini

qemu-char: use consistent idiom for removing sources

Always check that the source is active, and zero the tag afterwards.

The occurrence in pty_chr_state will trigger with the next patch, the
others are just theoretical.

Signed-off-by: Paolo Bonzini <>...
85a67692 04/22/2013 04:52 pm Paolo Bonzini

qemu-char: simplify pty polling

There is no need to use a timer and pty_chr_read to detect a connected
pty. It is simpler to just call g_poll periodically and check for POLLHUP.
It is done once per second, and only if the pty is disconnected, so it
is cheap enough....
cdbf6e16 04/22/2013 04:52 pm Paolo Bonzini

qemu-char: correct return value from chr_read functions

Even if a CharDriverState's source is blocked by the front-end,
it must not be dropped. The IOWatchPoll that wraps it will take
care of adding and removing it to the main loop. Only remove
the source when the channel is closed; and in that case, make sure...
0aa09897 04/22/2013 04:47 pm Alexey Kardashevskiy

translate-all: fix compiler warning and linked error

The code did use profile_getclock() but did not include
include/qemu/timer.h where this function is defined. The patch fixes this.

Signed-off-by: Alexey Kardashevskiy <>
Message-id: ...
f1ab7a5a 04/22/2013 04:08 pm Anthony Liguori

Merge remote-tracking branch 'kwolf/for-anthony' into staging

  1. By Kevin Wolf (16) and Stefan Hajnoczi (4)
  2. Via Kevin Wolf
    • kwolf/for-anthony:
      qemu-iotests: add 053 unaligned compressed image size test
      block: Allow overriding backing.file.filename
      block: Remove filename parameter from .bdrv_file_open()...
25690739 04/22/2013 04:05 pm Anthony Liguori

Merge remote-tracking branch 'bonzini/nbd-next' into staging

  1. By Stefan Hajnoczi
  2. Via Paolo Bonzini
    • bonzini/nbd-next:
      nbd: set TCP_NODELAY
      nbd: use TCP_CORK in nbd_co_send_request()
      nbd: unlock mutex in nbd_co_send_request() error path

Message-id: ...
6165daa4 04/22/2013 04:05 pm Anthony Liguori

Merge remote-tracking branch 'bonzini/scsi-next' into staging

  1. By Paolo Bonzini (5) and others
  2. Via Paolo Bonzini
    • bonzini/scsi-next:
      vhost-scsi-s390: new device supporting the tcm_vhost Linux kernel module
      vhost-scsi-ccw: new device supporting the tcm_vhost Linux kernel module...
d6394988 04/22/2013 04:04 pm Anthony Liguori

Merge remote-tracking branch 'luiz/queue/qmp' into staging

  1. By Amos Kong (1) and Luiz Capitulino (1)
  2. Via Luiz Capitulino
    • luiz/queue/qmp:
      virtio-balloon: fix integer overflow in BALLOON_CHANGE QMP event
      monitor: fix the wrong order of releasing keys...
1cb6f506 04/22/2013 12:37 pm Kevin Wolf

block: Allow overriding backing.file.filename

If a filename is passed in the driver-specific options from the command
line, the backing file path from the image is ignored now.

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
7da94ca7 04/22/2013 12:37 pm Stefan Hajnoczi

qemu-iotests: add 053 unaligned compressed image size test

Test that qemu-img convert -c works when input image length is not a
multiple of the cluster size.

Previously an error message would be produced:

qemu-img: error while compressing sector 0: Input/output error...
56d1b4d2 04/22/2013 12:34 pm Kevin Wolf

block: Remove filename parameter from .bdrv_file_open()

It is unused now in all block drivers.

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
2af5ef70 04/22/2013 11:27 am Kevin Wolf

block: Fail gracefully when using a format driver on protocol level

Specifying the wrong driver could fail an assertion:

$ qemu-system-x86_64 -drive file.driver=qcow2,file=x
qemu-system-x86_64: block.c:721: bdrv_open_common: Assertion `file !=
((void *)0)' failed....
31ca6d07 04/22/2013 11:27 am Kevin Wolf

block: Add driver-specific options for backing files

Options starting in "backing." are passed to the backing file now. If
you don't need to specify the filename for the backing file, you can add
it on the command line instead of in the image file:

$ qemu-nbd -t /tmp/test.img...
035fccdf 04/22/2013 11:27 am Kevin Wolf

block: Enable filename option

This allows using the file.filename option instead of the string that
comes from -drive file=... and is passed around as a separate parameter.
The goal is to get rid of this parameter and use the options QDict more
consistently....
c66a6157 04/22/2013 11:27 am Kevin Wolf

raw-posix: Use bdrv_open options instead of filename

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
8a79380b 04/22/2013 11:27 am Kevin Wolf

raw-win32: Use bdrv_open options instead of filename

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
f4681212 04/22/2013 11:27 am Kevin Wolf

blkdebug: Use bdrv_open options instead of filename

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
16c79092 04/22/2013 11:27 am Kevin Wolf

blkverify: Use bdrv_open options instead of filename

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
8e6d58cd 04/22/2013 11:27 am Kevin Wolf

curl: Use bdrv_open options instead of filename

As a bonus, going through the QemuOpts QEMU_OPT_SIZE parser for the
readahead option gives us proper error reporting that the previous use
of atoi() lacked.

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
b4894776 04/22/2013 11:27 am Kevin Wolf

gluster: Use bdrv_open options instead of filename

This is only to convert the internal interface that is used for passing
the "filename" to be parsed, but converting to actual fine grained
options is left for another day, as it doesn't look trivial.

Signed-off-by: Kevin Wolf <>...
60beb341 04/22/2013 11:27 am Kevin Wolf

iscsi: Use bdrv_open options instead of filename

This is only to convert the internal interface that is used for passing
the "filename" to be parsed, but converting to actual fine grained
options is left for another day, as it doesn't look trivial.

Signed-off-by: Kevin Wolf <>...
a9ccedc3 04/22/2013 11:27 am Kevin Wolf

rbd: Use bdrv_open options instead of filename

This is only to convert the internal interface that is used for passing
the "filename" to be parsed, but converting to actual fine grained
options is left for another day, as it doesn't look trivial.

Signed-off-by: Kevin Wolf <>...
c8c96350 04/22/2013 11:27 am Kevin Wolf

sheepdog: Use bdrv_open options instead of filename

This is only to convert the internal interface that is used for passing
the "filename" to be parsed, but converting to actual fine grained
options is left for another day, as it doesn't look trivial.

Signed-off-by: Kevin Wolf <>...
7ad9be64 04/22/2013 11:27 am Kevin Wolf

vvfat: Use bdrv_open options instead of filename

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
f4d38bef 04/22/2013 11:27 am Stefan Hajnoczi

qcow2: allow sub-cluster compressed write to last cluster

Compression in qcow2 requires image length to be a multiple of the
cluster size. Lift this requirement by zero-padding the final cluster
when necessary. The virtual disk size is still not cluster-aligned, so...
16b3c5cd 04/22/2013 11:27 am Stefan Hajnoczi

qcow: allow sub-cluster compressed write to last cluster

Compression in qcow requires image length to be a multiple of the
cluster size. Lift this requirement by zero-padding the final cluster
when necessary. The virtual disk size is still not cluster-aligned, so...
54f106d5 04/22/2013 11:27 am Stefan Hajnoczi

qemu-img: do not zero-pad the compressed write buffer

bdrv_write_compressed() does not allow requests that span the end of the
device. Therefore it is useless to zero-pad the last cluster and
thereby exceed the end of the device.

Let image formats handle zero-padding the final compressed cluster, if...
bdda9232 04/22/2013 11:27 am Kevin Wolf

qemu-iotests: Fix _filter_qemu

$QEMU_PROG happens to be 'qemu' in my setup, so this sed command
replaces a bit too much. Restrict it to the start of the line and to
when it's followed by a colon, i.e. the form used by error messages.

Signed-off-by: Kevin Wolf <>...
68c0aa6e 04/21/2013 07:44 pm Peter Maydell

ui/cocoa.m: Fix recent compile breakage

Fix failures to compile introduced by recent console commits
1dbfa00503, 81c0d5a6) which removed is_graphic_console() and
vga_hw_update() without updating the cocoa UI backend to match.

Signed-off-by: Peter Maydell <>...
089305ac 04/20/2013 10:27 pm Pavel Dovgaluk

i386 ROR r8/r16 instruction fix

Fixed EFLAGS corruption by ROR r8/r16 instruction located at the end of the TB.

Signed-off-by: Pavel Dovgalyuk <>
Reviewed-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>
21e5181f 04/20/2013 08:54 pm Peter Maydell

qdev: Drop taddr properties

Drop all the infrastructure for taddr properties (ie ones which
are 'hwaddr' sized). These are now unused, and any further desired
use would be rather questionable since device properties shouldn't
generally depend on a type that is conceptually variable based on...
19298eca 04/20/2013 08:54 pm Peter Maydell

hw/sm501: Use correct setter for sysbus-ohci dma-address property

The sysbus-ohci dma-address property is declared as a HEX64
property, not a TADDR, so use the correct setter for it.

Signed-off-by: Peter Maydell <>
Acked-by: Andreas Färber <>...
f4374c82 04/20/2013 02:39 pm Blue Swirl

Merge branch 'arm-devs.next' of git://git.linaro.org/people/pmaydell/qemu-arm

  • 'arm-devs.next' of git://git.linaro.org/people/pmaydell/qemu-arm:
    hw/versatile_pci: Drop unnecessary vpb_pci_config_addr()
    versatile_pci: Expose PCI memory space to system...
32370db3 04/20/2013 02:38 pm Blue Swirl

Merge branch 'target-arm.next' of git://git.linaro.org/people/pmaydell/qemu-arm

  • 'target-arm.next' of git://git.linaro.org/people/pmaydell/qemu-arm:
    target-arm: Correctly restore FPSCR
    target-arm: Add some missing CPU state fields to VMState
    target-arm: port ARM CPU save/load to use VMState...
87885c8e 04/20/2013 02:38 pm Blue Swirl

Merge branch 'linux-user-for-upstream' of git://git.linaro.org/people/rikuvoipio/qemu

  • 'linux-user-for-upstream' of git://git.linaro.org/people/rikuvoipio/qemu:
    linux-user: fix setgroups/getgroups for non-UID16 archs
    linux-user: fix undefined shift in copy_to_user_fdset...
d6e51919 04/19/2013 05:19 pm Paolo Bonzini

vhost-scsi-s390: new device supporting the tcm_vhost Linux kernel module

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Asias He <>
Cc: Michael S. Tsirkin <>
Signed-off-by: Nicholas Bellinger <>...
ccf6916c 04/19/2013 05:18 pm Paolo Bonzini

vhost-scsi-ccw: new device supporting the tcm_vhost Linux kernel module

Signed-off-by: Paolo Bonzini <>
50787628 04/19/2013 05:18 pm Nicholas Bellinger

vhost-scsi-pci: new device supporting the tcm_vhost Linux kernel module

Cc: Michael S. Tsirkin <>
Signed-off-by: Nicholas Bellinger <>
Signed-off-by: Asias He <>
Signed-off-by: Paolo Bonzini <>
e9cd423f 04/19/2013 05:18 pm Paolo Bonzini

virtio: simplify Makefile conditionals

Signed-off-by: Paolo Bonzini <>
5e9be92d 04/19/2013 05:18 pm Nicholas Bellinger

vhost-scsi: new device supporting the tcm_vhost Linux kernel module

The WWPN specified in configfs is passed to "-device vhost-scsi-pci".
The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not
available from the QEMU command-line. Instead, I hardcode it to zero....
292c8e50 04/19/2013 05:17 pm Paolo Bonzini

virtio-scsi: create VirtIOSCSICommon

This patch refactors existing virtio-scsi code into VirtIOSCSICommon
in order to allow virtio_scsi_init_common() to be used by both internal
virtio_scsi_init() and external vhost-scsi-pci code.

Cc: Michael S. Tsirkin <>...
f691df52 04/19/2013 04:38 pm Anthony Liguori

Merge remote-tracking branch 'stefanha/trivial-patches' into staging

  1. By Stefan Weil (3) and others
  2. Via Stefan Hajnoczi
    • stefanha/trivial-patches:
      m25p80: Remove bogus include of devices.h
      ssh: Remove unnecessary use of strlen function.
      block/ssh: Add missing gcc format attributes...
5dff24be 04/19/2013 04:38 pm Anthony Liguori

Merge remote-tracking branch 'mst/tags/for_anthony' into staging

pci: add pci test device

This adds a new device that we can use for testing PCI PIO and MMIO, with and
without ioeventfd in different configurations. FAST_MMIO will be added if/when
kvm supports it. Also included are minor cleanups in kvm APIs that it needs....
b6c99f8a 04/19/2013 04:37 pm Anthony Liguori

Merge remote-tracking branch 'qemu-kvm/uq/master' into staging

  1. By Jan Kiszka (4) and Marcelo Tosatti (1)
  2. Via Marcelo Tosatti
    • qemu-kvm/uq/master:
      vmxcap: Update according to SDM of January 2013
      target-i386: kvm: save/restore steal time MSR
      vmxcap: Report APIC register emulation and RDTSCP control...
153d02e3 04/19/2013 03:32 pm Amos Kong

monitor: fix the wrong order of releasing keys

(qemu) sendkey ctrl_r-scroll_lock-scroll_lock

Executing this command could not let Windows guest panic, it caused by
the wrong order of releasing keys. This problem was introduced by
commit e4c8f004c55d9da3eae3e14df740238bf805b5d6....
dcc6ceff 04/19/2013 03:32 pm Luiz Capitulino

virtio-balloon: fix integer overflow in BALLOON_CHANGE QMP event

Because dev->actual is uint32_t, the expression 'dev->actual <<
VIRTIO_BALLOON_PFN_SHIFT' is truncated to 32 bits. This overflows when
dev->actual >= 1048576.

To reproduce:

1. Start a VM with a QMP socket and 5G of RAM...
3cc1d208 04/19/2013 02:24 pm Juan Quintela

target-arm: port ARM CPU save/load to use VMState

Port the ARM CPU save/load code to use VMState. Some state is
saved in a slightly different order to simplify things -- for
example arrays are saved one after the other rather than 'striped',
and we always save all 32 VFP registers even if the CPU happens...
602131e9 04/19/2013 02:24 pm Peter Maydell

target-arm: Add some missing CPU state fields to VMState

A number of CPU state fields were accidentally omitted from
our migration state: some OMAP specific cp15 registers, and
some related to state for load/store exclusive insns. Add them.

Signed-off-by: Peter Maydell <>
e91f229a 04/19/2013 02:24 pm Peter Maydell

target-arm: Correctly restore FPSCR

Use the helper functions to save and restore the FPSCR, so that
we correctly propagate rounding mode and flushing behaviour into
the float_status fields. This also allows us to stop saving the
vector length/stride fields separately....
3b328448 04/19/2013 02:24 pm Peter Chubb

target-arm: Reinsert missing return statement in ARM mode SRS decode

Since patch
81465888c5306cd94abb9847e560796fd13d3c2f
target-arm: factor out handling of SRS instruction
the ARM mode SRS instruction has not worked in QEMU.

The problem is a missing return directive that was removed in the...
af9277e6 04/19/2013 01:15 pm Peter Maydell

hw/versatile_pci: Drop unnecessary vpb_pci_config_addr()

Drop the vpb_pci_config_addr() function -- it is unnecessary since
the size of the memory regions means the hwaddr is always within
the 24 bit size. (This function was probably a leftover from when...
7468d73a 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Implement the PCI controller's control registers

The versatile_pci PCI controller has a set of control registers which
handle the mapping between PCI and system address spaces. Implement
these registers (though for now they have no effect since we don't...
a2bff788 04/19/2013 01:15 pm Peter Maydell

arm/realview: Fix mapping of PCI regions

Fix the mapping of the PCI regions for the realview board, which were
all incorrect. (This was never noticed because the Linux kernel
doesn't actually include a PCI driver for the realview boards.)

Signed-off-by: Peter Maydell <>...
89a32d32 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Expose PCI memory space to system

The VersatilePB's PCI controller exposes the PCI memory space to the
system via three regions controlled by the mapping control registers.
Implement this so that guests can actually use MMIO-BAR PCI cards....
5f37ef92 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Put the host bridge PCI device at slot 29

On real hardware the host bridge appears as a PCI device in slot 29,
so make QEMU put its host bridge in that slot too.

Signed-off-by: Peter Maydell <>
Acked-by: Paul Brook <>
66a96d70 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Implement the correct PCI IRQ mapping

Implement the correct IRQ mapping for the Versatile PCI controller; it
differs between realview and versatile boards, but the previous QEMU
implementation was correct only for the first PCI card on a versatile...
cd93dbf3 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Update to realize and instance init functions

Update the Versatile PCI controller to use a realize function rather
than SysBusDevice::init. To reflect the fact that the 'realview_pci'
class is taking most of its implementation from 'versatile_pci' (and...
0688810b 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Change to subclassing TYPE_PCI_HOST_BRIDGE

Change versatile_pci to subclass TYPE_PCI_HOST_BRIDGE and generally
handle PCI in a more QOM-like fashion.

Signed-off-by: Peter Maydell <>
Acked-by: Paul Brook <>
967c2607 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Use separate PCI I/O space rather than system I/O space

Rather than overloading the system I/O space (which doesn't even make
any sense on ARM) for PCI I/O, create an memory region in the PCI
controller and use that to represent the I/O space....
c5c86c53 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Fix hardcoded tabs

There is just one line in this source file with a hardcoded tab
indent, so just fix it.

Signed-off-by: Peter Maydell <>
Acked-by: Paul Brook <>
5fb8084f 04/19/2013 01:15 pm Peter Maydell

versatile_pci: Expose PCI I/O region on Versatile PB

Comments in the QEMU source code claim that the version of the PCI
controller on the VersatilePB board doesn't support the PCI I/O
region, but this is incorrect; expose that region, map it in the
correct location, and drop the misleading comments....
ad6b40f4 04/19/2013 12:45 pm Peter Crosthwaite

m25p80: Remove bogus include of devices.h

I think in the early revisions of this we had an instantiation helper
for the device in devices.h. This was later removed and this header was
left over. Removed

Signed-off-by: Peter Crosthwaite <>...
c7a101f5 04/19/2013 12:45 pm Richard W.M. Jones

ssh: Remove unnecessary use of strlen function.

Reviewed-by: Eric Blake <>
Reviewed-by: Stefan Weil <>

Signed-off-by: Stefan Hajnoczi <>