Statistics
| Branch: | Revision:

root / ui @ 136be99e

# Date Author Comment
1643f2b2 05/30/2012 05:28 am Gerd Hoffmann

vnc: fix segfault in vnc_display_pw_expire()

NULL pointer dereference in case no vnc server is configured.
Catch this and return -EINVAL like vnc_display_password() does.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>
60b46aa2 05/29/2012 12:40 pm Andreas Färber

cocoa: Suppress Cocoa frontend for -qtest

Signed-off-by: Andreas Färber <>
a6ba35b3 05/10/2012 08:37 pm Amos Kong

sockets: change inet_connect() to support nonblock socket

Add a bool argument to inet_connect() to assign if set socket
to block/nonblock, and delete original argument 'socktype'
that is unused.
Add a new argument to inet_connect()/inet_connect_opts(),
to pass back connect error by error class....
029409e5 05/10/2012 08:37 pm Amos Kong

sockets: use error class to pass listen error

Add a new argument in inet_listen()/inet_listen_opts()
to pass back listen error.

Change nbd, qemu-char, vnc to use new interface.

Signed-off-by: Amos Kong <>
Reviewed-by: Orit Wasserman <>...
4efee029 05/03/2012 11:45 am Alon Levy

spice_info: add mouse_mode

Add mouse_mode, either server or mouse, to qmp and hmp commands, based
on spice_server_is_server_mouse added in spice-server 0.10.3.

Signed-off-by: Alon Levy <>
Signed-off-by: Gerd Hoffmann <>
5cbdb3a3 04/07/2012 05:00 pm Stefan Weil

Replace Qemu by QEMU in comments

The official spelling is QEMU.

Signed-off-by: Stefan Weil <>
Reviewed-by: Andreas Färber <>
[: fixed comment style in hw/sun4m.c]
Signed-off-by: Blue Swirl <>
a13ccc99 03/22/2012 03:29 pm Alon Levy

ui/spice-display: use uintptr_t when casting qxl physical addresses

The current intptr_t casts are a problem when the address's highest
bit is 1, and it is cast to a intptr_t and then to uint64_t, such
as at:
surface.mem = (intptr_t)ssd->buf;...
34d14c6d 03/22/2012 03:29 pm Peter Maydell

ui/spice-display.c: Fix compilation warnings on 32 bit hosts

Fix compilation failures ("cast from pointer to integer of
different size [-Werror=pointer-to-int-cast]") by using
uintptr_t instead.

Signed-off-by: Peter Maydell <>
Signed-off-by: Gerd Hoffmann <>
b85a4ec8 03/19/2012 08:37 pm Anthony Liguori

Merge remote-tracking branch 'stefanha/trivial-patches' into staging

  • stefanha/trivial-patches:
    qemu-ga: for w32, fix leaked handle ov.hEvent in ga_channel_write()
    ioapic: fix build with DEBUG_IOAPIC
    .gitignore: add qemu-bridge-helper and option rom build products...
d0638b18 03/19/2012 02:12 pm Marc-André Lureau

spice: set spice uuid and name

This allows a Spice client to identify a VM

Signed-off-by: Gerd Hoffmann <>
c480bb7d 03/19/2012 02:12 pm Alon Levy

qxl: switch qxl.c to trace-events

dprint is still used for qxl_init_common one time prints.

also switched parts of spice-display.c over, mainly all the callbacks to
spice server.

All qxl device trace events start with the qxl device id.

Signed-off-by: Alon Levy <>...
ad1be899 03/19/2012 02:12 pm Alon Levy

spice: fix broken initialization

Commit 1b71f7c14fab6f00c2680d4489fbee7baf796e4f moved MODULE_INIT_QOM to
way before MODULE_INIT_MACHINE, thereby breaking assumptions made in
spice-core.c which registered both a type initializer and a machine
intializer....
ee032ca1 03/19/2012 12:52 pm Stefan Weil

vnc: Fix packed boolean struct members

This patch fixes warnings reported by splint:

For variables which are packed in a single bit, a signed data type
like 'int' does not make much sense.

There is no obvious reason why the two values should be packed,...
175b2a6e 03/14/2012 11:22 pm Corentin Chary

vnc: don't mess up with iohandlers in the vnc thread

The threaded VNC servers messed up with QEMU fd handlers without
any kind of locking, and that can cause some nasty race conditions.

Using qemu_mutex_lock_iothread() won't work because vnc_dpy_cpy(),
which will wait for the current job queue to finish, can be called with...
9e4dd565 03/14/2012 11:22 pm Stefan Weil

vnc: Limit r/w access to size of allocated memory

This fixes memory reads and writes which exceeded the upper limit
of allocated memory vd->guest.ds->data and vd->server->data.

Cc: Anthony Liguori <>
Signed-off-by: Stefan Weil <>...
1d3323de 03/12/2012 09:05 pm Gerd Hoffmann

implement vnc_dpy_setdata

The comment is wrong, we have to do something in the setdata callback.
Changing the framebuffer backing storage (happens when the guest pans
the display) renders the whole screen content invalid.

Trigger #1: cirrus vga + 32bit linux guest + vesafb with ypan enabled....
0ea5c0cd 03/08/2012 05:22 pm Stefan Weil

vnc: Add break statement

This was not a bug, but it is not common practice to omit the break statement
from the last case statement before an empty default case.

Any change of the default case would introduce a bug.

This was reported as a warning by splint....
339a475f 02/28/2012 06:22 pm Christophe Fergeau

spice: use error_report to report errors

Error message reporting during spice startup wasn't consistent, it was done
with fprintf(stderr, "") but sometimes the message didn't have a trailing
\n. Using error_report make the intent of the message clearer and deal...
35c63329 02/28/2012 06:22 pm Christophe Fergeau

Error out when tls-channel option is used without TLS

It's currently possible to setup spice channels using TLS when
no TLS port has been specified (ie TLS is disabled). This cannot
work, so better to error out in such a situation.

Signed-off-by: Gerd Hoffmann <>
2e1a98c9 02/27/2012 10:46 am Alon Levy

qxl: introduce QXLCookie

Will be used in the next patch.

Signed-off-by: Alon Levy <>
Signed-off-by: Gerd Hoffmann <>
81fb6f15 02/27/2012 10:46 am Alon Levy

qxl: make qxl_render_update async

RHBZ# 747011

Removes the last user of QXL_SYNC when using update drivers that use the
_ASYNC io ports.

The last user is qxl_render_update, it is called both by qxl_hw_update
which is the vga_hw_update_ptr passed to graphic_console_init, and by...
bb5a8cd5 02/27/2012 10:46 am Alon Levy

qxl: fix spice+sdl no cursor regression

regression introduced by 075360945860ad9bdd491921954b383bf762b0e5,

v2: lock around qemu_spice_cursor_refresh_unlocked

Reported-by: Fabiano Fidêncio <>
Signed-off-by: Alon Levy <>...
63ea491d 02/27/2012 10:46 am Alon Levy

sdl: remove NULL check, g_malloc0 can't fail

Signed-off-by: Alon Levy <>
Signed-off-by: Gerd Hoffmann <>
4295e15a 02/27/2012 10:46 am Alon Levy

qxl: require spice >= 0.8.2

drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result,
any check for SPICE_SERVER_VERSION that is now always satisfied,
and SPICE_INTERFACE_CORE_MINOR >= 3 tests, because
0.8.2 has SPICE_INTERFACE_QXL_MINOR 1 and
SPICE_INTERFACE_CORE_MINOR 3....
1f51470d 02/24/2012 05:06 pm Markus Armbruster

Revert "qemu-char: Print strerror message on failure" and deps

The commit's purpose is laudable:

The only way for chardev drivers to communicate an error was to
    return a NULL pointer, which resulted in an error message that
    said that something went wrong, but not why....
f1f5f407 02/21/2012 11:36 am Daniel P. Berrange

Add SPICE support to add_client monitor command

With the acceptance of some new APIs to libspice-server.so it
is possible to add support for SPICE to the 'add_client'
monitor command, bringing parity with VNC. Since SPICE can
use TLS or plain connections, the command also gains a new...
faa98223 02/21/2012 11:36 am Yonit Halperin

spice: support ipv6 channel address in monitor events and in spice info

RHBZ #788444

CC: Gerd Hoffmann <>

Signed-off-by: Yonit Halperin <>
Signed-off-by: Gerd Hoffmann <>
7dfbfc79 02/17/2012 05:58 pm Daniel P. Berrange

vnc: Don't demote authentication scheme when changing password/disabling login

Currently when disabling login in VNC, the password is cleared out and the
authentication protocol is forced to AUTH_VNC. If you're using a stronger
authentication protocol, this has the effect of downgrading your security...
cf5cfe04 02/16/2012 02:40 am Anthony Liguori

Merge remote-tracking branch 'kraxel/vnc.2' into staging

  • kraxel/vnc.2:
    vnc: lift modifier keys on client disconnect.
    vnc: implement shared flag handling.
    vnc: fix ctrl key in vnc terminal emulation
    Fix vnc memory corruption with width = 1400
83f7d43a 02/15/2012 05:39 pm Andreas Färber

qom: Unify type registration

Replace device_init() with generalized type_init().

While at it, unify naming convention: type_init([$prefix_]register_types)
Also, type_init() is a function, so add preceding blank line where
necessary and don't put a semicolon after the closing brace....
ce3e1417 02/10/2012 10:58 am Gerd Hoffmann

Fix vnc memory corruption with width = 1400

vnc assumes that the screen width is a multiple of 16 in several places.
If this is not the case vnc will overrun buffers, corrupt memory, make
qemu crash.

This is the minimum fix for this bug. It makes sure we don't overrun the...
e26437c2 02/10/2012 10:58 am Gerd Hoffmann

vnc: fix ctrl key in vnc terminal emulation

Make the control keys for terminals on the vnc display
(i.e. qemu -vnc :0 -serial vc) work. Makes the terminals
alot more usable as typing Ctrl-C in your serial console
actually has the desired effect ;)

Signed-off-by: Gerd Hoffmann <>
8cf36489 02/10/2012 10:58 am Gerd Hoffmann

vnc: implement shared flag handling.

VNC clients send a shared flag in the client init message. Up to now
qemu completely ignores this. This patch implements shared flag
handling. It comes with three policies: By default qemu behaves as one
would expect: Asking for a exclusive access grants exclusive access to...
7bc9318b 02/10/2012 10:58 am Gerd Hoffmann

vnc: lift modifier keys on client disconnect.

For any modifier key (shift, ctrl, alt) still pressed on disconnect
inject a key-up event into the guest. The vnc client is gone, it will
not do that, so qemu has to do it instead.

Without this keys will get stuck, making the guest act in weird ways...
85f94f86 02/01/2012 10:45 pm Jan Kiszka

sdl: Fix block prevention of SDL_WM_GrabInput

Consistently check for SDL_APPINPUTFOCUS before trying to grab the input
focus. Just checking for SDL_APPACTIVE doesn't work. Moving the check to
sdl_grab_start allows for some consolidation.

Signed-off-by: Jan Kiszka <>...
eaa2e027 02/01/2012 10:45 pm Jan Kiszka

Revert "Handle SDL grabs failing (Mark McLoughlin)"

This reverts commit 6bb816031f8bc0aafc3476e6dfa4293ee3a5f106.

SDL_WM_GrabInput does not reliably bail out if grabbing is impossible.
So if we get here, we already lost and will block. But this can no
longer happen due to the check in sdl_grab_start. So this patch became...
822f98d2 02/01/2012 10:45 pm Jan Kiszka

sdl: Grab input on end of non-absolute mouse click

By grabbing the input already on button down, we leave the button in
that state for the host GUI. Thus it takes another click after releasing
the input again to synchronize the mouse button state.

Avoid this by grabbing on button up....
02df4d6f 02/01/2012 10:45 pm Jan Kiszka

sdl: Limit sdl_grab_end in handle_activation to Windows hosts

There are scenarios on Linux with some SDL versions where
handle_activation is continuous invoked with state = SDL_APPINPUTFOCUS
and gain = 0 while we grabbed the input. This causes a ping-pong when we...
66596356 02/01/2012 10:45 pm Jan Kiszka

sdl: Do not grab mouse on mode switch while in background

When the mouse mode changes to absolute while the SDL windows is not in
focus, refrain from grabbing the input. It would steal from some other
window.

Signed-off-by: Jan Kiszka <>...
a6aa9d3e 01/18/2012 02:23 pm Luiz Capitulino

vnc: Simplify vnc_display_password()

Drop the qerror_report() call from it and let its callers set the error
themselves. This also allows for dropping the 'ret' variable.

Signed-off-by: Luiz Capitulino <>
cee8e6ad 01/13/2012 12:36 pm Stefan Hajnoczi

vnc: fix no-lock-key-sync strncmp() length

The no-lock-key-sync option is being parsed incorrectly because of an
outdated strcmp() length value. Use the correct length so that invalid
option names do not match.

Reported-by: Dr David Alan Gilbert <>...
9423a2e8 12/14/2011 03:59 pm Anthony Liguori

Merge remote-tracking branch 'stefanha/trivial-patches-next' into staging
e7d81004 12/14/2011 01:09 pm Stefan Weil

Fix spelling in comments, documentation and messages

accidently->accidentally
annother->another
choosen->chosen
consideres->considers
decriptor->descriptor
developement->development
paramter->parameter
preceed->precede
preceeding->preceding
priviledge->privilege...
cf218714 12/13/2011 01:06 am Jan Kiszka

qemu-thread: add API for joinable threads

Split from Jan's original qemu-thread-posix.c patch. No semantic change,
just introduce the new API that POSIX and Win32 implementations will
conform to.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Paolo Bonzini <>...
3a93113a 12/06/2011 11:56 am Dong Xu Wang

fix typo: delete redundant semicolon

Double semicolons should be single.

Signed-off-by: Dong Xu Wang <>
Signed-off-by: Stefan Hajnoczi <>
e5bed759 12/02/2011 12:50 pm Dong Xu Wang

fix spelling in ui sub directory

Cc: Anthony Liguori <>
Signed-off-by: Dong Xu Wang <>
Signed-off-by: Stefan Hajnoczi <>
f2d3476e 11/11/2011 08:49 pm Markus Armbruster

ui: Plug memory leaks on parse_keyboard_layout() error path

Spotted by Coverity.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Anthony Liguori <>
302d9d6f 11/10/2011 02:29 pm Markus Armbruster

ui/vnc: Convert sasl.mechlist to g_malloc() & friends

Fixes protocol_client_auth_sasl_mechname() not to crash when malloc()
fails. Spotted by Coverity.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Stefan Hajnoczi <>
8aceefd7 11/02/2011 12:29 am Anthony Liguori

Merge remote-tracking branch 'afaerber/cocoa-for-upstream' into staging
ae878b17 11/01/2011 11:52 pm Stefan Weil

ui/vnc: Fix use of free() instead of g_free()

Please note that mechlist still uses malloc / strdup / free.

Signed-off-by: Stefan Weil <>
Signed-off-by: Anthony Liguori <>
13766eb1 11/01/2011 09:41 pm Andreas Färber

cocoa: Close sheet after image file selection

If no disk image is specified, the Cocoa frontend displays a modal sheet
to let the user select an image file to boot from.

This sheet is never closed and it permanently obscures the emulator window.

Close it after obtaining the file name in case the user did select a file....
96b3d73f 10/31/2011 06:02 pm Anthony Liguori

Merge remote-tracking branch 'qmp/queue/qmp' into staging

Conflicts:
ui/spice-core.c
2b54aa87 10/27/2011 04:48 pm Luiz Capitulino

qapi: Convert query-vnc

There are three important remarks in relation to the non-qapi command:

1. This commit also fixes the behavior of the 'query-vnc' and 'info vnc'
    commands to return an error when qemu is built without VNC support
    (ie. --disable-vnc). The non-qapi command would return the OK...
d1f29646 10/27/2011 04:48 pm Luiz Capitulino

qapi: Convert query-spice

Signed-off-by: Anthony Liguori <>
Signed-off-by: Luiz Capitulino <>
3bb781f3 10/25/2011 03:00 pm Alon Levy

ui/spice-core: fix segfault in monitor

Fix segfault if a qxl device is present but no spice command line
argument is given.

RHBZ 743251.

Signed-off-by: Alon Levy <>
08cc67f3 10/25/2011 03:00 pm Gerd Hoffmann

spice: fix file handle cleanup

Setting both read and write handlers to NULL in qemu_set_fd_handler
is not enougth to make qemu purge the file handle from the list.
We must set opaque to NULL too.

Signed-off-by: Gerd Hoffmann <>
edc5cb1a 10/25/2011 03:00 pm Yonit Halperin

spice: turn client_migrate_info to async

RHBZ 737921
Spice client is required to connect to the migration target before/as migration
starts. Since after migration starts, the target qemu is blocked and cannot accept new spice client
we trigger the connection to the target upon client_migrate_info command....
026f773f 10/25/2011 03:00 pm Yonit Halperin

spice: support the new migration interface (spice 0.8.3)

- call spice_server_migrate_(start|end|connect).
- register spice_migrate_connect completion callback

Signed-off-by: Yonit Halperin <>
Signed-off-by: Gerd Hoffmann <>
f9ab6091 10/25/2011 03:00 pm Jan Kiszka

spice: Convert core to QEMU thread API

No need to use pthread directly, we have proper abstractions for
identity checking.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Gerd Hoffmann <>
7073693b 10/20/2011 02:23 pm Juan Quintela

migration: Export a function that tells if the migration has finished correctly

This will allow us to hide the state values.

Signed-off-by: Juan Quintela <>
7b0a03a1 09/21/2011 01:10 pm Christoph Egger

use qemu_* ctype functions

Fix "warning: array subscript has type 'char'" on NetBSD.

Signed-off-by: Christoph Egger <>
Signed-off-by: Stefan Hajnoczi <>
43b26fc8 09/21/2011 12:49 pm Jan Kiszka

Drop unneeded pthread.h inclusions

Signed-off-by: Jan Kiszka <>
Signed-off-by: Stefan Hajnoczi <>
1dfb4dd9 09/15/2011 10:39 pm Luiz Capitulino

Replace the VMSTOP macros with a proper state type

Today, when notifying a VM state change with vm_state_notify(),
we pass a VMSTOP macro as the 'reason' argument. This is not ideal
because the VMSTOP macros tell why qemu stopped and not exactly
what the current VM state is....
1354869c 09/15/2011 10:39 pm Luiz Capitulino

Drop the vm_running global variable

Use runstate_is_running() instead, which is introduced by this commit.

Signed-off-by: Luiz Capitulino <>
f40d5508 09/09/2011 08:58 pm Gerd Hoffmann

vns/tls: don't use depricated gnutls functions

Avoid using deprecated gnutls functions with recent gnutls versions.
Fixes build failure on Fedora 16. Keep the old way for compatibility
with old installations such as RHEL-5 (gnutls 1.4.x).

Based on a patch from Raghavendra D Prabhu <>...
7e79cf40 09/07/2011 10:20 am Yonit Halperin

spice: set qxl->ssd.running=true before telling spice to start, RHBZ #733993

If qxl->ssd.running=true is set after telling spice to start, the spice server
thread can call qxl_send_events while qxl->ssd.running is still false. This leads to
assert(d->ssd.running)....
22b626e2 09/07/2011 10:20 am Gerd Hoffmann

spice: workaround a spice server bug.

spice server might call the channel_event callback from spice server
thread context. Detect that and aquire iothread lock if needed,
f8b8d633 08/22/2011 10:37 pm Jan Kiszka

sdl: Don't release input on mouse mode change in full-screen mode

While in full-screen mode, the input focus naturally belongs to the SDL
window. Avoid dropping it when switching from absolute to relative
mouse mode.

Signed-off-by: Jan Kiszka <>...
58a06675 08/21/2011 09:42 pm Blue Swirl

Convert last qemu_free and qemu_malloc uses

7267c0947d7e8ae5dff7bafd932c3bc285f43e5c missed
a few cases, fix them.

Signed-off-by: Blue Swirl <>
7267c094 08/21/2011 07:01 am Anthony Liguori

Use glib memory allocation and free functions

qemu_malloc/qemu_free no longer exist after this commit.

Signed-off-by: Anthony Liguori <>
8df0c7e8 08/10/2011 07:52 pm Alon Levy

ui/spice-core: report compiled-version in info spice/query-spice

Signed-off-by: Alon Levy <>
Signed-off-by: Gerd Hoffmann <>
9510a486 08/05/2011 06:57 pm Jan Kiszka

sdl: Refactor sdl_send_mouse_event

Replace width/height globals with the identical values from real_screen,
refactor the function according to our coding style.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
2a8ad7da 08/05/2011 06:57 pm Jan Kiszka

sdl: Fix full screen toggling from scaled mode

When switching to full screen mode from a scaled window, we need to
resize to DisplayState's dimension, not the scaled "real" screen size.
Moreover, scaling mode may have manipulated the bpp. So we need to
restore it from the DisplayState as well....
f9977897 08/05/2011 06:57 pm Jan Kiszka

sdl: Restore scaling mode on return from full screen

Save the scaling mode and its geometry when going full screen, restore
it when returning to windowed mode.

CC: Stefano Stabellini <>
Signed-off-by: Jan Kiszka <>...
982aae66 08/05/2011 06:57 pm Jan Kiszka

sdl: Drop bogus gui_fullscreen_initial_grab

There must be no difference between initial -full-screen and switching
to this mode via the hot key.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
110defd7 08/05/2011 06:57 pm Jan Kiszka

sdl: Initialize gui_fullscreen earlier during setup

This ensures that we actually enter full screen on startup when e.g.
'-vga none -full-screen' was specified.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
f8558100 08/05/2011 06:57 pm Jan Kiszka

sdl: Consistently avoid grabbing input for text consoles

There were some preexisting bits that released the input when switching
to text console. This patch spreads this logic consistently and also
avoids grabbing the input while a text console is active....
f623d885 08/05/2011 06:57 pm Jan Kiszka

sdl: Never release input while in full screen mode

It's confusing to suddenly find two mice in full screen mode when
switching consoles or accidentally hitting the grab hot keys.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
74d9dc69 08/05/2011 06:57 pm Jan Kiszka

sdl: Fix cursor handling when switching consoles in absolute mouse mode

Restore the cursor when switching from graphic to text console while the
mouse is in absolute mode. Disable it again when returning.

Signed-off-by: Jan Kiszka <>...
35b0f237 08/05/2011 06:57 pm Jan Kiszka

sdl: Dynamically grab input in absolute mouse mode

Not grabbing the input means that special keys like ALT+TAB are still
handled by the host. Improve the usability by grabbing input once the
mouse is inside the guest screen, provided the SDL window has the input...
d6a65ba3 08/05/2011 06:57 pm Jan Kiszka

sdl: Add zoom hot keys

Allow to enlarge or shrink the screen via CTRL-ALT-+/-. In contrast to
scaling the window, these controls always preserve the aspect ratio of
the current console.

CC: Stefano Stabellini <>
Signed-off-by: Jan Kiszka <>...
1ae1caf1 08/05/2011 06:57 pm Jan Kiszka

sdl: Factor out event handlers from sdl_refresh

No functional changes.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
941f511a 08/05/2011 06:57 pm Jan Kiszka

sdl: Fix termination in -no-shutdown mode

Just like the monitor does, we need to clear no_shutdown before calling
qemu_system_shutdown_request on quit requests. Otherwise, QEMU just
stops the VM.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
91ada980 08/05/2011 06:57 pm Jan Kiszka

sdl: Do not make full screen mode resizable

This prevents continuous resizing events and improper screen setups when
going full screen.

CC: Stefano Stabellini <>
Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
97ad1c26 08/05/2011 06:57 pm Jan Kiszka

sdl: Avoid redundant scaling deactivation

Prevents screen flickering.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
d71680c8 08/05/2011 06:57 pm Jan Kiszka

sdl: Properly mark modifier+u as hotkey

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>
5ff4e36c 08/03/2011 01:03 pm Alon Levy

qxl: async io support using new spice api

Some of the QXL port i/o commands are waiting for the spice server to
complete certain actions. Add async versions for these commands, so we
don't block the vcpu while the spice server processses the command.
Instead the qxl device will raise an IRQ when done....
5c59d118 08/01/2011 01:43 pm Gerd Hoffmann

spice: add worker wrapper functions.

Add wrapper functions for all spice worker calls.

Signed-off-by: Gerd Hoffmann <>
a963f876 08/01/2011 01:43 pm Gerd Hoffmann

spice: add qemu_spice_display_init_common

Factor out SimpleSpiceDisplay initialization into
qemu_spice_display_init_common() and call it from
both qxl.c (for vga mode) and spice-display.c

Signed-off-by: Gerd Hoffmann <>
aee32bf3 08/01/2011 01:43 pm Gerd Hoffmann

spice/qxl: move worker wrappers

Move the wrapper functions which are used by qxl only to qxl.c.
Rename them from qemu_spice_* to qxl_spice_*. Also pass in a
qxl state pointer instead of a SimpleSpiceDisplay pointer.

Signed-off-by: Gerd Hoffmann <>
00aa0040 07/25/2011 05:38 pm Blue Swirl

Wrap recv to avoid warnings

Avoid warnings like these by wrapping recv():
CC slirp/ip_icmp.o
/src/qemu/slirp/ip_icmp.c: In function 'icmp_receive':
/src/qemu/slirp/ip_icmp.c:418:5: error: passing argument 2 of 'recv' from incompatible pointer type [-Werror]...
9e8dd451 07/23/2011 07:26 pm Jan Kiszka

notifier: Pass data argument to callback

This allows to pass additional information to the notifier callback
which is useful if sender and receiver do not share any other distinct
data structure.

Will be used first for the clock reset notifier.

Signed-off-by: Jan Kiszka <>...
7e7e2ebc 07/23/2011 07:19 pm Daniel P. Berrange

Store VNC auth scheme per-client as well as per-server

A future patch will introduce a situation where different
clients may have different authentication schemes set.
When a new client arrives, copy the 'auth' and 'subauth'
fields from VncDisplay into the client's VncState, and...
13661089 07/23/2011 07:19 pm Daniel P. Berrange

Introduce a 'client_add' monitor command accepting an open FD

Allow client connections for VNC and socket based character
devices to be passed in over the monitor using SCM_RIGHTS.

One intended usage scenario is to start QEMU with VNC on a
UNIX domain socket. An unprivileged user which cannot access...
3836620c 07/23/2011 07:19 pm Daniel P. Berrange

Remove unused USES_X509_AUTH macro from VNC sasl code

The USES_X509_AUTH macro is defined in several VNC files,
but not used in all of them. Remove the unused definition.

  • ui/vnc-auth-sasl.c: Remove USES_X509_AUTH macro

Signed-off-by: Anthony Liguori <>
6e1db57b 07/23/2011 07:18 pm Kevin Wolf

qemu-char: Print strerror message on failure

The only way for chardev drivers to communicate an error was to return a NULL
pointer, which resulted in an error message that said that something went
wrong, but not why.

This patch changes the interface to return 0/-errno and updates...
df9cb669 07/20/2011 11:08 am Gerd Hoffmann

spice: add sanity check for spice ports

Make sure at least one port (port=.. or tls-port=...)
is specified. Also apply range checks to the port numbers.

Signed-off-by: Gerd Hoffmann <>
fba810f1 07/04/2011 04:35 pm Gerd Hoffmann

spice: catch spice server initialization failures.

When the spice server initialization fails report this and exit instead
of ignoring the error.

Signed-off-by: Gerd Hoffmann <>
22795174 07/04/2011 04:35 pm Alon Levy

qxl: set mm_time in vga update

This fixes a problem where on windows 7 startup phase, before the qxl driver
is loaded, the drawables are sufficiently large and video like to trigger a
stream, but the lack of a filled mm time field triggers a warning in spice-gtk....
2fb0c09f 06/27/2011 06:21 pm Stefan Weil

vnc: Fix compilation with --enable-vnc-png

Commit f26e428da505709ec03b2ed2c9eb3db82b30bd7b fixed compilation
with --enable-vnc-png, but broke it with --enable-vnc-png.

The breakage is caused by pngconfig.h which checks whether
setjmp.h was already included and fails because qemu-common.h...