qemu-char: Rename opened to be_open
Rename the opened variable to be_open to reflect that it contains theopened state of the backend.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>Message-id: 1364292483-16564-2-git-send-email-hdegoede@redhat.comSigned-off-by: Anthony Liguori <aliguori@us.ibm.com>
pcie: Add endpoint capability initialization wrapper
Fix the awkward API of mangling the caller specified PCIe type andjust provide an interface to initialize an endpoint device. Thiswill pick either a regular endpoint or integrated endpoint based onthe bus and return pcie_cap_init to doing exactly what is asked....
hw: move qdev-monitor.o to toplevel directory
qdev-monitor.c is the only "core qdev" file that is not used inuser-mode emulation, and it does not define anything that is usedby hardware models. Remove it from the hw/ directory andremove hw/qdev-monitor.h from hw/qdev.h too; this requires...
xhci: fix bad print specifier
This fixes the following compilation error:hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type‘long long unsigned int’, but argument 4 has type ‘unsigned int’
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>...
unbreak hw/usb/redirect.c build
Commit 8550a02d1239415342959f6a32d178bc05c557cc added a streamsparameter to usb_wakeup and didn't update redirect.c. Fix it.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
uas-uas: usb3 streams
Add usb3 streams support to the uas (usb attached scsi) emulation.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
usb-xhci: usb3 streams
Add streams support to the xhci emulation. No secondary streams yet,only linear stream arays are supported for now.
usb-host: move legacy cmd line bits
The code handling the "-usbdevice host:..." legacy command linesyntax is moved to the new hw/usb/host-legacy.c file.
usb-host: remove usb_host_device_close
Nobody implements that anyway.
usb: add usb_ep_set_halted
usb: make usb_packet_copy operate on combined packets
Likewise usb_packet_skip.Also usb_packet_size.
usb-redir: simplify packet copy
usb_packet_copy can handle combined packets now,so it isn't needed to special-case them any more.
Also use the new usb_packet_size() function.
usb: fix endpoint descriptor ordering
Fix the ordering of the endpoint descriptors for superspeed endpoints:The superspeed companion must come first, possible additionaldescriptors for the endpoint after that.
usb-core: usb3 streams
This patch adds support for usb3 streams to the usb subsystem core.This is just adding a streams field / parameter in a number of places.
allow disabling usb smartcard support
usb-storage: use scsi_req_enqueue return value
make usb devices configurable
Leave the core usb devices (usb hub, tablet, mouse, keyboard)enabled unconditionally. Make the other ones configurable.
Exceptions: - bluetooth: not qdevified yet, has a vl.c dependency because of that, thus disabling isn't as easy as not linking the...
usb: Makefile cleanup
Group files, sprinkle in some comments.
net: intorduce qemu_del_nic()
To support multiqueue nic, this patch separate the nic destructor fromqemu_del_net_client() to a new helper qemu_del_nic() since the mapping bettweenNiCState and NetClientState were not 1:1 in multiqueue. The following patches...
net: introduce qemu_get_nic()
To support multiqueue, this patch introduces a helper qemu_get_nic() to getNICState from a NetClientState. The following patches would refactor this helperto support multiqueue.
Signed-off-by: Jason Wang <jasowang@redhat.com>...
net: introduce qemu_get_queue()
To support multiqueue, the patch introduce a helper qemu_get_queue()which is used to get the NetClientState of a device. The following patches wouldrefactor this helper to support multiqueue.
ohci: add missing break
usb: add usb-bot device (scsi bulk-only transport).
Basically the same as usb-storage, but without automatic scsidevice setup. Also features support for up to 16 LUNs.
Revert "usb-storage: Drop useless null test in usb_msd_handle_data()"
This reverts commit a1cbfd554e11bb8af38c2f3e1f1574bf4c563cd2.
Test isn't useless. scsi_req_enqueue() may finish the request (willactually happen for requests which don't trigger any I/O such as...
usb: Fix compilation for MinGW (regression)
84f2d0ea added an argument to function usb_host_info.The stub function must match the declaration in usb.h.
Signed-off-by: Stefan Weil <sw@weilnetz.de>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
HMP: add QDict to info callback handler
This patch change all info call back function to takeadditional QDict * parameter, which allow those commandtake parameter. Now it is set to NULL at default case.
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>...
usb-storage: Drop useless null test in usb_msd_handle_data()
scsi_req_new() never returns null, and scsi_req_enqueue() dereferencesthe pointer, so checking for null is useless.
Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Merge remote-tracking branch 'kraxel/usb.76' into staging
ehci: Assert state machine is sane w.r.t. EHCIQueue
Coverity worries the EHCIQueue pointer could be null when we pass itto functions that reference it. The state machine ensures it can't benull then. Assert that, to hush the checker.
Signed-off-by: Markus Armbruster <armbru@redhat.com>...
usb-host: Drop superfluous null test from usb_host_auto_scan()
Coverity points out that port is later passed to usb_host_open(),which dereferences it. It actually can't be null: it always points tousb_host_scan()'s auto port[]. Drop the superfluous port == NULL...
usb-host: Initialize dev->port the obviously safe way
Coverity worries the strcpy() could overrun the destination. Itcan't, because the source always points to usb_host_scan()'s autoport[], which has the same size. Use pstrcpy() anyway, to hush thechecker....
xhci: create xhci_detach_slot helper function
xhci: call xhci_detach_slot on root port detach too
xhci: nuke transfe5rs on detach
build: remove CONFIG_SMARTCARD
The passthru smartcard does not have the shared library dependency, buildit unconditionally.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Make all static TypeInfos const
Since 39bffca2030950ef6efe57c2fac8327a45ae1015 (qdev: register alltypes natively through QEMU Object Model), TypeInfo as used inthe common, non-iterative pattern is no longer amended with informationand should therefore be const....
usbredir: Add support for buffered bulk input (v2)
Buffered bulk mode is intended for bulk input endpoints, where the data isof a streaming nature (not part of a command-response protocol). Theseendpoints' input buffer may overflow if data is not read quickly enough....
uhci: stop using portio lists
uhci: Fix 1 ms delay in interrupt reporting to the guest
Re-arrange how we process frames / increase frnum / report pending interrupts,to avoid a 1 ms delay in interrupt reporting to the guest. This increasesthe packet throughput for cases where the guest submits a single packet,...
uhci: Fix pending interrupts getting lost on migration
Signed-off-by: Hans de Goede <hdegoede@redhat.com>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
uhci: Add a QH_VALID define
Rather then using the magic 32 value in various places.
uhci: Limit amount of frames processed in one go
Before this patch uhci would process an unlimited amount of frames whenbehind on schedule, by setting the timer to a time already past, causing thetimer subsys to immediately recall the frame_timer function gain....
uhci: Maximize how many frames we catch up when behind
If somehow we've gotten behind a lot, simply skip ahead, like the ehci codedoes.
hid: Change idle handling to use a timer
This leads to cleaner code in usb-hid, and removes up to a 1000 calls / sec toqemu_get_clock_ns(vm_clock) if idle-time is set to its default value of 0.
usb: Fix usb_ep_find_packet_by_id
usb_ep_find_packet_by_id mistakenly only checks the first packet and if thatis not a match, keeps trying the first packet! This patch fixes this.
usb: Add an usb_device_ep_stopped USBDevice method
Some usb devices (host or network redirection) can benefit from knowing whenthe guest stops using an endpoint. Redirection may involve submitting packetsindependently from the guest (in combination with a fifo buffer between the...
usbredir: Add an usbredir_stop_ep helper function
usbredir: Add USBEP2I and I2USBEP helper macros
usbredir: Add ep_stopped USBDevice method
To ensure that interrupt receiving is properly stopped when the guest isno longer interested in an interrupt endpoint.
usbredir: Verify we have 32 bits bulk length cap when redirecting to xhci
The xhci-hcd may submit bulk transfers > 65535 bytes even when not usingbulk-in pipeling, so usbredir can only be used in combination with an xhcihcd if the client has the 32 bits bulk length capability....
usbredir: Add usbredir_init_endpoints() helper
usb-redir: Add debugging to bufpq save / restore
xhci: call set-address with dummy usbpacket
Due to the way devices are addressed with xhci (done by hardware, notthe guest os) there is no packet when invoking the set-address controlrequest. Create a dummy packet in that case to avoid null pointerdereferences....
usb/ehci: Clean up SysBus and PCI EHCI split
SysBus EHCI was introduced in a hurry before 1.3 Soft Freeze.To use QOM casts in place of DO_UPCAST() / FROM_SYSBUS(), we need anidentifying type. Introduce generic abstract base types for PCI andSysBus EHCI to allow multiple types to access the shared fields....
usb/ehci: Move capsbase and opregbase into SysBus EHCI class
This allows specific derived models to use different values.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
usb/ehci: Add SysBus EHCI device for Exynos4210
It uses a different capsbase and opregbase than the Xilinx device.
Signed-off-by: Liming Wang <walimisdev@gmail.com>Signed-off-by: Andreas Färber <andreas.faerber@web.de>Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>...
ehci: Add a ehci_writeback_async_complete_packet helper function
Also drop the warning printf, which was there mainly because this was anuntested code path (as the previous bug fixes to it show), but that nolonger is the case now :)
Signed-off-by: Hans de Goede <hdegoede@redhat.com>...
ehci: Add ehci_verify_qh and ehci_verify_qtd helper functions
ehci: Verify guest does not change the token of inflight qtd-s
This is not allowed, except for clearing active on cancellation, so don'twarn when the new token does not have its active bit set.
This unifies the cancellation path for modified qtd-s, and prepares...
ehci: Move get / put_dwords upwards
No other changes.
ehci: writeback_async_complete_packet: verify qh and qtd
ehci: Verify qtd for async completed packets
Remove the short-circuiting of fetchqtd in fetchqh, so that theqtd gets properly verified before completing the transaction.
ehci: Add an ehci_get_pid helper function
ehci: Verify a queue's ep direction does not change
ehci_fill_queue assumes that there is a one on one relationship between an epand a qh, this patch adds a check to ensure this.
Note I don't expect this to ever trigger, this is just something I noticed...
ehci: Use uframe precision for interrupt threshold checking (v2)
Before this patch, the following could happen:1) Transfer completes, raises interrupt2) .5 ms later we check if the guest has queued up any new transfers3) We find and execute a new transfer...
ehci: Further speedup rescanning if async schedule after raising an interrupt
I tried lowering the time between raising an interrupt and rescanning theasync schedule to see if the guest has queued a new transfer before, butthat did not have any positive effect. I now believe the cause for this is...
ehci: Don't call commit_irq after raising PCD
ehci_raise_irq(s, USBSTS_PCD), gets applied immediately so there is no needto call commit_irq after it.
usb/redirect.c: unbreak compilation due to include/char/char.h
Broken since:
commit 927d4878b0ff319ed87fed9363f314613b0a5ed9Author: Paolo Bonzini <pbonzini@redhat.com>Date: Mon Dec 17 18:20:05 2012 +0100
softmmu: move remaining include files to include/ subdirectories...
softmmu: move remaining include files to include/ subdirectories
softmmu: move include files to include/sysemu/
misc: move include files to include/qemu/
monitor: move include files to include/monitor/
janitor: add guards to headers
exec: move include files to include/exec/
ui: move files to ui/ and include/ui/
net: reorganize headers
Move public headers to include/net, and leave private headers in net/.Put the virtio headers in include/net/tap.h, removing the multiple copiesthat existed. Leave include/net/tap.h as the interface for NICs, andnet/tap_int.h as the interface for OS-specific parts of the tap backend....
net: move Bluetooth stuff out of net.h
janitor: do not rely on indirect inclusions of or from qemu-char.h
Various header files rely on qemu-char.h including qemu-config.h ormain-loop.h, but they really do not need qemu-char.h at all (particularlyinteresting is the case of the block layer!). Clean this up, and also...
pci: update all users to look in pci/
update all users so we can remove the makefile hack.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
usb-tablet: Allow connecting to ehci
Our ehci code has is capable of significantly lowering the wakeup ratefor the hcd emulation while the device is idle. It is possible to addsimilar code ot the uhci emulation, but that simply is not there atm,and there is no reason why a (virtual) usb-tablet can not be a USB-2 device....
usb: Call wakeup when data becomes available for all devices with int eps
This is necessary for proper interaction with the xhci controller, and itwill allow other hcds to lower there frame timer while waiting for interruptdata.
usb: Don't allow USB_RET_ASYNC for interrupt packets
It is tempting to use USB_RET_ASYNC for interrupt packets, rather then thecurrent NAK + polling approach, but this causes issues for migration, asan async completed packet will not getting written back to guest memory until...
usb: Allow overriding of usb_desc at the device level
This allows devices to present a different set of descriptors based ondevice properties.
ehci: Lower timer freq when the periodic schedule is idle
Lower the timer freq if no iso schedule packets complete for 64 frames ina row.
We can safely do this, without adding latency, because:1) If there is isoc traffic this will never trigger2) For async handled interrupt packets (only usb-host), the completion handler...
usb: tag usb host adapters as not hotpluggable.
Hotplugging them simply doesn't work, so tag them accordingly toavoid users trying and then crashing qemu.
For xhci there is nothing fundamental which prevents hotplug fromworking, we'll "only" need a exit() function which cleans up...
usb: fail usbdevice_create() when there is no USB bus
Report an error instead of segfaulting when attaching a USB device to amachine with no USB busses:
$ qemu-system-arm -machine vexpress-a9 \ -sd Fedora-17-armhfp-vexpress-mmcblk0.img \ -kernel vmlinuz-3.4.2-3.fc17.armv7hl \...
ehci-sysbus: Attach DMA context.
This was left as NULL on the initial merge due to debate on the mailing list onhow to handle DMA contexts for sysbus devices. Patch9e11908f12f92e31ea94dc2a4c962c836cba9f2a was later merged to fix OHCI. This is the,equivalent fix for sysbus EHCI....
uhci: Add a completions_only flag for async completions
Add a completions_only flag, and set this when running process_frame for asynccompletion handling, this fixes 2 issues in a single patch:
1) It makes sure async completed packets get written to guest mem immediately,...
uhci: Don't allow the guest to set port-enabled when there is no dev connected
It is possible for device disconnect and the guest trying to reset the port(because of USB xact errors prior to the disconnect getting signaled) to race,when we hit this race, the guest will write the port-control register with its...
uhci: Fix double unlink
uhci_async_cancel() already does a uhci_async_unlink().
usb-bt: Return NAK instead of STALL when interrupt ep has no data
I noticed this while making all devices with interrupt endpoints properlydo wakeup. While at it also add wakeup support.
Note that I've not tested this, but returning STALL for an interrupt ep...
usb-smartcard-reader: Properly NAK interrupt eps when we've no events
When we've no data to return from the interrupt endpoint, return NAK ratherthen a 0 length packet.
CC: Alon Levy <alevy@redhat.com>Signed-off-by: Hans de Goede <hdegoede@redhat.com>...
usb-redir: Split usb_handle_interrupt_data into separate in/out functions
No functional changes.
usb-redir: Don't handle interrupt output packets async
Instead report them as successfully completed directly on submission, thishas 2 advantages:
1) This matches the timing of interrupt output packets on real hardware,with the previous async handling, if an ep has an interval of say 500 ms,...
ehci: keep the frame timer running in case the guest asked for frame list rollover interrupts
ehci: handle dma errors
Starting with commit 1c380f9460522f32c8dd2577b2a53d518ec91c6d dmatransfers can actually fail. This patch makes ehci keep trackof the busmaster bit in pci config space, by setting/clearing thedma_context pointer. Attempts to dma without context will result...
usb-redir: Only add actually in flight packets to the in flight queue
Packets which are queued up, but not yet handed over to the device, arenot in flight.
usb-redir: Set default debug level to warning
The previous default of 0 means that even errors and warnings would notget printed, which is really not a good default.
usb-host: update tracing
Now that we have separate status and length fields in USBPacketupdate the completion tracepoint to log both.
usb-host: fix splitted transfers
USBPacket->actual_length wasn't updated correctly for USBPacketssplitted into multiple urbs. Fix it.