« Previous | Next » 

Revision 217bfb44

ID217bfb445b54db618a30f3a39170bebd9fd9dbf2

Added by Peter Maydell over 12 years ago

hw/arm_gic.c: Ignore attempts to complete nonexistent IRQs

Ignore attempts to complete non-existent IRQs; this fixes a buffer
overrun if the guest writes a bad value to the GICC_EOIR register.
(This case is UNPREDICTABLE so ignoring it is a valid choice.)
Note that doing nothing if the guest writes 1023 to this register
is not in fact a change in behaviour: the old code would also
always do nothing in this case but in a non-obvious way.
(The buffer overrun was noted by Coverity, see bug 887883.)

Signed-off-by: Peter Maydell <>
Signed-off-by: Andrzej Zaborowski <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences