« Previous | Next » 

Revision 2f61652d

ID2f61652d660ec1ffdadf926401a174c11f5c13a7

Added by Luiz Capitulino over 11 years ago

qmp: dump-guest-memory: don't spin if non-blocking fd would block

fd_write_vmcore() will indefinitely spin for a non-blocking
file-descriptor that would block. However, if the fd is non-blocking,
how does it make sense to spin?

Change this behavior to return an error instead.

Note that this can only happen with an fd provided by a management
application. The fd opened internally by dump-guest-memory is blocking.

While there, also fix 'writen_size' variable name.

Signed-off-by: Luiz Capitulino <>
Reviewed-by: Eric Blake <>
Reviewed-by: Markus Armbruster <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences