Statistics
| Branch: | Revision:

root / hw @ 49823868

# Date Author Comment
49823868 07/11/2010 08:00 pm Isaku Yamahata

pci: introduce multifunction property.

introduce multifunction property.
Also introduce new convenient device creation function which
will be used later.

For bisectability this patch doesn't do anything, but sets the property
resulting in no functional changes....

f4594a3b 07/11/2010 08:00 pm Isaku Yamahata

qdev: implement qdev_prop_set_bit().

implement qdev_prop_set_bit().

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Blue Swirl <>

e327e323 07/11/2010 08:00 pm Isaku Yamahata

pci: remove PCIDeviceInfo::header_type

replace PCIDeviceInfo::header_type with is_bridge
as suggested by Michael S. Tsirkin <>

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Blue Swirl <>

b80d4a98 07/11/2010 08:00 pm Isaku Yamahata

pci: don't overwrite multi functio bit in pci header type.

Don't overwrite pci header type.
Otherwise, multi function bit which pci_init_header_type() sets
appropriately is lost.
Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero
which is already zero cleared....

6fa84913 07/11/2010 08:00 pm Isaku Yamahata

pci: insert assert that auto-assigned-address function is single function device.

Auto-assigned-address pci function (passing devfn = -1) is always
single function.
This patch adds assert() to guarantee that auto-assigned-address function
is always single function device at function = 0....

520128bd 07/11/2010 07:58 pm Isaku Yamahata

pci: use PCI_DEVFN() where appropriate.

Use PCI_DEVFN() and PCI_FUNC_MAX where appropriate.
This patch make it clear that func = 0.

test:
The following object files with/without this patch are stripped and compared.
They remains same.
arm-softmmu/versatile_pci.o...

5efb397f 07/06/2010 06:48 pm Anthony Liguori

Merge remote branch 'kwolf/for-anthony' into staging

6772b936 07/06/2010 06:36 pm Alex Williamson

qdev: Add a get_dev_path() function to BusInfo

This function is meant to provide a stable device path for buses
which are able to implement it. If a bus has a globally unique
addresses scheme, one address level may be sufficient to provide
a path. Other buses may need to recursively traverse up the...

4f43c1ff 07/06/2010 06:36 pm Alex Williamson

pci: Implement BusInfo.get_dev_path()

This works great for PCI since a <segment>:<bus>:<dev>.<fn> uniquely
describes a global address. No need to traverse up the qdev tree.
PCI segment support is a placeholder for compatibility once we
support multiple segments....

0be71e32 07/06/2010 06:36 pm Alex Williamson

savevm: Add DeviceState param

When available, we'd like to be able to access the DeviceState
when registering a savevm. For buses with a get_dev_path()
function, this will allow us to create more unique savevm
id strings.

Signed-off-by: Alex Williamson <>...

5fce2b3e 07/06/2010 06:36 pm Alex Williamson

eepro100: Add a dev field to eeprom new/free functions

This allows us to create a more meaningful savevm string.

Signed-off-by: Alex Williamson <>
Signed-off-by: Anthony Liguori <>

01657c86 07/06/2010 06:36 pm Alex Williamson

virtio-net: Incorporate a DeviceState pointer and let savevm track instances

Stuff a pointer to the DeviceState into the VirtIONet structure so that
we can easily remove the vmstate entry later. Also, let vmstate track
the instance number (it should always be zero internally since the...

1724f049 07/06/2010 06:36 pm Alex Williamson

qemu_ram_alloc: Add DeviceState and name parameters

These will be used to generate unique id strings for ramblocks. The name
field is required, the device pointer is optional as most callers don't
have a device. When there's no device or the device isn't a child of...

230741dc 07/06/2010 06:36 pm Alex Williamson

pci: Free the space allocated for the option rom on removal

Signed-off-by: Alex Williamson <>
Signed-off-by: Anthony Liguori <>

680a34ee 07/06/2010 06:36 pm Jan Kiszka

scsi: Fix SCSI bus reset

When the controller raises the SCSI reset line, we have to perform the
requested reset on all disks attached to the controller's bus. Moreover,
reset is edge triggered, so avoid repeating it if the line was already
high.

Signed-off-by: Jan Kiszka <>...

f292787d 07/06/2010 06:36 pm Gleb Natapov

make rtc alatm work

Convert alarm time from BCD if needed before comparing with current
time.

Signed-off-by: Gleb Natapov <>
Signed-off-by: Anthony Liguori <>

44ae28f3 07/06/2010 06:36 pm Alex Williamson

pc: Allocate all ram in a single qemu_ram_alloc()

This will benefit us when we migrate based on ramblock name since
we won't be bouncing between separate blocks.

Signed-off-by: Alex Williamson <>
Signed-off-by: Anthony Liguori <>

7aa9c811 07/06/2010 06:05 pm Markus Armbruster

ide: Reject readonly drives unless CD-ROM

drive_init() doesn't permit option readonly for if=ide, but that's
worthless: we get it via if=none and -device.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>

dce9e928 07/06/2010 06:05 pm Markus Armbruster

ide: Reject invalid CHS geometry

drive_init() doesn't permit invalid CHS for if=ide, but that's
worthless: we get it via if=none and -device.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>

2930b313 07/06/2010 06:05 pm john cooper

Add virtio disk identification support

This patch adds the final missing bits for support of
passing a serial/id string to a virtio-blk guest driver.

The guest-side component already exists in the virtio
driver, and has recently been reworked by Ryan to export...

b47b3525 07/06/2010 06:05 pm Markus Armbruster

fdc: Reject unimplemented error actions

drive_init() doesn't permit them for if=floppy, but that's worthless:
we get them via if=none and -global.

This can make device initialization fail. Since all callers of
fdctrl_init_isa() ignore its value, change it to die instead of...

bd6c9a61 07/06/2010 06:05 pm Markus Armbruster

qdev: Don't hw_error() in qdev_init_nofail()

Some of the failures are internal errors, and hw_error() is okay then.
But the common way to fail is bad user input, e.g. -global
isa-fdc.driveA=foo where drive foo has an unsupported rerror value.

exit(1) instead....

620f862e 07/06/2010 06:05 pm Markus Armbruster

scsi: Reject unimplemented error actions

drive_init() doesn't permit rerror for if=scsi, but that's worthless:
we get it via if=none and -device.

Moreover, scsi-generic doesn't support werror. Since drive_init()
doesn't catch that, option werror was silently ignored even with...

42e766a2 07/06/2010 06:05 pm Markus Armbruster

scsi: Error locations for -drive if=scsi device initialization

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>

f597627f 07/06/2010 06:05 pm Markus Armbruster

ide: Improve error messages

Use error_report(), because it points to the error location.

Reword "tried to assign twice" messages to make it clear that we're
complaining about the unit property.

Report invalid unit property instead of failing silently.
...

cd8722bb 07/06/2010 06:05 pm Markus Armbruster

ide: Replace IDEState members is_cdrom, is_cf by drive_kind

The two aren't independent variables. Make that obvious.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>

c4d74df7 07/06/2010 06:05 pm Markus Armbruster

ide: Make ide_init_drive() return success

It still always succeeds. The next commits will add failures.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>

734003e6 07/06/2010 04:31 pm Anthony Liguori

Merge remote branch 'kwolf/for-anthony' into staging

a88790a1 07/03/2010 09:48 am Paolo Bonzini

remove exec-all.h inclusion from cpu.h

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Blue Swirl <>

f8b6cc00 07/02/2010 02:18 pm Markus Armbruster

qdev: Decouple qdev_prop_drive from DriveInfo

Make the property point to BlockDriverState, cutting out the DriveInfo
middleman. This prepares the ground for block devices that don't have
a DriveInfo.

Currently all user-defined ones have a DriveInfo, because the only way...

18846dee 07/02/2010 02:18 pm Markus Armbruster

block: Catch attempt to attach multiple devices to a blockdev

For instance, -device scsi-disk,drive=foo -device scsi-disk,drive=foo
happily creates two SCSI disks connected to the same block device.
It's all downhill from there.

Device usb-storage deliberately attaches twice to the same blockdev,...

7d0d6950 07/02/2010 02:18 pm Markus Armbruster

block: Fix virtual media change for if=none

BlockDriverState member removable controls whether virtual media
change (monitor commands change, eject) is allowed. It is set when
the "type hint" is BDRV_TYPE_CDROM or BDRV_TYPE_FLOPPY.

The type hint is only set by drive_init(). It sets BDRV_TYPE_FLOPPY...

57c88866 07/02/2010 02:18 pm Markus Armbruster

ide: Make PIIX and ISA IDE init functions return the qdev

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>

c0897e0c 07/02/2010 02:18 pm Markus Armbruster

pc: Fix CMOS info for drives defined with -device

Drives defined with drive if=ide get get created along with the IDE
controller, inside machine
>init(). That's before cmos_init().
Drives defined with -device get created during generic device init.
That's after cmos_init(). Because of that, CMOS has no information on...

fa66b909 07/02/2010 02:18 pm Markus Armbruster

scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers

None of its callers checks for failure. scsi_hot_add() can crash
because of that:

(qemu) drive_add 4 if=scsi,format=host_device,file=/dev/sg1
scsi-generic: scsi generic interface too old
Segmentation fault (core dumped)...

fa12fbbe 07/02/2010 02:18 pm Markus Armbruster

ide: Make it explicit that ide_create_drive() can't fail

All callers of ide_create_drive() ignore its value. Currently
harmless, because it fails only when qdev_init() fails, which fails
only when ide_drive_initfn() fails, which never fails.

Brittle. Change it to die instead of silently ignoring failure....

14bafc54 07/02/2010 02:18 pm Markus Armbruster

blockdev: Clean up automatic drive deletion

We automatically delete blockdev host parts on unplug of the guest
device. Too much magic, but we can't change that now.

The delete happens early in the guest device teardown, before the
connection to the host part is severed. Thus, the guest part's...

449041d4 06/30/2010 11:58 pm Kevin Wolf

qdev-properties: Fix (u)intXX parsers

scanf calls must not use PRI constants, they have probably the wrong size and
corrupt memory. We could replace them by SCN ones, but strtol is simpler than
scanf here anyway. While at it, also fix the parsers to reject garbage after...

6881dd5f 06/30/2010 09:43 pm TeLeMan

usb-uhci: fix commit 8e65b7c04965c8355e4ce43211582b6b83054e3d for vmstate

The commit 8e65b7c04965c8355e4ce43211582b6b83054e3d introduced
expire_time of UHCIState. But expire_time is not in vmstate, the
second uhci_frame_timer will not be fired immediately after loadvm....

c1ff227b 06/30/2010 09:41 pm cmchao

hw/omap : make local function static and remove declaration from header

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

7f132a21 06/30/2010 09:41 pm cmchao

hw/omap1.c : separate interrupt controller module

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

2d08cc7c 06/30/2010 09:41 pm cmchao

hw/omap2.c : separate spi module

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

cc9577cf 06/30/2010 09:41 pm cmchao

hw/omap2.c : separate tap module(Test-Chip-level)

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

2c1d9ecb 06/30/2010 09:41 pm cmchao

hw/omwp2.c : separate l4 interconnect module

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

02d74341 06/30/2010 09:41 pm cmchao

hw/omap1.c : separate uart module

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

d82310f7 06/30/2010 09:41 pm cmchao

hw/omap2.c : separate gpio module

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

c58d37cf 06/30/2010 09:41 pm cmchao

hw/omap2.c : separate gptimer module

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

011d87d0 06/30/2010 09:41 pm cmchao

hw/omap2.c : separate synctimer module

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

f3354b0e 06/30/2010 09:41 pm cmchao

hw/omap2.c : separate gpmc(general purpose memory controller)

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

0bf43016 06/30/2010 09:41 pm cmchao

hw/omap2.c : separate sdrc (sdram controller)

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

e5c6b25a 06/30/2010 09:41 pm cmchao

hw/omap1.c : separate gpio module

Signed-off-by: cmchao <>
Signed-off-by: Aurelien Jarno <>

f83ccb3e 06/30/2010 09:38 pm Markus Armbruster

virtio-serial: Simplify virtio_serial_load()

For all i, ports_map[i] is used in and only in the i-th iteration.
Replace the dynamic array by a scalar variable.

Signed-off-by: Markus Armbruster <>
Acked-by: Amit Shah <>...

81bf96d3 06/30/2010 09:35 pm Markus Armbruster

usb-serial: Fail instead of crash when chardev is missing

Signed-off-by: Markus Armbruster <>
Acked-by: Gerd Hoffmann <>
Signed-off-by: Aurelien Jarno <>

33dd2983 06/30/2010 08:39 pm Aurelien Jarno

MIPS: fix fulong bios loading

Signed-off-by: Aurelien Jarno <>

45e7e4bc 06/30/2010 12:26 am Aurelien Jarno

r2d: fix pflash mapping

Signed-off-by: Aurelien Jarno <>

016512f3 06/30/2010 12:07 am Huacai Chen

MIPS: Initial support of VIA IDE controller used by fulong mini pc

Signed-off-by: Huacai Chen <>
Signed-off-by: Aurelien Jarno <>

30235a54 06/30/2010 12:07 am Huacai Chen

MIPS: Initial support of VIA USB controller used by fulong mini pc

Signed-off-by: Huacai Chen <>
Signed-off-by: Aurelien Jarno <>

051c190b 06/30/2010 12:07 am Huacai Chen

MIPS: Initial support of fulong mini pc (machine construction)

Signed-off-by: Huacai Chen <>
Signed-off-by: Aurelien Jarno <>

d1d74664 06/30/2010 12:07 am Paolo Bonzini

lsi53c895a: fix Phase Mismatch Jump

lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does
not matter with Linux guests because it uses just one routine for
both, but it breaks Windows 64-bit guests. This is the text
from the spec:

"[The PMJCTL] bit controls which decision mechanism is used...
d0f7453d 06/30/2010 12:07 am Huacai Chen

MIPS: Initial support of bonito north bridge used by fulong mini pc

Signed-off-by: Huacai Chen <>
Signed-off-by: Aurelien Jarno <>

edf79e66 06/30/2010 12:07 am Huacai Chen

Initial support of vt82686b south bridge used by fulong mini pc

Signed-off-by: Huacai Chen <>
Signed-off-by: Aurelien Jarno <>

427bd8d6 06/27/2010 07:08 pm Jan Kiszka

x86: Clean up CPU reset

Signed-off-by: Jan Kiszka <>
Signed-off-by: Blue Swirl <>

94c5f455 06/27/2010 07:06 pm Artyom Tarasenko

mask all interrupts when MASTER_DISABLE is set

The MASTER_DISABLE bit (aka mask-all) masks all the interrupts.

According to Sun-4M System Architecture
"The level–15 interrupt sources [...] are maskable with the Interrupt Target
Mask Register. While these interrupts are considered ’non–maskable’ within...

3a5c16fc 06/27/2010 07:04 pm Blue Swirl

fw_cfg: convert to qdev

Convert fw_cfg to qdev.

Signed-off-by: Blue Swirl <>

738012be 06/27/2010 07:04 pm Blue Swirl

Remove useless device dependency of HAS_AUDIO

System architecture dictates whether HAS_AUDIO is defined. It's then
useless to check for HAS_AUDIO in files which are only used on those
architectures which always have audio.

Signed-off-by: Blue Swirl <>

00ec5c37 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Security model for mkdir

Signed-off-by: Venkateswararao Jujjuri <>
Signed-off-by: Anthony Liguori <>

879c2813 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Security model for symlink and readlink

Mapped mode stores extended attributes in the user space of the extended
attributes. Given that the user space extended attributes are available
to regular files only, special files are created as regular files on the...

1c293312 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Implement Security model for mknod

Mapped mode stores extended attributes in the user space of the extended
attributes. Given that the user space extended attributes are available
to regular files only, special files are created as regular files on the...

63729c36 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Implement Security model for mksock using mknod.

This patch uses mknod to create socket.

On Host/Fileserver:
rw------. 1 virfsuid virtfsgid 0 2010-05-11 09:57 asocket1

On Guest/Client:
srwxr-xr-x 1 guestuser guestuser 0 2010-05-11 12:57 asocket1...

8a911107 06/22/2010 11:15 pm Alex Williamson

virtio-pci: fix bus master bug setting on load

The comment suggests we're checking for the driver in the ready
state and bus master disabled, but the code is checking that it's
not in the ready state.

Signed-off-by: Alex Williamson <>...

758e8e38 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Make infrastructure for the new security model.

This patch adds required infrastructure for the new security model.

- A new configure option for attr/xattr.
- if CONFIG_VIRTFS will be defined if both CONFIG_LINUX and CONFIG_ATTR defined.
- Defines routines related to both security models....

e95ead32 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Security model for chmod

Signed-off-by: Venkateswararao Jujjuri <>
Signed-off-by: Anthony Liguori <>

f7613bee 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Security model for chown

mapped model changes the owner in the extended attributes.
passthrough model does the change through lchown() as the
server don't need to follow the link and client will send the
actual filesystem object.

Signed-off-by: Venkateswararao Jujjuri <>...

1237ad76 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Implemented Security model for lstat and fstat

Signed-off-by: Venkateswararao Jujjuri <>
Signed-off-by: Anthony Liguori <>

4750a96f 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Security model for create/open2

In the mapped security model, VirtFS server intercepts and maps
the file object create and get/set attribute requests. Files on the fileserver
will be created with VirtFS servers (QEMU) user credentials and the
client-users credentials are stored in extended attributes. On the request...

0db09dd2 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

Flush the debug message out to the log file.

This patch fluesh the debug messages to the log file at the end of each
debug message.

Changes from V1:
Used fflush instead fseek for the flush.

Signed-off-by: Venkateswararao Jujjuri <>...

fac4f111 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Rearrange fileop structures

This patch rearranges the fileop structures by moving the structure definitions
from virtio-9p.c to virtio-9p.h file. No functional changes.

Signed-off-by: Venkateswararao Jujjuri <>
Signed-off-by: Anthony Liguori <>

9ce56db6 06/22/2010 11:15 pm Venkateswararao Jujjuri (JV)

virtio-9p: Introduces an option to specify the security model.

The new option is:

-fsdev fstype,id=myid,path=/share_path/,security_model=[mapped|passthrough]
-virtfs fstype,path=/share_path/,security_model=[mapped|passthrough],mnt_tag=tag

In the case of mapped security model, files are created with QEMU user...

20a81e4d 06/22/2010 03:38 pm Yoshiaki Tamura

virtio-blk: fix the list operation in virtio_blk_load().

Although it is really rare to get in to the while loop, the list
operation in the loop is obviously wrong.

Signed-off-by: Yoshiaki Tamura <>
Signed-off-by: Kevin Wolf <>

01bedeba 06/22/2010 03:38 pm Nicholas Bellinger

scsi-bus: Add PERSISTENT_RESERVE_OUT SCSIRequest->cmd.mode setup

This patch updates hw/scsi-bus.c to add the PERSISTENT_RESERVE_OUT cdb
case in scsi_req_xfer_mode() to set SCSI_XFER_TO_DEV for outgoing WRITE data.

Signed-off-by: Nicholas A. Bellinger <>...

c7126d5b 06/22/2010 03:38 pm Nicholas Bellinger

scsi-bus: Add MAINTENANCE_IN and MAINTENANCE_OUT SCSIRequest xfer and mode assignments

This patch updates hw/scsi-bus.c to add MAINTENANCE_IN and MAINTENANCE_OUT case in
scsi_req_length() for TYPE_ROM with MMC commands. It also adds the MAINTENANCE_OUT
case in scsi_req_xfer_mode() to set SCSI_XFER_TO_DEV for outgoing write data....

92a16d7a 06/19/2010 10:47 am Blue Swirl

apic: qdev conversion cleanup

Make APICState completely private to apic.c by using DeviceState
in external APIs.

Move apic_init() to pc.c.

Signed-off-by: Blue Swirl <>

8546b099 06/19/2010 10:44 am Blue Swirl

apic: convert to qdev

Convert to qdev.

Use an opaque CPUState pointer because of missing VMState
implementation for CPUState.

Signed-off-by: Blue Swirl <>

0e26b7b8 06/19/2010 10:42 am Blue Swirl

apic: avoid using CPUState internals

Move the actual CPUState contents handling to cpu.h and cpuid.c.

Handle CPU reset and set env->halted in pc.c.

Add a function to get the local APIC state of the current
CPU for the MMIO.

Signed-off-by: Blue Swirl <>

4a942cea 06/19/2010 10:42 am Blue Swirl

apic: avoid passing CPUState from CPU code

Pass only APICState when accessing APIC from CPU code.

Signed-off-by: Blue Swirl <>

cf6d64bf 06/19/2010 10:42 am Blue Swirl

apic: avoid passing CPUState from devices

Pass only APICState from pc.c.

Signed-off-by: Blue Swirl <>

96051119 06/19/2010 10:41 am Blue Swirl

ioapic: convert to qdev

Convert to qdev.

Signed-off-by: Blue Swirl <>

7d0500c4 06/17/2010 07:32 pm Blue Swirl

ioapic: unexport ioapic_set_irq

There's no need to use ioapic_set_irq() outside of ioapic.c, so
make it static.

Signed-off-by: Blue Swirl <>

d2c5efd8 06/16/2010 12:43 am Stefan Weil

Fix comparison which always returned false

Comparing an 8 bit value with ~0 does not work as expected.
Replace ~0 by UINT8_MAX in comparison and also in assignment
(and fix coding style, too).

Cc: Gleb Natapov <>
Cc: Anthony Liguori <>...

167e609a 06/15/2010 11:59 am Jan Kiszka

xen: Fix build error due to missing include

Signed-off-by: Jan Kiszka <>
Signed-off-by: Kevin Wolf <>

abd7f68d 06/15/2010 10:41 am Markus Armbruster

block: Move error actions from DriveInfo to BlockDriverState

That's where they belong semantically (block device host part), even
though the actions are actually executed by guest device code.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>

bb350a5e 06/15/2010 10:41 am Jes Sorensen

Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE

Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE in hw/fdc.c

Per https://bugs.launchpad.net/qemu/+bug/424453 the correct values
for FD_CMD_SAVE is 0x2e and FD_CMD_RESTORE is 0x4e. Verified against...

46aaebff 06/14/2010 11:46 pm Jes Sorensen

un-register kbd driver in case of USB kbd unplug.

If a USB keyboard is unplugged, the keyboard eventhandler is never
removed, and events will continue to be passed through to the device,
causing crashes or memory corruption.

Signed-off-by: Jes Sorensen <>...

7e608e89 06/14/2010 11:46 pm Christoph Hellwig

virtio-blk: stop tracking old_bs

There is a 1:1 relation between VirtIOBlock and BlockDriverState instances,
no need to track it because it won't change.

Signed-off-by: Christoph Hellwig <>
Signed-off-by: Anthony Liguori <>

c20fd872 06/14/2010 11:46 pm Christoph Hellwig

virtio-blk: simplify multiwrite calling conventions

Pass the MultiReqBuffer structure down all the way to the I/O submission
instead of takin it apart. Also mark num_writes unsigned as it can't
go negative, and take the check for any pending I/O requests into the...

3709c1b7 06/14/2010 11:46 pm Daniel P. Berrange

Clarify error message when a PCI slot is already in use (v2)

When mistakenly configuring two devices in the same PCI slot,
QEMU gives a not entirely obvious message about a 'devfn' being
in use:

$ qemu -device rtl8139 -device virtio-balloon-pci,bus=pci.0,addr=0x3...

1bb65042 06/14/2010 11:46 pm Markus Armbruster

qdev: Revert the hack to let -net nic and pci_add set qdev ID

Setting the ID in pci_nic_init() is a blatant violation of the
DeviceState abstraction. Which even carries a comment advising
against this:

/* This structure should not be accessed directly. We declare it here...

4cf3e6f3 06/14/2010 11:46 pm Alex Williamson

acpi_piix4: save gpe and pci hotplug slot status

PCI hotplug currently doesn't work after a migration because
we don't migrate the enable bits of the GPE state. Pull hotplug
structs into vmstate.

Signed-off-by: Alex Williamson <>...

f2fcffbb 06/14/2010 07:41 pm Edgar E. Iglesias

etrax-ser: Support the uart rx fifo.

Add support for the rx fifo to speed up bulk transfers.

Signed-off-by: Edgar E. Iglesias <>

40ac17cd 06/14/2010 07:12 pm Gleb Natapov

pass info about hpets to seabios.]

Currently HPET ACPI table is created regardless of whether qemu actually
created hpet device. This may confuse some guests that don't check that
hpet is functional before using it. Solve this by passing info about
hpets in qemu to seabios via fw config interface. Additional benefit is...