« Previous | Next » 

Revision 57285302

ID57285302af51a8bae334c03e1f8243e935373953

Added by Michael Ellerman over 12 years ago

pseries: Check we have a chardev in spapr_vty_init()

If qemu is run like:

qemu-system-ppc64 -nodefaults -device spapr-vty

We end up in spapr_vty_init() with dev->chardev == NULL. Currently
that leads to a segfault because we unconditionally call
qemu_chr_add_handlers().

Although we could make that call conditional, I think a spapr-vty
without a chardev is basically useless so fail the init. This is
similar to what the serial code does for example.

Signed-off-by: Michael Ellerman <>
Signed-off-by: David Gibson <>
Signed-off-by: Alexander Graf <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences