« Previous | Next » 

Revision 57b6bdf3

ID57b6bdf37c64985cf02b8737c550d52759059c9d

Added by Benoît Canet about 10 years ago

blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.

As bdrv_open() documentation states:
"The reference to the QDict belongs to the block layer * after the call (even on failure), so if the caller intends to reuse the * dictionary, it needs to use QINCREF before calling bdrv_open."

the optional options dict will not be reused after bdrv_open() and should
belong to the block layer so remove the extra QDECREF.

Signed-off-by: Benoit Canet <>
Reviewed-by: Kevin Wolf <>
Signed-off-by: Stefan Hajnoczi <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences