Revision 697a77e6
ID | 697a77e6e7357f4ae6c74f06a4fa31701442d79d |
sparc64 support TSB related MMU registers
Posting updated patch to the list...
On Fri, Apr 24, 2009 at 9:42 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
>
> Nice, though I didn't notice any visible improvement in my tests.This early in boot process there is not much to output; and I test
recent kernel which may use different startup sequence.
I modified openbios cif handler to output arguments and I now can see
visible difference.>
> About the patch, there are a few problems:
> - it breaks Sparc32You mean it stops working?
Does not even build.
Fixed now.
> - commented out code is ugly
> - if and else should be on the same line as '{' or '}'
> - long lines should be wrapped
> - in the line:
> + return (((tag_access_register & 0x1fff)<<48)|(tag_access_register >> 22));
> there should be white space between ) and << and 48.
>
Also the ")|(" in between is crowded.
Maybe the coding style does not describe this well enough.
BTW Supplying indent template would be great.
Please see the updated patch qemu-sparc64-tsb-asi-2.patch attached.
--
Kind regards,
Igor V. Kovalenko
Files
- added
- modified
- copied
- renamed
- deleted