Statistics
| Branch: | Revision:

root / hw / pl110.c @ 70705261

History | View | Annotate | Download (10.1 kB)

1 bdd5003a pbrook
/* 
2 bdd5003a pbrook
 * Arm PrimeCell PL110 Color LCD Controller
3 bdd5003a pbrook
 *
4 cdbdb648 pbrook
 * Copyright (c) 2005-2006 CodeSourcery.
5 bdd5003a pbrook
 * Written by Paul Brook
6 bdd5003a pbrook
 *
7 bdd5003a pbrook
 * This code is licenced under the GNU LGPL
8 bdd5003a pbrook
 */
9 bdd5003a pbrook
10 bdd5003a pbrook
#include "vl.h"
11 bdd5003a pbrook
12 bdd5003a pbrook
#define PL110_CR_EN   0x001
13 bdd5003a pbrook
#define PL110_CR_BEBO 0x200
14 bdd5003a pbrook
#define PL110_CR_BEPO 0x400
15 bdd5003a pbrook
#define PL110_CR_PWR  0x800
16 bdd5003a pbrook
17 bdd5003a pbrook
enum pl110_bppmode
18 bdd5003a pbrook
{
19 bdd5003a pbrook
    BPP_1,
20 bdd5003a pbrook
    BPP_2,
21 bdd5003a pbrook
    BPP_4,
22 bdd5003a pbrook
    BPP_8,
23 bdd5003a pbrook
    BPP_16,
24 bdd5003a pbrook
    BPP_32
25 bdd5003a pbrook
};
26 bdd5003a pbrook
27 bdd5003a pbrook
typedef struct {
28 bdd5003a pbrook
    uint32_t base;
29 bdd5003a pbrook
    DisplayState *ds;
30 cdbdb648 pbrook
    /* The Versatile/PB uses a slightly modified PL110 controller.  */
31 cdbdb648 pbrook
    int versatile;
32 bdd5003a pbrook
    void *pic;
33 bdd5003a pbrook
    uint32_t timing[4];
34 bdd5003a pbrook
    uint32_t cr;
35 bdd5003a pbrook
    uint32_t upbase;
36 bdd5003a pbrook
    uint32_t lpbase;
37 bdd5003a pbrook
    uint32_t int_status;
38 bdd5003a pbrook
    uint32_t int_mask;
39 bdd5003a pbrook
    int cols;
40 bdd5003a pbrook
    int rows;
41 bdd5003a pbrook
    enum pl110_bppmode bpp;
42 bdd5003a pbrook
    int invalidate;
43 bdd5003a pbrook
    uint32_t pallette[256];
44 bdd5003a pbrook
    uint32_t raw_pallette[128];
45 bdd5003a pbrook
    int irq;
46 bdd5003a pbrook
} pl110_state;
47 bdd5003a pbrook
48 bdd5003a pbrook
static const unsigned char pl110_id[] =
49 bdd5003a pbrook
{ 0x10, 0x11, 0x04, 0x00, 0x0d, 0xf0, 0x05, 0xb1 };
50 bdd5003a pbrook
51 cdbdb648 pbrook
/* The Arm documentation (DDI0224C) says the CLDC on the Versatile board
52 cdbdb648 pbrook
   has a different ID.  However Linux only looks for the normal ID.  */
53 cdbdb648 pbrook
#if 0
54 cdbdb648 pbrook
static const unsigned char pl110_versatile_id[] =
55 cdbdb648 pbrook
{ 0x93, 0x10, 0x04, 0x00, 0x0d, 0xf0, 0x05, 0xb1 };
56 cdbdb648 pbrook
#else
57 cdbdb648 pbrook
#define pl110_versatile_id pl110_id
58 cdbdb648 pbrook
#endif
59 cdbdb648 pbrook
60 bdd5003a pbrook
static inline uint32_t rgb_to_pixel8(unsigned int r, unsigned int g, unsigned b)
61 bdd5003a pbrook
{
62 bdd5003a pbrook
    return ((r >> 5) << 5) | ((g >> 5) << 2) | (b >> 6);
63 bdd5003a pbrook
}
64 bdd5003a pbrook
65 bdd5003a pbrook
static inline uint32_t rgb_to_pixel15(unsigned int r, unsigned int g, unsigned b)
66 bdd5003a pbrook
{
67 bdd5003a pbrook
    return ((r >> 3) << 10) | ((g >> 3) << 5) | (b >> 3);
68 bdd5003a pbrook
}
69 bdd5003a pbrook
70 bdd5003a pbrook
static inline uint32_t rgb_to_pixel16(unsigned int r, unsigned int g, unsigned b)
71 bdd5003a pbrook
{
72 bdd5003a pbrook
    return ((r >> 3) << 11) | ((g >> 2) << 5) | (b >> 3);
73 bdd5003a pbrook
}
74 bdd5003a pbrook
75 bdd5003a pbrook
static inline uint32_t rgb_to_pixel24(unsigned int r, unsigned int g, unsigned b)
76 bdd5003a pbrook
{
77 bdd5003a pbrook
    return (r << 16) | (g << 8) | b;
78 bdd5003a pbrook
}
79 bdd5003a pbrook
80 bdd5003a pbrook
static inline uint32_t rgb_to_pixel32(unsigned int r, unsigned int g, unsigned b)
81 bdd5003a pbrook
{
82 bdd5003a pbrook
    return (r << 16) | (g << 8) | b;
83 bdd5003a pbrook
}
84 bdd5003a pbrook
85 bdd5003a pbrook
typedef void (*drawfn)(uint32_t *, uint8_t *, const uint8_t *, int);
86 bdd5003a pbrook
87 bdd5003a pbrook
#define BITS 8
88 bdd5003a pbrook
#include "pl110_template.h"
89 bdd5003a pbrook
#define BITS 15
90 bdd5003a pbrook
#include "pl110_template.h"
91 bdd5003a pbrook
#define BITS 16
92 bdd5003a pbrook
#include "pl110_template.h"
93 bdd5003a pbrook
#define BITS 24
94 bdd5003a pbrook
#include "pl110_template.h"
95 bdd5003a pbrook
#define BITS 32
96 bdd5003a pbrook
#include "pl110_template.h"
97 bdd5003a pbrook
98 bdd5003a pbrook
static int pl110_enabled(pl110_state *s)
99 bdd5003a pbrook
{
100 bdd5003a pbrook
  return (s->cr & PL110_CR_EN) && (s->cr & PL110_CR_PWR);
101 bdd5003a pbrook
}
102 bdd5003a pbrook
103 95219897 pbrook
static void pl110_update_display(void *opaque)
104 bdd5003a pbrook
{
105 bdd5003a pbrook
    pl110_state *s = (pl110_state *)opaque;
106 bdd5003a pbrook
    drawfn* fntable;
107 bdd5003a pbrook
    drawfn fn;
108 bdd5003a pbrook
    uint32_t *pallette;
109 bdd5003a pbrook
    uint32_t addr;
110 bdd5003a pbrook
    uint32_t base;
111 bdd5003a pbrook
    int dest_width;
112 bdd5003a pbrook
    int src_width;
113 bdd5003a pbrook
    uint8_t *dest;
114 bdd5003a pbrook
    uint8_t *src;
115 cdbdb648 pbrook
    int first, last = 0;
116 bdd5003a pbrook
    int dirty, new_dirty;
117 bdd5003a pbrook
    int i;
118 bdd5003a pbrook
119 bdd5003a pbrook
    if (!pl110_enabled(s))
120 bdd5003a pbrook
        return;
121 bdd5003a pbrook
    
122 bdd5003a pbrook
    switch (s->ds->depth) {
123 af2f6733 pbrook
    case 0:
124 af2f6733 pbrook
        return;
125 bdd5003a pbrook
    case 8:
126 bdd5003a pbrook
        fntable = pl110_draw_fn_8;
127 bdd5003a pbrook
        dest_width = 1;
128 bdd5003a pbrook
        break;
129 bdd5003a pbrook
    case 15:
130 bdd5003a pbrook
        fntable = pl110_draw_fn_15;
131 bdd5003a pbrook
        dest_width = 2;
132 bdd5003a pbrook
        break;
133 bdd5003a pbrook
    case 16:
134 bdd5003a pbrook
        fntable = pl110_draw_fn_16;
135 bdd5003a pbrook
        dest_width = 2;
136 bdd5003a pbrook
        break;
137 bdd5003a pbrook
    case 24:
138 bdd5003a pbrook
        fntable = pl110_draw_fn_24;
139 bdd5003a pbrook
        dest_width = 3;
140 bdd5003a pbrook
        break;
141 bdd5003a pbrook
    case 32:
142 bdd5003a pbrook
        fntable = pl110_draw_fn_32;
143 bdd5003a pbrook
        dest_width = 4;
144 bdd5003a pbrook
        break;
145 bdd5003a pbrook
    default:
146 af2f6733 pbrook
        fprintf(stderr, "pl110: Bad color depth\n");
147 bdd5003a pbrook
        exit(1);
148 bdd5003a pbrook
    }
149 bdd5003a pbrook
    if (s->cr & PL110_CR_BEBO)
150 bdd5003a pbrook
      fn = fntable[s->bpp + 6];
151 bdd5003a pbrook
    else if (s->cr & PL110_CR_BEPO)
152 bdd5003a pbrook
      fn = fntable[s->bpp + 12];
153 bdd5003a pbrook
    else
154 bdd5003a pbrook
      fn = fntable[s->bpp];
155 bdd5003a pbrook
    
156 bdd5003a pbrook
    src_width = s->cols;
157 bdd5003a pbrook
    switch (s->bpp) {
158 bdd5003a pbrook
    case BPP_1:
159 bdd5003a pbrook
        src_width >>= 3;
160 bdd5003a pbrook
        break;
161 bdd5003a pbrook
    case BPP_2:
162 bdd5003a pbrook
        src_width >>= 2;
163 bdd5003a pbrook
        break;
164 bdd5003a pbrook
    case BPP_4:
165 bdd5003a pbrook
        src_width >>= 1;
166 bdd5003a pbrook
        break;
167 bdd5003a pbrook
    case BPP_8:
168 bdd5003a pbrook
        break;
169 bdd5003a pbrook
    case BPP_16:
170 bdd5003a pbrook
        src_width <<= 1;
171 bdd5003a pbrook
        break;
172 bdd5003a pbrook
    case BPP_32:
173 bdd5003a pbrook
        src_width <<= 2;
174 bdd5003a pbrook
        break;
175 bdd5003a pbrook
    }
176 bdd5003a pbrook
    dest_width *= s->cols;
177 bdd5003a pbrook
    pallette = s->pallette;
178 bdd5003a pbrook
    base = s->upbase;
179 bdd5003a pbrook
    /* HACK: Arm aliases physical memory at 0x80000000.  */
180 bdd5003a pbrook
    if (base > 0x80000000)
181 bdd5003a pbrook
        base -= 0x80000000;
182 bdd5003a pbrook
    src = phys_ram_base + base;
183 bdd5003a pbrook
    dest = s->ds->data;
184 bdd5003a pbrook
    first = -1;
185 bdd5003a pbrook
    addr = base;
186 bdd5003a pbrook
187 bdd5003a pbrook
    dirty = cpu_physical_memory_get_dirty(addr, VGA_DIRTY_FLAG);
188 e6e5906b pbrook
    new_dirty = dirty;
189 bdd5003a pbrook
    for (i = 0; i < s->rows; i++) {
190 e6e5906b pbrook
        if ((addr & ~TARGET_PAGE_MASK) + src_width >= TARGET_PAGE_SIZE) {
191 bdd5003a pbrook
            uint32_t tmp;
192 e6e5906b pbrook
            new_dirty = 0;
193 bdd5003a pbrook
            for (tmp = 0; tmp < src_width; tmp += TARGET_PAGE_SIZE) {
194 bdd5003a pbrook
                new_dirty |= cpu_physical_memory_get_dirty(addr + tmp,
195 bdd5003a pbrook
                                                           VGA_DIRTY_FLAG);
196 bdd5003a pbrook
            }
197 bdd5003a pbrook
        }
198 bdd5003a pbrook
199 bdd5003a pbrook
        if (dirty || new_dirty || s->invalidate) {
200 bdd5003a pbrook
            fn(pallette, dest, src, s->cols);
201 bdd5003a pbrook
            if (first == -1)
202 bdd5003a pbrook
                first = i;
203 bdd5003a pbrook
            last = i;
204 bdd5003a pbrook
        }
205 bdd5003a pbrook
        dirty = new_dirty;
206 bdd5003a pbrook
        addr += src_width;
207 bdd5003a pbrook
        dest += dest_width;
208 bdd5003a pbrook
        src += src_width;
209 bdd5003a pbrook
    }
210 bdd5003a pbrook
    if (first < 0)
211 bdd5003a pbrook
      return;
212 bdd5003a pbrook
213 bdd5003a pbrook
    s->invalidate = 0;
214 bdd5003a pbrook
    cpu_physical_memory_reset_dirty(base + first * src_width,
215 bdd5003a pbrook
                                    base + (last + 1) * src_width,
216 bdd5003a pbrook
                                    VGA_DIRTY_FLAG);
217 bdd5003a pbrook
    dpy_update(s->ds, 0, first, s->cols, last - first + 1);
218 bdd5003a pbrook
}
219 bdd5003a pbrook
220 95219897 pbrook
static void pl110_invalidate_display(void * opaque)
221 bdd5003a pbrook
{
222 bdd5003a pbrook
    pl110_state *s = (pl110_state *)opaque;
223 bdd5003a pbrook
    s->invalidate = 1;
224 bdd5003a pbrook
}
225 bdd5003a pbrook
226 bdd5003a pbrook
static void pl110_update_pallette(pl110_state *s, int n)
227 bdd5003a pbrook
{
228 bdd5003a pbrook
    int i;
229 bdd5003a pbrook
    uint32_t raw;
230 bdd5003a pbrook
    unsigned int r, g, b;
231 bdd5003a pbrook
232 bdd5003a pbrook
    raw = s->raw_pallette[n];
233 bdd5003a pbrook
    n <<= 1;
234 bdd5003a pbrook
    for (i = 0; i < 2; i++) {
235 bdd5003a pbrook
        r = (raw & 0x1f) << 3;
236 bdd5003a pbrook
        raw >>= 5;
237 bdd5003a pbrook
        g = (raw & 0x1f) << 3;
238 bdd5003a pbrook
        raw >>= 5;
239 bdd5003a pbrook
        b = (raw & 0x1f) << 3;
240 bdd5003a pbrook
        /* The I bit is ignored.  */
241 bdd5003a pbrook
        raw >>= 6;
242 bdd5003a pbrook
        switch (s->ds->depth) {
243 bdd5003a pbrook
        case 8:
244 bdd5003a pbrook
            s->pallette[n] = rgb_to_pixel8(r, g, b);
245 bdd5003a pbrook
            break;
246 bdd5003a pbrook
        case 15:
247 bdd5003a pbrook
            s->pallette[n] = rgb_to_pixel15(r, g, b);
248 bdd5003a pbrook
            break;
249 bdd5003a pbrook
        case 16:
250 bdd5003a pbrook
            s->pallette[n] = rgb_to_pixel16(r, g, b);
251 bdd5003a pbrook
            break;
252 bdd5003a pbrook
        case 24:
253 bdd5003a pbrook
        case 32:
254 bdd5003a pbrook
            s->pallette[n] = rgb_to_pixel32(r, g, b);
255 bdd5003a pbrook
            break;
256 bdd5003a pbrook
        }
257 bdd5003a pbrook
        n++;
258 bdd5003a pbrook
    }
259 bdd5003a pbrook
}
260 bdd5003a pbrook
261 bdd5003a pbrook
static void pl110_resize(pl110_state *s, int width, int height)
262 bdd5003a pbrook
{
263 bdd5003a pbrook
    if (width != s->cols || height != s->rows) {
264 bdd5003a pbrook
        if (pl110_enabled(s)) {
265 132ea32f pbrook
            dpy_resize(s->ds, width, height);
266 bdd5003a pbrook
        }
267 bdd5003a pbrook
    }
268 bdd5003a pbrook
    s->cols = width;
269 bdd5003a pbrook
    s->rows = height;
270 bdd5003a pbrook
}
271 bdd5003a pbrook
272 bdd5003a pbrook
/* Update interrupts.  */
273 bdd5003a pbrook
static void pl110_update(pl110_state *s)
274 bdd5003a pbrook
{
275 bdd5003a pbrook
  /* TODO: Implement interrupts.  */
276 bdd5003a pbrook
}
277 bdd5003a pbrook
278 bdd5003a pbrook
static uint32_t pl110_read(void *opaque, target_phys_addr_t offset)
279 bdd5003a pbrook
{
280 bdd5003a pbrook
    pl110_state *s = (pl110_state *)opaque;
281 bdd5003a pbrook
282 bdd5003a pbrook
    offset -= s->base;
283 bdd5003a pbrook
    if (offset >= 0xfe0 && offset < 0x1000) {
284 cdbdb648 pbrook
        if (s->versatile)
285 cdbdb648 pbrook
            return pl110_versatile_id[(offset - 0xfe0) >> 2];
286 cdbdb648 pbrook
        else
287 cdbdb648 pbrook
            return pl110_id[(offset - 0xfe0) >> 2];
288 bdd5003a pbrook
    }
289 bdd5003a pbrook
    if (offset >= 0x200 && offset < 0x400) {
290 bdd5003a pbrook
        return s->raw_pallette[(offset - 0x200) >> 2];
291 bdd5003a pbrook
    }
292 bdd5003a pbrook
    switch (offset >> 2) {
293 bdd5003a pbrook
    case 0: /* LCDTiming0 */
294 bdd5003a pbrook
        return s->timing[0];
295 bdd5003a pbrook
    case 1: /* LCDTiming1 */
296 bdd5003a pbrook
        return s->timing[1];
297 bdd5003a pbrook
    case 2: /* LCDTiming2 */
298 bdd5003a pbrook
        return s->timing[2];
299 bdd5003a pbrook
    case 3: /* LCDTiming3 */
300 bdd5003a pbrook
        return s->timing[3];
301 bdd5003a pbrook
    case 4: /* LCDUPBASE */
302 bdd5003a pbrook
        return s->upbase;
303 bdd5003a pbrook
    case 5: /* LCDLPBASE */
304 bdd5003a pbrook
        return s->lpbase;
305 bdd5003a pbrook
    case 6: /* LCDIMSC */
306 bdd5003a pbrook
        return s->int_mask;
307 bdd5003a pbrook
    case 7: /* LCDControl */
308 bdd5003a pbrook
        return s->cr;
309 bdd5003a pbrook
    case 8: /* LCDRIS */
310 bdd5003a pbrook
        return s->int_status;
311 bdd5003a pbrook
    case 9: /* LCDMIS */
312 bdd5003a pbrook
        return s->int_status & s->int_mask;
313 bdd5003a pbrook
    case 11: /* LCDUPCURR */
314 bdd5003a pbrook
        /* TODO: Implement vertical refresh.  */
315 bdd5003a pbrook
        return s->upbase;
316 bdd5003a pbrook
    case 12: /* LCDLPCURR */
317 bdd5003a pbrook
        return s->lpbase;
318 bdd5003a pbrook
    default:
319 bdd5003a pbrook
        cpu_abort (cpu_single_env, "pl110_read: Bad offset %x\n", offset);
320 bdd5003a pbrook
        return 0;
321 bdd5003a pbrook
    }
322 bdd5003a pbrook
}
323 bdd5003a pbrook
324 bdd5003a pbrook
static void pl110_write(void *opaque, target_phys_addr_t offset,
325 bdd5003a pbrook
                        uint32_t val)
326 bdd5003a pbrook
{
327 bdd5003a pbrook
    pl110_state *s = (pl110_state *)opaque;
328 bdd5003a pbrook
    int n;
329 bdd5003a pbrook
330 bdd5003a pbrook
    /* For simplicity invalidate the display whenever a control register
331 bdd5003a pbrook
       is writen to.  */
332 bdd5003a pbrook
    s->invalidate = 1;
333 bdd5003a pbrook
    offset -= s->base;
334 bdd5003a pbrook
    if (offset >= 0x200 && offset < 0x400) {
335 bdd5003a pbrook
        /* Pallette.  */
336 bdd5003a pbrook
        n = (offset - 0x200) >> 2;
337 bdd5003a pbrook
        s->raw_pallette[(offset - 0x200) >> 2] = val;
338 bdd5003a pbrook
        pl110_update_pallette(s, n);
339 e10c2bfb pbrook
        return;
340 bdd5003a pbrook
    }
341 bdd5003a pbrook
    switch (offset >> 2) {
342 bdd5003a pbrook
    case 0: /* LCDTiming0 */
343 bdd5003a pbrook
        s->timing[0] = val;
344 bdd5003a pbrook
        n = ((val & 0xfc) + 4) * 4;
345 bdd5003a pbrook
        pl110_resize(s, n, s->rows);
346 bdd5003a pbrook
        break;
347 bdd5003a pbrook
    case 1: /* LCDTiming1 */
348 bdd5003a pbrook
        s->timing[1] = val;
349 bdd5003a pbrook
        n = (val & 0x3ff) + 1;
350 bdd5003a pbrook
        pl110_resize(s, s->cols, n);
351 bdd5003a pbrook
        break;
352 bdd5003a pbrook
    case 2: /* LCDTiming2 */
353 bdd5003a pbrook
        s->timing[2] = val;
354 bdd5003a pbrook
        break;
355 bdd5003a pbrook
    case 3: /* LCDTiming3 */
356 bdd5003a pbrook
        s->timing[3] = val;
357 bdd5003a pbrook
        break;
358 bdd5003a pbrook
    case 4: /* LCDUPBASE */
359 bdd5003a pbrook
        s->upbase = val;
360 bdd5003a pbrook
        break;
361 bdd5003a pbrook
    case 5: /* LCDLPBASE */
362 bdd5003a pbrook
        s->lpbase = val;
363 bdd5003a pbrook
        break;
364 bdd5003a pbrook
    case 6: /* LCDIMSC */
365 cdbdb648 pbrook
        if (s->versatile)
366 cdbdb648 pbrook
            goto control;
367 cdbdb648 pbrook
    imsc:
368 bdd5003a pbrook
        s->int_mask = val;
369 bdd5003a pbrook
        pl110_update(s);
370 bdd5003a pbrook
        break;
371 bdd5003a pbrook
    case 7: /* LCDControl */
372 cdbdb648 pbrook
        if (s->versatile)
373 cdbdb648 pbrook
            goto imsc;
374 cdbdb648 pbrook
    control:
375 bdd5003a pbrook
        s->cr = val;
376 bdd5003a pbrook
        s->bpp = (val >> 1) & 7;
377 bdd5003a pbrook
        if (pl110_enabled(s)) {
378 bdd5003a pbrook
            dpy_resize(s->ds, s->cols, s->rows);
379 bdd5003a pbrook
        }
380 bdd5003a pbrook
        break;
381 bdd5003a pbrook
    case 10: /* LCDICR */
382 bdd5003a pbrook
        s->int_status &= ~val;
383 bdd5003a pbrook
        pl110_update(s);
384 bdd5003a pbrook
        break;
385 bdd5003a pbrook
    default:
386 bdd5003a pbrook
        cpu_abort (cpu_single_env, "pl110_write: Bad offset %x\n", offset);
387 bdd5003a pbrook
    }
388 bdd5003a pbrook
}
389 bdd5003a pbrook
390 bdd5003a pbrook
static CPUReadMemoryFunc *pl110_readfn[] = {
391 bdd5003a pbrook
   pl110_read,
392 bdd5003a pbrook
   pl110_read,
393 bdd5003a pbrook
   pl110_read
394 bdd5003a pbrook
};
395 bdd5003a pbrook
396 bdd5003a pbrook
static CPUWriteMemoryFunc *pl110_writefn[] = {
397 bdd5003a pbrook
   pl110_write,
398 bdd5003a pbrook
   pl110_write,
399 bdd5003a pbrook
   pl110_write
400 bdd5003a pbrook
};
401 bdd5003a pbrook
402 95219897 pbrook
void *pl110_init(DisplayState *ds, uint32_t base, void *pic, int irq,
403 95219897 pbrook
                 int versatile)
404 bdd5003a pbrook
{
405 bdd5003a pbrook
    pl110_state *s;
406 bdd5003a pbrook
    int iomemtype;
407 bdd5003a pbrook
408 bdd5003a pbrook
    s = (pl110_state *)qemu_mallocz(sizeof(pl110_state));
409 bdd5003a pbrook
    iomemtype = cpu_register_io_memory(0, pl110_readfn,
410 bdd5003a pbrook
                                       pl110_writefn, s);
411 95219897 pbrook
    cpu_register_physical_memory(base, 0x00000fff, iomemtype);
412 bdd5003a pbrook
    s->base = base;
413 bdd5003a pbrook
    s->ds = ds;
414 cdbdb648 pbrook
    s->versatile = versatile;
415 bdd5003a pbrook
    s->pic = pic;
416 bdd5003a pbrook
    s->irq = irq;
417 95219897 pbrook
    graphic_console_init(ds, pl110_update_display, pl110_invalidate_display,
418 95219897 pbrook
                         NULL, s);
419 bdd5003a pbrook
    /* ??? Save/restore.  */
420 bdd5003a pbrook
    return s;
421 bdd5003a pbrook
}