« Previous | Next » 

Revision 8464b273

ID8464b273d69c61e33c55347e5b6bc0659687bae2

Added by Alexander Graf over 10 years ago

ahci: fix win7 hang on boot

When AHCI executes an asynchronous IDE command, it checked DRDY without
checking either DRQ or BSY. This sometimes caused interrupt to be sent
before command is actually completed.

This resulted in a race condition: if guest then managed to access the
device before command has completed, it would hang waiting for an
interrupt.
This was observed with windows 7 guests.

To fix, check for DRQ or BSY in additiona to DRDY, if set,
the command is asynchronous so delay the interrupt until
asynchronous done callback is invoked.

Reported-by: Michael S. Tsirkin <>
Reviewed-by: Michael S. Tsirkin <>
Tested-by: Michael S. Tsirkin <>
Signed-off-by: Michael S. Tsirkin <>
Signed-off-by: Kevin Wolf <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences