« Previous | Next » 

Revision aa830cdc

IDaa830cdc28edb69c1fe81c8fd9471ab288ad0926

Added by Peter Maydell over 10 years ago

qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration

The function qobject_from_json() doesn't actually allow its
argument to be a format string -- it passes a NULL va_list*
to qobject_from_jsonv(), and the parser code will then never
actually interpret %-escape sequences (it tests whether the
va_list pointer is NULL and will stop with a parse error).

The spurious attribute markup causes clang warnings in some
of the test cases where we programmatically construct JSON
to feed to qobject_from_json():

tests/test-qmp-input-visitor.c:76:35: warning: format string is not a
string literal (potentially insecure) [-Wformat-security]
data->obj = qobject_from_json(json_string);
^~~~~~~~~

Remove the incorrect attribute.

Signed-off-by: Peter Maydell <>
Suggested-by: Paolo Bonzini <>
Reviewed-by: Eric Blake <>
Reviewed-by: Andreas Färber <>
Signed-off-by: Michael Tokarev <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences