Statistics
| Branch: | Revision:

root / linux-user @ ac46eb8b

# Date Author Comment
9e0b74a4 06/16/2010 03:03 pm Paul Brook

Strace mprotect flags.

Teach strace code about linux specific mprotect flags.

Signed-off-by: Paul Brook <>

97374d38 06/16/2010 03:03 pm Paul Brook

Usermode exec-stack fix

When loading a shared library that requires an executable stack,
glibc uses the mprotext PROT_GROWSDOWN flag to achieve this.
We don't support PROT_GROWSDOWN.
Add a special case to handle changing the stack permissions in this way....

d35b261c 06/11/2010 07:15 pm Richard Henderson

s390x: Avoid _llseek.

There's no _llseek on s390x either. Replace the existing
test for x86_64 with a functional test for __NR_llseek.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

7ee2822c 06/10/2010 01:09 am Paolo Bonzini

rename CONFIG_QEMU_PREFIX

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Aurelien Jarno <>

0fddbbf2 06/09/2010 05:10 pm Nathan Froyd

linux-user: honor low bit of entry PC for MIPS

Signed-off-by: Nathan Froyd <>
Signed-off-by: Aurelien Jarno <>

68a1c816 05/29/2010 04:27 am Paul Brook

Pre-allocate guest address space

Allow pre-allocation of the guest virtual address space in usermode emulation.

Signed-off-by: Paul Brook <>

0be1d07c 05/29/2010 12:27 am Richard Henderson

alpha-linux-user: Fill in SI_CODE for SIGSEGV.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

680c877a 05/29/2010 12:27 am Richard Henderson

linux-user: Use qemu-malloc.c.

Since we're no longer setting PAGE_RESERVED, there's no need to
implement qemu_malloc via mmap.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

564e2fe8 05/29/2010 12:20 am Riccardo Magliocchetti

linux-user: Fix compilation with DEBUG defined

Signed-off-by: Riccardo Magliocchetti <>
Signed-off-by: Aurelien Jarno <>

9e42382f 05/21/2010 07:42 pm Riku Voipio

linux-user: do not warn for missing pselect6

Libc will fallback gracefully if pselect6 is not available. Thus put
pselect6 to nowarn until the atomicity issues of the original pselect6
patch are dealt with.

Signed-off-by: Riku Voipio <>...

9002ec79 05/21/2010 07:41 pm Richard Henderson

tcg: Initialize the prologue after GUEST_BASE is fixed.

This will allow backends to make intelligent choices about how
to implement GUEST_BASE.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

9231733a 05/21/2010 07:22 pm Richard Henderson

alpha-linux-user: Fix getxpid.

Put ppid in the second return register.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

f43ce12b 05/21/2010 07:22 pm Richard Henderson

alpha-linux-user: Fix sigsuspend parameters.

Alpha passes the signal set in a register, not by reference.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

a5b3b13b 05/21/2010 07:22 pm Richard Henderson

alpha-linux-user: Fix sigprocmask.

Alpha passes oldset by value in a register, and returns the newset
as the return value; as compared to the standard implementation in
which both are passed by reference. This requires being able to
distinguish negative return values that are not errors. Do this in...

7dd46c02 05/21/2010 07:22 pm Richard Henderson

alpha-linux-user: Fix brk error return.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

1b6bd8c7 05/21/2010 07:22 pm Richard Henderson

alpha-linux-user: Fix siginfo.si_addr for SIGSEGV and SIGBUS.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

57f18a95 05/21/2010 07:22 pm Richard Henderson

alpha-linux-user: Add correct sigaction constants.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

fb41a66e 05/21/2010 07:22 pm Richard Henderson

alpha-linux-user: Fix pipe return mechanism.

At the same time, tidy the code wrt MIPS and SH4 which have the
same two register return mechanism. Fix confusion between pipe
and pipe2 with an explicit flags=0, when the guest will not be
using the two register return mechanism....

e476492e 05/19/2010 07:39 pm Aurelien Jarno

linux-user: fix 32-bit host breakage

Fix breakage introduced by commit 81bbe906c89b6b7af58a1eeb96ec5a0bfdc3386f.

Signed-off-by: Aurelien Jarno <>

0d5d4699 05/19/2010 04:24 pm Edgar E. Iglesias

microblaze: Update elf machine nums.

189 was allocated in upstream binutils.

0xbaab was the old temporary value. Still used by some tools and the
linux kernel.

I've seen 115 in older gdb versions, but lets ignore that one.

Signed-off-by: Edgar E. Iglesias <>

e4cbd44d 05/19/2010 04:09 pm Edgar E. Iglesias

microblaze: Add linux-user core dumping support.

Signed-off-by: Edgar E. Iglesias <>

81bbe906 05/18/2010 08:30 pm takasi-y@ops.dti.ne.jp

linux-user: rlimit conversion between host and target.

rlim_t conversion between host and target added.
Otherwise there are some incorrect case like
- RLIM_INFINITY on 32bit target > 64bit host.
RLIM_INFINITY on 64bit host > mips and sparc target ?
Big value(for 32bit target) on 64bit host -> 32bit target....

5a834bb4 05/09/2010 11:19 pm Blue Swirl

sparc: Fix lazy flag calculation on interrupts, refactor

Recalculate Sparc64 CPU flags on interrupts, otherwise some earlier
flags could be stored to pstate.

Refactor PSR/CCR/CWP handling: concentrate the actual
functions to op_helper.c.

Thanks to Igor Kovalenko for reporting....

2e9a5713 05/05/2010 06:32 pm Paul Brook

Remove PAGE_RESERVED

The usermode PAGE_RESERVED code is not required by the current mmap
implementation, and is already broken when guest_base != 0.
Unfortunately the bsd emulation still uses the old mmap implementation,
so we can't rip it out altogether....

c581deda 05/05/2010 06:32 pm Paul Brook

Better default guest_base

Avoid loading linux-user applications in address space already used/reserved
by the host.

Signed-off-by: Paul Brook <>

ac316ca4 04/27/2010 06:50 am Richard Henderson

target-alpha: Implement rs/rc properly.

This is a per-cpu flag; there's no need for a spinlock of any kind.

We were also failing to manipulate the flag with $31 as a target reg
and failing to clear the flag on execution of a return-from-interrupt
instruction....

a4b388ff 04/27/2010 06:50 am Richard Henderson

target-alpha: Enable NPTL.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

6910b8f6 04/27/2010 06:50 am Richard Henderson

target-alpha: Fix load-locked/store-conditional.

Use an exception plus start_exclusive to implement the compare-and-swap.
This follows the example set by the MIPS and PPC ports.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

ed18c5ce 04/26/2010 08:30 pm Richard Henderson

linux-user: Fix sparc32plus stat64 syscalls.

Check TARGET_ABI_BITS, not TARGET_LONG_BITS, when deciding
whether or not the guest needs special 64-bit stat translation.

Signed-off-by: Richard Henderson <>
Signed-off-by: Blue Swirl <>

2cc20260 04/25/2010 09:04 pm Richard Henderson

linux-user: Fix Sparc64 syscall returns.

Signed-off-by: Richard Henderson <>
Signed-off-by: Blue Swirl <>

6495a044 04/25/2010 03:59 pm Richard Henderson

linux-user: Remove ELFLOAD32.

The ABI-specific types used by linux_binprm and image_info
are different after forcing TARGET_ABI32 on. Which means
that the parameters that load_elf_binary_multi sees are not
those that loader_exec passed. This is inherently broken...

e00ac249 04/14/2010 01:19 am takasi-y@ops.dti.ne.jp

linux-user: do_shmdt(): Fix page_set_flags's 2nd arg.

2nd arg of page_set_flags() should be start+size, but size.

Signed-off-by: Takashi YOSHII <>
Acked-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

f7177937 04/08/2010 12:11 pm Aurelien Jarno

linux-user: switch default ppc64 CPU to 970fx from 970

Signed-off-by: Aurelien Jarno <>

a1606b0b 04/01/2010 10:51 pm Stefan Weil

Fix compilation with missing inotify_init1

Commit c05c7a7306a23a4b01d1606172b142c45caffc92
breaks cross compilation for mips (and other
compilations without CONFIG_INOTIFY1):

make1: Entering directory `/qemu/bin/mips'
CC i386-linux-user/syscall.o...

60e99246 04/01/2010 10:51 pm Aurelien Jarno

linux-user/ia64: workaround ia64 strangenesses

ia64 has some strangenesses that need to be workaround:
- it has a __clone2() syscall instead of the using clone() one, with
different arguments, and which is not declared in the usual headers.
- ucontext.uc_sigmask is declared with type long int, while it is...

29e922b6 03/29/2010 10:24 pm Blue Swirl

Compile qemu-timer only once

Arrange various declarations so that also non-CPU code can access
them, adjust users.

Move CPU specific code to cpus.c.

Signed-off-by: Blue Swirl <>

7983f435 03/28/2010 05:52 pm Rob Landley

linux-user/ppc: use the Linux register layout

The dynamic linker converts the Linux layout to the AIX layout and is
reentrant so it won't do it a second time if it's already been
converted. In short it work just fine with either register layout.

OTOH, statically linked binaries expect a Linux layout....

703e0e89 03/27/2010 03:16 pm Richard Henderson

linux-user: Use RLIMIT_STACK for default stack size.

The current default stack limit of 512kB is far too small; a fair
number of gcc testsuite failures (for all guests) are directly
attributable to this. Using the -s option in every invocation of
the emulator is annoying to say the least....

7270547f 03/26/2010 09:48 pm Michael Casadevall

linux-user: Add the syscall id for pselect6 on ARM

As this is now supported in newer linux kernels.

Signed-off-by: Michael Casadevall <>
Signed-off-by: Riku Voipio <>
Signed-off-by: Aurelien Jarno <>

c05c7a73 03/26/2010 06:15 pm Riku Voipio

linux-user: add inotify_init1 syscall support

New syscall which gets actively used when you have a
fresh kernel.

Signed-off-by: Riku Voipio <>
Signed-off-by: Aurelien Jarno <>

43dc2a64 03/18/2010 08:41 pm Blue Swirl

Replace assert(0) with abort() or cpu_abort()

When building with -DNDEBUG, assert(0) will not stop execution
so it must not be used for abnormal termination.

Use cpu_abort() when in CPU context, abort() otherwise.

Signed-off-by: Blue Swirl <>

a6c6f76c 03/13/2010 04:18 pm Blue Swirl

Fix build with -DNDEBUG in CFLAGS

Signed-off-by: Blue Swirl <>

b480d9b7 03/13/2010 01:25 am Paul Brook

Fix usermode virtual address type

Usermode virtual addresses are abi_ulong, not target_ulong.

Signed-off-by: Paul Brook <>

14f24e14 03/12/2010 06:29 pm Richard Henderson

linux-user: Fix mmap_find_vma returning invalid addresses.

Don't return addresses that aren't properly aligned for the guest,
e.g. when the guest has a larger page size than the host. Don't
return addresses that are outside the virtual address space for the...

7bc7b099 03/12/2010 06:29 pm Richard Henderson

linux-user: Use h2g_valid in qemu_vmalloc.

Signed-off-by: Richard Henderson <>

70539e18 03/07/2010 05:48 pm Blue Swirl

Update to a hopefully more future proof FSF address

See also 8167ee883931cb20c6264fc19d040ce2dc6ceaaa,
530e7615ce3c01882e582c84dc6304ab98a3d5c5 and
fad6cb1a565bb73f83fc0e2654489457b489e436.

Signed-off-by: Blue Swirl <>

d8714436 03/06/2010 08:37 pm takasi-y@ops.dti.ne.jp

linux-user: Save/restore fpu registers to signal context on sh4

As "todo" comment in source code.
And modify restore_sigcontext() to have three args as kernel's does.

Signed-off-by: Takashi YOSHII <>
Signed-off-by: Aurelien Jarno <>

597c0212 03/06/2010 08:35 pm takasi-y@ops.dti.ne.jp

linux-user: Fix syscall pipe2() retval on sh4

On linux/sh4
pipe() return values by r0:r1 as SH C calling convention.
pipe2() return values on memory as traditional unix way.

Signed-off-by: Takashi YOSHII <>
Signed-off-by: Aurelien Jarno <>

9f9f0309 03/01/2010 06:39 am Paul Brook

Disassembler symbol lookup fix

Fix function signature for userspace disassembler symbol lookup.

Signed-off-by: Paul Brook <>

6049f4f8 02/28/2010 06:54 pm Richard Henderson

alpha-linux-user: Implement signals.

Move userland PALcode handling into linux-user main loop so that
we can send signals from there. This also makes alpha_palcode.c
system-level only, so don't build it for userland. Add defines
for GENTRAP PALcall mapping to signals....

dad081ee 02/24/2010 12:36 am Richard Henderson

target-alpha: Reduce internal processor registers for user-mode.

The existing set of IPRs is totally irrelevant to user-mode emulation.
Indeed, they most are irrelevant to implementing kernel-mode emulation,
and would only be relevant to PAL-mode emulation, which I suspect that...

b5ec5ce0 02/23/2010 12:16 am john cooper

Add cpu model configuration support..

This is a reimplementation of prior versions which adds
the ability to define cpu models for contemporary processors.
The added models are likewise selected via -cpu <name>,
and are intended to displace the existing convention...

5f2243f3 02/19/2010 06:04 pm Paul Brook

Fix strace or FUTEX_PRIVATE_FLAG

FUTEX_PRIVATE_FLAG is a bit orred with an existing futex op,
not a distinct value.

Signed-off-by: Paul Brook <>

da79030f 02/06/2010 06:19 pm Loïc Minier

linux-user: adapt uname machine to emulated CPU

This patch for linux-user adapts the output of the emulated uname()
syscall to match the configured CPU. Tested with x86, x86-64 and arm
emulation.

Signed-off-by: Riku Voipio <>
Signed-off-by: Loïc Minier <>

fb7e378c 01/26/2010 10:59 pm Kirill A. Shutemov

linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE

CC i386-linux-user/mmap.o
cc1: warnings being treated as errors
/usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c: In function 'mmap_frag':
/usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c:253: error: ignoring return value of 'pread', declared with attribute warn_unused_result...

ee636500 01/26/2010 10:59 pm Juan Quintela

mmap_frag() users only check for -1 error

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

0ddbc96e 01/17/2010 10:51 am Mike Frysinger

fix linux-user microblaze ELF_ARCH definition

Signed-off-by: Mike Frysinger <>
Signed-off-by: Edgar E. Iglesias <>

8b0ee8c5 01/14/2010 04:59 pm Vince Weaver

alpha: fix stat64 issue

The stat64/fstat64 syscalls are broken for alpha linux-user.

This is because Alpha, even though it is native 64-bits, has a stat64
syscall that is different than regular stat. This means that the
"TARGET_LONG_BITS==64" check in syscall.c isn't enough. Below is...

f7001a3b 12/24/2009 01:17 am Aurelien Jarno

linux-user: fix build with gcc-4.1

Signed-off-by: Aurelien Jarno <>

73b01960 12/21/2009 05:03 pm Alexander Graf

PPC: Make DCR uint32_t

For what I know DCR is always 32 bits wide, so we should also use uint32_t to
pass it along the stacks.

This fixes a warning when compiling qemu-system-ppc64 with KVM enabled, making
it compile without --disable-werror

Signed-off-by: Alexander Graf <>...

b711de95 12/21/2009 02:52 pm Aurelien Jarno

PPC64: Fix alternate timebase

Fix the alternate time base the same way as the default timebase. SPR_ATBL
should return a 64-bit value on 64 bit implementations.

Signed-off-by: Aurelien Jarno <>

e3ea6529 12/21/2009 02:42 pm Alexander Graf

PPC64: Fix timebase

On PPC we have a 64-bit time base. Usually (PPC32) this is accessed using
two separate 32 bit SPR accesses to SPR_TBU and SPR_TBL.

On PPC64 the SPR_TBL register acts as 64 bit though, so we get the full
64 bits as return value. If we only take the lower ones, fine. But Linux...

a3b3912a 12/21/2009 12:29 pm Richard Henderson

linux-user: Add aliases for some Alpha syscalls

Alpha always used 32-bit uids, but never renamed the syscalls
to match i386 when 32-bit uids were added there. This enables
the proper bits in syscall.c.

Signed-off-by: Richard Henderson <>...

49995e17 12/19/2009 09:29 pm Aurelien Jarno

linux-user: use TARGET_ABI_FMT_lx to print abi_ulong types

Signed-off-by: Aurelien Jarno <>

dd0a3651 12/19/2009 09:29 pm Nathan Froyd

linux-user: fix ELF_USE_CORE_DUMP/USE_ELF_CORE_DUMP confusion

Signed-off-by: Nathan Froyd <>
Signed-off-by: Aurelien Jarno <>

21e807fa 12/19/2009 09:29 pm Nathan Froyd

linux-user: commonify definitions of target typedefs

There's no sense in separately declaring target_{elf_greg,uid,gid,pid}_t
for every architecture. Just declare them once with appropriate
USE_UID16 handling.

Signed-off-by: Nathan Froyd <>...

d049e626 12/19/2009 09:29 pm Nathan Froyd

linux-user: fix ARM core dumps on opposite-endian hosts

Signed-off-by: Nathan Froyd <>
Signed-off-by: Aurelien Jarno <>

e2f3e741 12/19/2009 09:29 pm Nathan Froyd

linux-user: add core dump support for PPC

Signed-off-by: Nathan Froyd <>
Signed-off-by: Aurelien Jarno <>

51e52606 12/19/2009 09:29 pm Nathan Froyd

linux-user: add core dump support for MIPS

Signed-off-by: Nathan Froyd <>
Signed-off-by: Aurelien Jarno <>

7a93cc55 12/19/2009 09:29 pm Nathan Froyd

linux-user: add core dump support for M68K

Signed-off-by: Nathan Froyd <>
Signed-off-by: Aurelien Jarno <>

7631c97e 12/19/2009 09:29 pm Nathan Froyd

linux-user: add core dump support for SH

Signed-off-by: Nathan Froyd <>
Signed-off-by: Aurelien Jarno <>

d032d1b4 12/19/2009 08:45 pm Riku Voipio

linux-user: Fix mmap_lock ordering

mmap_lock() can be called while tb_lock() is being held. To
avoid deadlock when one thread is holding mmap_lock and another
tb_lock, always lock first tb_lock().

Signed-off-by: Riku Voipio <>
Signed-off-by: Aurelien Jarno <>

66393fb9 12/19/2009 08:45 pm Riku Voipio

linux-user: cleanup force_sig() calls

Force_sig should be always called with TARGET_ signals.
Not that it really matters with SEGV, so this patch is
just for cleanup and improving consistency.

Signed-off-by: Riku Voipio <>
Signed-off-by: Aurelien Jarno <>

8a57a6c7 12/13/2009 09:32 pm Richard Henderson

target-alpha: Drop bogus UNIQ initial value on Linux.

Signed-off-by: Richard Henderson <>
Signed-off-by: Aurelien Jarno <>

ba0e276d 12/13/2009 09:32 pm Richard Henderson

target-alpha: Fixes for alpha-linux syscalls.

1. Add correct definitions of error numbers.
2. Implement SYS_osf_sigprocmask
3. Implement SYS_osf_get/setsysinfo for IEEE_FP_CONTROL.

This last requires exposing the FPCR value to do_syscall.
Since this value is actually split up into the float_status,...

725b8a69 12/11/2009 05:38 pm Paul Brook

Fix ARM userspace strex implementation.

Signed-off-by: Paul Brook <>

3ca05588 11/24/2009 08:51 pm Arnaud Patard

linux-user: remove hardcoded value of _NSIG in signal.c

In a bunch of places, 64 is used as value of _NSIG but it's wrong
at least on MIPS were _NSIG is 128.

Based on a patch from Arnaud Patard <>

Signed-off-by: Aurelien Jarno <>

e9273455 11/24/2009 03:10 pm Paul Brook

Add missing break.

Signed-off-by: Paul Brook <>

426f5abc 11/22/2009 11:35 pm Paul Brook

ARM atomic ops rewrite

Implement ARMv6 atomic ops (ldrex/strex) using the same trick as PPC.

Signed-off-by: Paul Brook <>

5499b6ff 11/22/2009 03:12 pm Aurelien Jarno

target-mips: rename CP0_LLAddr into lladdr

The variable CP0_LLAddr represent the full lladdr, not the actual
register value, which is only part of this value and depends on the
CPU.

Signed-off-by: Aurelien Jarno <>

b4558d74 11/07/2009 06:34 pm Blue Swirl

(x86/Sparc/PPC)-user: fix cpu_copy

b55a37c981914aa8ecd21b9a2a2fb37f39b917c5 moved the call to cpu_reset
to user emulators. But cpu_copy also initializes a CPU structure, so add the
call also there.

Signed-off-by: Blue Swirl <>

b55a37c9 11/07/2009 12:37 pm Blue Swirl

user: move CPU reset call to main.c for x86/PPC/Sparc

Signed-off-by: Blue Swirl <>

dab46405 10/17/2009 09:52 pm Jan-Simon Möller

Re: linux-user/syscall.c - don't add GUEST_BASE to NULL pointer

This patch fixes the mount call. GUEST_BASE shouldn't be added to a NULL pointer on arg5 . failing call:
mount("rootfs", "/", 0x47a78, MS_MGC_VAL|MS_REMOUNT, 0x10000) = -1 EFAULT (Bad address)...

f7680a55 10/17/2009 11:38 am Ulrich Hecht

linux-user: KD/VT/FB ioctls

everything needed to run SDL on a framebuffer device in the userspace emulator

Signed-off-by: Ulrich Hecht <>
Signed-off-by: Riku Voipio <>

cf6de34a 10/16/2009 02:37 pm Riku Voipio

linux-user: Update ARM hwcaps

Update ARM hwcaps to match Linux kernel 2.6.31 state

Signed-off-by: Riku Voipio <>

e2cc3f6e 10/16/2009 02:36 pm Paul Bolle

linux-user: don't zero a buffer twice

prepare_binprm() zeroes bprm->buf. That buffer is already zeroed in
main() and hasn't been touched since so that is not necessary.

Signed-off-by: Paul Bolle <>
Signed-off-by: Riku Voipio <>

61322e91 10/15/2009 11:55 pm Max Filippov

linux-user: fix ppc target_stat64 st_blocks layout

Swap __pad1 and st_blocks fields location to maintain proper alignment.
This fixes incorrect 'du' and 'stat' report on ppc guest.

Signed-off-by: Max Filippov <>
Signed-off-by: Riku Voipio <>

d0927938 10/15/2009 11:55 pm Ulrich Hecht

implementations of dup3 and fallocate that are good enough to fool LTP

updated fallocate check to new configure, added dup3 check as suggested
by Jan-Simon Möller.

Riku: updated to apply to current git.

Signed-off-by: Ulrich Hecht <>
Signed-off-by: Riku Voipio <>

69137206 10/15/2009 11:55 pm Ulrich Hecht

linux-user: getpriority errno fix

getpriority returned wrong errno; fixes LTP test getpriority02.

Signed-off-by: Ulrich Hecht <>
Signed-off-by: Riku Voipio <>

3bc0bdca 10/04/2009 02:24 pm Paul Bolle

linux-user: fix "#if 0"'d printf()

Make an "#if 0"'d printf() in load_elf_binary(), probably left to aid in
debugging, reflect what the actual code does. The current printf() will
only confuse those who "#if 1" it (it certainly confused me enough to
write this trivial patch)....

22e41040 10/02/2009 08:59 pm Michael S. Tsirkin

linux-user: fix up oversealous nitpicking

Looks like linux-user code was correct, just unreadable: what it wanted
to do with "-=" was really assign a negative number, not decrement. Fix
up accordingly.

Reported-by: Laurent Desnogues <>...

c227f099 10/02/2009 12:12 am Anthony Liguori

Revert "Get rid of _t suffix"

In the very least, a change like this requires discussion on the list.

The naming convention is goofy and it causes a massive merge problem. Something
like this must be presented on the list first so people can provide input...

99a0949b 10/01/2009 09:45 pm malc

Get rid of _t suffix

Some not so obvious bits, slirp and Xen were left alone for the time
being.

Signed-off-by: malc <>

e8bbe36c 09/30/2009 09:56 pm Michael S. Tsirkin

linux-user: fix coding style nit

Put space between = and & when taking a pointer,
to avoid confusion with old-style "&=".

Signed-off-by: Michael S. Tsirkin <>
Signed-off-by: Blue Swirl <>

6ece4df6 09/30/2009 09:45 pm Michael S. Tsirkin

elfload: fix coding style nit

Put space between = and * when dereferencing a pointer,
to avoid confusion with old-style "*="

Signed-off-by: Michael S. Tsirkin <>
Signed-off-by: Blue Swirl <>

5d024825 09/30/2009 09:45 pm Michael S. Tsirkin

linux-user: fix old style decrement usage

Modern compilers do not parse "=-" as decrement:
you must use "-=" for that.

Signed-off-by: Michael S. Tsirkin <>
Signed-off-by: Blue Swirl <>

dfd3f85c 09/25/2009 10:53 pm Juan Quintela

__thread should be before real type

Signed-off-by: Juan Quintela <>
Signed-off-by: Blue Swirl <>

86178a57 09/25/2009 10:51 pm Juan Quintela

static and inline should came before the type of the functions

Signed-off-by: Juan Quintela <>
Signed-off-by: Blue Swirl <>

d4fa8d90 09/21/2009 09:40 pm Blue Swirl

Export tables properly to avoid a Sparse warning

Signed-off-by: Blue Swirl <>

b9d38e95 09/21/2009 09:11 pm Blue Swirl

Fix Sparse warnings about using plain integer as NULL pointer

Signed-off-by: Blue Swirl <>