Statistics
| Branch: | Revision:

root @ b9a7b74f

# Date Author Comment
c1799a84 06/14/2013 05:33 pm Paolo Bonzini

build: rename TARGET_ARCH2 to TARGET_NAME

Do not introduce any new use yet.

Signed-off-by: Paolo Bonzini <>
Message-id:
Signed-off-by: Peter Maydell <>
b9a7b74f 06/14/2013 05:33 pm Paolo Bonzini

build: do not use TARGET_ARCH

TARGET_ARCH is generally wrong to use, there are better variables
provided in config-target.mak. The right one is usually TARGET_NAME
(previously TARGET_ARCH2), but for bsd-user we can also use TARGET_ABI_DIR
for consistency with linux-user....
c14518e9 06/14/2013 05:19 pm Alon Levy

Add a stp file for usage from build directory

For systemtap the location of the process being tapped is crucial, as a
result the existing stp file requires installation for use.

There are now two files:
$(TARGET_DIR)/$(QEMU_PROG).stp-installed: copied to $(tapdir)/$(QEMU_PROG).stp...
301255e6 06/14/2013 03:51 pm Anthony Liguori

Merge remote-tracking branch 'mjt/trivial-patches-next' into staging

  1. By Michael Tokarev (4) and others
  2. Via Michael Tokarev
    • mjt/trivial-patches-next: (26 commits)
      piix: fix some printf errors when debug is enabled
      cputlb: fix debug logs
      create qemu_openpty_raw() helper function and move it to a separate file...
5f13731f 06/14/2013 03:51 pm Anthony Liguori

Merge remote-tracking branch 'afaerber/qom-cpu' into staging

  1. By Andreas Färber (12) and others
  2. Via Andreas Färber
    • afaerber/qom-cpu:
      spapr_rtas: Abstract rtas_start_cpu() with qemu_get_cpu()
      spapr_rtas: Abstract rtas_query_cpu_stopped_state() with qemu_get_cpu()...
86a6a077 06/14/2013 03:51 pm Anthony Liguori

Merge remote-tracking branch 'pmaydell/tcg-aarch64.next' into staging

  1. By Claudio Fontana (9) and others
  2. Via Peter Maydell
    • pmaydell/tcg-aarch64.next:
      MAINTAINERS: add tcg/aarch64 maintainer
      configure: permit compilation on arm aarch64
      tcg/aarch64: implement user mode qemu ld/st...
db9707f7 06/14/2013 03:50 pm Anthony Liguori

Merge remote-tracking branch 'pmaydell/target-arm.next' into staging

  1. By Peter Chubb
  2. Via Peter Maydell
    • pmaydell/target-arm.next:
      Fix rfe instruction

Message-id:
Signed-off-by: Anthony Liguori <>
6e8d2b65 06/14/2013 03:50 pm Anthony Liguori

Merge remote-tracking branch 'rth/tcg-for-anthony' into staging

  1. By Richard Henderson
  2. Via Richard Henderson
    • rth/tcg-for-anthony:
      tcg: Remove redundant tcg_target_init checks
      tcg: Use QEMU_BUILD_BUG_ON for CPU_TLB_ENTRY_BITS

Message-id: ...
ba275adb 06/14/2013 01:38 pm Hu Tao

piix: fix some printf errors when debug is enabled

And use PRIxxx macros if possible.

Signed-off-by: Hu Tao <>
Signed-off-by: Michael Tokarev <>
54b949d2 06/14/2013 01:29 pm Hervé Poussineau

cputlb: fix debug logs

'pd' variable has been removed in 06ef3525e1f271b6a842781a05eace5cf63b95c2.

Signed-off-by: Hervé Poussineau <>
Signed-off-by: Michael Tokarev <>
4efeabbb 06/14/2013 01:28 pm Michael Tokarev

create qemu_openpty_raw() helper function and move it to a separate file

In two places qemu uses openpty() which is very system-dependent,
and in both places the pty is switched to raw mode as well.
Make a wrapper function which does both steps, and move all the...
c67e216b 06/13/2013 01:11 am Andreas Färber

spapr_rtas: Abstract rtas_start_cpu() with qemu_get_cpu()

Instead of looping over all CPUArchState, use a helper to obtain the
desired CPUState.
Free the "cpu" variable for PowerPCCPU, to access its CPUPPCState.

Signed-off-by: Andreas Färber <>
05318a85 06/13/2013 12:43 am Andreas Färber

spapr_rtas: Abstract rtas_query_cpu_stopped_state() with qemu_get_cpu()

Instead of looping over all CPUArchState, use a helper to obtain the
desired CPUState directly. Saves a CPUPPCState variable and QOM cast.

Signed-off-by: Andreas Färber <>
b25a464c 06/12/2013 06:20 pm Claudio Fontana

MAINTAINERS: add tcg/aarch64 maintainer

Signed-off-by: Claudio Fontana <>
Message-id:
Signed-off-by: Peter Maydell <>
9c4a059d 06/12/2013 06:20 pm Claudio Fontana

tcg/aarch64: implement byte swap operations

implement the optional byte swap operations with the dedicated
aarch64 instructions.

Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>
Message-id: ...
31f1275b 06/12/2013 06:20 pm Claudio Fontana

tcg/aarch64: implement sign/zero extend operations

implement the optional sign/zero extend operations with the dedicated
aarch64 instructions.

Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>
Message-id: ...
f129061c 06/12/2013 06:20 pm Claudio Fontana

user-exec.c: aarch64 initial implementation of cpu_signal_handler

Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>
Reviewed-by: Peter Maydell <>
Message-id: ...
6a91c7c9 06/12/2013 06:20 pm Jani Kokkonen

tcg/aarch64: implement user mode qemu ld/st

also put aarch64 in the list of archs that do not need an ldscript.

Signed-off-by: Jani Kokkoken <>
Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>...
1f080313 06/12/2013 06:20 pm Claudio Fontana

configure: permit compilation on arm aarch64

support compiling on aarch64.

Reviewed-by: Peter Maydell <>
Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>
Message-id: ...
66926895 06/12/2013 06:20 pm Peter Maydell

configure: Drop CONFIG_ATFILE test

Nobody uses the CONFIG_ATFILE test now, so just drop it.

Signed-off-by: Peter Maydell <>
Reviewed-by: Richard Henderson <>
Tested-by: Claudio Fontana <>
Message-id:

1d256776 06/12/2013 06:20 pm Claudio Fontana

include/elf.h: add aarch64 ELF machine and relocs

we will use the 26bit relative relocs in the aarch64 tcg target.

Reviewed-by: Peter Maydell <>
Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>...
4a136e0a 06/12/2013 06:20 pm Claudio Fontana

tcg/aarch64: implement new TCG target for aarch64

add preliminary support for TCG target aarch64.

Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>
Reviewed-by: Peter Maydell <>...
36fac14a 06/12/2013 06:20 pm Claudio Fontana

tcg/aarch64: improve arith shifted regs operations

for arith operations, add SUBS, ANDS, ADDS and add a shift parameter
so that all arith instructions can make use of shifted registers.

Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>...
7deea126 06/12/2013 06:20 pm Claudio Fontana

tcg/aarch64: implement AND/TEST immediate pattern

add functions to AND/TEST registers with immediate patterns.

Signed-off-by: Claudio Fontana <>
Reviewed-by: Richard Henderson <>
Message-id: ...
3307e236 06/12/2013 06:20 pm Peter Maydell

linux-user: Allow getdents to be provided by getdents64

Newer architectures may only implement the getdents64 syscall, not
getdents. Provide an implementation of getdents in terms of getdents64
so that we can run getdents-using targets on a getdents64-only host....
c0d472b1 06/12/2013 06:20 pm Peter Maydell

linux-user: Drop direct use of openat etc syscalls

The linux-user syscall emulation layer currently supports the
openat family of syscalls via two mechanisms: simply calling
the corresponding libc functions, and making direct syscalls.
Since glibc has supported these functions since at least glibc...
520b6dd4 06/12/2013 05:43 pm Michael Tokarev

main-loop: do not include slirp/slirp.h, use libslirp.h instead

The header slirp/slirp.h is an internal header for slirp, and
main-loop.c does not use internals from there. Instead, it uses
public functions (slirp_update_timeout(), slirp_pollfds_fill()
etc) which are declared in slirp/libslirp.h....
581fe784 06/12/2013 03:04 pm Alon Levy

libcacard/vscclient: fix leakage of socket on error paths

Spotted by Coverity.

Signed-off-by: Alon Levy <>
Reviewed-by: Peter Maydell <>
Signed-off-by: Michael Tokarev <>
b3a1c626 06/12/2013 12:19 pm Alexey Kardashevskiy

KVM: ARM: Add dummy kvm_arch_init_irq_routing()

The common KVM code insists on calling kvm_arch_init_irq_routing()
as soon as it sees kernel header support for it (regardless of whether
QEMU supports it). Provide a dummy function to satisfy this.

Signed-off-by: Alexey Kardashevskiy <>...
48475e14 06/12/2013 12:19 pm Alexey Kardashevskiy

KVM: S390: Add dummy kvm_arch_init_irq_routing()

The common KVM code insists on calling kvm_arch_init_irq_routing()
as soon as it sees kernel header support for it (regardless of whether
QEMU supports it). Provide a dummy function to satisfy this.

Signed-off-by: Alexey Kardashevskiy <>...
82169660 06/12/2013 12:19 pm Scott Wood

KVM: PPC: Add dummy kvm_arch_init_irq_routing()

The common KVM code insists on calling kvm_arch_init_irq_routing()
as soon as it sees kernel header support for it (regardless of whether
QEMU supports it). Provide a dummy function to satisfy this.

Unlike x86, PPC does not have one default irqchip, so there's no common...
e098b453 06/12/2013 12:19 pm Alexey Kardashevskiy

linux-headers: Update to v3.10-rc5

This adds symbols required for PPC64 pseries platform features:
1. sPAPR live migration;
2. in-kernel XICS interrupt controller.

Signed-off-by: Alexey Kardashevskiy <>
Signed-off-by: Michael Tokarev <>
baefb8bf 06/12/2013 12:17 pm Stefan Hajnoczi

ivshmem: add missing error exit(2)

If the user fails to specify 'chardev' or 'shm' then we cannot continue.
Exit right away so that we don't invoke shm_open(3) with a NULL pointer.

It would be nice to replace exit(1) with error returns in the PCI device...
7f4f0a22 06/11/2013 10:45 pm Peter Crosthwaite

char/serial: cosmetic fixes.

Some cosmetic fixes to char/serial fixing some checkpatch errors.

Cc:

Signed-off-by: Peter Crosthwaite <>
Reviewed-by: Andreas Färber <>
Signed-off-by: Michael Tokarev <>
8e8638fa 06/11/2013 10:45 pm Peter Crosthwaite

char/serial: Use generic Fifo8

Use the generic Fifo8 helper provided by QEMU, rather than re-implement
privately.

Signed-off-by: Peter Crosthwaite <>
Signed-off-by: Michael Tokarev <>
b5601df7 06/11/2013 10:45 pm Peter Crosthwaite

char/serial: serial_ioport_write: Factor out common code

These three lines are common to both FIFO and regular mode. Just factor
them out to outside the if rather than replicate the same lines inside
both if and else.

Cc:

Signed-off-by: Peter Crosthwaite <>...
787ba4f0 06/11/2013 10:45 pm Peter Wu

gtk: implement -full-screen

Aiming for GTK as replacement for SDL, a feature like -full-screen should also
be implemented.

Bringing the window into full-screen mode is done by activating the "Fullscreen"
menu item. This is done after showing the windows to make the cursor and menu...
047d4e15 06/11/2013 10:45 pm Peter Wu

Unbreak -no-quit for GTK, validate SDL options

Certain options (-no-frame, -alt-grab, -ctrl-grab) only make sense with SDL.
When compiling without SDL, these options (and -no-quit) print an error message
and exit qemu.

In case QEMU is compiled with SDL support, the three aforementioned options...
8a3e8f7f 06/11/2013 10:45 pm Andreas Färber

Makefile: Install qemu-img and qemu-nbd man pages only if built

When splitting openSUSE's qemu and qemu-linux-user packages we noticed
that for linux-user-only builds unrelated man pages got installed.
It's surely possible to delete them before packaging, but not installing...
909a196d 06/11/2013 10:45 pm Stefan Weil

device tree: Fix cppcheck warning

Fix this cppcheck warning:

Checking device_tree.c...
device_tree.c:216: style:
Checking if unsigned variable 'r' is less than zero.

Signed-off-by: Stefan Weil <>
Signed-off-by: Michael Tokarev <>
dcb07809 06/11/2013 10:45 pm Stefan Weil

hw/scsi: Don't increment a boolean value

This fixes a warning from cppcheck.

Signed-off-by: Stefan Weil <>
Signed-off-by: Michael Tokarev <>
1e2a1d41 06/11/2013 10:45 pm Stefan Weil

target-sparc: Replace free by g_free

The wrong function was reported by cppcheck.

Signed-off-by: Stefan Weil <>
Reviewed-by: Andreas Färber <>
Signed-off-by: Michael Tokarev <>
c5633d99 06/11/2013 10:45 pm Stefan Weil

hw/xen: Use g_free instead of free and fix potential memory leaks

The wrong functions and the missing calls of g_free were reported
by cppcheck.

Signed-off-by: Stefan Weil <>
Acked-by: Stefano Stabellini <>
Signed-off-by: Michael Tokarev <>
c58e6201 06/11/2013 10:45 pm Michael Tokarev

qemu-char: remove a few needless #includes

This removes <syslog.h> since we don't use
syslogging, and removes second, solaris-specific,
include of <net/if.h> (which is included in
a common part of the file)

Signed-off-by: Michael Tokarev <>
f3a22014 06/11/2013 10:45 pm Michael Tokarev

gitignore: unignore *.patch

This partially reverts:

commit 082369e62c5bbaba89f173c2b803bc24115bb111
 Author: liguang &lt;&gt;
 Date:   Fri Mar 22 16:44:13 2013 +0800
gitignore: ignore more files

I'm not sure how this went in. The thing is that...
224ead26 06/11/2013 10:45 pm Ed Maste

configure: remove ${config_host_ld} variable

It was only used in one place (and already expanded in one other).

Signed-off-by: Ed Maste <>
Signed-off-by: Michael Tokarev <>
45f0b043 06/11/2013 10:45 pm Ed Maste

configure: Disable host-bsd USB on FreeBSD

It hasn't built since FreeBSD 8.x, and is disabled by a patch in the
FreeBSD ports tree. FreeBSD is migrating to QEMU's libusb support.

Signed-off-by: Ed Maste <>
Signed-off-by: Michael Tokarev <>
5c9f4336 06/11/2013 10:45 pm Peter Crosthwaite

intc/xilinx_intc: Use qemu_set_irq

Use qemu_set_irq rather than if-elsing qemu_irq_(lower|raise). No
functional change, just reduces verbosity.

Cc:

Signed-off-by: Peter Crosthwaite <>
Signed-off-by: Michael Tokarev <>
9e5e2b23 06/11/2013 10:45 pm Richard W.M. Jones

curl: Whitespace only changes.

Trivial patch to remove odd whitespace.

Signed-off-by: Richard W.M. Jones <>
Signed-off-by: Michael Tokarev <>
11ed09cf 06/11/2013 08:38 pm Andreas Färber

memory_mapping: Improve qemu_get_guest_memory_mapping() error reporting

Pass any Error out into dump_init() and have it actually stop on errors.
Whether it is unsupported on a certain CPU can be checked by looking for
a NULL CPUClass::get_memory_mapping field....
1b3509ca 06/11/2013 08:01 pm Andreas Färber

dump: Abstract dump_init() with cpu_synchronize_all_states()

Instead of calling cpu_synchronize_state() for each CPU, call the
existing cpu_synchronize_all_states() helper.

Reviewed-by: Luiz Capitulino <>
Signed-off-by: Andreas Färber <>
6db297ea 06/11/2013 07:18 pm Andreas Färber

cpu: Change default for CPUClass::get_paging_enabled()

qemu_get_guest_memory_mapping() uses cpu_paging_enabled() to determine
whether to use cpu_get_memory_mapping() to return mappings or whether to
fall back to a simple identity map.

Since by default CPUClass::get_memory_mapping() is not implemented,...
2a78636b 06/11/2013 07:16 pm Andreas Färber

dump: Drop qmp_dump_guest_memory() stub and build for all targets

qmp_dump_guest_memory() calls dump_init() and returns an Error when
cpu_get_dump_info() returns an error, as done by the stub.
So there is no need to have a stub for qmp_dump_guest_memory()....
c22d8e04 06/11/2013 07:10 pm Andreas Färber

memory_mapping: Drop qemu_get_memory_mapping() stub

dump.c:dump_init() never checked for the return code anyway.
If paging is not enabled, it will fall back to an identity map.
If paging is enabled and getting memory mapping list is not
implemented, qemu_get_guest_memory_mapping() will return an error....
a23bbfda 06/11/2013 07:03 pm Andreas Färber

cpu: Turn cpu_get_memory_mapping() into a CPUState hook

Change error reporting from return value to Error argument.

Reviewed-by: Jens Freimann <>
Reviewed-by: Luiz Capitulino <>
[AF: Fixed cpu_get_memory_mapping() documentation]...
6d4d3ae7 06/11/2013 06:58 pm Andreas Färber

memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h

This will avoid issues with hwaddr and ram_addr_t when including
sysemu/memory_mapping.h for CONFIG_USER_ONLY, e.g., from qom/cpu.h.

Signed-off-by: Andreas Färber <>
444d5590 06/11/2013 06:50 pm Andreas Färber

cpu: Turn cpu_paging_enabled() into a CPUState hook

Relocate assignment of x86 get_arch_id to have all hooks in one place.

Reviewed-by: Jens Freimann <>
Reviewed-by: Luiz Capitulino <>
Signed-off-by: Andreas Färber <>
c51a944b 06/11/2013 01:09 am Andreas Färber

monitor: Simplify do_inject_mce() with qemu_get_cpu()

Avoids an open-coded CPU loop.

Reviewed-by: liguang <>
Reviewed-by: Luiz Capitulino <>
Signed-off-by: Andreas Färber <>
31ccdde2 06/11/2013 12:33 am Igor Mammedov

target-i386: cpu: Fix potential buffer overrun in get_register_name_32()

Spotted by Coverity,
x86_reg_info_32[] is CPU_NB_REGS32 elements long, so accessing
x86_reg_info_32[CPU_NB_REGS32] will be one element off array.

Signed-off-by: Igor Mammedov <>...
88f62c2b 06/11/2013 12:33 am Andreas Färber

dump: Move stubs into libqemustub.a

This allows us to drop CONFIG_NO_CORE_DUMP with its indirect dependency
on CONFIG_HAVE_CORE_DUMP.

Acked-by: Paolo Bonzini <>
Signed-off-by: Andreas Färber <>
8de433cb 06/11/2013 12:33 am Igor Mammedov

pc: Fix crash when attempting to hotplug CPU with negative ID

QMP command "{ 'execute': 'cpu-add', 'arguments': { 'id': 1 }}" may cause
QEMU SIGSEGV at:
piix4_cpu_hotplug_req ()
...
g>sts[cpu_id / 8] |= (1 << (cpu_id % 8));
...

Since for PC in current implementation id should be in range [0...maxcpus)...
45053fde 06/11/2013 12:33 am Eduardo Habkost

pc: Create pc-*-1.6 machine-types

Some CPU model fixes are going to be included and they will require
compatibility properties in the pc-*-1.5 machine-types.

Signed-off-by: Eduardo Habkost <>
Reviewed-by: Igor Mammedov <>...
ffce9ebb 06/11/2013 12:33 am Eduardo Habkost

target-i386: Update model values on Conroe/Penryn/Nehalem CPU models

The CPUID model values on Conroe, Penryn, and Nehalem are too
conservative and don't reflect the values found on real Conroe, Penryn,
and Nehalem CPUs.

This causes at least one known problems: Windows XP disables sysenter...
6b11322e 06/11/2013 12:33 am Eduardo Habkost

target-i386: Set level=4 on Conroe/Penryn/Nehalem

The CPUID level value on Conroe, Penryn, and Nehalem are too low. This
causes at least one known problem: the -smp "threads" option doesn't
work as expect if level is < 4, because thread count information is...
bd5c51ee 06/10/2013 07:38 pm Michael Roth

qemu-char: don't issue CHR_EVENT_OPEN in a BH

When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET,
and it was issued as a bottom-half:

86e94dea5b740dad65446c857f6959eae43e0ba6

Which we basically used to print out a greeting/prompt for the...
b62cd318 06/10/2013 07:37 pm Anthony Liguori

Merge remote-tracking branch 'luiz/queue/qmp' into staging

  1. By Luiz Capitulino (2) and Marcelo Tosatti (1)
  2. Via Luiz Capitulino
    • luiz/queue/qmp:
      correct RTC_CHANGE_EVENT description (v2)
      MAINTAINERS: split Monitor (QMP/HMP) entry
      MAINTAINERS: new maintainers for qapi-schema.json...
97f31cbc 06/10/2013 07:37 pm Anthony Liguori

Merge remote-tracking branch 'stefanha/net' into staging

  1. By Jason Wang (1) and Stefan Hajnoczi (1)
  2. Via Stefan Hajnoczi
    • stefanha/net:
      tap: fix NULL dereference when passing invalid parameters to tap
      vmxnet3: fix NICState cleanup

Message-id: ...
4039736e 06/10/2013 07:36 pm Peter Maydell

softfloat: Fix shift128Right for shift counts 64..127

shift128Right would give the wrong result for a shift count
between 64 and 127. This was never noticed because all of
our uses of this function are guaranteed not to use shift
counts in this range.

Signed-off-by: Peter Maydell <>...
f7da9c17 06/10/2013 07:36 pm Anthony Liguori

gtk: use better icon

The current icon looks pretty terrible rendered in Gnome. This
switches to a transparent SVG which looks much nicer.

Signed-off-by: Anthony Liguori <>
26ac7a31 06/10/2013 07:36 pm Paolo Bonzini

gdbstub: fix for commit 87f25c12bfeaaa0c41fb857713bbc7e8a9b757dc

This commit used the wrong check to prevent an assertion failure.
After this commit, you need to start a guest in the monitor, you
cannot use anymore the "c" command in the debugger. This is...
bc7d0e66 06/10/2013 07:36 pm Paolo Bonzini

gdbstub: let the debugger resume from guest panicked state

While in general we forbid a "continue" from the guest panicked
state, it makes sense to have an exception for that when continuing
in the debugger. Perhaps the guest entered that state due to a bug,...
4f293bd6 06/10/2013 02:04 pm Wendy Liang

xilinx_axidma: Do not set DMA .notify to NULL after notify

If a stream notify function is not ready, it may re-populate the notify call-
back to indicate it should be re-polled later. This break in this usage, as
immediately following the notify() call, .notify is set to NULL. reverse the...
4e298e46 06/10/2013 02:00 pm Stefan Weil

xilinx_axienet: Fix bit mask code

Obviously the code wanted to mask the lower bits but failed to do so
because of a missing "<".

cppcheck detected a conditional expression which was always true (1 < 7).

Signed-off-by: Stefan Weil <>
Signed-off-by: Edgar E. Iglesias <>
9914fbed 06/08/2013 12:01 am Marcelo Tosatti

correct RTC_CHANGE_EVENT description (v2)

Fix RTC_CHANGE event description to match implementation.

Signed-off-by: Marcelo Tosatti <>
Signed-off-by: Luiz Capitulino <>
7810d291 06/08/2013 12:00 am Luiz Capitulino

MAINTAINERS: new maintainers for qapi-schema.json

I'm facing two problems lately wrt QMP patch review: increasingly
lack of bandwidth and lack of background in so many different areas
that are getting new QMP commands almost every week.

In order to help me mitigate this problem, I'm adding Eric and Markus...
8899b4ae 06/08/2013 12:00 am Luiz Capitulino

MAINTAINERS: split Monitor (QMP/HMP) entry

This entry doesn't reflect reality for a few years now. This commit
splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
as a maintainer.

This is what we have been for the last few years. Also, it's going...
c87826a8 06/07/2013 04:48 pm Jason Wang

tap: fix NULL dereference when passing invalid parameters to tap

This patch forbid the following invalid parameters to tap:

1) fd and vhostfds were specified but vhostfd were not specified
2) vhostfds were specified but fds were not specified
3) fds and vhostfd were specified...
7387de16 06/07/2013 04:40 pm Anthony Liguori

Merge remote-tracking branch 'stefanha/block' into staging

  1. By Kevin Wolf (19) and others
  2. Via Stefan Hajnoczi
    • stefanha/block: (26 commits)
      hmp: add parameters device and -v for info block
      hmp: show ImageInfo in 'info block'
      qmp: add ImageInfo in BlockDeviceInfo used by query-block...
b8a75b60 06/07/2013 04:40 pm Anthony Liguori

Merge remote-tracking branch 'cohuck/virtio-ccw-upstr' into staging

  1. By Cornelia Huck
  2. Via Cornelia Huck
    • cohuck/virtio-ccw-upstr:
      virtio-ccw: Fix unsetting of indicators.
      s390x/css: Fix concurrent sense.

Message-id: ...
bd093a36 06/07/2013 02:45 pm Wenchao Xia

hmp: show ImageInfo in 'info block'

Now human monitor can show image details, include internal
snapshot and backing chain info for every block device.

Signed-off-by: Wenchao Xia <>
Signed-off-by: Stefan Hajnoczi <>
e73fe2b4 06/07/2013 02:45 pm Wenchao Xia

hmp: add parameters device and -v for info block

With these parameters, user can choose the information to be showed,
to avoid message flood in the monitor.

Signed-off-by: Wenchao Xia <>
Signed-off-by: Stefan Hajnoczi <>
fb0ed453 06/07/2013 02:37 pm Wenchao Xia

block: add snapshot info query function bdrv_query_snapshot_info_list()

This patch adds function bdrv_query_snapshot_info_list(), which will
retrieve snapshot info of an image in qmp object format. The implementation
is based on the code moved from qemu-img.c with modification to fit more...
43526ec8 06/07/2013 02:37 pm Wenchao Xia

block: add image info query function bdrv_query_image_info()

This patch adds function bdrv_query_image_info(), which will
retrieve image info in qmp object format. The implementation is
based on the code moved from qemu-img.c, but uses block layer
function to get snapshot info....
553a7e87 06/07/2013 02:37 pm Wenchao Xia

qmp: add ImageInfo in BlockDeviceInfo used by query-block

Now image info will be retrieved as an embbed json object inside
BlockDeviceInfo, backing chain info and all related internal snapshot
info can be got in the enhanced recursive structure of ImageInfo. New...
bd07684a 06/06/2013 12:27 pm Kevin Wolf

ide-test: Add FLUSH CACHE test case

This checks in particular that BSY is set while the flush request is in
flight.

Signed-off-by: Kevin Wolf <>
Signed-off-by: Stefan Hajnoczi <>
f68ec837 06/06/2013 12:27 pm Andreas Färber

ide: Set BSY bit during FLUSH

The implementation of the ATA FLUSH command invokes a flush at the block
layer, which may on raw files on POSIX entail a synchronous fdatasync().
This may in some cases take so long that the SLES 11 SP1 guest driver
reports I/O errors and filesystems get corrupted or remounted read-only....
c27d5656 06/06/2013 12:27 pm Kevin Wolf

ide-test: Add enum value for DEV

Get rid of the magic number.

Signed-off-by: Kevin Wolf <>
Signed-off-by: Stefan Hajnoczi <>
bf736fe3 06/06/2013 12:27 pm Kevin Wolf

blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events

Signed-off-by: Kevin Wolf <>
Signed-off-by: Stefan Hajnoczi <>
c2cdf5c5 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Move functions for registering and running commands

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
Signed-off-by: Stefan Hajnoczi <>
d1174f13 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Move command_loop() and friends

Signed-off-by: Kevin Wolf <>
Signed-off-by: Stefan Hajnoczi <>
0b613881 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Move remaining helpers from cmd.c

Signed-off-by: Kevin Wolf <>
Signed-off-by: Stefan Hajnoczi <>
3d21994f 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Interface cleanup

Signed-off-by: Kevin Wolf <>
Signed-off-by: Stefan Hajnoczi <>
02da386a 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Use the qemu version for -V

Always printing 0.0.1 and never updating the version number wasn't very
useful. qemu-io is released with qemu, so using the same version number
makes most sense.

Signed-off-by: Kevin Wolf <>
Signed-off-by: Stefan Hajnoczi <>
587da2c3 06/06/2013 12:27 pm Kevin Wolf

Make qemu-io commands available in HMP

It was decided to not make this command available in QMP in order to
make clear that this is not supposed to be a stable API and should be
used only for testing and debugging purposes.

Signed-off-by: Kevin Wolf <>...
734c3b85 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Don't use global bs in command implementations

Pass in the BlockDriverState to the command handlers instead of using
the global variable. This is an important step to make the commands
usable outside of qemu-io.

Signed-off-by: Kevin Wolf <>...
797ac58c 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Split off commands to qemu-io-cmds.c

This is the implementation of all qemu-io commands that make sense to be
called from the qemu monitor, i.e. everything except open, close and
quit.

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>...
dd583296 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Factor out qemuio_command

It's duplicated code. Move it to qemu-io-cmds.c because it's not
dependent on any static data of the qemu-io tool.

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
Signed-off-by: Stefan Hajnoczi <>
f18a834a 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Move 'help' function

No reason to treat it different from other commands. Move it to
qemu-io-cmds.c, adapt the coding style and register it like any other
command.

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>...
e681be7e 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Move 'quit' function

This one only makes sense in the context of the qemu-io tool, so move it
to qemu-io.c. Adapt coding style and register it like other commands.

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>...
a38ed811 06/06/2013 12:27 pm Kevin Wolf

qemu-io: Move qemu_strsep() to cutils.c

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
Signed-off-by: Stefan Hajnoczi <>