root / hw / qdev-monitor.c @ bc927e48
History | View | Annotate | Download (16.1 kB)
1 | ee46d8a5 | Anthony Liguori | /*
|
---|---|---|---|
2 | ee46d8a5 | Anthony Liguori | * Dynamic device configuration and creation.
|
3 | ee46d8a5 | Anthony Liguori | *
|
4 | ee46d8a5 | Anthony Liguori | * Copyright (c) 2009 CodeSourcery
|
5 | ee46d8a5 | Anthony Liguori | *
|
6 | ee46d8a5 | Anthony Liguori | * This library is free software; you can redistribute it and/or
|
7 | ee46d8a5 | Anthony Liguori | * modify it under the terms of the GNU Lesser General Public
|
8 | ee46d8a5 | Anthony Liguori | * License as published by the Free Software Foundation; either
|
9 | ee46d8a5 | Anthony Liguori | * version 2 of the License, or (at your option) any later version.
|
10 | ee46d8a5 | Anthony Liguori | *
|
11 | ee46d8a5 | Anthony Liguori | * This library is distributed in the hope that it will be useful,
|
12 | ee46d8a5 | Anthony Liguori | * but WITHOUT ANY WARRANTY; without even the implied warranty of
|
13 | ee46d8a5 | Anthony Liguori | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
14 | ee46d8a5 | Anthony Liguori | * Lesser General Public License for more details.
|
15 | ee46d8a5 | Anthony Liguori | *
|
16 | ee46d8a5 | Anthony Liguori | * You should have received a copy of the GNU Lesser General Public
|
17 | ee46d8a5 | Anthony Liguori | * License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
18 | ee46d8a5 | Anthony Liguori | */
|
19 | ee46d8a5 | Anthony Liguori | |
20 | ee46d8a5 | Anthony Liguori | #include "qdev.h" |
21 | ee46d8a5 | Anthony Liguori | #include "monitor.h" |
22 | a15fef21 | Luiz Capitulino | #include "qmp-commands.h" |
23 | 5f629d94 | Alexander Graf | #include "arch_init.h" |
24 | ee46d8a5 | Anthony Liguori | |
25 | ee46d8a5 | Anthony Liguori | /*
|
26 | ee46d8a5 | Anthony Liguori | * Aliases were a bad idea from the start. Let's keep them
|
27 | ee46d8a5 | Anthony Liguori | * from spreading further.
|
28 | ee46d8a5 | Anthony Liguori | */
|
29 | ee46d8a5 | Anthony Liguori | typedef struct QDevAlias |
30 | ee46d8a5 | Anthony Liguori | { |
31 | ee46d8a5 | Anthony Liguori | const char *typename; |
32 | ee46d8a5 | Anthony Liguori | const char *alias; |
33 | 5f629d94 | Alexander Graf | uint32_t arch_mask; |
34 | ee46d8a5 | Anthony Liguori | } QDevAlias; |
35 | ee46d8a5 | Anthony Liguori | |
36 | ee46d8a5 | Anthony Liguori | static const QDevAlias qdev_alias_table[] = { |
37 | 5f629d94 | Alexander Graf | { "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X }, |
38 | 5f629d94 | Alexander Graf | { "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X }, |
39 | 5f629d94 | Alexander Graf | { "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X }, |
40 | 5f629d94 | Alexander Graf | { "virtio-balloon-pci", "virtio-balloon", |
41 | 5f629d94 | Alexander Graf | QEMU_ARCH_ALL & ~QEMU_ARCH_S390X }, |
42 | 5f629d94 | Alexander Graf | { "virtio-blk-s390", "virtio-blk", QEMU_ARCH_S390X }, |
43 | 5f629d94 | Alexander Graf | { "virtio-net-s390", "virtio-net", QEMU_ARCH_S390X }, |
44 | 5f629d94 | Alexander Graf | { "virtio-serial-s390", "virtio-serial", QEMU_ARCH_S390X }, |
45 | ee46d8a5 | Anthony Liguori | { "lsi53c895a", "lsi" }, |
46 | ee46d8a5 | Anthony Liguori | { "ich9-ahci", "ahci" }, |
47 | c3ebd3ba | Jan Kiszka | { "kvm-pci-assign", "pci-assign" }, |
48 | ee46d8a5 | Anthony Liguori | { } |
49 | ee46d8a5 | Anthony Liguori | }; |
50 | ee46d8a5 | Anthony Liguori | |
51 | ee46d8a5 | Anthony Liguori | static const char *qdev_class_get_alias(DeviceClass *dc) |
52 | ee46d8a5 | Anthony Liguori | { |
53 | ee46d8a5 | Anthony Liguori | const char *typename = object_class_get_name(OBJECT_CLASS(dc)); |
54 | ee46d8a5 | Anthony Liguori | int i;
|
55 | ee46d8a5 | Anthony Liguori | |
56 | ee46d8a5 | Anthony Liguori | for (i = 0; qdev_alias_table[i].typename; i++) { |
57 | 5f629d94 | Alexander Graf | if (qdev_alias_table[i].arch_mask &&
|
58 | 5f629d94 | Alexander Graf | !(qdev_alias_table[i].arch_mask & arch_type)) { |
59 | 5f629d94 | Alexander Graf | continue;
|
60 | 5f629d94 | Alexander Graf | } |
61 | 5f629d94 | Alexander Graf | |
62 | ee46d8a5 | Anthony Liguori | if (strcmp(qdev_alias_table[i].typename, typename) == 0) { |
63 | ee46d8a5 | Anthony Liguori | return qdev_alias_table[i].alias;
|
64 | ee46d8a5 | Anthony Liguori | } |
65 | ee46d8a5 | Anthony Liguori | } |
66 | ee46d8a5 | Anthony Liguori | |
67 | ee46d8a5 | Anthony Liguori | return NULL; |
68 | ee46d8a5 | Anthony Liguori | } |
69 | ee46d8a5 | Anthony Liguori | |
70 | ee46d8a5 | Anthony Liguori | static bool qdev_class_has_alias(DeviceClass *dc) |
71 | ee46d8a5 | Anthony Liguori | { |
72 | ee46d8a5 | Anthony Liguori | return (qdev_class_get_alias(dc) != NULL); |
73 | ee46d8a5 | Anthony Liguori | } |
74 | ee46d8a5 | Anthony Liguori | |
75 | ee46d8a5 | Anthony Liguori | static void qdev_print_devinfo(ObjectClass *klass, void *opaque) |
76 | ee46d8a5 | Anthony Liguori | { |
77 | ee46d8a5 | Anthony Liguori | DeviceClass *dc; |
78 | ee46d8a5 | Anthony Liguori | bool *show_no_user = opaque;
|
79 | ee46d8a5 | Anthony Liguori | |
80 | ee46d8a5 | Anthony Liguori | dc = (DeviceClass *)object_class_dynamic_cast(klass, TYPE_DEVICE); |
81 | ee46d8a5 | Anthony Liguori | |
82 | ee46d8a5 | Anthony Liguori | if (!dc || (show_no_user && !*show_no_user && dc->no_user)) {
|
83 | ee46d8a5 | Anthony Liguori | return;
|
84 | ee46d8a5 | Anthony Liguori | } |
85 | ee46d8a5 | Anthony Liguori | |
86 | ee46d8a5 | Anthony Liguori | error_printf("name \"%s\"", object_class_get_name(klass));
|
87 | 0d936928 | Anthony Liguori | if (dc->bus_type) {
|
88 | 0d936928 | Anthony Liguori | error_printf(", bus %s", dc->bus_type);
|
89 | ee46d8a5 | Anthony Liguori | } |
90 | ee46d8a5 | Anthony Liguori | if (qdev_class_has_alias(dc)) {
|
91 | ee46d8a5 | Anthony Liguori | error_printf(", alias \"%s\"", qdev_class_get_alias(dc));
|
92 | ee46d8a5 | Anthony Liguori | } |
93 | ee46d8a5 | Anthony Liguori | if (dc->desc) {
|
94 | ee46d8a5 | Anthony Liguori | error_printf(", desc \"%s\"", dc->desc);
|
95 | ee46d8a5 | Anthony Liguori | } |
96 | ee46d8a5 | Anthony Liguori | if (dc->no_user) {
|
97 | ee46d8a5 | Anthony Liguori | error_printf(", no-user");
|
98 | ee46d8a5 | Anthony Liguori | } |
99 | ee46d8a5 | Anthony Liguori | error_printf("\n");
|
100 | ee46d8a5 | Anthony Liguori | } |
101 | ee46d8a5 | Anthony Liguori | |
102 | ee46d8a5 | Anthony Liguori | static int set_property(const char *name, const char *value, void *opaque) |
103 | ee46d8a5 | Anthony Liguori | { |
104 | ee46d8a5 | Anthony Liguori | DeviceState *dev = opaque; |
105 | ee46d8a5 | Anthony Liguori | |
106 | ee46d8a5 | Anthony Liguori | if (strcmp(name, "driver") == 0) |
107 | ee46d8a5 | Anthony Liguori | return 0; |
108 | ee46d8a5 | Anthony Liguori | if (strcmp(name, "bus") == 0) |
109 | ee46d8a5 | Anthony Liguori | return 0; |
110 | ee46d8a5 | Anthony Liguori | |
111 | ee46d8a5 | Anthony Liguori | if (qdev_prop_parse(dev, name, value) == -1) { |
112 | ee46d8a5 | Anthony Liguori | return -1; |
113 | ee46d8a5 | Anthony Liguori | } |
114 | ee46d8a5 | Anthony Liguori | return 0; |
115 | ee46d8a5 | Anthony Liguori | } |
116 | ee46d8a5 | Anthony Liguori | |
117 | ee46d8a5 | Anthony Liguori | static const char *find_typename_by_alias(const char *alias) |
118 | ee46d8a5 | Anthony Liguori | { |
119 | ee46d8a5 | Anthony Liguori | int i;
|
120 | ee46d8a5 | Anthony Liguori | |
121 | ee46d8a5 | Anthony Liguori | for (i = 0; qdev_alias_table[i].alias; i++) { |
122 | 5f629d94 | Alexander Graf | if (qdev_alias_table[i].arch_mask &&
|
123 | 5f629d94 | Alexander Graf | !(qdev_alias_table[i].arch_mask & arch_type)) { |
124 | 5f629d94 | Alexander Graf | continue;
|
125 | 5f629d94 | Alexander Graf | } |
126 | 5f629d94 | Alexander Graf | |
127 | ee46d8a5 | Anthony Liguori | if (strcmp(qdev_alias_table[i].alias, alias) == 0) { |
128 | ee46d8a5 | Anthony Liguori | return qdev_alias_table[i].typename;
|
129 | ee46d8a5 | Anthony Liguori | } |
130 | ee46d8a5 | Anthony Liguori | } |
131 | ee46d8a5 | Anthony Liguori | |
132 | ee46d8a5 | Anthony Liguori | return NULL; |
133 | ee46d8a5 | Anthony Liguori | } |
134 | ee46d8a5 | Anthony Liguori | |
135 | ee46d8a5 | Anthony Liguori | int qdev_device_help(QemuOpts *opts)
|
136 | ee46d8a5 | Anthony Liguori | { |
137 | ee46d8a5 | Anthony Liguori | const char *driver; |
138 | ee46d8a5 | Anthony Liguori | Property *prop; |
139 | ee46d8a5 | Anthony Liguori | ObjectClass *klass; |
140 | ee46d8a5 | Anthony Liguori | |
141 | ee46d8a5 | Anthony Liguori | driver = qemu_opt_get(opts, "driver");
|
142 | c8057f95 | Peter Maydell | if (driver && is_help_option(driver)) {
|
143 | ee46d8a5 | Anthony Liguori | bool show_no_user = false; |
144 | ee46d8a5 | Anthony Liguori | object_class_foreach(qdev_print_devinfo, TYPE_DEVICE, false, &show_no_user);
|
145 | ee46d8a5 | Anthony Liguori | return 1; |
146 | ee46d8a5 | Anthony Liguori | } |
147 | ee46d8a5 | Anthony Liguori | |
148 | c8057f95 | Peter Maydell | if (!driver || !qemu_opt_has_help_opt(opts)) {
|
149 | ee46d8a5 | Anthony Liguori | return 0; |
150 | ee46d8a5 | Anthony Liguori | } |
151 | ee46d8a5 | Anthony Liguori | |
152 | ee46d8a5 | Anthony Liguori | klass = object_class_by_name(driver); |
153 | ee46d8a5 | Anthony Liguori | if (!klass) {
|
154 | ee46d8a5 | Anthony Liguori | const char *typename = find_typename_by_alias(driver); |
155 | ee46d8a5 | Anthony Liguori | |
156 | ee46d8a5 | Anthony Liguori | if (typename) {
|
157 | ee46d8a5 | Anthony Liguori | driver = typename; |
158 | ee46d8a5 | Anthony Liguori | klass = object_class_by_name(driver); |
159 | ee46d8a5 | Anthony Liguori | } |
160 | ee46d8a5 | Anthony Liguori | } |
161 | ee46d8a5 | Anthony Liguori | |
162 | ee46d8a5 | Anthony Liguori | if (!klass) {
|
163 | ee46d8a5 | Anthony Liguori | return 0; |
164 | ee46d8a5 | Anthony Liguori | } |
165 | bce54474 | Paolo Bonzini | do {
|
166 | bce54474 | Paolo Bonzini | for (prop = DEVICE_CLASS(klass)->props; prop && prop->name; prop++) {
|
167 | bce54474 | Paolo Bonzini | /*
|
168 | bce54474 | Paolo Bonzini | * TODO Properties without a parser are just for dirty hacks.
|
169 | bce54474 | Paolo Bonzini | * qdev_prop_ptr is the only such PropertyInfo. It's marked
|
170 | bce54474 | Paolo Bonzini | * for removal. This conditional should be removed along with
|
171 | bce54474 | Paolo Bonzini | * it.
|
172 | bce54474 | Paolo Bonzini | */
|
173 | 90ca64a9 | Paolo Bonzini | if (!prop->info->set) {
|
174 | d03d6b4e | Anthony Liguori | continue; /* no way to set it, don't show */ |
175 | d03d6b4e | Anthony Liguori | } |
176 | d03d6b4e | Anthony Liguori | error_printf("%s.%s=%s\n", driver, prop->name,
|
177 | d03d6b4e | Anthony Liguori | prop->info->legacy_name ?: prop->info->name); |
178 | ee46d8a5 | Anthony Liguori | } |
179 | bce54474 | Paolo Bonzini | klass = object_class_get_parent(klass); |
180 | bce54474 | Paolo Bonzini | } while (klass != object_class_by_name(TYPE_DEVICE));
|
181 | ee46d8a5 | Anthony Liguori | return 1; |
182 | ee46d8a5 | Anthony Liguori | } |
183 | ee46d8a5 | Anthony Liguori | |
184 | 57c9fafe | Anthony Liguori | static Object *qdev_get_peripheral(void) |
185 | ee46d8a5 | Anthony Liguori | { |
186 | 8b45d447 | Anthony Liguori | static Object *dev;
|
187 | ee46d8a5 | Anthony Liguori | |
188 | ee46d8a5 | Anthony Liguori | if (dev == NULL) { |
189 | dfe47e70 | Andreas Fรคrber | dev = container_get(qdev_get_machine(), "/peripheral");
|
190 | ee46d8a5 | Anthony Liguori | } |
191 | ee46d8a5 | Anthony Liguori | |
192 | 8b45d447 | Anthony Liguori | return dev;
|
193 | ee46d8a5 | Anthony Liguori | } |
194 | ee46d8a5 | Anthony Liguori | |
195 | 57c9fafe | Anthony Liguori | static Object *qdev_get_peripheral_anon(void) |
196 | ee46d8a5 | Anthony Liguori | { |
197 | 8b45d447 | Anthony Liguori | static Object *dev;
|
198 | ee46d8a5 | Anthony Liguori | |
199 | ee46d8a5 | Anthony Liguori | if (dev == NULL) { |
200 | dfe47e70 | Andreas Fรคrber | dev = container_get(qdev_get_machine(), "/peripheral-anon");
|
201 | ee46d8a5 | Anthony Liguori | } |
202 | ee46d8a5 | Anthony Liguori | |
203 | 8b45d447 | Anthony Liguori | return dev;
|
204 | ee46d8a5 | Anthony Liguori | } |
205 | ee46d8a5 | Anthony Liguori | |
206 | ee46d8a5 | Anthony Liguori | static void qbus_list_bus(DeviceState *dev) |
207 | ee46d8a5 | Anthony Liguori | { |
208 | ee46d8a5 | Anthony Liguori | BusState *child; |
209 | ee46d8a5 | Anthony Liguori | const char *sep = " "; |
210 | ee46d8a5 | Anthony Liguori | |
211 | ee46d8a5 | Anthony Liguori | error_printf("child busses at \"%s\":",
|
212 | ee46d8a5 | Anthony Liguori | dev->id ? dev->id : object_get_typename(OBJECT(dev))); |
213 | ee46d8a5 | Anthony Liguori | QLIST_FOREACH(child, &dev->child_bus, sibling) { |
214 | ee46d8a5 | Anthony Liguori | error_printf("%s\"%s\"", sep, child->name);
|
215 | ee46d8a5 | Anthony Liguori | sep = ", ";
|
216 | ee46d8a5 | Anthony Liguori | } |
217 | ee46d8a5 | Anthony Liguori | error_printf("\n");
|
218 | ee46d8a5 | Anthony Liguori | } |
219 | ee46d8a5 | Anthony Liguori | |
220 | ee46d8a5 | Anthony Liguori | static void qbus_list_dev(BusState *bus) |
221 | ee46d8a5 | Anthony Liguori | { |
222 | 0866aca1 | Anthony Liguori | BusChild *kid; |
223 | ee46d8a5 | Anthony Liguori | const char *sep = " "; |
224 | ee46d8a5 | Anthony Liguori | |
225 | ee46d8a5 | Anthony Liguori | error_printf("devices at \"%s\":", bus->name);
|
226 | 0866aca1 | Anthony Liguori | QTAILQ_FOREACH(kid, &bus->children, sibling) { |
227 | 0866aca1 | Anthony Liguori | DeviceState *dev = kid->child; |
228 | ee46d8a5 | Anthony Liguori | error_printf("%s\"%s\"", sep, object_get_typename(OBJECT(dev)));
|
229 | ee46d8a5 | Anthony Liguori | if (dev->id)
|
230 | ee46d8a5 | Anthony Liguori | error_printf("/\"%s\"", dev->id);
|
231 | ee46d8a5 | Anthony Liguori | sep = ", ";
|
232 | ee46d8a5 | Anthony Liguori | } |
233 | ee46d8a5 | Anthony Liguori | error_printf("\n");
|
234 | ee46d8a5 | Anthony Liguori | } |
235 | ee46d8a5 | Anthony Liguori | |
236 | ee46d8a5 | Anthony Liguori | static BusState *qbus_find_bus(DeviceState *dev, char *elem) |
237 | ee46d8a5 | Anthony Liguori | { |
238 | ee46d8a5 | Anthony Liguori | BusState *child; |
239 | ee46d8a5 | Anthony Liguori | |
240 | ee46d8a5 | Anthony Liguori | QLIST_FOREACH(child, &dev->child_bus, sibling) { |
241 | ee46d8a5 | Anthony Liguori | if (strcmp(child->name, elem) == 0) { |
242 | ee46d8a5 | Anthony Liguori | return child;
|
243 | ee46d8a5 | Anthony Liguori | } |
244 | ee46d8a5 | Anthony Liguori | } |
245 | ee46d8a5 | Anthony Liguori | return NULL; |
246 | ee46d8a5 | Anthony Liguori | } |
247 | ee46d8a5 | Anthony Liguori | |
248 | ee46d8a5 | Anthony Liguori | static DeviceState *qbus_find_dev(BusState *bus, char *elem) |
249 | ee46d8a5 | Anthony Liguori | { |
250 | 0866aca1 | Anthony Liguori | BusChild *kid; |
251 | ee46d8a5 | Anthony Liguori | |
252 | ee46d8a5 | Anthony Liguori | /*
|
253 | ee46d8a5 | Anthony Liguori | * try to match in order:
|
254 | ee46d8a5 | Anthony Liguori | * (1) instance id, if present
|
255 | ee46d8a5 | Anthony Liguori | * (2) driver name
|
256 | ee46d8a5 | Anthony Liguori | * (3) driver alias, if present
|
257 | ee46d8a5 | Anthony Liguori | */
|
258 | 0866aca1 | Anthony Liguori | QTAILQ_FOREACH(kid, &bus->children, sibling) { |
259 | 0866aca1 | Anthony Liguori | DeviceState *dev = kid->child; |
260 | ee46d8a5 | Anthony Liguori | if (dev->id && strcmp(dev->id, elem) == 0) { |
261 | ee46d8a5 | Anthony Liguori | return dev;
|
262 | ee46d8a5 | Anthony Liguori | } |
263 | ee46d8a5 | Anthony Liguori | } |
264 | 0866aca1 | Anthony Liguori | QTAILQ_FOREACH(kid, &bus->children, sibling) { |
265 | 0866aca1 | Anthony Liguori | DeviceState *dev = kid->child; |
266 | ee46d8a5 | Anthony Liguori | if (strcmp(object_get_typename(OBJECT(dev)), elem) == 0) { |
267 | ee46d8a5 | Anthony Liguori | return dev;
|
268 | ee46d8a5 | Anthony Liguori | } |
269 | ee46d8a5 | Anthony Liguori | } |
270 | 0866aca1 | Anthony Liguori | QTAILQ_FOREACH(kid, &bus->children, sibling) { |
271 | 0866aca1 | Anthony Liguori | DeviceState *dev = kid->child; |
272 | ee46d8a5 | Anthony Liguori | DeviceClass *dc = DEVICE_GET_CLASS(dev); |
273 | ee46d8a5 | Anthony Liguori | |
274 | ee46d8a5 | Anthony Liguori | if (qdev_class_has_alias(dc) &&
|
275 | ee46d8a5 | Anthony Liguori | strcmp(qdev_class_get_alias(dc), elem) == 0) {
|
276 | ee46d8a5 | Anthony Liguori | return dev;
|
277 | ee46d8a5 | Anthony Liguori | } |
278 | ee46d8a5 | Anthony Liguori | } |
279 | ee46d8a5 | Anthony Liguori | return NULL; |
280 | ee46d8a5 | Anthony Liguori | } |
281 | ee46d8a5 | Anthony Liguori | |
282 | ee46d8a5 | Anthony Liguori | static BusState *qbus_find_recursive(BusState *bus, const char *name, |
283 | 0d936928 | Anthony Liguori | const char *bus_typename) |
284 | ee46d8a5 | Anthony Liguori | { |
285 | 0866aca1 | Anthony Liguori | BusChild *kid; |
286 | ee46d8a5 | Anthony Liguori | BusState *child, *ret; |
287 | ee46d8a5 | Anthony Liguori | int match = 1; |
288 | ee46d8a5 | Anthony Liguori | |
289 | ee46d8a5 | Anthony Liguori | if (name && (strcmp(bus->name, name) != 0)) { |
290 | ee46d8a5 | Anthony Liguori | match = 0;
|
291 | ee46d8a5 | Anthony Liguori | } |
292 | 0d936928 | Anthony Liguori | if (bus_typename &&
|
293 | 0d936928 | Anthony Liguori | (strcmp(object_get_typename(OBJECT(bus)), bus_typename) != 0)) {
|
294 | ee46d8a5 | Anthony Liguori | match = 0;
|
295 | ee46d8a5 | Anthony Liguori | } |
296 | ee46d8a5 | Anthony Liguori | if (match) {
|
297 | ee46d8a5 | Anthony Liguori | return bus;
|
298 | ee46d8a5 | Anthony Liguori | } |
299 | ee46d8a5 | Anthony Liguori | |
300 | 0866aca1 | Anthony Liguori | QTAILQ_FOREACH(kid, &bus->children, sibling) { |
301 | 0866aca1 | Anthony Liguori | DeviceState *dev = kid->child; |
302 | ee46d8a5 | Anthony Liguori | QLIST_FOREACH(child, &dev->child_bus, sibling) { |
303 | 0d936928 | Anthony Liguori | ret = qbus_find_recursive(child, name, bus_typename); |
304 | ee46d8a5 | Anthony Liguori | if (ret) {
|
305 | ee46d8a5 | Anthony Liguori | return ret;
|
306 | ee46d8a5 | Anthony Liguori | } |
307 | ee46d8a5 | Anthony Liguori | } |
308 | ee46d8a5 | Anthony Liguori | } |
309 | ee46d8a5 | Anthony Liguori | return NULL; |
310 | ee46d8a5 | Anthony Liguori | } |
311 | ee46d8a5 | Anthony Liguori | |
312 | ee46d8a5 | Anthony Liguori | static BusState *qbus_find(const char *path) |
313 | ee46d8a5 | Anthony Liguori | { |
314 | ee46d8a5 | Anthony Liguori | DeviceState *dev; |
315 | ee46d8a5 | Anthony Liguori | BusState *bus; |
316 | ee46d8a5 | Anthony Liguori | char elem[128]; |
317 | ee46d8a5 | Anthony Liguori | int pos, len;
|
318 | ee46d8a5 | Anthony Liguori | |
319 | ee46d8a5 | Anthony Liguori | /* find start element */
|
320 | ee46d8a5 | Anthony Liguori | if (path[0] == '/') { |
321 | ee46d8a5 | Anthony Liguori | bus = sysbus_get_default(); |
322 | ee46d8a5 | Anthony Liguori | pos = 0;
|
323 | ee46d8a5 | Anthony Liguori | } else {
|
324 | ee46d8a5 | Anthony Liguori | if (sscanf(path, "%127[^/]%n", elem, &len) != 1) { |
325 | ee46d8a5 | Anthony Liguori | assert(!path[0]);
|
326 | ee46d8a5 | Anthony Liguori | elem[0] = len = 0; |
327 | ee46d8a5 | Anthony Liguori | } |
328 | ee46d8a5 | Anthony Liguori | bus = qbus_find_recursive(sysbus_get_default(), elem, NULL);
|
329 | ee46d8a5 | Anthony Liguori | if (!bus) {
|
330 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_BUS_NOT_FOUND, elem); |
331 | ee46d8a5 | Anthony Liguori | return NULL; |
332 | ee46d8a5 | Anthony Liguori | } |
333 | ee46d8a5 | Anthony Liguori | pos = len; |
334 | ee46d8a5 | Anthony Liguori | } |
335 | ee46d8a5 | Anthony Liguori | |
336 | ee46d8a5 | Anthony Liguori | for (;;) {
|
337 | ee46d8a5 | Anthony Liguori | assert(path[pos] == '/' || !path[pos]);
|
338 | ee46d8a5 | Anthony Liguori | while (path[pos] == '/') { |
339 | ee46d8a5 | Anthony Liguori | pos++; |
340 | ee46d8a5 | Anthony Liguori | } |
341 | ee46d8a5 | Anthony Liguori | if (path[pos] == '\0') { |
342 | ee46d8a5 | Anthony Liguori | return bus;
|
343 | ee46d8a5 | Anthony Liguori | } |
344 | ee46d8a5 | Anthony Liguori | |
345 | ee46d8a5 | Anthony Liguori | /* find device */
|
346 | ee46d8a5 | Anthony Liguori | if (sscanf(path+pos, "%127[^/]%n", elem, &len) != 1) { |
347 | ee46d8a5 | Anthony Liguori | assert(0);
|
348 | ee46d8a5 | Anthony Liguori | elem[0] = len = 0; |
349 | ee46d8a5 | Anthony Liguori | } |
350 | ee46d8a5 | Anthony Liguori | pos += len; |
351 | ee46d8a5 | Anthony Liguori | dev = qbus_find_dev(bus, elem); |
352 | ee46d8a5 | Anthony Liguori | if (!dev) {
|
353 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_DEVICE_NOT_FOUND, elem); |
354 | ee46d8a5 | Anthony Liguori | if (!monitor_cur_is_qmp()) {
|
355 | ee46d8a5 | Anthony Liguori | qbus_list_dev(bus); |
356 | ee46d8a5 | Anthony Liguori | } |
357 | ee46d8a5 | Anthony Liguori | return NULL; |
358 | ee46d8a5 | Anthony Liguori | } |
359 | ee46d8a5 | Anthony Liguori | |
360 | ee46d8a5 | Anthony Liguori | assert(path[pos] == '/' || !path[pos]);
|
361 | ee46d8a5 | Anthony Liguori | while (path[pos] == '/') { |
362 | ee46d8a5 | Anthony Liguori | pos++; |
363 | ee46d8a5 | Anthony Liguori | } |
364 | ee46d8a5 | Anthony Liguori | if (path[pos] == '\0') { |
365 | ee46d8a5 | Anthony Liguori | /* last specified element is a device. If it has exactly
|
366 | ee46d8a5 | Anthony Liguori | * one child bus accept it nevertheless */
|
367 | ee46d8a5 | Anthony Liguori | switch (dev->num_child_bus) {
|
368 | ee46d8a5 | Anthony Liguori | case 0: |
369 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_DEVICE_NO_BUS, elem); |
370 | ee46d8a5 | Anthony Liguori | return NULL; |
371 | ee46d8a5 | Anthony Liguori | case 1: |
372 | ee46d8a5 | Anthony Liguori | return QLIST_FIRST(&dev->child_bus);
|
373 | ee46d8a5 | Anthony Liguori | default:
|
374 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_DEVICE_MULTIPLE_BUSSES, elem); |
375 | ee46d8a5 | Anthony Liguori | if (!monitor_cur_is_qmp()) {
|
376 | ee46d8a5 | Anthony Liguori | qbus_list_bus(dev); |
377 | ee46d8a5 | Anthony Liguori | } |
378 | ee46d8a5 | Anthony Liguori | return NULL; |
379 | ee46d8a5 | Anthony Liguori | } |
380 | ee46d8a5 | Anthony Liguori | } |
381 | ee46d8a5 | Anthony Liguori | |
382 | ee46d8a5 | Anthony Liguori | /* find bus */
|
383 | ee46d8a5 | Anthony Liguori | if (sscanf(path+pos, "%127[^/]%n", elem, &len) != 1) { |
384 | ee46d8a5 | Anthony Liguori | assert(0);
|
385 | ee46d8a5 | Anthony Liguori | elem[0] = len = 0; |
386 | ee46d8a5 | Anthony Liguori | } |
387 | ee46d8a5 | Anthony Liguori | pos += len; |
388 | ee46d8a5 | Anthony Liguori | bus = qbus_find_bus(dev, elem); |
389 | ee46d8a5 | Anthony Liguori | if (!bus) {
|
390 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_BUS_NOT_FOUND, elem); |
391 | ee46d8a5 | Anthony Liguori | if (!monitor_cur_is_qmp()) {
|
392 | ee46d8a5 | Anthony Liguori | qbus_list_bus(dev); |
393 | ee46d8a5 | Anthony Liguori | } |
394 | ee46d8a5 | Anthony Liguori | return NULL; |
395 | ee46d8a5 | Anthony Liguori | } |
396 | ee46d8a5 | Anthony Liguori | } |
397 | ee46d8a5 | Anthony Liguori | } |
398 | ee46d8a5 | Anthony Liguori | |
399 | ee46d8a5 | Anthony Liguori | DeviceState *qdev_device_add(QemuOpts *opts) |
400 | ee46d8a5 | Anthony Liguori | { |
401 | ee46d8a5 | Anthony Liguori | ObjectClass *obj; |
402 | ee46d8a5 | Anthony Liguori | DeviceClass *k; |
403 | ee46d8a5 | Anthony Liguori | const char *driver, *path, *id; |
404 | ee46d8a5 | Anthony Liguori | DeviceState *qdev; |
405 | ee46d8a5 | Anthony Liguori | BusState *bus; |
406 | ee46d8a5 | Anthony Liguori | |
407 | ee46d8a5 | Anthony Liguori | driver = qemu_opt_get(opts, "driver");
|
408 | ee46d8a5 | Anthony Liguori | if (!driver) {
|
409 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_MISSING_PARAMETER, "driver");
|
410 | ee46d8a5 | Anthony Liguori | return NULL; |
411 | ee46d8a5 | Anthony Liguori | } |
412 | ee46d8a5 | Anthony Liguori | |
413 | ee46d8a5 | Anthony Liguori | /* find driver */
|
414 | ee46d8a5 | Anthony Liguori | obj = object_class_by_name(driver); |
415 | ee46d8a5 | Anthony Liguori | if (!obj) {
|
416 | ee46d8a5 | Anthony Liguori | const char *typename = find_typename_by_alias(driver); |
417 | ee46d8a5 | Anthony Liguori | |
418 | ee46d8a5 | Anthony Liguori | if (typename) {
|
419 | ee46d8a5 | Anthony Liguori | driver = typename; |
420 | ee46d8a5 | Anthony Liguori | obj = object_class_by_name(driver); |
421 | ee46d8a5 | Anthony Liguori | } |
422 | ee46d8a5 | Anthony Liguori | } |
423 | ee46d8a5 | Anthony Liguori | |
424 | ee46d8a5 | Anthony Liguori | if (!obj) {
|
425 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver", "device type"); |
426 | ee46d8a5 | Anthony Liguori | return NULL; |
427 | ee46d8a5 | Anthony Liguori | } |
428 | ee46d8a5 | Anthony Liguori | |
429 | ee46d8a5 | Anthony Liguori | k = DEVICE_CLASS(obj); |
430 | ee46d8a5 | Anthony Liguori | |
431 | ee46d8a5 | Anthony Liguori | /* find bus */
|
432 | ee46d8a5 | Anthony Liguori | path = qemu_opt_get(opts, "bus");
|
433 | ee46d8a5 | Anthony Liguori | if (path != NULL) { |
434 | ee46d8a5 | Anthony Liguori | bus = qbus_find(path); |
435 | ee46d8a5 | Anthony Liguori | if (!bus) {
|
436 | ee46d8a5 | Anthony Liguori | return NULL; |
437 | ee46d8a5 | Anthony Liguori | } |
438 | 0d936928 | Anthony Liguori | if (strcmp(object_get_typename(OBJECT(bus)), k->bus_type) != 0) { |
439 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_BAD_BUS_FOR_DEVICE, |
440 | 0d936928 | Anthony Liguori | driver, object_get_typename(OBJECT(bus))); |
441 | ee46d8a5 | Anthony Liguori | return NULL; |
442 | ee46d8a5 | Anthony Liguori | } |
443 | ee46d8a5 | Anthony Liguori | } else {
|
444 | 0d936928 | Anthony Liguori | bus = qbus_find_recursive(sysbus_get_default(), NULL, k->bus_type);
|
445 | ee46d8a5 | Anthony Liguori | if (!bus) {
|
446 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_NO_BUS_FOR_DEVICE, |
447 | c3594ed7 | Alberto Garcia | k->bus_type, driver); |
448 | ee46d8a5 | Anthony Liguori | return NULL; |
449 | ee46d8a5 | Anthony Liguori | } |
450 | ee46d8a5 | Anthony Liguori | } |
451 | ee46d8a5 | Anthony Liguori | if (qdev_hotplug && !bus->allow_hotplug) {
|
452 | ee46d8a5 | Anthony Liguori | qerror_report(QERR_BUS_NO_HOTPLUG, bus->name); |
453 | ee46d8a5 | Anthony Liguori | return NULL; |
454 | ee46d8a5 | Anthony Liguori | } |
455 | ee46d8a5 | Anthony Liguori | |
456 | ee46d8a5 | Anthony Liguori | if (!bus) {
|
457 | ee46d8a5 | Anthony Liguori | bus = sysbus_get_default(); |
458 | ee46d8a5 | Anthony Liguori | } |
459 | ee46d8a5 | Anthony Liguori | |
460 | ee46d8a5 | Anthony Liguori | /* create device, set properties */
|
461 | ee46d8a5 | Anthony Liguori | qdev = DEVICE(object_new(driver)); |
462 | ee46d8a5 | Anthony Liguori | qdev_set_parent_bus(qdev, bus); |
463 | ee46d8a5 | Anthony Liguori | |
464 | ee46d8a5 | Anthony Liguori | id = qemu_opts_id(opts); |
465 | ee46d8a5 | Anthony Liguori | if (id) {
|
466 | ee46d8a5 | Anthony Liguori | qdev->id = id; |
467 | b2d4b3f7 | Anthony Liguori | } |
468 | b2d4b3f7 | Anthony Liguori | if (qemu_opt_foreach(opts, set_property, qdev, 1) != 0) { |
469 | b2d4b3f7 | Anthony Liguori | qdev_free(qdev); |
470 | b2d4b3f7 | Anthony Liguori | return NULL; |
471 | b2d4b3f7 | Anthony Liguori | } |
472 | b2d4b3f7 | Anthony Liguori | if (qdev->id) {
|
473 | 57c9fafe | Anthony Liguori | object_property_add_child(qdev_get_peripheral(), qdev->id, |
474 | 57c9fafe | Anthony Liguori | OBJECT(qdev), NULL);
|
475 | ee46d8a5 | Anthony Liguori | } else {
|
476 | ee46d8a5 | Anthony Liguori | static int anon_count; |
477 | ee46d8a5 | Anthony Liguori | gchar *name = g_strdup_printf("device[%d]", anon_count++);
|
478 | 57c9fafe | Anthony Liguori | object_property_add_child(qdev_get_peripheral_anon(), name, |
479 | 57c9fafe | Anthony Liguori | OBJECT(qdev), NULL);
|
480 | ee46d8a5 | Anthony Liguori | g_free(name); |
481 | ee46d8a5 | Anthony Liguori | } |
482 | f424d5c4 | Paolo Bonzini | if (qdev_init(qdev) < 0) { |
483 | f424d5c4 | Paolo Bonzini | qerror_report(QERR_DEVICE_INIT_FAILED, driver); |
484 | f424d5c4 | Paolo Bonzini | return NULL; |
485 | f424d5c4 | Paolo Bonzini | } |
486 | ee46d8a5 | Anthony Liguori | qdev->opts = opts; |
487 | ee46d8a5 | Anthony Liguori | return qdev;
|
488 | ee46d8a5 | Anthony Liguori | } |
489 | ee46d8a5 | Anthony Liguori | |
490 | ee46d8a5 | Anthony Liguori | |
491 | ee46d8a5 | Anthony Liguori | #define qdev_printf(fmt, ...) monitor_printf(mon, "%*s" fmt, indent, "", ## __VA_ARGS__) |
492 | ee46d8a5 | Anthony Liguori | static void qbus_print(Monitor *mon, BusState *bus, int indent); |
493 | ee46d8a5 | Anthony Liguori | |
494 | ee46d8a5 | Anthony Liguori | static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props, |
495 | bce54474 | Paolo Bonzini | int indent)
|
496 | ee46d8a5 | Anthony Liguori | { |
497 | ee46d8a5 | Anthony Liguori | if (!props)
|
498 | ee46d8a5 | Anthony Liguori | return;
|
499 | d822979b | Paolo Bonzini | for (; props->name; props++) {
|
500 | d822979b | Paolo Bonzini | Error *err = NULL;
|
501 | d822979b | Paolo Bonzini | char *value;
|
502 | d822979b | Paolo Bonzini | char *legacy_name = g_strdup_printf("legacy-%s", props->name); |
503 | d822979b | Paolo Bonzini | if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) { |
504 | d822979b | Paolo Bonzini | value = object_property_get_str(OBJECT(dev), legacy_name, &err); |
505 | d822979b | Paolo Bonzini | } else {
|
506 | 8185bfc1 | Paolo Bonzini | value = object_property_print(OBJECT(dev), props->name, &err); |
507 | d822979b | Paolo Bonzini | } |
508 | d822979b | Paolo Bonzini | g_free(legacy_name); |
509 | d822979b | Paolo Bonzini | |
510 | d822979b | Paolo Bonzini | if (err) {
|
511 | d822979b | Paolo Bonzini | error_free(err); |
512 | d822979b | Paolo Bonzini | continue;
|
513 | ee46d8a5 | Anthony Liguori | } |
514 | bce54474 | Paolo Bonzini | qdev_printf("%s = %s\n", props->name,
|
515 | d822979b | Paolo Bonzini | value && *value ? value : "<null>");
|
516 | d822979b | Paolo Bonzini | g_free(value); |
517 | ee46d8a5 | Anthony Liguori | } |
518 | ee46d8a5 | Anthony Liguori | } |
519 | ee46d8a5 | Anthony Liguori | |
520 | 0d936928 | Anthony Liguori | static void bus_print_dev(BusState *bus, Monitor *mon, DeviceState *dev, int indent) |
521 | 0d936928 | Anthony Liguori | { |
522 | 0d936928 | Anthony Liguori | BusClass *bc = BUS_GET_CLASS(bus); |
523 | 0d936928 | Anthony Liguori | |
524 | 0d936928 | Anthony Liguori | if (bc->print_dev) {
|
525 | 0d936928 | Anthony Liguori | bc->print_dev(mon, dev, indent); |
526 | 0d936928 | Anthony Liguori | } |
527 | 0d936928 | Anthony Liguori | } |
528 | 0d936928 | Anthony Liguori | |
529 | ee46d8a5 | Anthony Liguori | static void qdev_print(Monitor *mon, DeviceState *dev, int indent) |
530 | ee46d8a5 | Anthony Liguori | { |
531 | bce54474 | Paolo Bonzini | ObjectClass *class; |
532 | ee46d8a5 | Anthony Liguori | BusState *child; |
533 | ee46d8a5 | Anthony Liguori | qdev_printf("dev: %s, id \"%s\"\n", object_get_typename(OBJECT(dev)),
|
534 | ee46d8a5 | Anthony Liguori | dev->id ? dev->id : "");
|
535 | ee46d8a5 | Anthony Liguori | indent += 2;
|
536 | ee46d8a5 | Anthony Liguori | if (dev->num_gpio_in) {
|
537 | ee46d8a5 | Anthony Liguori | qdev_printf("gpio-in %d\n", dev->num_gpio_in);
|
538 | ee46d8a5 | Anthony Liguori | } |
539 | ee46d8a5 | Anthony Liguori | if (dev->num_gpio_out) {
|
540 | ee46d8a5 | Anthony Liguori | qdev_printf("gpio-out %d\n", dev->num_gpio_out);
|
541 | ee46d8a5 | Anthony Liguori | } |
542 | bce54474 | Paolo Bonzini | class = object_get_class(OBJECT(dev)); |
543 | bce54474 | Paolo Bonzini | do {
|
544 | bce54474 | Paolo Bonzini | qdev_print_props(mon, dev, DEVICE_CLASS(class)->props, indent); |
545 | bce54474 | Paolo Bonzini | class = object_class_get_parent(class); |
546 | bce54474 | Paolo Bonzini | } while (class != object_class_by_name(TYPE_DEVICE));
|
547 | da9fbe76 | Gerd Hoffmann | bus_print_dev(dev->parent_bus, mon, dev, indent); |
548 | ee46d8a5 | Anthony Liguori | QLIST_FOREACH(child, &dev->child_bus, sibling) { |
549 | ee46d8a5 | Anthony Liguori | qbus_print(mon, child, indent); |
550 | ee46d8a5 | Anthony Liguori | } |
551 | ee46d8a5 | Anthony Liguori | } |
552 | ee46d8a5 | Anthony Liguori | |
553 | ee46d8a5 | Anthony Liguori | static void qbus_print(Monitor *mon, BusState *bus, int indent) |
554 | ee46d8a5 | Anthony Liguori | { |
555 | 0866aca1 | Anthony Liguori | BusChild *kid; |
556 | ee46d8a5 | Anthony Liguori | |
557 | ee46d8a5 | Anthony Liguori | qdev_printf("bus: %s\n", bus->name);
|
558 | ee46d8a5 | Anthony Liguori | indent += 2;
|
559 | 0d936928 | Anthony Liguori | qdev_printf("type %s\n", object_get_typename(OBJECT(bus)));
|
560 | 0866aca1 | Anthony Liguori | QTAILQ_FOREACH(kid, &bus->children, sibling) { |
561 | 0866aca1 | Anthony Liguori | DeviceState *dev = kid->child; |
562 | ee46d8a5 | Anthony Liguori | qdev_print(mon, dev, indent); |
563 | ee46d8a5 | Anthony Liguori | } |
564 | ee46d8a5 | Anthony Liguori | } |
565 | ee46d8a5 | Anthony Liguori | #undef qdev_printf
|
566 | ee46d8a5 | Anthony Liguori | |
567 | ee46d8a5 | Anthony Liguori | void do_info_qtree(Monitor *mon)
|
568 | ee46d8a5 | Anthony Liguori | { |
569 | ee46d8a5 | Anthony Liguori | if (sysbus_get_default())
|
570 | ee46d8a5 | Anthony Liguori | qbus_print(mon, sysbus_get_default(), 0);
|
571 | ee46d8a5 | Anthony Liguori | } |
572 | ee46d8a5 | Anthony Liguori | |
573 | ee46d8a5 | Anthony Liguori | void do_info_qdm(Monitor *mon)
|
574 | ee46d8a5 | Anthony Liguori | { |
575 | ee46d8a5 | Anthony Liguori | object_class_foreach(qdev_print_devinfo, TYPE_DEVICE, false, NULL); |
576 | ee46d8a5 | Anthony Liguori | } |
577 | ee46d8a5 | Anthony Liguori | |
578 | ee46d8a5 | Anthony Liguori | int do_device_add(Monitor *mon, const QDict *qdict, QObject **ret_data) |
579 | ee46d8a5 | Anthony Liguori | { |
580 | 4e89978e | Luiz Capitulino | Error *local_err = NULL;
|
581 | ee46d8a5 | Anthony Liguori | QemuOpts *opts; |
582 | ee46d8a5 | Anthony Liguori | |
583 | 4e89978e | Luiz Capitulino | opts = qemu_opts_from_qdict(qemu_find_opts("device"), qdict, &local_err);
|
584 | 4e89978e | Luiz Capitulino | if (error_is_set(&local_err)) {
|
585 | 4e89978e | Luiz Capitulino | qerror_report_err(local_err); |
586 | 4e89978e | Luiz Capitulino | error_free(local_err); |
587 | ee46d8a5 | Anthony Liguori | return -1; |
588 | ee46d8a5 | Anthony Liguori | } |
589 | ee46d8a5 | Anthony Liguori | if (!monitor_cur_is_qmp() && qdev_device_help(opts)) {
|
590 | ee46d8a5 | Anthony Liguori | qemu_opts_del(opts); |
591 | ee46d8a5 | Anthony Liguori | return 0; |
592 | ee46d8a5 | Anthony Liguori | } |
593 | ee46d8a5 | Anthony Liguori | if (!qdev_device_add(opts)) {
|
594 | ee46d8a5 | Anthony Liguori | qemu_opts_del(opts); |
595 | ee46d8a5 | Anthony Liguori | return -1; |
596 | ee46d8a5 | Anthony Liguori | } |
597 | ee46d8a5 | Anthony Liguori | return 0; |
598 | ee46d8a5 | Anthony Liguori | } |
599 | ee46d8a5 | Anthony Liguori | |
600 | a15fef21 | Luiz Capitulino | void qmp_device_del(const char *id, Error **errp) |
601 | ee46d8a5 | Anthony Liguori | { |
602 | ee46d8a5 | Anthony Liguori | DeviceState *dev; |
603 | ee46d8a5 | Anthony Liguori | |
604 | ee46d8a5 | Anthony Liguori | dev = qdev_find_recursive(sysbus_get_default(), id); |
605 | ee46d8a5 | Anthony Liguori | if (NULL == dev) { |
606 | a15fef21 | Luiz Capitulino | error_set(errp, QERR_DEVICE_NOT_FOUND, id); |
607 | a15fef21 | Luiz Capitulino | return;
|
608 | 56f9107e | Luiz Capitulino | } |
609 | 56f9107e | Luiz Capitulino | |
610 | a15fef21 | Luiz Capitulino | qdev_unplug(dev, errp); |
611 | ee46d8a5 | Anthony Liguori | } |
612 | ee46d8a5 | Anthony Liguori | |
613 | ee46d8a5 | Anthony Liguori | void qdev_machine_init(void) |
614 | ee46d8a5 | Anthony Liguori | { |
615 | ee46d8a5 | Anthony Liguori | qdev_get_peripheral_anon(); |
616 | ee46d8a5 | Anthony Liguori | qdev_get_peripheral(); |
617 | ee46d8a5 | Anthony Liguori | } |