Statistics
| Branch: | Revision:

root / hw @ bfb811ad

# Date Author Comment
e61a1e0a 12/03/2009 06:04 pm Juan Quintela

vmstate: Add support for VBUFFERS

Support for buffer that are pointed by a pointer (i.e. not embedded)
where the size that we want to use is a field in the state.
We also need a new place to store where to start in the middle of the
buffer, as now it is a pointer, not the offset of the 1st field....

11fe0e6e 12/03/2009 06:04 pm Juan Quintela

vmstate: Introduce VMSTATE_STRUCT_TEST

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

543fc7b2 12/03/2009 06:04 pm Juan Quintela

vmstate: Introduce VMSTATE_STRUCT_POINTER_TEST

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

2fee4078 12/03/2009 06:04 pm Juan Quintela

vmstate: Introduce UINT16_TEST support

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

bfb811ad 12/03/2009 06:04 pm Juan Quintela

vmstate: remove usused VMSTATE_STRUCT_ARRAY_SIZE_UINT8

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

d9494b19 12/03/2009 06:04 pm Jan Kiszka

vmstate: Fix info field of VMSTATE_MACADDR

Signed-off-by: Jan Kiszka <>
Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

38f5b2b8 12/03/2009 05:41 pm Laszlo Ast

lsi53c895a: Use alternative address when already reselected

See SCRIPTS, 3.2.17 SELECT.

Signed-off-by: Laszlo Ast <>
Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

e560125e 12/03/2009 05:41 pm Laszlo Ast

lsi53c895a: Implement IRQ on reselection

The critical part of this change is how to deal with simultaneaous
generation of interrupts. The only (normal) case when this happens in
the emulation is near simultaneous reselection + selection. If selection
comes first, there is no problem, since the target attempting...

38215553 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: GET_CONFIGURATION

Move GET_CONFIGURATION emulation from scsi_send_command() to
scsi_disk_emulate_command().

Also add GET_CONFIGURATION to scsi-defs.h and scsi_command_name().

Signed-off-by: Gerd Hoffmann <>...

5dd90e2a 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: SERVICE_ACTION_IN

Move SERVICE_ACTION_IN emulation from scsi_send_command() to
scsi_disk_emulate_command().

Also add SERVICE_ACTION_IN to scsi-defs.h and scsi_command_name().

Signed-off-by: Gerd Hoffmann <>...

39ec9a50 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: REPORT_LUNS

Move REPORT_LUNS emulation from scsi_send_command() to
scsi_disk_emulate_command().

Also add REPORT_LUNS to scsi-defs.h and scsi_command_name().

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

88f8a5ed 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: VERIFY

Move VERIFY emulation from scsi_send_command() to
scsi_disk_emulate_command().

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

bd536cf3 12/03/2009 05:41 pm Gerd Hoffmann

scsi: add read/write 16 commands.

Add READ_16 + friends to scsi-defs.h, scsi_command_name() and the
request parsing helper functions.

Use them in scsi-disk.c too.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

a15fdf86 12/03/2009 05:41 pm Laszlo Ast

lsi53c895a: Whitespace and typo fixes

Signed-off-by: Laszlo Ast <>
Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

cc9f28bc 12/03/2009 05:41 pm Laszlo Ast

lsi53c895a: Add support for LSI53C700 Family Compatibility bit

Signed-off-by: Laszlo Ast <>
Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

77203ea0 12/03/2009 05:41 pm Laszlo Ast

lsi53c895a: Fix message code of DISCONNECT

See SCSI-2, 6.5 Message system description/message codes.

Signed-off-by: Laszlo Ast <>
Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

07a1bea8 12/03/2009 05:41 pm Laszlo Ast

lsi53c895a: Fix SDID in SELECT ID command

See SCRIPTS Programming Guide, 3.2.17 SELECT.

Signed-off-by: Laszlo Ast <>
Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

0b06c059 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: INQUIRY

Move INQUIRY emulation from scsi_send_command() to
scsi_disk_emulate_command(). Also split the longish INQUITY emulation
code into the new scsi_disk_emulate_inquiry() function. Serial number
handling is slightly changed, we don't copy it any more but look it up...

3d53ba18 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: RESERVE+RELEASE

Move RESERVE+RELEASE emulation from scsi_send_command() to
scsi_disk_emulate_command().

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

ebddfcbe 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: MODE_SENSE

Move MODE_SENSE emulation from scsi_send_command() to
scsi_disk_emulate_command(). Create two helper functions:
mode_sense_page() which writes the actual mode pages and
scsi_disk_emulate_mode_sense() which holds the longish MODE_SENSE...

8d3628ff 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: START_STOP

Move START_STOP emulation from scsi_send_command() to
scsi_disk_emulate_command().

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

c68b9f34 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: ALLOW_MEDIUM_REMOVAL

Move ALLOW_MEDIUM_REMOVAL emulation from scsi_send_command() to
scsi_disk_emulate_command().

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

e7e25e32 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: READ_CAPACITY

Move READ_CAPACITY emulation from scsi_send_command() to
scsi_disk_emulate_command().

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

fc903943 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: SYNCHRONIZE_CACHE

Move SYNCHRONIZE_CACHE emulation from scsi_send_command() to
scsi_disk_emulate_command().

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

02880f43 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: READ_TOC

Move READ_TOC emulation from scsi_send_command() to
scsi_disk_emulate_command(). Add scsi_disk_emulate_read_toc() function
which holds the longisch READ_TOC emulation code.

Signed-off-by: Gerd Hoffmann <>...

ec766865 12/03/2009 05:41 pm Gerd Hoffmann

scsi: add scsi_req_print()

Handy for debugging.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

aa5dbdc1 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: core + TEST_UNIT_READY.

Add new scsi_disk_emulate_command() function, which will -- when
finished -- handle all scsi disk command emulation except actual I/O
(READ+WRITE commands) which goes to the block layer. The function...

51ad87c9 12/03/2009 05:41 pm Gerd Hoffmann

scsi-disk: restruct emulation: REQUEST_SENSE

Move REQUEST_SENSE emulation from scsi_send_command() to
scsi_disk_emulate_command().

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

97a06435 12/03/2009 05:41 pm Gerd Hoffmann

scsi: add xfer mode

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

37659e51 12/03/2009 05:41 pm Gerd Hoffmann

scsi: move sense to SCSIDevice, create SCSISense struct.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

251882b7 12/03/2009 05:41 pm Gerd Hoffmann

scsi: move dinfo to SCSIDevice

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

ed3a34a3 12/03/2009 05:41 pm Gerd Hoffmann

scsi: move status to SCSIRequest.

Also add and use the scsi_req_complete() helper function for calling the
completion callback.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

1e37607b 12/03/2009 05:41 pm Gerd Hoffmann

scsi: add/fix header protection.

Also delete the leftover and unused scsi-disk.h file.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

4c41d2ef 12/03/2009 05:41 pm Gerd Hoffmann

scsi: create common SCSIRequest structure.

Rename the SCSIRequest structs in scsi-disk.c and scsi-generic.c to
SCSIDiskReq and SCSIGenericReq. Create a SCSIRequest struct and move
the common elements over.

Signed-off-by: Gerd Hoffmann <>...

9af99d98 12/03/2009 05:41 pm Gerd Hoffmann

scsi: move request lists to QTAILQ.

Changes: * Move from open-coded lists to QTAILQ macros. * Move the struct elements to the common data structures
(SCSIDevice + SCSIRequest). * Drop free request pools. * Fix request cleanup in the destroy callback....

89b08ae1 12/03/2009 05:41 pm Gerd Hoffmann

scsi: move SCSIRequest management to common code.

Create generic functions to allocate, find and release SCSIRequest
structs. Make scsi-disk and scsi-generic use them.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

29362ebe 12/03/2009 05:41 pm Gerd Hoffmann

scsi: move scsi command buffer from SCSIGenericReq to SCSIRequest.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

b07995e3 12/03/2009 05:41 pm Gerd Hoffmann

scsi: move blocksize from SCSIGenericState to SCSIDevice

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

0d65e1f8 12/03/2009 05:41 pm Gerd Hoffmann

scsi: add scsi-defs.h

Largely based on <scsi/scsi.h> from linux. Added into the tree so we
can use the defines everywhere, not just in scsi-generic.c (which is
linux-specific).

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

91376656 12/03/2009 05:41 pm Gerd Hoffmann

scsi: move type from SCSIGenericState to SCSIDevice

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

2ec749cb 12/03/2009 05:41 pm Gerd Hoffmann

scsi: add request parsing helpers to common code.

Add helper functions for scsi request parsing to common code. Getting
command length, transfer size, and linear block address is handled.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

ebf46023 12/03/2009 05:41 pm Gerd Hoffmann

scsi: use command defines in scsi-disk.c

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

e0394b8b 12/03/2009 05:41 pm Mark McLoughlin

net: convert usb-net to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

d7539ab4 12/03/2009 05:41 pm Mark McLoughlin

net: convert xilinx_ethlite to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

658788c5 12/03/2009 05:41 pm Mark McLoughlin

net: convert xen to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

665a3b07 12/03/2009 05:41 pm Mark McLoughlin

net: remove VLANClientState members now in NetClientInfo

Add a NetClientInfo pointer to VLANClientState and use that
for the typecode and function pointers.

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

1f30d10a 12/03/2009 05:41 pm Mark McLoughlin

net: convert mipsnet to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

3a94dd18 12/03/2009 05:41 pm Mark McLoughlin

net: convert musicpal to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

42a4260f 12/03/2009 05:41 pm Mark McLoughlin

net: convert smc91c111 to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

8c9b63b9 12/03/2009 05:41 pm Mark McLoughlin

net: convert stellaris to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

e00e365e 12/03/2009 05:41 pm Mark McLoughlin

net: convert eepro100 to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

05f41fe3 12/03/2009 05:41 pm Mark McLoughlin

net: convert dp8393x to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

163bf3a5 12/03/2009 05:41 pm Mark McLoughlin

net: convert etrax to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

83b9f88c 12/03/2009 05:41 pm Mark McLoughlin

net: convert LAN9118 to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

1cc49d95 12/03/2009 05:41 pm Mark McLoughlin

net: convert mcf_fec to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

a03e2aec 12/03/2009 05:41 pm Mark McLoughlin

net: convert e1000 to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

1673ad51 12/03/2009 05:41 pm Mark McLoughlin

net: convert rtl8139 to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

1c2045b5 12/03/2009 05:41 pm Mark McLoughlin

net: convert ne2000 to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

1fa51482 12/03/2009 05:41 pm Mark McLoughlin

net: convert pcnet to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

eb6b6c12 12/03/2009 05:41 pm Mark McLoughlin

net: convert virtio to NICState

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

5096fae3 12/03/2009 05:41 pm Mark McLoughlin

qdev: move DO_UPCAST() into osdep.h

Nothing qdev specific about this, make it available throughtout.

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

e13b10be 12/03/2009 05:41 pm Mark McLoughlin

net: remove NICInfo::vc

Since 1cc33683, this field is not set for most devices, so just
remove it and its remaining few uses.

Signed-off-by: Mark McLoughlin <>
Signed-off-by: Anthony Liguori <>

a90ffa49 12/03/2009 05:41 pm Juan Quintela

ac97: port to vmstate

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

1d190d5c 12/03/2009 05:41 pm Juan Quintela

c4231a: port to vmstate

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

709ae102 12/03/2009 05:41 pm Juan Quintela

gus: port to vmstate

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

0148d177 12/03/2009 05:41 pm Juan Quintela

ac97: sizeof needs %zd

This change makes DEBUG_AC97 to compile again

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

7626f39f 12/03/2009 05:41 pm Juan Quintela

ac97: recalculate active after loadvm

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

3b6b2126 12/03/2009 05:41 pm Juan Quintela

ac97: up savevm version and remove active from state

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

ebfd6f4d 12/03/2009 05:41 pm Juan Quintela

sb16: port to vmstate

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

3a14c2df 12/03/2009 05:41 pm Juan Quintela

es1370: port to vmstate

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

3ced9f7a 12/03/2009 05:41 pm Luiz Capitulino

qdev: Use QError for 'device not found' error

Please, note that we will lose the "Try -device '?' for a list"
hint as it's qdev specific.

Signed-off-by: Luiz Capitulino <>
Signed-off-by: Anthony Liguori <>

b3a21988 12/02/2009 06:26 pm Juha Riihimäki

fix I2C slave addressing

With the recent device handling changes the I2C slave addressing code
was broken. With current code, if a slave with the correct address is

not found on the bus the last scanned slave on the bus will be
addressed. This is wrong. Please find attached a patch to fix it....

51954d56 12/02/2009 04:57 pm Gerd Hoffmann

Fix qdev property type definition for isa serial/parallel devices

Use the correct qdev property type for these devices.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>

e3c916e6 12/02/2009 04:57 pm Jean-Christophe DUBOIS

Fix qemu_free use in scsi-generic.c

scsi-generic.c is using free() instead of qemu_free().
Fix it.

Signed-off-by: Jean-Christophe DUBOIS <>
Signed-off-by: Anthony Liguori <>

834fac78 12/02/2009 04:57 pm Jean-Christophe DUBOIS

Fix free use in xen_backend.c

xen_backend.c is using qemu_free() instead of free().
Fix it.

Signed-off-by: Jean-Christophe DUBOIS <>
Signed-off-by: Anthony Liguori <>

2bc6f59b 12/02/2009 04:57 pm Jean-Christophe DUBOIS

Fix qemu_malloc/qemu_free use in rtl8139.c

rtl8139.c is using malloc()/free() instead of qemu_malloc()/qemu_free().
Fix it.

Signed-off-by: Jean-Christophe DUBOIS <>
Signed-off-by: Anthony Liguori <>

d6318738 12/02/2009 04:57 pm Michael S. Tsirkin

pci: move apb specific stuff to apb_pci.c

pci code had a TODO to move apb specific
pci bridge initialization to apb_pci.
Implement this and remove the TODO.

Signed-off-by: Michael S. Tsirkin <>
Signed-off-by: Anthony Liguori <>

b2538b4b 12/02/2009 04:57 pm Jean-Christophe DUBOIS

Fix qemu_free use in acpi.c

acpi.c is using free() instead of qemu_free().
Fix it.

Signed-off-by: Jean-Christophe DUBOIS <>
Signed-off-by: Anthony Liguori <>

49cd8046 12/02/2009 04:57 pm Jean-Christophe DUBOIS

Fix qemu_free use in baum.c

baum.c is using free() instead of qemu_free().
Fix it.

Signed-off-by: Jean-Christophe DUBOIS <>
Signed-off-by: Anthony Liguori <>

5f6eab3f 12/02/2009 04:57 pm Jean-Christophe DUBOIS

Fix qemu_free use in nand.c

nand.c is using free() instead of qemu_free().
Fix it.

Signed-off-by: Jean-Christophe DUBOIS <>
Signed-off-by: Anthony Liguori <>

2db69b23 12/02/2009 04:57 pm Jean-Christophe DUBOIS

Fix qemu_free use in bt-l2cap.c

bt-l2cap.c is using free() instead of qemu_free().
Fix it.

Signed-off-by: Jean-Christophe DUBOIS <>
Signed-off-by: Anthony Liguori <>

6f0953b1 12/02/2009 04:57 pm Jean-Christophe DUBOIS

Fix qemu_free use in nseries.c

nseries.c is using free() instead of qemu_free().
Fix it.

Signed-off-by: Jean-Christophe DUBOIS <>
Signed-off-by: Anthony Liguori <>

1062977b 12/02/2009 04:47 pm Stefan Weil

vga-pci: Fix access to linear framebuffer

Anthony Liguori's patch fixes the problems with
vga display in graphical mode and SeaBIOS.

I only adapted some values for vga-pci.

Signed-off-by: Stefan Weil <>
Signed-off-by: Anthony Liguori <>

98304c84 12/01/2009 06:00 pm Michael S. Tsirkin

msix: clear pending bit of an unused vector

PCI spec states:
if a masked vector has its Pending bit set, and the associated
underlying interrupt events are somehow satisfied (usually by software
though the exact manner is function-specific), the function must clear...

1f944c66 12/01/2009 06:00 pm Michael S. Tsirkin

msix: fix reset value for enable bit

On reset, we currently clear all bits in msix control register except
enable bit. This is wrong: the spec says we should clear writeable
bits: function mask and enable bit.
Correct this.

Signed-off-by: Michael S. Tsirkin <>

ae1be0bb 12/01/2009 05:59 pm Michael S. Tsirkin

msix: fix mask bit state after reset

PCI spec states that mask bit must be 1 after reset.
Make it so.

Signed-off-by: Michael S. Tsirkin <>

1b8e9b27 12/01/2009 05:58 pm Michael S. Tsirkin

virtio: do not reset msix state on soft reset

msix state is managed by OS, not the
driver, so it's wrong to touch it
on io from driver.
Mark all vectors unused instead.

Signed-off-by: Michael S. Tsirkin <>

b5f28bca 12/01/2009 05:58 pm Michael S. Tsirkin

msix: add helper to unuse all msix entries

will be used by virtio on soft reset

Signed-off-by: Michael S. Tsirkin <>

88a95564 12/01/2009 05:52 pm Michael S. Tsirkin

pci: convert goto into scope in bridge_filter

goto into scope is evil. rearrange pci_bridge_filter
so that we always go to end of function on error.

Signed-off-by: Michael S. Tsirkin <>
Acked-by: Isaku Yamahata <>

d46636b8 12/01/2009 05:52 pm Isaku Yamahata

pci: pci bridge related clean up.

- fix bridge prefetchable memory accesser to check 64bit or not.
- use pcibus_t consistently instead mixing pcibus_t and uint64_t.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

10c9c329 12/01/2009 05:52 pm Isaku Yamahata

pci: fix pci_config_get_io_base().

fix typo in pci_config_get_io_base().

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

b47b0706 12/01/2009 05:52 pm Isaku Yamahata

pci: remove magic number, 256 in pci.c

This patch replaces magic number, 256, with ARRAY_SIZE().

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

876a350d 12/01/2009 05:52 pm Michael S. Tsirkin

pci: split up up pci_update mappings

Split bar address math into a separate function.
In particular, this gets rid of an ugly forward goto
into scope that we have there.

Signed-off-by: Michael S. Tsirkin <>
Acked-by: Isaku Yamahata <>

ec503442 12/01/2009 05:52 pm Isaku Yamahata

pci: clean up of pci_update_mappings()

This patch converts r->size == 0 to !r_size.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

2c56b44b 12/01/2009 05:52 pm Isaku Yamahata

pci: remove unused constants

This patch removes unused constants committed by
fb23162885f7fd8cf7334bed22c25ac32c7d8b9d.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

fb47a2e9 12/01/2009 05:52 pm Isaku Yamahata

pci: move typedef, PCIHostState, PCIExpressHost to qemu-common.h.

This patch moves two typedefs, PCIHostState and PCIExpressHost to
qemu-common.h for consistency as PCIBus and PCIDevice are typedefed
in qemu-common.h.

Signed-off-by: Isaku Yamahata <>...

3c217c14 12/01/2009 05:52 pm Isaku Yamahata

pci: remove some unnecessary comment in pci.h

This patch removes some comment which should go into commit log
in pci.h.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

3e21ffc9 12/01/2009 05:52 pm Isaku Yamahata

pci: clean up of pci_init_wmask().

This patch replaces for loop by memset in pci_init_wmask().

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

c34369d4 12/01/2009 05:51 pm Isaku Yamahata

pci: kill unnecessary included in pci.c

including pci_host.h isn't needed by pci.c.
This patch kills it.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

42331e9f 12/01/2009 05:51 pm Isaku Yamahata

pci_host: remove unnecessary & 0xff.

This patch removes unnecessary & 0xff in pci_dev_find_by_addr().

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>