« Previous | Next » 

Revision cde0fc75

IDcde0fc7544ca590c83f349d4dcccf375d55d6042

Added by Markus Armbruster about 12 years ago

error: Let converted handlers print in human monitor

While fully converted handlers are not supposed to print anything when
running in a QMP monitor, they are free to print in a human monitor.
For instance, device_add (not yet converted) prints help, and will
continue to do so after conversion.

Moreover, utility functions converted to QError should remain usable
from unconverted handlers.

Two problems:

  • handler_audit() complains when a converted handler prints. Limit
    that to QMP monitors.
  • With QMP, handlers need to pass the error object by way of
    monitor_set_error(). However, we do that both for QMP and for the
    human monitor. The human monitor prints the error object after the
    handler returns. If the handler prints anything else, that output
    "overtakes" the error message.

    Limit use of monitor_set_error() to QMP monitors. Update
    handler_audit() accordingly.

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences