« Previous | Next » 

Revision de189a1b


Added by Kevin Wolf over 10 years ago

block: Handle multiwrite errors only when all requests have completed

Don't try to be clever by freeing all temporary data and calling all callbacks
when the return value (an error) is certain. Doing so has at least two
important problems:

  • The temporary data that is freed (qiov, possibly zero buffer) is still used
    by the requests that have not yet completed.
  • Calling the callbacks for all requests in the multiwrite means for the caller
    that it may free buffers etc. which are still in use.

Just remember the error value and do the cleanup when all requests have

Signed-off-by: Kevin Wolf <>


  • added
  • modified
  • copied
  • renamed
  • deleted

View differences