Activity
From 10/05/2009 to 11/03/2009
11/03/2009
- 06:14 pm ganeti-local Revision db8667b7: Workaround fake failures in drbd+live migration
- This patch is an attempt to fix the ugly issue during migration:
Cannot resync disks on node …: [True, 100]
If my ... - 06:14 pm Revision db8667b7: Workaround fake failures in drbd+live migration
- This patch is an attempt to fix the ugly issue during migration:
Cannot resync disks on node …: [True, 100]
If my ... - 04:31 pm Revision 099c52ad: Another round of pylint-related style fixes
- A newer version of pylint, more warnings…
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselm... - 04:31 pm ganeti-local Revision 099c52ad: Another round of pylint-related style fixes
- A newer version of pylint, more warnings…
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselm... - 03:42 pm ganeti-local Revision e3bdb1c2: Revert "configure: check for socat and its escape feature"
- This reverts commit 37fc2cf5ba8919cef407199ee540aad4b1a9a2b6, since it
introduces configure.ac changes that depend on... - 03:42 pm Revision e3bdb1c2: Revert "configure: check for socat and its escape feature"
- This reverts commit 37fc2cf5ba8919cef407199ee540aad4b1a9a2b6, since it
introduces configure.ac changes that depend on... - 03:42 pm ganeti-local Revision 1b48f7af: Revert "kvm console: use socat raw mode with escape"
- This reverts commit ce0eb6694e3fb2510035501539c7acc92a0f174e, since it depends
on 37fc2cf5ba8919cef407199ee540aad4b1a... - 03:42 pm Revision 1b48f7af: Revert "kvm console: use socat raw mode with escape"
- This reverts commit ce0eb6694e3fb2510035501539c7acc92a0f174e, since it depends
on 37fc2cf5ba8919cef407199ee540aad4b1a... - 03:20 pm Revision d2231b8c: Change behaviour of ConfigWriter._WriteConfig
- This patch changes the behaviour of _WriteConfig in case of
configuration errors:
- before, it used to abort the sav... - 03:20 pm ganeti-local Revision d2231b8c: Change behaviour of ConfigWriter._WriteConfig
- This patch changes the behaviour of _WriteConfig in case of
configuration errors:
- before, it used to abort the sav... - 03:20 pm Revision 679008e7: Add an example script for backing up the config
- This requires git and lockfile-progs, and only backs up config.data (see
the comments why).
Signed-off-by: Iustin Po... - 03:20 pm ganeti-local Revision 679008e7: Add an example script for backing up the config
- This requires git and lockfile-progs, and only backs up config.data (see
the comments why).
Signed-off-by: Iustin Po... - 03:14 pm Revision ce0eb669: kvm console: use socat raw mode with escape
- If this is enabled at configure time, we pass in different parameters to
the socat console, making it a lot more mana... - 03:14 pm ganeti-local Revision 37fc2cf5: configure: check for socat and its escape feature
- Currently we use a static value for the socat path, or we trust the
user-provided one. With this patch we still trust... - 03:14 pm ganeti-local Revision ce0eb669: kvm console: use socat raw mode with escape
- If this is enabled at configure time, we pass in different parameters to
the socat console, making it a lot more mana... - 03:14 pm Revision 66e7e01a: Fix version number in README
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:14 pm Revision 37fc2cf5: configure: check for socat and its escape feature
- Currently we use a static value for the socat path, or we trust the
user-provided one. With this patch we still trust... - 03:14 pm ganeti-local Revision 66e7e01a: Fix version number in README
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:07 pm ganeti-local Revision 31892b4c: utils: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:07 pm Revision 31892b4c: utils: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:45 pm ganeti-local Revision 2070598f: Change bdev.LogicalVolume.GetPVInfo usage
- We will need to enumerate selectively the PVs of (possible) many VGs and
not only the allocatable ones. For this we m... - 01:45 pm Revision d091393e: Implement cluster verify checks for wrong PV names
- Since ':' is not a valid character in PV names (for the way Ganeti uses
LVM), we need to check this and warn the user... - 01:45 pm ganeti-local Revision d091393e: Implement cluster verify checks for wrong PV names
- Since ':' is not a valid character in PV names (for the way Ganeti uses
LVM), we need to check this and warn the user... - 01:45 pm Revision 96c7a5b0: Throw specific error when ':' exists in PV names
- While ':' is not actually a supporte character in PV names (it has a
special meaning for commands like lvcreate), we ... - 01:45 pm Revision 2070598f: Change bdev.LogicalVolume.GetPVInfo usage
- We will need to enumerate selectively the PVs of (possible) many VGs and
not only the allocatable ones. For this we m... - 01:45 pm ganeti-local Revision 96c7a5b0: Throw specific error when ':' exists in PV names
- While ':' is not actually a supporte character in PV names (it has a
special meaning for commands like lvcreate), we ... - 12:51 pm ganeti-local Revision 6bcb1446: jqueue: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:51 pm Revision 6bcb1446: jqueue: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:51 pm ganeti-local Revision 06b78e8b: hv_xen: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:51 pm Revision 06b78e8b: hv_xen: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:51 pm ganeti-local Revision d3833ebd: bootstrap: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:51 pm Revision d3833ebd: bootstrap: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:51 pm ganeti-local Revision def8e2f6: bdev: Convert to utils.Retry
- Also replaces a hardcoded limit of 15 seconds with 1/4
of NET_RECONFIG_TIMEOUT.
Signed-off-by: Michael Hanselmann <h... - 12:51 pm Revision def8e2f6: bdev: Convert to utils.Retry
- Also replaces a hardcoded limit of 15 seconds with 1/4
of NET_RECONFIG_TIMEOUT.
Signed-off-by: Michael Hanselmann <h... - 12:51 pm ganeti-local Revision 3c0cdc83: backend: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:51 pm Revision 3c0cdc83: backend: Convert to utils.Retry
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:51 pm ganeti-local Revision de0ea66b: Add generic retry loop function
- There are quite a few retry loops with timeouts in Ganeti's
code. Duplicating code is not good, so this patch introdu... - 12:51 pm Revision de0ea66b: Add generic retry loop function
- There are quite a few retry loops with timeouts in Ganeti's
code. Duplicating code is not good, so this patch introdu... - 12:34 pm ganeti-local Revision 25231ec5: Ignore log messages in unittests
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:34 pm Revision 25231ec5: Ignore log messages in unittests
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
11/02/2009
- 04:14 pm ganeti-local Revision 7e9c6a78: Some improvements to gnt-node repair-storage
- Currently the repair storage has two issues:
- down instances are aborting the operation, even though they should be... - 04:14 pm Revision 7e9c6a78: Some improvements to gnt-node repair-storage
- Currently the repair storage has two issues:
- down instances are aborting the operation, even though they should be... - 04:14 pm Revision debac808: Convert the rest of the OpPrereqError users
- This finishes the conversion of OpPrereqError creation to two-argument
style. Any leftovers as one-argument are not b... - 04:14 pm ganeti-local Revision debac808: Convert the rest of the OpPrereqError users
- This finishes the conversion of OpPrereqError creation to two-argument
style. Any leftovers as one-argument are not b... - 04:14 pm ganeti-local Revision 045dd6d9: Add ecode to rpc.py's RpcResult.Raise()
- This patch adds a new ecode argument to RpcResult.Raise(). This allows
specifying the error code (for both OpExec and... - 04:14 pm Revision 045dd6d9: Add ecode to rpc.py's RpcResult.Raise()
- This patch adds a new ecode argument to RpcResult.Raise(). This allows
specifying the error code (for both OpExec and... - 04:14 pm ganeti-local Revision 5c983ee5: Introduce two-argument style for OpPrereqError
- This patch introduces a two-argument style for OpPrereqError. Only the
direct raise calls in cmdlib.py are converted,... - 04:14 pm Revision 5c983ee5: Introduce two-argument style for OpPrereqError
- This patch introduces a two-argument style for OpPrereqError. Only the
direct raise calls in cmdlib.py are converted,... - 04:06 pm Revision 159d4ec6: Remove the OpRetryError exception
- This is only used in two places, in an error path that is no longer
valid since Ganeti 2.0. We remove the try..except... - 04:06 pm ganeti-local Revision 159d4ec6: Remove the OpRetryError exception
- This is only used in two places, in an error path that is no longer
valid since Ganeti 2.0. We remove the try..except... - 02:07 pm Revision 3e53a60b: Activate disks while exporting an instance
- Exporting an instance not running or without activated disks
will fail. This patch makes sure to activate disks befor... - 02:07 pm ganeti-local Revision 3e53a60b: Activate disks while exporting an instance
- Exporting an instance not running or without activated disks
will fail. This patch makes sure to activate disks befor... - 02:05 pm ganeti-local Revision 23057d29: Epydoc fixes
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 02:05 pm Revision 23057d29: Epydoc fixes
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 02:04 pm Revision ea79fc15: backend: Don't overwrite function parameter with loop variable
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 02:04 pm ganeti-local Revision ea79fc15: backend: Don't overwrite function parameter with loop variable
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 02:04 pm Revision 8e1db003: Add QA test for “gnt-node {list,modify,repair}-storage”
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:04 pm ganeti-local Revision 8e1db003: Add QA test for “gnt-node {list,modify,repair}-storage”
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 10:22 am ganeti-local Revision 620a85fd: Unify the query fields for the storage framework
- This patch unifies the query fields in the storage framework for all
types. Note that the information is still comput... - 10:22 am Revision 620a85fd: Unify the query fields for the storage framework
- This patch unifies the query fields in the storage framework for all
types. Note that the information is still comput...
10/30/2009
- 01:23 pm Revision 366a7c89: hspace: Abstract the instance listing
- This also converts it to formatTable from hardcoded listing.
- 01:23 pm Revision 1f9066c0: Rework the instance spec CLI options
- This patch reworks the internal handling of the instance spec CLI
option, and adds a tiered spec option that will be ... - 01:23 pm Revision 2f567ac0: Convert option parsing to a monadic flow
- This allows us to do verification of option arguments in the assignment
functions themselves. - 01:23 pm ganeti-local Revision 2f567ac0: Convert option parsing to a monadic flow
- This allows us to do verification of option arguments in the assignment
functions themselves. - 01:23 pm ganeti-local Revision 366a7c89: hspace: Abstract the instance listing
- This also converts it to formatTable from hardcoded listing.
- 01:23 pm ganeti-local Revision 1f9066c0: Rework the instance spec CLI options
- This patch reworks the internal handling of the instance spec CLI
option, and adds a tiered spec option that will be ... - 12:46 pm ganeti-local Revision 8f215968: Make cluster initialization more reliable
- There was a race condition between starting the node daemon
and sending requests to write the ssconf files. With this... - 12:46 pm Revision 8f215968: Make cluster initialization more reliable
- There was a race condition between starting the node daemon
and sending requests to write the ssconf files. With this...
10/29/2009
- 06:06 pm ganeti-local Revision 1df79ce6: Don't show warnings on ADMIN_down instance failover
- Before:
$ gnt-instance failover -f inst1
… checking disk consistency between source and target
… - WARNING: Can't fin... - 06:06 pm Revision 1df79ce6: Don't show warnings on ADMIN_down instance failover
- Before:
$ gnt-instance failover -f inst1
… checking disk consistency between source and target
… - WARNING: Can't fin... - 04:48 pm Revision 936f3c59: Update NEWS
- Add rapi_users changes, rearrange a bit and one wording change.
Signed-off-by: Michael Hanselmann <hansmi@google.com... - 04:48 pm ganeti-local Revision 936f3c59: Update NEWS
- Add rapi_users changes, rearrange a bit and one wording change.
Signed-off-by: Michael Hanselmann <hansmi@google.com... - 11:33 am ganeti-local Revision c099b8d8: Add remote API users and passwords documentation
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:33 am Revision c099b8d8: Add remote API users and passwords documentation
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:33 am ganeti-local Revision 0b08f096: ganeti-rapi: Use new function to verify passwords
- This enables the use of hashed passwords in rapi_users.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review... - 11:33 am Revision 0b08f096: ganeti-rapi: Use new function to verify passwords
- This enables the use of hashed passwords in rapi_users.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review... - 11:33 am ganeti-local Revision bf9bd8dd: http.auth: Add new function to verify passwords
- This new function supports two schemes for passwords:
- Old-style cleartext passwords
- Hashed passwords according to... - 11:33 am Revision bf9bd8dd: http.auth: Add new function to verify passwords
- This new function supports two schemes for passwords:
- Old-style cleartext passwords
- Hashed passwords according to...
10/28/2009
- 12:10 pm ganeti-local Revision c6aa0c42: Makefile.am: Add more checks to distcheck-hook
- Also use grep only to convert find's output to an exit status.
Signed-off-by: Michael Hanselmann <hansmi@google.com>... - 12:10 pm Revision c6aa0c42: Makefile.am: Add more checks to distcheck-hook
- Also use grep only to convert find's output to an exit status.
Signed-off-by: Michael Hanselmann <hansmi@google.com>... - 05:00 am ganeti-local Revision c71a1a3d: Documentation updates
- Our admin guide was very very trivial. This patch updates it to contain
advice on when to use which commands, removes... - 05:00 am Revision c71a1a3d: Documentation updates
- Our admin guide was very very trivial. This patch updates it to contain
advice on when to use which commands, removes... - 03:49 am ganeti-local Revision c6f1af07: Fix another style issue
- For the Nth time, re-fix shadowing of outer-scope variable :)
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed... - 03:49 am Revision c6f1af07: Fix another style issue
- For the Nth time, re-fix shadowing of outer-scope variable :)
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed... - 03:48 am Revision dc09c3cf: Make gnt-node list-storage more standard
- This patch adds support for the -o+field,… format that the other list
commands accept and changes the format of the a... - 03:48 am ganeti-local Revision dc09c3cf: Make gnt-node list-storage more standard
- This patch adds support for the -o+field,… format that the other list
commands accept and changes the format of the a... - 03:47 am ganeti-local Revision 9b94905f: Rename the node storage commands
- To reduce confusion, the following gnt-node commands are renamed:
- physical-volumes → list-storage
- modify-volume ... - 03:47 am Revision 9b94905f: Rename the node storage commands
- To reduce confusion, the following gnt-node commands are renamed:
- physical-volumes → list-storage
- modify-volume ... - 03:22 am ganeti-local Revision 20eca47d: Fix an error handling case in TLReplaceDisks
- pylint is your friend, since the compiler doesn't exist.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ... - 03:22 am Revision 20eca47d: Fix an error handling case in TLReplaceDisks
- pylint is your friend, since the compiler doesn't exist.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ...
10/27/2009
- 03:14 pm ganeti-local Revision a4eae71f: Provide feedback from redistributing configuration
- This is particularily useful for “gnt-cluster redist-conf”, but
also for all other cases where the configuration file... - 03:14 pm Revision a4eae71f: Provide feedback from redistributing configuration
- This is particularily useful for “gnt-cluster redist-conf”, but
also for all other cases where the configuration file... - 01:53 pm ganeti-local Revision 25c92bc5: Makefile.am: Wrap long lines
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 01:53 pm ganeti-local Revision b76aac08: Include NEWS in documentation again
- This was implemented in 350ecfecca and reverted in 700bb84367
after it broke “make distcheck”. With other changes in ... - 01:53 pm ganeti-local Revision a10caf87: bash_completion: Move common code into function
- This reduces the size of the script by about 9 kB.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by... - 01:53 pm Revision a10caf87: bash_completion: Move common code into function
- This reduces the size of the script by about 9 kB.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by... - 01:53 pm Revision 25c92bc5: Makefile.am: Wrap long lines
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 01:53 pm Revision b76aac08: Include NEWS in documentation again
- This was implemented in 350ecfecca and reverted in 700bb84367
after it broke “make distcheck”. With other changes in ... - 01:52 pm ganeti-local Revision 7e1ccbe0: Makefile.am: Use noinst_DATA instead of all-local target
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:52 pm ganeti-local Revision f727d134: Makefile.am: Don't include MAINTAINERCLEANFILES in EXTRA_DIST
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:52 pm Revision 7e1ccbe0: Makefile.am: Use noinst_DATA instead of all-local target
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:52 pm Revision f727d134: Makefile.am: Don't include MAINTAINERCLEANFILES in EXTRA_DIST
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:51 pm ganeti-local Revision 13de7d59: Makefile.am: Make HTML doc building depend on stamp file
- This patch also adds an explicit list of all files written by
sphinx (“docoutput”).
By using an explicit list the bu... - 01:51 pm Revision 13de7d59: Makefile.am: Make HTML doc building depend on stamp file
- This patch also adds an explicit list of all files written by
sphinx (“docoutput”).
By using an explicit list the bu... - 12:55 pm Revision dd1dfd9a: Makefile.am: Use dependencies to create symlinks only if necessary
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 12:55 pm ganeti-local Revision dd1dfd9a: Makefile.am: Use dependencies to create symlinks only if necessary
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 12:54 pm ganeti-local Revision dbefcc7e: Makefile.am: Move stamp-directories to BUILT_SOURCES
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 12:54 pm Revision dbefcc7e: Makefile.am: Move stamp-directories to BUILT_SOURCES
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 02:54 am ganeti-local Revision 705dd60e: Fix gnt-debug breakage due to options move
- Commits d3ed23f and 4eb6265 broke gnt-debug due to renamed option
targets. Sorry again!
Signed-off-by: Iustin Pop <i... - 02:54 am Revision 705dd60e: Fix gnt-debug breakage due to options move
- Commits d3ed23f and 4eb6265 broke gnt-debug due to renamed option
targets. Sorry again!
Signed-off-by: Iustin Pop <i... - 02:54 am ganeti-local Revision e9022531: Fix gnt-node evacuate w. iallocator
- Commit 2bb5c911 moved around and changed the _RunAllocator function in
the DiskReplace → TaskLet conversion, but in t... - 02:54 am Revision e9022531: Fix gnt-node evacuate w. iallocator
- Commit 2bb5c911 moved around and changed the _RunAllocator function in
the DiskReplace → TaskLet conversion, but in t...
10/26/2009
- 04:48 pm ganeti-local Revision 19351457: InstanceIpToNodePrimaryIpQuery: use a query dict
- In 95b487b we changed InstanceIpToNodePrimaryIpQuery to be able to query
multiple instances at once. We also need to ... - 04:48 pm Revision 19351457: InstanceIpToNodePrimaryIpQuery: use a query dict
- In 95b487b we changed InstanceIpToNodePrimaryIpQuery to be able to query
multiple instances at once. We also need to ... - 04:48 pm Revision cd195419: SimpleConfigReader: ips are partitioned by link
- We were already half-doing it, but this completes the process.
1) We don't maintain a list of ips or an ip->instance... - 04:48 pm ganeti-local Revision cd195419: SimpleConfigReader: ips are partitioned by link
- We were already half-doing it, but this completes the process.
1) We don't maintain a list of ips or an ip->instance... - 12:17 pm Revision 47a626b0: SimpleConfigReader: queries for default nicparams
- GetDefaultNicParams returns the default nic parameters.
GetDefaultNicLink returns the default nic link.
Signed-off-b... - 12:17 pm ganeti-local Revision 47a626b0: SimpleConfigReader: queries for default nicparams
- GetDefaultNicParams returns the default nic parameters.
GetDefaultNicLink returns the default nic link.
Signed-off-b... - 12:17 pm ganeti-local Revision 6855f043: Import errors in confd __init__
- It's used by some functions defined there.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier ... - 12:17 pm ganeti-local Revision f3313af5: Use RUN_IN_TEMPDIR in Makefile.am
- Since we have this variable and use it in other places, remove the only
leftover hardcoded place.
Signed-off-by: Gui... - 12:17 pm Revision f3313af5: Use RUN_IN_TEMPDIR in Makefile.am
- Since we have this variable and use it in other places, remove the only
leftover hardcoded place.
Signed-off-by: Gui... - 12:17 pm Revision 6855f043: Import errors in confd __init__
- It's used by some functions defined there.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier ... - 11:41 am ganeti-local Revision b5e5632e: Allow '@' in tag values
- This allows using an email address (as is) as part of a tag. The main
problem that could arise is when parsing tags f... - 11:41 am Revision b5e5632e: Allow '@' in tag values
- This allows using an email address (as is) as part of a tag. The main
problem that could arise is when parsing tags f... - 11:41 am ganeti-local Revision f7e41aa2: Fix gnt-node modify-volume
- This was broken by me in 064c21f, sorry!
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselma... - 11:41 am Revision f7e41aa2: Fix gnt-node modify-volume
- This was broken by me in 064c21f, sorry!
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselma... - 11:40 am ganeti-local Revision aeaefce8: gnt-node: add short option -t for --storage-type
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:40 am Revision aeaefce8: gnt-node: add short option -t for --storage-type
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
10/23/2009
- 04:10 pm ganeti-local Revision e58b56ad: init script: allow singling out confd as well
- Currently we can start/stop the various subdaemons, but not confd.
Signed-off-by: Guido Trotter <ultrotter@google.co... - 04:10 pm Revision e58b56ad: init script: allow singling out confd as well
- Currently we can start/stop the various subdaemons, but not confd.
Signed-off-by: Guido Trotter <ultrotter@google.co... - 12:01 pm ganeti-local Revision d52ea991: cmdlib._AssembleInstanceDisks: Fix case where variable wouldn't be set
- The “result” variable may not be set and/or come from the previous loop.
Signed-off-by: Michael Hanselmann <hansmi@g... - 12:01 pm Revision d52ea991: cmdlib._AssembleInstanceDisks: Fix case where variable wouldn't be set
- The “result” variable may not be set and/or come from the previous loop.
Signed-off-by: Michael Hanselmann <hansmi@g...
10/22/2009
- 06:24 pm ganeti-local Revision 35fb11e3: Makefile: Use path from configure script for sphinx-build
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Ken Wehr <ksw@google.com> - 06:24 pm Revision 35fb11e3: Makefile: Use path from configure script for sphinx-build
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Ken Wehr <ksw@google.com> - 06:15 pm ganeti-local Revision 8866ec86: KVM netscript: add static routes, with no suffix
- The /32 suffix is useless, since the kernel already assumes single-host,
if no suffix is specified. Moreover we prefe... - 06:15 pm Revision 8866ec86: KVM netscript: add static routes, with no suffix
- The /32 suffix is useless, since the kernel already assumes single-host,
if no suffix is specified. Moreover we prefe... - 05:53 pm ganeti-local Revision 5db6a71c: gnt-job manpage: Remove detailed description for lock_status
- The format changed in the meantime and should be self-explanatory.
Signed-off-by: Michael Hanselmann <hansmi@google.... - 05:53 pm Revision 5db6a71c: gnt-job manpage: Remove detailed description for lock_status
- The format changed in the meantime and should be self-explanatory.
Signed-off-by: Michael Hanselmann <hansmi@google.... - 04:40 pm ganeti-local Revision b989b9d9: Adding '--no-ssh-init' option to 'gnt-cluster init'.
- Allows the initialization of a cluster without the creation or distribution
of SSH key pairs. Includes changes for Le... - 04:40 pm ganeti-local Revision b7b7cda6: Man page for ganeti-confd
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:40 pm ganeti-local Revision 2c5afffb: KVMHypervisor: implement instance policy routing
- Until now we relied on traffic from instances being policy routed via a
rule based on the instance network. With this... - 04:40 pm ganeti-local Revision e014f1d0: KVMHypervisor: configure v6 parameters on nic
- In routing mode we are tweaking a few parameters on the interface. With
this patch we'll tweak both the v4 and v6 one... - 04:40 pm Revision b989b9d9: Adding '--no-ssh-init' option to 'gnt-cluster init'.
- Allows the initialization of a cluster without the creation or distribution
of SSH key pairs. Includes changes for Le... - 04:40 pm Revision e014f1d0: KVMHypervisor: configure v6 parameters on nic
- In routing mode we are tweaking a few parameters on the interface. With
this patch we'll tweak both the v4 and v6 one... - 04:40 pm Revision 2c5afffb: KVMHypervisor: implement instance policy routing
- Until now we relied on traffic from instances being policy routed via a
rule based on the instance network. With this... - 04:40 pm Revision b7b7cda6: Man page for ganeti-confd
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:40 pm ganeti-local Revision 95b487bb: confd: query the pnode of multiple instances at once
- Signed-off-by: Flavio Silvestrow <flaviops@google.com>
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-b... - 04:40 pm Revision 95b487bb: confd: query the pnode of multiple instances at once
- Signed-off-by: Flavio Silvestrow <flaviops@google.com>
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-b... - 12:16 pm Revision 3782acd7: Try to reduce wrong errors in InstanceShutdown
- In backend.InstanceShutdown(), there is a race condition between
checking that the instance exists and trying to shut... - 12:16 pm ganeti-local Revision 3782acd7: Try to reduce wrong errors in InstanceShutdown
- In backend.InstanceShutdown(), there is a race condition between
checking that the instance exists and trying to shut... - 12:15 pm Revision 7734de0a: Revert breakage introduced in e4e9b80
- Commit e4e9b8064787df01a79846a40f49c8ae06a8eb0e introduced two problems
in backend.InstanceShutdown():
- first, it r... - 12:15 pm ganeti-local Revision 7734de0a: Revert breakage introduced in e4e9b80
- Commit e4e9b8064787df01a79846a40f49c8ae06a8eb0e introduced two problems
in backend.InstanceShutdown():
- first, it r... - 12:15 pm ganeti-local Revision 0cf11e68: Xen: Ignore the retry argument in stop instance
- Commit 4ad4511 changed the KVM hypervisor to send multiple shutdown
requests to the monitor, but it didn't change thi... - 12:15 pm Revision 0cf11e68: Xen: Ignore the retry argument in stop instance
- Commit 4ad4511 changed the KVM hypervisor to send multiple shutdown
requests to the monitor, but it didn't change thi...
10/21/2009
- 02:06 pm Revision ce0392e6: Some cleanup of Loader.mergeData
- This doesn't need to be a monadic function, let's make it a simpler one.
- 02:06 pm ganeti-local Revision ce0392e6: Some cleanup of Loader.mergeData
- This doesn't need to be a monadic function, let's make it a simpler one.
- 12:26 pm Revision 1645d22d: Ensure RpcResult has “payload” attribute
- Also add assertions to avoid missing attributes in the future.
They won't be included in optimized bytecode.
Signed-... - 12:26 pm ganeti-local Revision 1645d22d: Ensure RpcResult has “payload” attribute
- Also add assertions to avoid missing attributes in the future.
They won't be included in optimized bytecode.
Signed-... - 11:58 am Revision a5f8dcdc: hbal: ignore unknown instance in dynload file
- Since the utilisation file might be generated at a different time from
the hbal run, and instances could dissapear in... - 11:58 am ganeti-local Revision a5f8dcdc: hbal: ignore unknown instance in dynload file
- Since the utilisation file might be generated at a different time from
the hbal run, and instances could dissapear in... - 11:49 am Revision 4bfe220e: Fix hbal man page w.r.t. --print-instances
- The ordering was wrong, was showing node list details under
--print-instances. - 11:49 am ganeti-local Revision 4bfe220e: Fix hbal man page w.r.t. --print-instances
- The ordering was wrong, was showing node list details under
--print-instances. - 11:47 am Revision 30ff0c73: Expand the --print-instances output
- This adds run status, resource parameters and load parameters for
instances. - 11:47 am ganeti-local Revision 30ff0c73: Expand the --print-instances output
- This adds run status, resource parameters and load parameters for
instances.
10/20/2009
- 11:28 pm ganeti-local Revision aeaa2ea2: Fix typo in install.rst
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 11:28 pm Revision aeaa2ea2: Fix typo in install.rst
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 07:59 pm Revision 8ab90d80: install.rst: mention xen config for live migration
- This addresses issue 75.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi... - 07:59 pm ganeti-local Revision 8ab90d80: install.rst: mention xen config for live migration
- This addresses issue 75.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi... - 12:35 pm Revision 62066d05: Bump version to 2.1.0~beta2
- I forgot to bump the configure.ac version before tagging the 2.1.0~beta1
release. Since we cannot remove old tags (se... - 12:35 pm ganeti-local Revision 62066d05: Bump version to 2.1.0~beta2
- I forgot to bump the configure.ac version before tagging the 2.1.0~beta1
release. Since we cannot remove old tags (se... - 06:53 am ganeti-local Revision 7c0aa8e9: Introduce checks for /sys and /proc
- This patch adds checks for /proc and /sys in cluster verify, since
Ganeti relies on these special filesystems to be m... - 06:53 am Revision 7c0aa8e9: Introduce checks for /sys and /proc
- This patch adds checks for /proc and /sys in cluster verify, since
Ganeti relies on these special filesystems to be m...
10/19/2009
- 05:57 pm ganeti-local Revision d357f531: Fix serializer unittests
- Commit d22b29997cd broke the serializer unittests with certain
versions of simplejson. This patch removes sort_keys a... - 05:57 pm Revision d357f531: Fix serializer unittests
- Commit d22b29997cd broke the serializer unittests with certain
versions of simplejson. This patch removes sort_keys a... - 09:06 am Revision 8ed71b67: Old update to the NEWS file
- 0.1.8 was never documented in the NEWS file.
- 09:06 am ganeti-local Revision 8ed71b67: Old update to the NEWS file
- 0.1.8 was never documented in the NEWS file.
- 01:08 am Revision e7724ccc: Change the Container.findByName function
- This patch changes the signature and implementation of the function;
returning the item makes more sense (saves a loo... - 01:08 am ganeti-local Revision e7724ccc: Change the Container.findByName function
- This patch changes the signature and implementation of the function;
returning the item makes more sense (saves a loo... - 01:08 am ganeti-local Revision bbd8efd2: Some small style fixes
- 01:08 am Revision bbd8efd2: Some small style fixes
- 12:17 am Revision 8c9af2f0: Simplify the cstats initializer
- Since all values are initialized to zero, the exact ordering is not
important and thus we can use the positional mode... - 12:17 am ganeti-local Revision 8c9af2f0: Simplify the cstats initializer
- Since all values are initialized to zero, the exact ordering is not
important and thus we can use the positional mode... - 12:11 am Revision 668c03b3: Simplify Cluster.computeMoves
- Since we now have an actual type for describing the instance moves
(IMove), it's simpler to convert this into the mov... - 12:11 am ganeti-local Revision 668c03b3: Simplify Cluster.computeMoves
- Since we now have an actual type for describing the instance moves
(IMove), it's simpler to convert this into the mov...
10/18/2009
- 11:20 pm Revision eb2598ab: Remove obsolete export
- The ‘Placement’ type has been moved to Types.hs but we kept exporting it
from Cluster, which is not needed. - 11:20 pm ganeti-local Revision eb2598ab: Remove obsolete export
- The ‘Placement’ type has been moved to Types.hs but we kept exporting it
from Cluster, which is not needed. - 08:21 pm Revision c5f7412e: Generalise the node/instance listing
- This patch introduces a generic formatTable function (based on, and
similar to the Ganeti one, but different and more... - 08:21 pm ganeti-local Revision c5f7412e: Generalise the node/instance listing
- This patch introduces a generic formatTable function (based on, and
similar to the Ganeti one, but different and more... - 07:38 pm Revision ad6cffe4: Fix instance listing for non-redundant case
- 07:38 pm ganeti-local Revision ad6cffe4: Fix instance listing for non-redundant case
10/16/2009
- 05:51 pm ganeti-local Revision aeb0c953: cfgupgrade: Implement upgrade to 2.1.0
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:51 pm Revision aeb0c953: cfgupgrade: Implement upgrade to 2.1.0
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:51 pm ganeti-local Revision c008906b: bootstrap: Factorize HMAC key generation
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:51 pm Revision c008906b: bootstrap: Factorize HMAC key generation
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:51 pm ganeti-local Revision cd34faf2: Make bootstrap._GenerateSelfSignedSslCert public
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:51 pm Revision cd34faf2: Make bootstrap._GenerateSelfSignedSslCert public
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:51 pm Revision 11c31f5c: cfgupgrade: Remove Ganeti 1.2 support
- This also fixes a few typos.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@g... - 05:51 pm ganeti-local Revision 11c31f5c: cfgupgrade: Remove Ganeti 1.2 support
- This also fixes a few typos.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@g... - 05:51 pm ganeti-local Revision d22b2999: serializer: Sort keys in JSON
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:51 pm Revision d22b2999: serializer: Sort keys in JSON
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:24 pm ganeti-local Revision c4ef235b: Fix two haddoc/happy docstring issues
- 05:24 pm Revision c4ef235b: Fix two haddoc/happy docstring issues
- 05:20 pm Revision d1f5d461: Update hbal manpage with details about dynutil
- 05:20 pm ganeti-local Revision d1f5d461: Update hbal manpage with details about dynutil
- 04:59 pm Revision ee9724b9: Start using the utilisation scores in balancing
- This enables the per-node load/total available capacity scores to be
used in balancing. Note that the total available... - 04:59 pm ganeti-local Revision ee9724b9: Start using the utilisation scores in balancing
- This enables the per-node load/total available capacity scores to be
used in balancing. Note that the total available... - 04:59 pm Revision aa8d2e71: Add loading and processing of utilisation data
- This patch adds loading and processing the utilisation data during
instance moves. While the data is not yet used, it... - 04:59 pm ganeti-local Revision aa8d2e71: Add loading and processing of utilisation data
- This patch adds loading and processing the utilisation data during
instance moves. While the data is not yet used, it... - 02:54 pm Revision 4f83a560: Add an option to input utilisation data
- 02:54 pm ganeti-local Revision 4f83a560: Add an option to input utilisation data
- 02:43 pm ganeti-local Revision a488a217: Merge the Node.setPri and Node.addCpus functions
- The latter is only used right after the former in the Loader module, and
we'll need more of this 'update not with the... - 02:43 pm Revision a488a217: Merge the Node.setPri and Node.addCpus functions
- The latter is only used right after the former in the Loader module, and
we'll need more of this 'update not with the... - 10:41 am Revision 5b763470: Move some utility functions to Utils.hs
- These were already duplicate (Text and Simu) and we need tryRead in more places.
- 10:41 am ganeti-local Revision 5b763470: Move some utility functions to Utils.hs
- These were already duplicate (Text and Simu) and we need tryRead in more places.
- 10:09 am Revision 183a9c3d: Show the load on nodes in node lists
- The strange printf usage is due to some limitation (it seems) in ghc for
very long argument lists. The whole printout... - 10:09 am ganeti-local Revision 183a9c3d: Show the load on nodes in node lists
- The strange printf usage is due to some limitation (it seems) in ghc for
very long argument lists. The whole printout...
10/15/2009
- 05:47 pm ganeti-local Revision b03ee906: Bump version to 2.1.0~beta0
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 05:47 pm Revision b03ee906: Bump version to 2.1.0~beta0
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 05:47 pm Revision a6db1af2: mcpu: Use new timeout class for timeout
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:47 pm ganeti-local Revision a6db1af2: mcpu: Use new timeout class for timeout
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:47 pm Revision f4e673fb: locking: Convert pipe condition to new timeout class
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:47 pm ganeti-local Revision f4e673fb: locking: Convert pipe condition to new timeout class
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:47 pm ganeti-local Revision 7e8841bd: locking.LockSet: Move timeout calculation to separate class
- This class can also be used by mcpu.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <... - 05:47 pm Revision 7e8841bd: locking.LockSet: Move timeout calculation to separate class
- This class can also be used by mcpu.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <... - 05:47 pm ganeti-local Revision b6b87034: locking, mcpu: Ensure timeout is always >= 0.0
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:47 pm Revision b6b87034: locking, mcpu: Ensure timeout is always >= 0.0
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:05 pm Revision 2180829f: Add initial structure for utilisation balancing
- This patch adds the datatypes and modifies the nodes and instance types to have
such attributes. They are not used ye... - 05:05 pm ganeti-local Revision 2180829f: Add initial structure for utilisation balancing
- This patch adds the datatypes and modifies the nodes and instance types to have
such attributes. They are not used ye... - 05:00 pm ganeti-local Revision 507fda3f: Allow displaying the instance map in hbal
- This is similar to --print-nodes, but with much fewer fields.
- 05:00 pm Revision 507fda3f: Allow displaying the instance map in hbal
- This is similar to --print-nodes, but with much fewer fields.
- 11:49 am ganeti-local Revision 181d4e04: Add an explicit export list to Instance.hs
- This exports all functions, but it's still good to have.
- 11:49 am Revision 181d4e04: Add an explicit export list to Instance.hs
- This exports all functions, but it's still good to have.
- 11:33 am Revision 3a3c1eb4: More hlint fixes
- This makes (for now) the code hlint-clean. This is per se not a huge
gain, but it allows easier tracking of regressio... - 11:33 am ganeti-local Revision 3a3c1eb4: More hlint fixes
- This makes (for now) the code hlint-clean. This is per se not a huge
gain, but it allows easier tracking of regressio...
10/14/2009
- 04:43 pm Revision c15f7183: Style change: camel-casing of unittests
- 04:43 pm ganeti-local Revision c15f7183: Style change: camel-casing of unittests
- 04:41 pm Revision f5b553da: Style change: cluster CStats camel-casing
- This is again the cs_x to csX name change.
- 04:41 pm ganeti-local Revision f5b553da: Style change: cluster CStats camel-casing
- This is again the cs_x to csX name change.
- 04:41 pm Revision 2060348b: Style change: node and instance attributes
- This changes from a_b to aB in all node and instance attributes, to
match the standard Haskell style. Also attributes... - 04:41 pm ganeti-local Revision 2060348b: Style change: node and instance attributes
- This changes from a_b to aB in all node and instance attributes, to
match the standard Haskell style. Also attributes... - 01:45 pm ganeti-local Revision fca250e9: Modify the internals of the detailed CV scores
- Before we used a tuple; since we'll need more metrics in the future,
it's simpler to transform this into a list of do... - 01:45 pm Revision fca250e9: Modify the internals of the detailed CV scores
- Before we used a tuple; since we'll need more metrics in the future,
it's simpler to transform this into a list of do... - 11:56 am Revision 0bfbb3e8: Update the hbal manpage w.r.t. job execution
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:56 am ganeti-local Revision 0bfbb3e8: Update the hbal manpage w.r.t. job execution
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:56 am Revision b2245847: Implement first version of job execution
- This not so nice patch adds submit/wait-for-completion functionality in
hbal. When enabled via ‘-X’ (only working on ... - 11:56 am ganeti-local Revision b2245847: Implement first version of job execution
- This not so nice patch adds submit/wait-for-completion functionality in
hbal. When enabled via ‘-X’ (only working on ... - 11:56 am ganeti-local Revision 0df5a1b4: Add a command line option for executing jobs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:56 am Revision 0df5a1b4: Add a command line option for executing jobs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:56 am Revision 9a2ff880: Add two specialized Luxi calls
- This are higher level wrappers over the basic callMethod.
Signed-off-by: Iustin Pop <iustin@google.com> - 11:56 am ganeti-local Revision 9a2ff880: Add two specialized Luxi calls
- This are higher level wrappers over the basic callMethod.
Signed-off-by: Iustin Pop <iustin@google.com> - 11:56 am ganeti-local Revision dfbbd43a: Change iMoveToJob to properly create migrates
- The current Cluster.iMoveToJob always creates failovers, which is not
what we want. This simply used the original ins... - 11:56 am Revision dfbbd43a: Change iMoveToJob to properly create migrates
- The current Cluster.iMoveToJob always creates failovers, which is not
what we want. This simply used the original ins... - 11:55 am ganeti-local Revision 924f9c16: Extend the MoveJob type to hold the instance index
- This will be needed in order to generate the proper instance move commands.
Signed-off-by: Iustin Pop <iustin@google... - 11:55 am Revision 924f9c16: Extend the MoveJob type to hold the instance index
- This will be needed in order to generate the proper instance move commands.
Signed-off-by: Iustin Pop <iustin@google... - 11:53 am Revision 13b6cb3f: Add a simple module for dealing with Ganeti jobs
- This holds for now just the job status definitions and its serialisation
to/from JSON.
Signed-off-by: Iustin Pop <iu... - 11:53 am ganeti-local Revision 13b6cb3f: Add a simple module for dealing with Ganeti jobs
- This holds for now just the job status definitions and its serialisation
to/from JSON.
Signed-off-by: Iustin Pop <iu...
10/13/2009
- 08:08 pm ganeti-local Revision e4335b5b: locking.LockSet: Improve assertions
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm Revision e4335b5b: locking.LockSet: Improve assertions
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm ganeti-local Revision 76e2f08a: locking: Factorize LockSet.acquire
- By moving the main code of LockSet.acquire to its own function
we reduce the code complexity a bit and clarify the ex... - 08:08 pm Revision 76e2f08a: locking: Factorize LockSet.acquire
- By moving the main code of LockSet.acquire to its own function
we reduce the code complexity a bit and clarify the ex... - 08:08 pm ganeti-local Revision 6f14fc27: mcpu: Make sure added locks are released on errors
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm Revision 6f14fc27: mcpu: Make sure added locks are released on errors
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm ganeti-local Revision 23683c26: Test LockSet.acquire return value for timeout
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm Revision 23683c26: Test LockSet.acquire return value for timeout
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm ganeti-local Revision fc1baca9: opcodes: Add missing shutdown_timeout to OpRemoveInstance
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm Revision fc1baca9: opcodes: Add missing shutdown_timeout to OpRemoveInstance
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm ganeti-local Revision 63d96e4c: luxi: Pass socket path directly to exception, not in tuple
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 08:08 pm Revision 63d96e4c: luxi: Pass socket path directly to exception, not in tuple
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 04:02 pm ganeti-local Revision f940cf61: Update NEWS for instance shutdown timeout
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:02 pm ganeti-local Revision 4d98c565: gnt-* use the correct opcode slot to build opcodes
- gnt-* scripts were building wrong opcodes for commands which had the
shutdown_timeout slot (due to missing testing af... - 04:02 pm Revision f940cf61: Update NEWS for instance shutdown timeout
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:02 pm Revision 4d98c565: gnt-* use the correct opcode slot to build opcodes
- gnt-* scripts were building wrong opcodes for commands which had the
shutdown_timeout slot (due to missing testing af... - 03:18 pm ganeti-local Revision cc291012: Update documentation for recreate-disks
- This also clarifies the UUIDs NEWS entry.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselm... - 03:18 pm Revision cc291012: Update documentation for recreate-disks
- This also clarifies the UUIDs NEWS entry.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselm... - 03:03 pm ganeti-local Revision 64246438: rapi: fix tag operations
- This patch fixes the tag PUT/DELETE operations, and additionally changes
the _Tags_* functions to take only positiona... - 03:03 pm Revision 64246438: rapi: fix tag operations
- This patch fixes the tag PUT/DELETE operations, and additionally changes
the _Tags_* functions to take only positiona... - 01:58 pm ganeti-local Revision 920a91bf: Update NEWS for Ganeti 2.1
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:58 pm Revision 920a91bf: Update NEWS for Ganeti 2.1
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:58 pm ganeti-local Revision aa287e8c: Convert NEWS to ASCII
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:58 pm Revision aa287e8c: Convert NEWS to ASCII
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:24 pm ganeti-local Revision 7e5eaaa8: cli: add SHUTDOWN_TIMEOUT_OPT
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:24 pm ganeti-local Revision 17c3f802: Add timeout options to other LUs
- All the LUs that shut down the instance need to be able too pass the
timeout parameter as well.
Signed-off-by: Guido... - 01:24 pm ganeti-local Revision 1e2c9fd3: Update manpages for --shutdown-timeout
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:24 pm Revision 7e5eaaa8: cli: add SHUTDOWN_TIMEOUT_OPT
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:24 pm Revision 17c3f802: Add timeout options to other LUs
- All the LUs that shut down the instance need to be able too pass the
timeout parameter as well.
Signed-off-by: Guido... - 01:24 pm Revision 1e2c9fd3: Update manpages for --shutdown-timeout
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
10/12/2009
- 03:30 pm Revision f6c68f9d: Only update the version file on make dist
- Since on regular compiles the version information is not critical, it's
better to only update it on make dist; furthe... - 03:30 pm ganeti-local Revision f6c68f9d: Only update the version file on make dist
- Since on regular compiles the version information is not critical, it's
better to only update it on make dist; furthe... - 03:13 pm ganeti-local Revision 66dac8e0: Fix haddock issues with tuple members
- It seems that haddock cannot document tuple members - but arguably, once
one needs to do that, tuples should not be u... - 03:13 pm Revision 66dac8e0: Fix haddock issues with tuple members
- It seems that haddock cannot document tuple members - but arguably, once
one needs to do that, tuples should not be u... - 01:48 pm Revision e3200b18: mcpu: Change lock attempt timeout calculation
- With this patch all timeouts are pre-calculated. The interface of
the _LockTimeoutStrategy class is also changed a bi... - 01:48 pm ganeti-local Revision e3200b18: mcpu: Change lock attempt timeout calculation
- With this patch all timeouts are pre-calculated. The interface of
the _LockTimeoutStrategy class is also changed a bi... - 01:48 pm ganeti-local Revision 69b99987: Code and docstring style fixes
- Found using pylint and epydoc.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ult... - 01:48 pm Revision 69b99987: Code and docstring style fixes
- Found using pylint and epydoc.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ult... - 01:47 pm Revision 211b6132: mcpu: Improve lock reporting with timeouts
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:47 pm ganeti-local Revision 211b6132: mcpu: Improve lock reporting with timeouts
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:47 pm ganeti-local Revision 407339d0: mcpu: Implement lock timeouts
- The timeout is always between ~0.1 and ~10.0 seconds. A small
variation of ±5% is added to prevent different jobs fro... - 01:47 pm Revision 407339d0: mcpu: Implement lock timeouts
- The timeout is always between ~0.1 and ~10.0 seconds. A small
variation of ±5% is added to prevent different jobs fro... - 01:47 pm ganeti-local Revision 6b95b76d: mcpu: Remove unused exclusive_BGL attribute
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:47 pm Revision 6b95b76d: mcpu: Remove unused exclusive_BGL attribute
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:46 pm ganeti-local Revision 5aab242c: locking.LockSet: Implement acquire timeouts
- The timeout passed to LockSet.acquire() is measured over all lock acquires. If
LockSet.acquire fails to acquire all r... - 01:46 pm Revision 5aab242c: locking.LockSet: Implement acquire timeouts
- The timeout passed to LockSet.acquire() is measured over all lock acquires. If
LockSet.acquire fails to acquire all r...
10/09/2009
- 06:28 pm ganeti-local Revision 95a5d0fb: Update gnt-instance(8) for shutdown --timeout
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:28 pm Revision 95a5d0fb: Update gnt-instance(8) for shutdown --timeout
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:28 pm ganeti-local Revision 6263189c: Accept shutdown timeout from the user
- Using the new --timeout option:
- gnt-instance shutdown is changed to accept a timeout
- the opcode is changed to ho... - 06:28 pm Revision 6263189c: Accept shutdown timeout from the user
- Using the new --timeout option:
- gnt-instance shutdown is changed to accept a timeout
- the opcode is changed to ho... - 06:02 pm Revision b5762e2a: cli: add a timeout option
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:02 pm ganeti-local Revision b5762e2a: cli: add a timeout option
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:02 pm Revision a2771c83: ChrootManager: clean StopInstance
- Currently it has lots for duplicated code, and internal retries.
Clean it up with the following assumptions:
We'll p... - 06:02 pm ganeti-local Revision a2771c83: ChrootManager: clean StopInstance
- Currently it has lots for duplicated code, and internal retries.
Clean it up with the following assumptions:
We'll p... - 06:02 pm ganeti-local Revision 4ad45119: KVMHypervisor: use the StopInstance retry feature
- Since we know StopInstance is going to be called more than once (at
least twice, once with force and once without, bu... - 06:02 pm Revision 4ad45119: KVMHypervisor: use the StopInstance retry feature
- Since we know StopInstance is going to be called more than once (at
least twice, once with force and once without, bu... - 06:01 pm ganeti-local Revision e4e9b806: backend.InstanceShutdown: small cleanup
- 1) unhardcode the timeout, abstracting it in a constant
2) Use time.time() rather than hiding the timeout in a range(... - 06:01 pm Revision e4e9b806: backend.InstanceShutdown: small cleanup
- 1) unhardcode the timeout, abstracting it in a constant
2) Use time.time() rather than hiding the timeout in a range(... - 06:01 pm Revision 88cd08aa: Add default instance shutdown timeout constant
- It reflects the "current" two minutes we give to the instance.
Signed-off-by: Guido Trotter <ultrotter@google.com>
R... - 06:01 pm ganeti-local Revision 88cd08aa: Add default instance shutdown timeout constant
- It reflects the "current" two minutes we give to the instance.
Signed-off-by: Guido Trotter <ultrotter@google.com>
R... - 06:01 pm Revision 07b49e41: Hypervisors: Add retry= to StopInstance
- Currently some hypervisors need the stop operations to be retried more
than once, while other ones only do it in one ... - 06:01 pm ganeti-local Revision 07b49e41: Hypervisors: Add retry= to StopInstance
- Currently some hypervisors need the stop operations to be retried more
than once, while other ones only do it in one ... - 05:28 pm ganeti-local Revision 6915bc28: Get rid of utils.CommaJoin
- - We never remember to use it (5 uses vs 21 " ,".join())
- It's longer to write than " ,".join()
- The added value of... - 05:28 pm Revision 6915bc28: Get rid of utils.CommaJoin
- - We never remember to use it (5 uses vs 21 " ,".join())
- It's longer to write than " ,".join()
- The added value of...
10/08/2009
- 01:36 pm Revision ca2843dc: makefile: regenerate version when it changes
- If we're building on a different version, the version file needs to be
regenerated.
Signed-off-by: Guido Trotter <ul... - 01:36 pm ganeti-local Revision ca2843dc: makefile: regenerate version when it changes
- If we're building on a different version, the version file needs to be
regenerated.
Signed-off-by: Guido Trotter <ul... - 01:06 pm Revision e97f211e: parseNode: don't lookup values in drained nodes
- Currently parseNode skips looking for values in offline nodes, but tries
to read them for drained ones. With this pat... - 01:06 pm ganeti-local Revision e97f211e: parseNode: don't lookup values in drained nodes
- Currently parseNode skips looking for values in offline nodes, but tries
to read them for drained ones. With this pat...
10/07/2009
- 01:16 pm ganeti-local Revision 691dfed9: ethers hook: allow more than one daemon pidfile
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:16 pm Revision 691dfed9: ethers hook: allow more than one daemon pidfile
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:14 pm Revision 9e32b93b: burnin: skip instance moves on single node
- If we have only one node, instance moves fail, because it tries to move
the instance to itself. Skipping the operatio... - 01:14 pm ganeti-local Revision 9e32b93b: burnin: skip instance moves on single node
- If we have only one node, instance moves fail, because it tries to move
the instance to itself. Skipping the operatio... - 12:31 pm Revision bcdf16d7: Match instance and node names case insensitively
- Since DNS cannot contain two names with different cases anyway, this
should be ok.
Signed-off-by: Guido Trotter <ult... - 12:31 pm ganeti-local Revision bcdf16d7: Match instance and node names case insensitively
- Since DNS cannot contain two names with different cases anyway, this
should be ok.
Signed-off-by: Guido Trotter <ult... - 12:31 pm ganeti-local Revision 256eb94b: Add case_sensitive keyword to MatchNameComponent
- Now featuring unit testing, and more deterministic results on some
corner cases.
Signed-off-by: Guido Trotter <ultro... - 12:31 pm Revision 256eb94b: Add case_sensitive keyword to MatchNameComponent
- Now featuring unit testing, and more deterministic results on some
corner cases.
Signed-off-by: Guido Trotter <ultro...
10/06/2009
- 03:35 pm ganeti-local Revision 6e6bb8d5: VNC password: move to hv param and use in kvm
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 03:35 pm Revision 6e6bb8d5: VNC password: move to hv param and use in kvm
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com>
10/05/2009
- 04:49 pm ganeti-local Revision c69a43c8: Implement strict mode for devel/review
- This should prevent typos in aliases from going unnoticed.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Rev... - 04:49 pm Revision c69a43c8: Implement strict mode for devel/review
- This should prevent typos in aliases from going unnoticed.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Rev... - 12:47 pm ganeti-local Revision f2c05717: Check the OS name for variants
- If an OS supports variants, unless --force-variant is specified a valid
variant must be passed.
Signed-off-by: Guido... - 12:47 pm ganeti-local Revision bdfec6fd: Update ganeti-os-interface(7) for API 15
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 12:47 pm Revision bdfec6fd: Update ganeti-os-interface(7) for API 15
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 12:47 pm Revision f2c05717: Check the OS name for variants
- If an OS supports variants, unless --force-variant is specified a valid
variant must be passed.
Signed-off-by: Guido... - 12:47 pm Revision 06073e85: Allow --force-variant for instance add/reinstall
- Passing this option makes an undeclared variant be passed to the os "as
is", hoping it'll be able to figure it out (a... - 12:47 pm ganeti-local Revision 06073e85: Allow --force-variant for instance add/reinstall
- Passing this option makes an undeclared variant be passed to the os "as
is", hoping it'll be able to figure it out (a... - 12:47 pm Revision 47804ec9: Add force_variant slot to Create/ReinstallInstance
- These two opcode need to know whether an unknown variant must be forced
through or not.
Signed-off-by: Guido Trotter... - 12:47 pm ganeti-local Revision 47804ec9: Add force_variant slot to Create/ReinstallInstance
- These two opcode need to know whether an unknown variant must be forced
through or not.
Signed-off-by: Guido Trotter... - 12:46 pm ganeti-local Revision e3ac208c: Update client os lists to name+variant format
- List of OSes are displayed by gnt-os list, rapi, and gnt-instance
reinstall --select-os, and checked by burnin. In al... - 12:46 pm Revision e3ac208c: Update client os lists to name+variant format
- List of OSes are displayed by gnt-os list, rapi, and gnt-instance
reinstall --select-os, and checked by burnin. In al... - 12:39 pm ganeti-local Revision 95075fba: Populate OS variants if an api >= 15 is present
- Adding the file name to the os_files dict will fill in the full path and
get it checked, if present we also read it a... - 12:39 pm ganeti-local Revision 6d79896b: Add slot and constant for supported OS variants
- The slot will contain a list of variants, and the variants file constant
contains the file in the os dir which is sup... - 12:39 pm ganeti-local Revision f11280b5: OSEnvironment: populate OS_VARIANT
- According to the design on api_version >= 15 the OS variant is the part
of the OS name after the "+" sign. If none is... - 12:39 pm ganeti-local Revision 6ee7102a: OSFromDisk: handle variants when loading os
- When we load an OS from disk, we need _TryOSFromDisk to get the real
name, without any variant. This allows any funct... - 12:39 pm ganeti-local Revision ba00557a: Add per-node variants list to OS diagnose output
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 12:39 pm ganeti-local Revision 1e288a26: Add "variants" field to LUDiagnoseOS
- If selected this field will contain a list of os variants supported on
all nodes.
Signed-off-by: Guido Trotter <ultr... - 12:39 pm ganeti-local Revision 07150497: cli.CalculateOSNames
- Given an os and its variants, return a list of "full" os names.
Signed-off-by: Guido Trotter <ultrotter@google.com>
... - 12:39 pm Revision e16dfb5b: gnt-os diagnose: show os variants
- We already show the per-node os variants, also show the global ones.
Signed-off-by: Guido Trotter <ultrotter@google.... - 12:39 pm Revision 6d79896b: Add slot and constant for supported OS variants
- The slot will contain a list of variants, and the variants file constant
contains the file in the os dir which is sup... - 12:39 pm Revision 95075fba: Populate OS variants if an api >= 15 is present
- Adding the file name to the os_files dict will fill in the full path and
get it checked, if present we also read it a... - 12:39 pm Revision f11280b5: OSEnvironment: populate OS_VARIANT
- According to the design on api_version >= 15 the OS variant is the part
of the OS name after the "+" sign. If none is... - 12:39 pm Revision 6ee7102a: OSFromDisk: handle variants when loading os
- When we load an OS from disk, we need _TryOSFromDisk to get the real
name, without any variant. This allows any funct... - 12:39 pm Revision ba00557a: Add per-node variants list to OS diagnose output
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 12:39 pm Revision 1e288a26: Add "variants" field to LUDiagnoseOS
- If selected this field will contain a list of os variants supported on
all nodes.
Signed-off-by: Guido Trotter <ultr... - 12:39 pm Revision 07150497: cli.CalculateOSNames
- Given an os and its variants, return a list of "full" os names.
Signed-off-by: Guido Trotter <ultrotter@google.com>
... - 12:39 pm ganeti-local Revision e16dfb5b: gnt-os diagnose: show os variants
- We already show the per-node os variants, also show the global ones.
Signed-off-by: Guido Trotter <ultrotter@google.... - 12:39 pm ganeti-local Revision 84e3f66f: Fix rpc.call_os_get to actually return the OS
- Since nobody ever read the actual OS object, this bug was introduced in
the rpc conversion.
Signed-off-by: Guido Tro... - 12:39 pm ganeti-local Revision b6b45e0d: Convert os api version file name to a constant
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 12:39 pm ganeti-local Revision 41ba4061: TryOSFromDisk: s/os_scripts/os_files/
- We'll be using this dict/loop to check more than just scripts, so we're
renaming the variables appropriately.
Signed... - 12:39 pm ganeti-local Revision 0757c107: TryOSFromDisk: only check actual os scripts for +x
- Currently all checked files in the loop are os scripts, so nothing will
change, but in the future we only want the +x... - 12:39 pm Revision 84e3f66f: Fix rpc.call_os_get to actually return the OS
- Since nobody ever read the actual OS object, this bug was introduced in
the rpc conversion.
Signed-off-by: Guido Tro... - 12:39 pm Revision 0757c107: TryOSFromDisk: only check actual os scripts for +x
- Currently all checked files in the loop are os scripts, so nothing will
change, but in the future we only want the +x... - 12:39 pm Revision 41ba4061: TryOSFromDisk: s/os_scripts/os_files/
- We'll be using this dict/loop to check more than just scripts, so we're
renaming the variables appropriately.
Signed... - 12:39 pm Revision b6b45e0d: Convert os api version file name to a constant
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com> - 12:31 pm ganeti-local Revision 2f2dbb4b: Add support for using the bootloader in xen-pvm
- This patch adds three optional parameters:
- 'use_bootloader', whether use or not the bootloader
- 'bootloader_pa... - 12:31 pm Revision 2f2dbb4b: Add support for using the bootloader in xen-pvm
- This patch adds three optional parameters:
- 'use_bootloader', whether use or not the bootloader
- 'bootloader_pa...
Also available in: Atom