Statistics
| Branch: | Tag: | Revision:

root / autotools / check-python-code @ 0aee8ee9

History | View | Annotate | Download (1.9 kB)

1 eed5c5df Michael Hanselmann
#!/bin/bash
2 eed5c5df Michael Hanselmann
#
3 eed5c5df Michael Hanselmann
4 eed5c5df Michael Hanselmann
# Copyright (C) 2009 Google Inc.
5 eed5c5df Michael Hanselmann
#
6 eed5c5df Michael Hanselmann
# This program is free software; you can redistribute it and/or modify
7 eed5c5df Michael Hanselmann
# it under the terms of the GNU General Public License as published by
8 eed5c5df Michael Hanselmann
# the Free Software Foundation; either version 2 of the License, or
9 eed5c5df Michael Hanselmann
# (at your option) any later version.
10 eed5c5df Michael Hanselmann
#
11 eed5c5df Michael Hanselmann
# This program is distributed in the hope that it will be useful, but
12 eed5c5df Michael Hanselmann
# WITHOUT ANY WARRANTY; without even the implied warranty of
13 eed5c5df Michael Hanselmann
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
14 eed5c5df Michael Hanselmann
# General Public License for more details.
15 eed5c5df Michael Hanselmann
#
16 eed5c5df Michael Hanselmann
# You should have received a copy of the GNU General Public License
17 eed5c5df Michael Hanselmann
# along with this program; if not, write to the Free Software
18 eed5c5df Michael Hanselmann
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
19 eed5c5df Michael Hanselmann
# 02110-1301, USA.
20 eed5c5df Michael Hanselmann
21 bdba4757 Michael Hanselmann
set -e
22 bdba4757 Michael Hanselmann
23 674711de Michael Hanselmann
readonly maxlinelen=$(for ((i=0; i<81; ++i)); do echo -n .; done)
24 674711de Michael Hanselmann
25 674711de Michael Hanselmann
if [[ "${#maxlinelen}" != 81 ]]; then
26 674711de Michael Hanselmann
  echo "Internal error: Check for line length is incorrect" >&2
27 674711de Michael Hanselmann
  exit 1
28 674711de Michael Hanselmann
fi
29 674711de Michael Hanselmann
30 bdba4757 Michael Hanselmann
# "[...] If the last ARG evaluates to 0, let returns 1; 0 is returned
31 bdba4757 Michael Hanselmann
# otherwise.", hence ignoring the return value.
32 bdba4757 Michael Hanselmann
let problems=0 || :
33 eed5c5df Michael Hanselmann
34 eed5c5df Michael Hanselmann
for script; do
35 9648f1b4 Michael Hanselmann
  if grep -n -H -F $'\t' "$script"; then
36 eed5c5df Michael Hanselmann
    let ++problems
37 eed5c5df Michael Hanselmann
    echo "Found tabs in $script" >&2
38 eed5c5df Michael Hanselmann
  fi
39 b757f830 Michael Hanselmann
40 9648f1b4 Michael Hanselmann
  if grep -n -H -E '[[:space:]]$' "$script"; then
41 b757f830 Michael Hanselmann
    let ++problems
42 b757f830 Michael Hanselmann
    echo "Found end-of-line-whitespace in $script" >&2
43 b757f830 Michael Hanselmann
  fi
44 b757f830 Michael Hanselmann
45 11c684bf Michael Hanselmann
  # FIXME: This will also match "foo.xrange(...)"
46 11c684bf Michael Hanselmann
  if grep -n -H -E '^[^#]*\<xrange\>' "$script"; then
47 11c684bf Michael Hanselmann
    let ++problems
48 11c684bf Michael Hanselmann
    echo "Forbidden function 'xrange' used in $script" >&2
49 11c684bf Michael Hanselmann
  fi
50 11c684bf Michael Hanselmann
51 42f539ee Michael Hanselmann
  if grep -n -H -E -i '#[[:space:]]*(vim|Local[[:space:]]+Variables):' "$script"
52 42f539ee Michael Hanselmann
  then
53 42f539ee Michael Hanselmann
    let ++problems
54 42f539ee Michael Hanselmann
    echo "Found editor-specific settings in $script" >&2
55 42f539ee Michael Hanselmann
  fi
56 42f539ee Michael Hanselmann
57 674711de Michael Hanselmann
  if grep -n -H "^$maxlinelen" "$script"; then
58 eed5c5df Michael Hanselmann
    let ++problems
59 eed5c5df Michael Hanselmann
    echo "Longest line in $script is longer than 80 characters" >&2
60 eed5c5df Michael Hanselmann
  fi
61 eed5c5df Michael Hanselmann
done
62 eed5c5df Michael Hanselmann
63 eed5c5df Michael Hanselmann
if [[ "$problems" -gt 0 ]]; then
64 b757f830 Michael Hanselmann
  echo "Found $problems problem(s) while checking code." >&2
65 eed5c5df Michael Hanselmann
  exit 1
66 eed5c5df Michael Hanselmann
fi