« Previous | Next » 

Revision f489fcc0

IDf489fcc0d4b7ffe03d6c4062f909e9c69760566e

Added by Faidon Liambotis over 12 years ago

Fix OS creation's error handling when pausing sync

Cherry-picked from fac30cead6893b68085b6896d4db2a4f8ae43363:
Resolved one conflict in lib/cmdlib.py.

Commit 41e1e79 introduced a feature in which when wait_for_sync is not
set, DRBD sync is paused during the OS installation.

Doing so, however, broke OS creation's error handling: the result value
from the instance_os_add RPC call was overwritten by the one of the
blockdev_pause_resume_sync call before there was a chance for it to
be raised and thus masking possible errors in the OS creation.

Note that the wipe method, from which the pause technique was inspired,
does not suffer from this bug.

Signed-off-by: Faidon Liambotis <>
Signed-off-by: Vangelis Koukis <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences