#!/usr/bin/python
#
-# Copyright (C) 2013 Google Inc.
+# Copyright (C) 2008, 2011, 2012, 2013 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
"""
+import unittest
+import operator
+import os
+import tempfile
+import shutil
+
+from ganeti import constants
+from ganeti import compat
+from ganeti import ht
+from ganeti import objects
from ganeti import opcodes
+from ganeti import utils
+from ganeti import pathutils
+from ganeti import rpc
+from ganeti.cmdlib import cluster
+from ganeti.hypervisor import hv_xen
from testsupport import *
import testutils
+import mocks
+
+
+class TestCertVerification(testutils.GanetiTestCase):
+ def setUp(self):
+ testutils.GanetiTestCase.setUp(self)
+
+ self.tmpdir = tempfile.mkdtemp()
+
+ def tearDown(self):
+ shutil.rmtree(self.tmpdir)
+
+ def testVerifyCertificate(self):
+ cluster._VerifyCertificate(testutils.TestDataFilename("cert1.pem"))
+
+ nonexist_filename = os.path.join(self.tmpdir, "does-not-exist")
+
+ (errcode, msg) = cluster._VerifyCertificate(nonexist_filename)
+ self.assertEqual(errcode, cluster.LUClusterVerifyConfig.ETYPE_ERROR)
+
+ # Try to load non-certificate file
+ invalid_cert = testutils.TestDataFilename("bdev-net.txt")
+ (errcode, msg) = cluster._VerifyCertificate(invalid_cert)
+ self.assertEqual(errcode, cluster.LUClusterVerifyConfig.ETYPE_ERROR)
+
+
+class TestClusterVerifySsh(unittest.TestCase):
+ def testMultipleGroups(self):
+ fn = cluster.LUClusterVerifyGroup._SelectSshCheckNodes
+ mygroupnodes = [
+ objects.Node(name="node20", group="my", offline=False),
+ objects.Node(name="node21", group="my", offline=False),
+ objects.Node(name="node22", group="my", offline=False),
+ objects.Node(name="node23", group="my", offline=False),
+ objects.Node(name="node24", group="my", offline=False),
+ objects.Node(name="node25", group="my", offline=False),
+ objects.Node(name="node26", group="my", offline=True),
+ ]
+ nodes = [
+ objects.Node(name="node1", group="g1", offline=True),
+ objects.Node(name="node2", group="g1", offline=False),
+ objects.Node(name="node3", group="g1", offline=False),
+ objects.Node(name="node4", group="g1", offline=True),
+ objects.Node(name="node5", group="g1", offline=False),
+ objects.Node(name="node10", group="xyz", offline=False),
+ objects.Node(name="node11", group="xyz", offline=False),
+ objects.Node(name="node40", group="alloff", offline=True),
+ objects.Node(name="node41", group="alloff", offline=True),
+ objects.Node(name="node50", group="aaa", offline=False),
+ ] + mygroupnodes
+ assert not utils.FindDuplicates(map(operator.attrgetter("name"), nodes))
+
+ (online, perhost) = fn(mygroupnodes, "my", nodes)
+ self.assertEqual(online, ["node%s" % i for i in range(20, 26)])
+ self.assertEqual(set(perhost.keys()), set(online))
+
+ self.assertEqual(perhost, {
+ "node20": ["node10", "node2", "node50"],
+ "node21": ["node11", "node3", "node50"],
+ "node22": ["node10", "node5", "node50"],
+ "node23": ["node11", "node2", "node50"],
+ "node24": ["node10", "node3", "node50"],
+ "node25": ["node11", "node5", "node50"],
+ })
+
+ def testSingleGroup(self):
+ fn = cluster.LUClusterVerifyGroup._SelectSshCheckNodes
+ nodes = [
+ objects.Node(name="node1", group="default", offline=True),
+ objects.Node(name="node2", group="default", offline=False),
+ objects.Node(name="node3", group="default", offline=False),
+ objects.Node(name="node4", group="default", offline=True),
+ ]
+ assert not utils.FindDuplicates(map(operator.attrgetter("name"), nodes))
+
+ (online, perhost) = fn(nodes, "default", nodes)
+ self.assertEqual(online, ["node2", "node3"])
+ self.assertEqual(set(perhost.keys()), set(online))
+
+ self.assertEqual(perhost, {
+ "node2": [],
+ "node3": [],
+ })
+
+
+class TestClusterVerifyFiles(unittest.TestCase):
+ @staticmethod
+ def _FakeErrorIf(errors, cond, ecode, item, msg, *args, **kwargs):
+ assert ((ecode == constants.CV_ENODEFILECHECK and
+ ht.TNonEmptyString(item)) or
+ (ecode == constants.CV_ECLUSTERFILECHECK and
+ item is None))
+
+ if args:
+ msg = msg % args
+
+ if cond:
+ errors.append((item, msg))
+
+ def test(self):
+ errors = []
+ nodeinfo = [
+ objects.Node(name="master.example.com",
+ uuid="master-uuid",
+ offline=False,
+ vm_capable=True),
+ objects.Node(name="node2.example.com",
+ uuid="node2-uuid",
+ offline=False,
+ vm_capable=True),
+ objects.Node(name="node3.example.com",
+ uuid="node3-uuid",
+ master_candidate=True,
+ vm_capable=False),
+ objects.Node(name="node4.example.com",
+ uuid="node4-uuid",
+ offline=False,
+ vm_capable=True),
+ objects.Node(name="nodata.example.com",
+ uuid="nodata-uuid",
+ offline=False,
+ vm_capable=True),
+ objects.Node(name="offline.example.com",
+ uuid="offline-uuid",
+ offline=True),
+ ]
+ files_all = set([
+ pathutils.CLUSTER_DOMAIN_SECRET_FILE,
+ pathutils.RAPI_CERT_FILE,
+ pathutils.RAPI_USERS_FILE,
+ ])
+ files_opt = set([
+ pathutils.RAPI_USERS_FILE,
+ hv_xen.XL_CONFIG_FILE,
+ pathutils.VNC_PASSWORD_FILE,
+ ])
+ files_mc = set([
+ pathutils.CLUSTER_CONF_FILE,
+ ])
+ files_vm = set([
+ hv_xen.XEND_CONFIG_FILE,
+ hv_xen.XL_CONFIG_FILE,
+ pathutils.VNC_PASSWORD_FILE,
+ ])
+ nvinfo = {
+ "master-uuid": rpc.RpcResult(data=(True, {
+ constants.NV_FILELIST: {
+ pathutils.CLUSTER_CONF_FILE: "82314f897f38b35f9dab2f7c6b1593e0",
+ pathutils.RAPI_CERT_FILE: "babbce8f387bc082228e544a2146fee4",
+ pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",
+ hv_xen.XEND_CONFIG_FILE: "b4a8a824ab3cac3d88839a9adeadf310",
+ hv_xen.XL_CONFIG_FILE: "77935cee92afd26d162f9e525e3d49b9"
+ }})),
+ "node2-uuid": rpc.RpcResult(data=(True, {
+ constants.NV_FILELIST: {
+ pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",
+ hv_xen.XEND_CONFIG_FILE: "b4a8a824ab3cac3d88839a9adeadf310",
+ }
+ })),
+ "node3-uuid": rpc.RpcResult(data=(True, {
+ constants.NV_FILELIST: {
+ pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",
+ pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",
+ }
+ })),
+ "node4-uuid": rpc.RpcResult(data=(True, {
+ constants.NV_FILELIST: {
+ pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",
+ pathutils.CLUSTER_CONF_FILE: "conf-a6d4b13e407867f7a7b4f0f232a8f527",
+ pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",
+ pathutils.RAPI_USERS_FILE: "rapiusers-ea3271e8d810ef3",
+ hv_xen.XL_CONFIG_FILE: "77935cee92afd26d162f9e525e3d49b9"
+ }
+ })),
+ "nodata-uuid": rpc.RpcResult(data=(True, {})),
+ "offline-uuid": rpc.RpcResult(offline=True),
+ }
+ assert set(nvinfo.keys()) == set(map(operator.attrgetter("uuid"), nodeinfo))
+
+ verify_lu = cluster.LUClusterVerifyGroup(mocks.FakeProc(),
+ opcodes.OpClusterVerify(),
+ mocks.FakeContext(),
+ None)
+
+ verify_lu._ErrorIf = compat.partial(self._FakeErrorIf, errors)
+
+ # TODO: That's a bit hackish to mock only this single method. We should
+ # build a better FakeConfig which provides such a feature already.
+ def GetNodeName(node_uuid):
+ for node in nodeinfo:
+ if node.uuid == node_uuid:
+ return node.name
+ return None
+
+ verify_lu.cfg.GetNodeName = GetNodeName
+
+ verify_lu._VerifyFiles(nodeinfo, "master-uuid", nvinfo,
+ (files_all, files_opt, files_mc, files_vm))
+ self.assertEqual(sorted(errors), sorted([
+ (None, ("File %s found with 2 different checksums (variant 1 on"
+ " node2.example.com, node3.example.com, node4.example.com;"
+ " variant 2 on master.example.com)" % pathutils.RAPI_CERT_FILE)),
+ (None, ("File %s is missing from node(s) node2.example.com" %
+ pathutils.CLUSTER_DOMAIN_SECRET_FILE)),
+ (None, ("File %s should not exist on node(s) node4.example.com" %
+ pathutils.CLUSTER_CONF_FILE)),
+ (None, ("File %s is missing from node(s) node4.example.com" %
+ hv_xen.XEND_CONFIG_FILE)),
+ (None, ("File %s is missing from node(s) node3.example.com" %
+ pathutils.CLUSTER_CONF_FILE)),
+ (None, ("File %s found with 2 different checksums (variant 1 on"
+ " master.example.com; variant 2 on node4.example.com)" %
+ pathutils.CLUSTER_CONF_FILE)),
+ (None, ("File %s is optional, but it must exist on all or no nodes (not"
+ " found on master.example.com, node2.example.com,"
+ " node3.example.com)" % pathutils.RAPI_USERS_FILE)),
+ (None, ("File %s is optional, but it must exist on all or no nodes (not"
+ " found on node2.example.com)" % hv_xen.XL_CONFIG_FILE)),
+ ("nodata.example.com", "Node did not return file checksum data"),
+ ]))
class TestLUClusterActivateMasterIp(CmdlibTestCase):
"""Script for unittesting the cmdlib module"""
-import os
import unittest
-import tempfile
-import shutil
import operator
import itertools
import copy
from ganeti import compat
from ganeti import rpc
from ganeti import locking
-from ganeti import pathutils
from ganeti.masterd import iallocator
-from ganeti.hypervisor import hv_xen
import testutils
import mocks
-class TestCertVerification(testutils.GanetiTestCase):
- def setUp(self):
- testutils.GanetiTestCase.setUp(self)
-
- self.tmpdir = tempfile.mkdtemp()
-
- def tearDown(self):
- shutil.rmtree(self.tmpdir)
-
- def testVerifyCertificate(self):
- cluster._VerifyCertificate(testutils.TestDataFilename("cert1.pem"))
-
- nonexist_filename = os.path.join(self.tmpdir, "does-not-exist")
-
- (errcode, msg) = cluster._VerifyCertificate(nonexist_filename)
- self.assertEqual(errcode, cluster.LUClusterVerifyConfig.ETYPE_ERROR)
-
- # Try to load non-certificate file
- invalid_cert = testutils.TestDataFilename("bdev-net.txt")
- (errcode, msg) = cluster._VerifyCertificate(invalid_cert)
- self.assertEqual(errcode, cluster.LUClusterVerifyConfig.ETYPE_ERROR)
-
-
class TestOpcodeParams(testutils.GanetiTestCase):
def testParamsStructures(self):
for op in sorted(mcpu.Processor.DISPATCH_TABLE):
self.assertEqual(set(["inst3c"]), set(prev))
-class TestClusterVerifySsh(unittest.TestCase):
- def testMultipleGroups(self):
- fn = cluster.LUClusterVerifyGroup._SelectSshCheckNodes
- mygroupnodes = [
- objects.Node(name="node20", group="my", offline=False),
- objects.Node(name="node21", group="my", offline=False),
- objects.Node(name="node22", group="my", offline=False),
- objects.Node(name="node23", group="my", offline=False),
- objects.Node(name="node24", group="my", offline=False),
- objects.Node(name="node25", group="my", offline=False),
- objects.Node(name="node26", group="my", offline=True),
- ]
- nodes = [
- objects.Node(name="node1", group="g1", offline=True),
- objects.Node(name="node2", group="g1", offline=False),
- objects.Node(name="node3", group="g1", offline=False),
- objects.Node(name="node4", group="g1", offline=True),
- objects.Node(name="node5", group="g1", offline=False),
- objects.Node(name="node10", group="xyz", offline=False),
- objects.Node(name="node11", group="xyz", offline=False),
- objects.Node(name="node40", group="alloff", offline=True),
- objects.Node(name="node41", group="alloff", offline=True),
- objects.Node(name="node50", group="aaa", offline=False),
- ] + mygroupnodes
- assert not utils.FindDuplicates(map(operator.attrgetter("name"), nodes))
-
- (online, perhost) = fn(mygroupnodes, "my", nodes)
- self.assertEqual(online, ["node%s" % i for i in range(20, 26)])
- self.assertEqual(set(perhost.keys()), set(online))
-
- self.assertEqual(perhost, {
- "node20": ["node10", "node2", "node50"],
- "node21": ["node11", "node3", "node50"],
- "node22": ["node10", "node5", "node50"],
- "node23": ["node11", "node2", "node50"],
- "node24": ["node10", "node3", "node50"],
- "node25": ["node11", "node5", "node50"],
- })
-
- def testSingleGroup(self):
- fn = cluster.LUClusterVerifyGroup._SelectSshCheckNodes
- nodes = [
- objects.Node(name="node1", group="default", offline=True),
- objects.Node(name="node2", group="default", offline=False),
- objects.Node(name="node3", group="default", offline=False),
- objects.Node(name="node4", group="default", offline=True),
- ]
- assert not utils.FindDuplicates(map(operator.attrgetter("name"), nodes))
-
- (online, perhost) = fn(nodes, "default", nodes)
- self.assertEqual(online, ["node2", "node3"])
- self.assertEqual(set(perhost.keys()), set(online))
-
- self.assertEqual(perhost, {
- "node2": [],
- "node3": [],
- })
-
-
-class TestClusterVerifyFiles(unittest.TestCase):
- @staticmethod
- def _FakeErrorIf(errors, cond, ecode, item, msg, *args, **kwargs):
- assert ((ecode == constants.CV_ENODEFILECHECK and
- ht.TNonEmptyString(item)) or
- (ecode == constants.CV_ECLUSTERFILECHECK and
- item is None))
-
- if args:
- msg = msg % args
-
- if cond:
- errors.append((item, msg))
-
- def test(self):
- errors = []
- nodeinfo = [
- objects.Node(name="master.example.com",
- uuid="master-uuid",
- offline=False,
- vm_capable=True),
- objects.Node(name="node2.example.com",
- uuid="node2-uuid",
- offline=False,
- vm_capable=True),
- objects.Node(name="node3.example.com",
- uuid="node3-uuid",
- master_candidate=True,
- vm_capable=False),
- objects.Node(name="node4.example.com",
- uuid="node4-uuid",
- offline=False,
- vm_capable=True),
- objects.Node(name="nodata.example.com",
- uuid="nodata-uuid",
- offline=False,
- vm_capable=True),
- objects.Node(name="offline.example.com",
- uuid="offline-uuid",
- offline=True),
- ]
- files_all = set([
- pathutils.CLUSTER_DOMAIN_SECRET_FILE,
- pathutils.RAPI_CERT_FILE,
- pathutils.RAPI_USERS_FILE,
- ])
- files_opt = set([
- pathutils.RAPI_USERS_FILE,
- hv_xen.XL_CONFIG_FILE,
- pathutils.VNC_PASSWORD_FILE,
- ])
- files_mc = set([
- pathutils.CLUSTER_CONF_FILE,
- ])
- files_vm = set([
- hv_xen.XEND_CONFIG_FILE,
- hv_xen.XL_CONFIG_FILE,
- pathutils.VNC_PASSWORD_FILE,
- ])
- nvinfo = {
- "master-uuid": rpc.RpcResult(data=(True, {
- constants.NV_FILELIST: {
- pathutils.CLUSTER_CONF_FILE: "82314f897f38b35f9dab2f7c6b1593e0",
- pathutils.RAPI_CERT_FILE: "babbce8f387bc082228e544a2146fee4",
- pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",
- hv_xen.XEND_CONFIG_FILE: "b4a8a824ab3cac3d88839a9adeadf310",
- hv_xen.XL_CONFIG_FILE: "77935cee92afd26d162f9e525e3d49b9"
- }})),
- "node2-uuid": rpc.RpcResult(data=(True, {
- constants.NV_FILELIST: {
- pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",
- hv_xen.XEND_CONFIG_FILE: "b4a8a824ab3cac3d88839a9adeadf310",
- }
- })),
- "node3-uuid": rpc.RpcResult(data=(True, {
- constants.NV_FILELIST: {
- pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",
- pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",
- }
- })),
- "node4-uuid": rpc.RpcResult(data=(True, {
- constants.NV_FILELIST: {
- pathutils.RAPI_CERT_FILE: "97f0356500e866387f4b84233848cc4a",
- pathutils.CLUSTER_CONF_FILE: "conf-a6d4b13e407867f7a7b4f0f232a8f527",
- pathutils.CLUSTER_DOMAIN_SECRET_FILE: "cds-47b5b3f19202936bb4",
- pathutils.RAPI_USERS_FILE: "rapiusers-ea3271e8d810ef3",
- hv_xen.XL_CONFIG_FILE: "77935cee92afd26d162f9e525e3d49b9"
- }
- })),
- "nodata-uuid": rpc.RpcResult(data=(True, {})),
- "offline-uuid": rpc.RpcResult(offline=True),
- }
- assert set(nvinfo.keys()) == set(map(operator.attrgetter("uuid"), nodeinfo))
-
- verify_lu = cluster.LUClusterVerifyGroup(mocks.FakeProc(),
- opcodes.OpClusterVerify(),
- mocks.FakeContext(),
- None)
-
- verify_lu._ErrorIf = compat.partial(self._FakeErrorIf, errors)
-
- # TODO: That's a bit hackish to mock only this single method. We should
- # build a better FakeConfig which provides such a feature already.
- def GetNodeName(node_uuid):
- for node in nodeinfo:
- if node.uuid == node_uuid:
- return node.name
- return None
-
- verify_lu.cfg.GetNodeName = GetNodeName
-
- verify_lu._VerifyFiles(nodeinfo, "master-uuid", nvinfo,
- (files_all, files_opt, files_mc, files_vm))
- self.assertEqual(sorted(errors), sorted([
- (None, ("File %s found with 2 different checksums (variant 1 on"
- " node2.example.com, node3.example.com, node4.example.com;"
- " variant 2 on master.example.com)" % pathutils.RAPI_CERT_FILE)),
- (None, ("File %s is missing from node(s) node2.example.com" %
- pathutils.CLUSTER_DOMAIN_SECRET_FILE)),
- (None, ("File %s should not exist on node(s) node4.example.com" %
- pathutils.CLUSTER_CONF_FILE)),
- (None, ("File %s is missing from node(s) node4.example.com" %
- hv_xen.XEND_CONFIG_FILE)),
- (None, ("File %s is missing from node(s) node3.example.com" %
- pathutils.CLUSTER_CONF_FILE)),
- (None, ("File %s found with 2 different checksums (variant 1 on"
- " master.example.com; variant 2 on node4.example.com)" %
- pathutils.CLUSTER_CONF_FILE)),
- (None, ("File %s is optional, but it must exist on all or no nodes (not"
- " found on master.example.com, node2.example.com,"
- " node3.example.com)" % pathutils.RAPI_USERS_FILE)),
- (None, ("File %s is optional, but it must exist on all or no nodes (not"
- " found on node2.example.com)" % hv_xen.XL_CONFIG_FILE)),
- ("nodata.example.com", "Node did not return file checksum data"),
- ]))
-
-
class _FakeLU:
def __init__(self, cfg=NotImplemented, proc=NotImplemented,
rpc=NotImplemented):
projects / ganeti-local / commitdiff