Don't use hardcoded name for pylint

Look it up at configure time instead.

Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>

diff --git a/Makefile.am b/Makefile.am
index d87864f..513d67b 100644 (file)
--- a/Makefile.am
+++ b/Makefile.am
@@ -483,7 +483,8 @@ check-local:
 
 .PHONY: lint
 lint: ganeti
-       pylint $(LINT_OPTS) $(lint_python_code)
+       @test -n "$(PYLINT)" || { echo 'pylint' not found during configure; exit 1; }
+       $(PYLINT) $(LINT_OPTS) $(lint_python_code)
 
 # a dist hook rule for catching revision control directories
 distcheck-hook:

diff --git a/configure.ac b/configure.ac
index 2a2ac0e..ae61c60 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -153,6 +153,14 @@ then
   AC_MSG_WARN([dot (from the graphviz suite) not found, documentation rebuild not possible])
 fi
 
+# Check for pylint
+AC_ARG_VAR(PYLINT, [pylint path])
+AC_PATH_PROG(PYLINT, [pylint], [])
+if test -z "$PYLINT"
+then
+  AC_MSG_WARN([pylint not found, checking code will not be possible])
+fi
+
 # Check for socat
 AC_ARG_VAR(SOCAT, [socat path])
 AC_PATH_PROG(SOCAT, [socat], [])