Add a few SharedLock delete() tests

- Check that even a shared acquire() fails on a deleted lock
- Check that delete() fails on a lock you share (must own it or nothing)

These are assumptions I build on in future code, so better check for them.
Currently no code change is necessary for them to be valid.

Reviewed-by: iustinp

diff --git a/test/ganeti.locking_unittest.py b/test/ganeti.locking_unittest.py
index 9e99ab1..75d9e94 100755 (executable)
--- a/test/ganeti.locking_unittest.py
+++ b/test/ganeti.locking_unittest.py
@@ -192,8 +192,13 @@ class TestSharedLock(unittest.TestCase):
   def testDelete(self):
     self.sl.delete()
     self.assertRaises(errors.LockError, self.sl.acquire)
+    self.assertRaises(errors.LockError, self.sl.acquire, shared=1)
     self.assertRaises(errors.LockError, self.sl.delete)
 
+  def testNoDeleteIfSharer(self):
+    self.sl.acquire(shared=1)
+    self.assertRaises(AssertionError, self.sl.delete)
+
   def testDeletePendingSharersExclusiveDelete(self):
     self.sl.acquire()
     Thread(target=self._doItSharer).start()