gnt-os diagnose: show os variants
authorGuido Trotter <ultrotter@google.com>
Fri, 2 Oct 2009 13:41:38 +0000 (14:41 +0100)
committerGuido Trotter <ultrotter@google.com>
Mon, 5 Oct 2009 09:39:21 +0000 (10:39 +0100)
We already show the per-node os variants, also show the global ones.

Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Olivier Tharan <olive@google.com>

scripts/gnt-os

index 1aacfac..0542a67 100755 (executable)
@@ -89,8 +89,8 @@ def DiagnoseOS(opts, args):
   @return: the desired exit code
 
   """
-  op = opcodes.OpDiagnoseOS(output_fields=["name", "valid", "node_status"],
-                            names=[])
+  op = opcodes.OpDiagnoseOS(output_fields=["name", "valid", "variants",
+                                           "node_status"], names=[])
   result = SubmitOpCode(op)
 
   if not result:
@@ -99,7 +99,7 @@ def DiagnoseOS(opts, args):
 
   has_bad = False
 
-  for os_name, os_valid, node_data in result:
+  for os_name, os_valid, os_variants, node_data in result:
     nodes_valid = {}
     nodes_bad = {}
     nodes_hidden = {}
@@ -140,6 +140,8 @@ def DiagnoseOS(opts, args):
           ToStdout(msg)
 
     ToStdout("OS: %s [global status: %s]", os_name, status)
+    if os_variants:
+      ToStdout("  Variants: [%s]" % ', '.join(os_variants))
     _OutputPerNodeOSStatus(nodes_valid)
     _OutputPerNodeOSStatus(nodes_bad)
     ToStdout("")