Fixed various warnings
authorChristos Stathis <chstath@ebs.gr>
Thu, 22 Sep 2011 09:12:00 +0000 (12:12 +0300)
committerChristos Stathis <chstath@ebs.gr>
Thu, 22 Sep 2011 09:12:00 +0000 (12:12 +0300)
21 files changed:
src/gr/grnet/pithos/resources/folder22.png [new file with mode: 0644]
src/gr/grnet/pithos/web/client/FilePropertiesDialog.java
src/gr/grnet/pithos/web/client/FolderPropertiesDialog.java
src/gr/grnet/pithos/web/client/Pithos.java
src/gr/grnet/pithos/web/client/VersionsList.java
src/gr/grnet/pithos/web/client/commands/AddUserCommand.java
src/gr/grnet/pithos/web/client/commands/CreateGroupCommand.java
src/gr/grnet/pithos/web/client/commands/DeleteGroupCommand.java
src/gr/grnet/pithos/web/client/commands/EmptyTrashCommand.java
src/gr/grnet/pithos/web/client/commands/RemoveUserCommand.java
src/gr/grnet/pithos/web/client/commands/RestoreTrashCommand.java
src/gr/grnet/pithos/web/client/commands/ToTrashCommand.java
src/gr/grnet/pithos/web/client/foldertree/File.java
src/gr/grnet/pithos/web/client/foldertree/FileVersions.java
src/gr/grnet/pithos/web/client/foldertree/Folder.java
src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java
src/gr/grnet/pithos/web/client/grouptree/GroupTreeView.java
src/gr/grnet/pithos/web/client/grouptree/GroupTreeViewModel.java
src/gr/grnet/pithos/web/client/grouptree/UserContextMenu.java
src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeView.java
src/gr/grnet/pithos/web/client/othersharedtree/OtherSharedTreeView.java

diff --git a/src/gr/grnet/pithos/resources/folder22.png b/src/gr/grnet/pithos/resources/folder22.png
new file mode 100644 (file)
index 0000000..65b7c2c
Binary files /dev/null and b/src/gr/grnet/pithos/resources/folder22.png differ
index d5343a8..41bdd3f 100644 (file)
@@ -51,8 +51,6 @@ import com.google.gwt.core.client.GWT;
 import com.google.gwt.core.client.Scheduler;\r
 import com.google.gwt.event.dom.client.ClickEvent;\r
 import com.google.gwt.event.dom.client.ClickHandler;\r
-import com.google.gwt.event.logical.shared.SelectionEvent;\r
-import com.google.gwt.event.logical.shared.SelectionHandler;\r
 import com.google.gwt.i18n.client.DateTimeFormat;\r
 import com.google.gwt.resources.client.ImageResource;\r
 import com.google.gwt.user.client.Window;\r
@@ -360,7 +358,7 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog {
         return permPanel;\r
     }\r
 \r
-    private VerticalPanel createVersionPanel(List<Version> versions) {\r
+    VerticalPanel createVersionPanel(List<Version> versions) {\r
         VerticalPanel versionPanel = new VerticalPanel();\r
         VersionsList verList = new VersionsList(app, this, images, file, versions);\r
         versionPanel.add(verList);\r
@@ -464,7 +462,4 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog {
         else\r
             app.updateFolder(file.getParent(), true, null);\r
     }\r
-\r
-       private void removeAllOldVersions() {\r
-       }\r
 }\r
index e852f38..f55a835 100644 (file)
@@ -368,13 +368,13 @@ public class FolderPropertiesDialog extends DialogBox {
                                 }\r
 \r
                                 @Override\r
-                                public void onError(Throwable t) {\r
-                                    GWT.log("", t);\r
-                                    if(t instanceof RestException){\r
-                                        app.displayError("Unable to update folder: " + ((RestException) t).getHttpStatusText());\r
+                                public void onError(Throwable _t) {\r
+                                    GWT.log("", _t);\r
+                                    if(_t instanceof RestException){\r
+                                        app.displayError("Unable to update folder: " + ((RestException) _t).getHttpStatusText());\r
                                     }\r
                                     else\r
-                                        app.displayError("System error modifying folder: " + t.getMessage());\r
+                                        app.displayError("System error modifying folder: " + _t.getMessage());\r
                                 }\r
                             };\r
                             newFolder.setHeader("X-Auth-Token", app.getToken());\r
index ced54ac..6dff284 100644 (file)
@@ -44,7 +44,6 @@ import gr.grnet.pithos.web.client.foldertree.Resource;
 import gr.grnet.pithos.web.client.grouptree.Group;
 import gr.grnet.pithos.web.client.grouptree.GroupTreeView;
 import gr.grnet.pithos.web.client.grouptree.GroupTreeViewModel;
-import gr.grnet.pithos.web.client.grouptree.User;
 import gr.grnet.pithos.web.client.mysharedtree.MysharedTreeView;
 import gr.grnet.pithos.web.client.mysharedtree.MysharedTreeViewModel;
 import gr.grnet.pithos.web.client.othersharedtree.OtherSharedTreeView;
@@ -95,8 +94,6 @@ import com.google.gwt.user.client.ui.HasHorizontalAlignment;
 import com.google.gwt.user.client.ui.HasVerticalAlignment;
 import com.google.gwt.user.client.ui.HorizontalPanel;
 import com.google.gwt.user.client.ui.HorizontalSplitPanel;
-import com.google.gwt.user.client.ui.Image;
-import com.google.gwt.user.client.ui.PushButton;
 import com.google.gwt.user.client.ui.RootPanel;
 import com.google.gwt.user.client.ui.VerticalPanel;
 import com.google.gwt.view.client.SelectionChangeEvent;
@@ -257,13 +254,13 @@ public class Pithos implements EntryPoint, ResizeHandler {
     private TagTreeViewModel tagTreeViewModel;
     private TagTreeView tagTreeView;
 
-    private GroupTreeViewModel groupTreeViewModel;
+    GroupTreeViewModel groupTreeViewModel;
     private GroupTreeView groupTreeView;
 
     private TreeView selectedTree;
     protected AccountResource account;
     
-    private Folder trash;
+    Folder trash;
 
     @SuppressWarnings("rawtypes")
        private List<SingleSelectionModel> selectionModels = new ArrayList<SingleSelectionModel>();
@@ -585,7 +582,7 @@ public class Pithos implements EntryPoint, ResizeHandler {
        HeadRequest<AccountResource> headAccount = new HeadRequest<AccountResource>(AccountResource.class, getApiPath(), username, "", account) {
 
                        @Override
-                       public void onSuccess(AccountResource _result) {
+                       public void onSuccess(@SuppressWarnings("unused") AccountResource _result) {
                                showStatistics();
                        }
 
@@ -609,12 +606,12 @@ public class Pithos implements EntryPoint, ResizeHandler {
        usedPercent.setHTML(String.valueOf(account.getUsedPercentage()));
        }
 
-       protected void createHomeContainer(final AccountResource account, final Command callback) {
+       protected void createHomeContainer(final AccountResource _account, final Command callback) {
         String path = "/" + Pithos.HOME_CONTAINER;
         PutRequest createPithos = new PutRequest(getApiPath(), getUsername(), path) {
             @Override
             public void onSuccess(@SuppressWarnings("unused") Resource result) {
-               if (!account.hasTrashContainer())
+               if (!_account.hasTrashContainer())
                        createTrashContainer(callback);
                else
                        fetchAccount(callback);
@@ -955,13 +952,13 @@ public class Pithos implements EntryPoint, ResizeHandler {
                GetRequest<Folder> getFolder = new GetRequest<Folder>(Folder.class, getApiPath(), f.getOwner(), "/" + f.getContainer() + "?format=json&delimiter=/&prefix=" + f.getPrefix(), f) {
 
                                        @Override
-                                       public void onSuccess(final Folder f) {
-                               Iterator<File> iter = f.getFiles().iterator();
-                               copyFiles(iter, targetUsername, targetUri + "/" + f.getName(), new Command() {
+                                       public void onSuccess(final Folder _f) {
+                               Iterator<File> iter = _f.getFiles().iterator();
+                               copyFiles(iter, targetUsername, targetUri + "/" + _f.getName(), new Command() {
                                    @Override
                                    public void execute() {
-                                       Iterator<Folder> iterf = f.getSubfolders().iterator();
-                                       copySubfolders(iterf, targetUsername, targetUri + "/" + f.getName(), callback);
+                                       Iterator<Folder> iterf = _f.getSubfolders().iterator();
+                                       copySubfolders(iterf, targetUsername, targetUri + "/" + _f.getName(), callback);
                                    }
                                });
                                        }
index a62822d..16784c6 100644 (file)
@@ -101,7 +101,7 @@ public class VersionsList extends Composite {
                        HTML restoreVersion = new HTML("<a href='#' class='hidden-link info'><span>" + AbstractImagePrototype.create(images.restore()).getHTML() + "</span><div>Restore this Version</div></a>");
                        restoreVersion.addClickHandler(new ClickHandler() {
                                @Override
-                               public void onClick(ClickEvent event) {
+                               public void onClick(@SuppressWarnings("unused") ClickEvent event) {
                                        restoreVersion(v.getVersion());
                                }
                        });
@@ -111,7 +111,7 @@ public class VersionsList extends Composite {
                        HTML downloadHtml = new HTML("<a class='hidden-link info' href='#'><span>" + AbstractImagePrototype.create(images.download()).getHTML()+"</span><div>View this Version</div></a>");
                        downloadHtml.addClickHandler(new ClickHandler() {
                                @Override
-                               public void onClick(ClickEvent event) {
+                               public void onClick(@SuppressWarnings("unused") ClickEvent event) {
                                        String fileUrl = app.getApiPath() + file.getOwner() + file.getUri() + "?X-Auth-Token=" + app.getToken() + "&version=" + v.getVersion();
                                        Window.open(fileUrl, "_BLANK", "");
                                }
@@ -131,7 +131,7 @@ public class VersionsList extends Composite {
                PostRequest restoreVersion = new PostRequest(app.getApiPath(), file.getOwner(), path) {
                        
                        @Override
-                       public void onSuccess(Resource result) {
+                       public void onSuccess(@SuppressWarnings("unused") Resource result) {
                                container.hide();
                        }
                        
index b1be216..6c5ecec 100644 (file)
@@ -77,7 +77,7 @@ public class AddUserCommand implements Command {
                PostRequest updateGroup = new PostRequest(app.getApiPath(), app.getUsername(), path) {
                                
                                @Override
-                               public void onSuccess(Resource result) {
+                               public void onSuccess(@SuppressWarnings("unused") Resource result) {
                                        app.updateGroupNode(group);
                                }
                                
index e7eec5b..b65b9bc 100644 (file)
 package gr.grnet.pithos.web.client.commands;
 
 import gr.grnet.pithos.web.client.Pithos;
-import gr.grnet.pithos.web.client.foldertree.Resource;
-import gr.grnet.pithos.web.client.grouptree.Group;
-import gr.grnet.pithos.web.client.rest.PostRequest;
-import gr.grnet.pithos.web.client.rest.RestException;
 
-import com.google.gwt.core.client.GWT;
-import com.google.gwt.core.client.Scheduler;
 import com.google.gwt.user.client.Command;
 import com.google.gwt.user.client.Window;
 import com.google.gwt.user.client.ui.PopupPanel;
index e6073eb..e2bd43a 100644 (file)
@@ -54,7 +54,7 @@ import com.google.gwt.user.client.ui.PopupPanel;
 public class DeleteGroupCommand implements Command {
        private PopupPanel containerPanel;
 
-    private Group group;
+    Group group;
 
     Pithos app;
     
@@ -76,7 +76,7 @@ public class DeleteGroupCommand implements Command {
                PostRequest updateGroup = new PostRequest(app.getApiPath(), app.getUsername(), path) {
                                
                                @Override
-                               public void onSuccess(Resource result) {
+                               public void onSuccess(@SuppressWarnings("unused") Resource result) {
                                        app.removeGroup(group);
                                }
                                
index 090c4be..5c5be5a 100644 (file)
@@ -110,7 +110,7 @@ public class EmptyTrashCommand implements Command{
                                                        DeleteRequest deleteF = new DeleteRequest(app.getApiPath(), f.getOwner(), path) {
                                                                
                                                                @Override
-                                                               public void onSuccess(Resource result) {
+                                                               public void onSuccess(@SuppressWarnings("unused") Resource result) {
                                                                        deleteSubfolder(iter2, callback);
                                                                }
                                                                
@@ -144,7 +144,7 @@ public class EmptyTrashCommand implements Command{
                        DeleteRequest deleteF = new DeleteRequest(app.getApiPath(), f.getOwner(), path) {
                                
                                @Override
-                               public void onSuccess(Resource result) {
+                               public void onSuccess(@SuppressWarnings("unused") Resource result) {
                                        deleteFile(iter, callback);
                                }
                                
index e4286a0..1787a7b 100644 (file)
@@ -44,7 +44,6 @@ import gr.grnet.pithos.web.client.rest.RestException;
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.core.client.Scheduler;
 import com.google.gwt.user.client.Command;
-import com.google.gwt.user.client.Window;
 import com.google.gwt.user.client.ui.PopupPanel;
 
 /**
@@ -77,7 +76,7 @@ public class RemoveUserCommand implements Command {
        PostRequest updateGroup = new PostRequest(app.getApiPath(), app.getUsername(), path) {
                        
                        @Override
-                       public void onSuccess(Resource result) {
+                       public void onSuccess(@SuppressWarnings("unused") Resource result) {
                                app.updateGroupNode(group);
                        }
                        
index 6aa58f7..40656c7 100644 (file)
@@ -111,7 +111,7 @@ public class RestoreTrashCommand implements Command {
                                                                DeleteRequest deleteFolder = new DeleteRequest(app.getApiPath(), f.getOwner(), f.getUri()) {
                                                                        
                                                                        @Override
-                                                                       public void onSuccess(Resource result) {
+                                                                       public void onSuccess(@SuppressWarnings("unused") Resource _result) {
                                                                                if (callback != null)
                                                                                        callback.execute();
                                                                        }
index e4a2262..e9b5197 100644 (file)
  */
 package gr.grnet.pithos.web.client.commands;
 
-import com.google.gwt.core.client.Scheduler;
-
-import gr.grnet.pithos.web.client.DeleteFolderDialog;
 import gr.grnet.pithos.web.client.Pithos;
 import gr.grnet.pithos.web.client.foldertree.File;
 import gr.grnet.pithos.web.client.foldertree.Folder;
 import gr.grnet.pithos.web.client.foldertree.Resource;
 import gr.grnet.pithos.web.client.rest.DeleteRequest;
-import gr.grnet.pithos.web.client.rest.PostRequest;
 import gr.grnet.pithos.web.client.rest.PutRequest;
 import gr.grnet.pithos.web.client.rest.RestException;
 
 import java.util.Iterator;
 import java.util.List;
 
-
 import com.google.gwt.core.client.GWT;
+import com.google.gwt.core.client.Scheduler;
 import com.google.gwt.user.client.Command;
 import com.google.gwt.user.client.ui.PopupPanel;
 
@@ -115,7 +111,7 @@ public class ToTrashCommand implements Command{
                                                                DeleteRequest deleteFolder = new DeleteRequest(app.getApiPath(), f.getOwner(), f.getUri()) {
                                                                        
                                                                        @Override
-                                                                       public void onSuccess(Resource result) {
+                                                                       public void onSuccess(@SuppressWarnings("unused") Resource _result) {
                                                                                if (callback != null)
                                                                                        callback.execute();
                                                                        }
index b3559e4..3a630d6 100644 (file)
 
 package gr.grnet.pithos.web.client.foldertree;
 
-import com.google.gwt.http.client.Header;
-import com.google.gwt.http.client.Response;
-import com.google.gwt.i18n.client.NumberFormat;
-import com.google.gwt.json.client.JSONObject;
-
-import gr.grnet.pithos.web.client.Pithos;
-
 import java.util.Date;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
 
+import com.google.gwt.http.client.Header;
+import com.google.gwt.http.client.Response;
+import com.google.gwt.i18n.client.NumberFormat;
+import com.google.gwt.json.client.JSONObject;
+
 public class File extends Resource {
     private String name;
 
index 3f1e58c..4d6e983 100644 (file)
@@ -1,14 +1,11 @@
 package gr.grnet.pithos.web.client.foldertree;
 
-import gr.grnet.pithos.web.client.SharingUsers;
-
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
 
 import com.google.gwt.http.client.Response;
 import com.google.gwt.json.client.JSONArray;
-import com.google.gwt.json.client.JSONObject;
 import com.google.gwt.json.client.JSONParser;
 import com.google.gwt.json.client.JSONValue;
 
index cb8361d..96d16d6 100644 (file)
@@ -39,7 +39,6 @@ import gr.grnet.pithos.web.client.Pithos;
 
 import java.util.Date;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.LinkedHashSet;
 import java.util.Map;
 import java.util.Set;
index 9893285..fadfa77 100644 (file)
@@ -35,6 +35,9 @@
 
 package gr.grnet.pithos.web.client.foldertree;
 
+import gr.grnet.pithos.web.client.FolderContextMenu;
+import gr.grnet.pithos.web.client.TreeView;
+
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.resources.client.ImageResource;
 import com.google.gwt.resources.client.ImageResource.ImageOptions;
@@ -46,8 +49,6 @@ import com.google.gwt.user.cellview.client.TreeNode;
 import com.google.gwt.user.client.Command;
 import com.google.gwt.user.client.ui.Composite;
 import com.google.gwt.user.client.ui.Tree;
-import gr.grnet.pithos.web.client.FolderContextMenu;
-import gr.grnet.pithos.web.client.TreeView;
 
 public class FolderTreeView extends Composite implements TreeView {
 
@@ -143,7 +144,8 @@ public class FolderTreeView extends Composite implements TreeView {
     }
 
 
-    public Folder getSelection() {
+    @Override
+       public Folder getSelection() {
        return model.getSelection();
     }
 
index 1ac877d..aafacfc 100644 (file)
@@ -36,7 +36,6 @@
 package gr.grnet.pithos.web.client.grouptree;
 
 import gr.grnet.pithos.web.client.FolderContextMenu;
-import gr.grnet.pithos.web.client.foldertree.Folder;
 
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.resources.client.ImageResource;
index 742bfe8..2c41372 100644 (file)
@@ -67,7 +67,7 @@ public class GroupTreeViewModel implements TreeViewModel {
                }
                
         @Override
-        public void onBrowserEvent(@SuppressWarnings("unused") Cell.Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, String s, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") com.google.gwt.cell.client.ValueUpdater<String> valueUpdater) {
+        public void onBrowserEvent(@SuppressWarnings("unused") Cell.Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, @SuppressWarnings("unused") String s, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") com.google.gwt.cell.client.ValueUpdater<String> valueUpdater) {
             if (event.getType().equals(ContextMenuEvent.getType().getName())) {
                 GroupContextMenu menu = new GroupContextMenu(app, GroupTreeView.images, null);
                 menu.setPopupPosition(event.getClientX(), event.getClientY());
index 0aa8def..8870109 100644 (file)
@@ -35,9 +35,6 @@
 package gr.grnet.pithos.web.client.grouptree;
 
 import gr.grnet.pithos.web.client.Pithos;
-import gr.grnet.pithos.web.client.commands.AddUserCommand;
-import gr.grnet.pithos.web.client.commands.CreateGroupCommand;
-import gr.grnet.pithos.web.client.commands.DeleteGroupCommand;
 import gr.grnet.pithos.web.client.commands.RemoveUserCommand;
 import gr.grnet.pithos.web.client.grouptree.GroupTreeView.Images;
 
index 78d864e..f2dd3f7 100644 (file)
@@ -141,7 +141,8 @@ public class MysharedTreeView extends Composite implements TreeView {
     }
 
 
-    public Folder getSelection() {
+    @Override
+       public Folder getSelection() {
        return model.getSelection();
     }
 
index 4da4b28..a81ae26 100644 (file)
@@ -144,7 +144,8 @@ public class OtherSharedTreeView extends Composite implements TreeView {
     }
 
 
-    public Folder getSelection() {
+    @Override
+       public Folder getSelection() {
        return model.getSelection();
     }