| Branch: | Tag: | Revision:

root / lib @ 27c7d9c3

Name Size
  watcher 1.2 kB 6.1 kB 124.8 kB 35.9 kB 127.9 kB 612.2 kB 4.3 kB 86.7 kB 63.1 kB 26.7 kB 10.8 kB 10.7 kB 79.7 kB 6 kB 61.1 kB 16.4 kB 26.1 kB 18.9 kB 7.3 kB 62.8 kB 67.3 kB 4.3 kB 66 kB 5.7 kB 9.6 kB 82.4 kB 26.1 kB 24 kB 6.3 kB 4.5 kB 11.5 kB 10.2 kB 13.2 kB 11.7 kB 7.4 kB 18.3 kB

Latest revisions

# Date Author Comment
27c7d9c3 04/29/2013 07:05 pm Thomas Thrainer

Use DRBD84ShowInfo based on DRBD version

Now the DRBD8 class actually checks which version of DRBD is running on
the system and chooses the right class to parse the `drbdsetup show`

Signed-off-by: Thomas Thrainer <>
Signed-off-by: Michele Tartara <>...

5520d04d 04/29/2013 07:05 pm Thomas Thrainer

Add `drbdsetup show` parser for DRBD 8.4

Common functionality between the DRBD 8.3 and DRBD 8.4 parser has been
extracted into BaseShowInfo. A test which verifies the behaviour is
included, but the DRBD84ShowInfo class is not yet used within the DRBD8

27d69b25 04/29/2013 07:05 pm Thomas Thrainer

Extract DRBD info parsing into

Parsing the status (/proc/drbd) and `drbdsetup show` output takes quite
a bit of code, which has to be augmented by even more with the DRBD 8.4
support. So extract all the related classes into their own file.

Signed-off-by: Thomas Thrainer <>...

d01e51a5 04/29/2013 07:05 pm Thomas Thrainer

Extract DRBD8ShowInfo class

This class parses the `drbdsetup show` output and represents it in an
easily accessible format. It got extracted so that 1) the DRBD8 class
can focus more on DRBD logic rather than parsing and 2) it's easier to
adapt the parser to new formats....

dcc4579c 04/29/2013 07:05 pm Thomas Thrainer

Rename _JoinProcDataPerMinor to _JoinLinesPerMinor

In the new context of the DRBD8Info class, the name
_JoinProcDataPerMinor doesn't fit any more. _JoinLinesPerMinor reflects
more precisely what's done, and doesn't imply that the data comes from

2fe690f1 04/29/2013 07:05 pm Thomas Thrainer

Extract /proc/drbd parsing code into DRBD8Info

As the DRBD8 class got bigger due to the previous merge of BaseDRBD, now
parts of it are ripped out into DRBD8Info. This new class parses
/proc/drbd and exposes the information in an easily accessible way. This...

fd300bc7 04/29/2013 07:05 pm Thomas Thrainer

Remove BaseDRBD

BaseDRBD was probably useful when DRBD 0.7 and DRBD 8 were supported.
However, there is only one subclass of BaseDRBD remaining (DRBD8), and
the separation of responsibilities between those two classes was rather
randomly chosen.

The unification into one class also eases the introduction of...

38396ae2 04/29/2013 07:04 pm Thomas Thrainer

Rename _MassageProcData to _JoinProcDataPerMinor

That's what the method actually does, so there is no reason why we
should use a funny but unreadable name.

Signed-off-by: Thomas Thrainer <>
Signed-off-by: Michele Tartara <>...

decf86f9 04/26/2013 05:39 pm Helga Velroyen


This patch makes the constant DEFAULT_ENABLED_DISK_TEMPLATES
a list instead of a set, because the order of the elements actually matters
as the first one is planned to be the default disk template for instance
creation. Also, this constant is always used like a list and thus providing it...

2d237e93 04/26/2013 05:12 pm Helga Velroyen

Fix lint error in cmdlib

Was accidentally introduced by commit 912737ba.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Guido Trotter <>

View revisions

Also available in: Atom