Use error_is_set() only when necessary
error_is_set(&var) is the same as var != NULL, but it takeswhole-program analysis to figure that out. Unnecessarily hard foroptimizers, static checkers, and human readers. Dumb it down toobvious.
Gets rid of several dozen Coverity false positives....
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
acpi,pc,pci fixes and enhancements
Most changes here are hotplug related:
This merges hotplug infrastructure changes by Igor,some acpi related fixes, and PC fixes.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>...
hw/pci: switch to a generic hotplug handling for PCIDevice
make qdev_unplug()/device_set_realized() to call hotplug handler'splug/unplug methods if available and remove not needed anymorehot(un)plug handling from PCIDevice.
In case if hotplug handler is not available, revert to the legacy...
qemu-iotests: add test for qcow2 preallocation with different cluster sizes
Reviewed-by: Max Reitz <mreitz@redhat.com>Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
qemu-iotest: Make 077 raw-only
The qemu-io command sequences make the assumption that an unalignedrequest on the format layer will be unaligned on the blkdebug layer aswell. This doesn't necessarily hold true for drivers other than raw.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>...
qemu-iotests: change _supported_proto to file for various tests
all these tests do anything of the following and thus fail with anyprotocol other than file: - the tests use rm, cp or mv shell commands which only work on file - the tests use qcow2.py - the images construct new filenames (e.g. backing file names) and...
qemu-iotests: blacklist test 020 for NFS protocol
reopening is currently not supported.
Signed-off-by: Peter Lieven <pl@kamp.de>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
qemu-iotests: enable test 016 and 025 to work with NFS protocol
qemu-iotests: enable support for NFS protocol
block: Fail gracefully with missing filename
This fixes a regression introduced in commit 2a05cbe42 ('block: Allowblock devices without files'):
$ qemu-system-x86_64 drive driver=fileqemu-system-x86_64: block.c:892: bdrv_open_common: Assertion`!drv>bdrv_needs_filename || filename != ((void *)0)' failed....
View revisions
Also available in: Atom