monitor: Cleanup ID assignment for compat switch
Canonicalize the ID assignment when creating monitor devices via thelegacy switch and use less easily colliding names.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
monitor: Reorder intialization to drop initial mux focus
So far a multiplexed monitor started disabled. Restore this property forthe new way of configuring by moving the monitor initialization beforeall devices (the last one to attach to a char-mux will gain the focus)....
Monitor: Return before exiting with 'quit'
The 'quit' Monitor command (implemented by do_quit()) callsexit() directly, this is problematic under QMP because QEMUexits before having a chance to send the ok response.
Clients don't know if QEMU exited because of a problem or...
QMP: Check "arguments" member's type
Otherwise the following input crashes QEMU:
{ "execute": "migrate", "arguments": "tcp:0:4446" }
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
QError: Improve QERR_QMP_BAD_INPUT_OBJECT desc
QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER
The QERR_QMP_BAD_INPUT_OBJECT error is going to be used onlyfor two problems: the input is not an object or the "execute" key is missing.
QError: New QERR_QMP_BAD_INPUT_OBJECT_MEMBER
sh4: remove dead assignments, spotted by clang analyzer
Value stored is never read.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
ppc: add missing 'break', spotted by clang analyzer
ppc: remove dead assignments, spotted by clang analyzer
View all revisions | View revisions
Also available in: Atom