History | View | Annotate | Download (31.3 kB)
Fix typo in comment (responsiblity -> responsibility)
Signed-off-by: Stefan Weil <weil@mail.berlios.de>Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
vmstate: move VMSTATE_PCIE_AER_ERRS to hw/hw.h
VMSTATE_PCIE_AER_ERRS is indeed useful for other emulation drivers.Move it to hw/hw.h under the name of VMSTATE_STRUCT_VARRAY_POINTER_UINT16.Also add VMSTATE_STRUCT_VARRAY_POINTER_INT32 which is more or less...
pcie/aer: glue aer error injection into qemu monitor
introduce pcie_aer_inject_error command.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
pci/aer: factor out common code
Same logic is used to assert interruptsand send msix messages, so add a static functin for this.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
pci/aer: remove dead code
Remove some unused variables and return values.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
pci/aer: fix interrupt on config write
config write handling for aer seems broken:For example, it won't clear a level interruptwhen command register is set to 0.
Make it match the spec: level should equalthe logical or of enabled bits, msi onlybe sent when the logical or changes....
pci/aer: fix error injection
Fix the injection logic upon aer message to follow 6.2.4.1.2 moreclosely: specifically only send an msi interrupt when the logical or ofthe enabled bits changed, not when a bit which was previously clearbecomes set.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>...
pci: untangle pci/msi dependency
msi depends on pci but pci should not depend on msi.The only dependency we have is a recent additionof pci_msi_ functions, IMO they add little enough toopen-code in the small number of users.
Follow-up patches add more cleanups....
Fix mingw32 and OpenBSD warnings
ffsl() is not universally available, so there are these warningson both mingw32 and OpenBSD:/src/qemu/hw/pcie_aer.c: In function 'pcie_aer_update_log':/src/qemu/hw/pcie_aer.c:399: warning: implicit declaration of function 'ffsl'...
pcie/aer: helper functions for pcie aer capability
This patch implements helper functions for pcie aer capabilitywhich will be used later.
pcie_aer: get rid of recursion
Added some TODOs: they are trivial but omitted hereto make the patch logic as transparent as possible.
pcie_aer: complete unwinding recursion
Open-code functions created in the previous patch,to make code more compact and clear.Detcted and documented what looks like a bug in codethat becomes apparent from this refactoring.