scsi-disk: fix the check of the DBD bit in the MODE SENSE command
The DBD bit does not work as expected.
SCSI-Spec:http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10"A disable block descriptors (DBD) bit of zero indicates that the targetmay return zero or more block descriptors in the returned MODE SENSE...
scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command
SCSI-Spec:http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10"An initiator may request any one or all of the supported mode pagesfrom a target. If an initiator issues a MODE SENSE command with a...
scsi-disk: fix the block descriptor returned by the MODE SENSE command
The block descriptor contains the number of blocks, not the highest LBA.Real hard disks return 0 if the number of blocks exceed the maximum 0xFFFFFF.
SCSI-Spec:http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.3.3...
scsi-disk: respect the page control (PC) field in the MODE SENSE command
The page control (PC) field defines the type of mode parameter valuesto be returned in the mode pages:
PC=0 : Current valuesPC=1 : Changeable valuesPC=2 : Default valuesPC=3 : Saved values...
scsi-disk: fix the mode data header returned by the MODE SENSE command
The header for the MODE SENSE command is 8 bytes long.
Signed-off-by: Bernhard Kohl <bernhard.kohl@nsn.com>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
scsi-disk: fix the mode data length field returned by the MODE SENSE command
The MODE DATA LENGTH field indicates the length in bytes of the followingdata that is available to be transferred. The mode data length does not includethe number of bytes in the MODE DATA LENGTH field....
virtio-blk: Fix migration of queued requests
in_sg[].iovec and out_sg[].ioved are pointer to (source) host memory andtherefore invalid after migration. When loading the device state we mustcreate a new mapping on the destination host.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
virtio: Factor virtqueue_map_sg out
Separate the mapping of requests to host memory from the descriptor iteration.The next patch will make use of it in a different context.
isapc: fix segfault.
https://bugs.launchpad.net/bugs/611646reports that ./i386-softmmu/qemu -M isapc segfaults.This patch fixes the segfault introduced byf885f1eaa8711c06033ceb1599e3750fb37c306f
It's because i440fx_state in pc_init1() isn't initialized....
etraxfs_eth: correct use of ! and &
Combining bitwise AND and logical NOT is suspicious.
Fixed by this Coccinelle script:// From http://article.gmane.org/gmane.linux.kernel/646367@ expression E1,E2; @( !E1 & !E2 |- !E1 & E2+ !(E1 & E2))
@ expression E1,E2;
Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>...
View revisions
Also available in: Atom