Statistics
| Branch: | Revision:

root / qga / channel-posix.c @ 4c1b8f1e

History | View | Annotate | Download (7.7 kB)

# Date Author Comment
7868181f 01/14/2013 08:08 pm Markus Armbruster

qemu-ga: Handle errors uniformely in ga_channel_open()

We detect errors in several places. One reports with g_error(), which
calls abort(), the others report with g_critical(). Three of them
exit(), three return false.

Always report with g_critical(), and return false....
d4f4a3ef 01/14/2013 08:07 pm Markus Armbruster

qemu-ga: Plug fd leak on ga_channel_open() error paths

Spotted by Coverity.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Reviewed-by: Michael Roth <>
Reviewed-by: Luiz Capitulino <>...
32c16620 01/14/2013 08:07 pm Markus Armbruster

qemu-ga: Plug fd leak on ga_channel_listen_accept() error path

Spotted by Coverity.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Reviewed-by: Michael Roth <>
Reviewed-by: Luiz Capitulino <>...
1d57db19 01/11/2013 10:33 am Peter Maydell

qga/channel-posix.c: Explicitly include string.h

Explicitly include string.h to avoid warnings under MacOS X/clang
about implicit declarations of strerror() and strlen().

Signed-off-by: Peter Maydell <>
Reviewed-by: Stefan Weil <>...
1de7afc9 12/19/2012 09:32 am Paolo Bonzini

misc: move include files to include/qemu/

Signed-off-by: Paolo Bonzini <>
4d4922c3 12/06/2012 10:17 am Eduardo Habkost

qga/channel-posix.c: Include headers it needs

Include:
- <errno.h> for errno
- <unistd.h> & <fcntl.h> for fcntl()
- <stdlib.h> for exit()
- "osdep.h" for qemu_open()

Some of those headers were probably being included by accident because
some other headers were including qemu-common.h, but those headers...
90119816 10/23/2012 02:54 pm Paolo Bonzini

qemu-ga: ask and print error information from qemu-sockets

Reviewed-by: Luiz Capitulino <>
Signed-off-by: Paolo Bonzini <>
7fc4e63e 10/23/2012 02:54 pm Paolo Bonzini

qemu-sockets: add Error ** to all functions

This lets me adjust the clients to do proper error propagation first,
thus avoiding temporary regressions in the quality of the error messages.

Reviewed-by: Luiz Capitulino <>
Signed-off-by: Paolo Bonzini <>
e61ab1da 05/01/2012 01:49 pm Andreas Färber

qemu-ga: Implement alternative to O_ASYNC

ga_channel_open() was using open flag O_ASYNC for SIGIO-driven I/O.
This breaks on illumos, so fall back to POSIX I_SETSIG ioctl (SIGPOLL).

Signed-off-by: Lee Essen <>
Signed-off-by: Andreas Färber <>...
125b310e 02/23/2012 11:40 pm Michael Roth

qemu-ga: move channel/transport functionality into wrapper class

This is mostly in preparation for the win32 port, which won't use
GIO channels for reasons that will be made clearer later. Here the
GAChannel class is just a loose wrapper around GIOChannel...