Statistics
| Branch: | Revision:

root / qemu-char.c @ 5a37532d

History | View | Annotate | Download (98.1 kB)

# Date Author Comment
2b316774 04/22/2013 04:52 pm Paolo Bonzini

qemu-char: do not operate on sources from finalize callbacks

Due to a glib bug, the finalize callback is called with the GMainContext
lock held. Thus, any operation on the context from the callback will
cause recursive locking and a deadlock. This happens, for example,...
910b6368 04/22/2013 04:52 pm Paolo Bonzini

qemu-char: use consistent idiom for removing sources

Always check that the source is active, and zero the tag afterwards.

The occurrence in pty_chr_state will trigger with the next patch, the
others are just theoretical.

Signed-off-by: Paolo Bonzini <>...
85a67692 04/22/2013 04:52 pm Paolo Bonzini

qemu-char: simplify pty polling

There is no need to use a timer and pty_chr_read to detect a connected
pty. It is simpler to just call g_poll periodically and check for POLLHUP.
It is done once per second, and only if the pty is disconnected, so it
is cheap enough....
cdbf6e16 04/22/2013 04:52 pm Paolo Bonzini

qemu-char: correct return value from chr_read functions

Even if a CharDriverState's source is blocked by the front-end,
it must not be dropped. The IOWatchPoll that wraps it will take
care of adding and removing it to the main loop. Only remove
the source when the channel is closed; and in that case, make sure...
4ceb193d 04/16/2013 01:06 am Anthony Liguori

Merge remote-tracking branch 'bonzini/hw-dirs' into staging

  • bonzini/hw-dirs:
    exec: remove useless declarations from memory-internal.h
    memory: move core typedefs to qemu/typedefs.h
    include: avoid useless includes of exec/ headers
    sysemu: avoid proliferation of include/ subdirectories...
dccfcd0e 04/15/2013 07:19 pm Paolo Bonzini

sysemu: avoid proliferation of include/ subdirectories

Signed-off-by: Paolo Bonzini <>
0ca5aa4f 04/15/2013 06:22 pm Paolo Bonzini

qemu-char: another io_add_watch_poll fix

After attaching the source, we have to remove the reference we hold
to it, because we do not hold anymore a pointer to the source.

If we do not do this, removing the source will not finalize it and
will not drop the "real" I/O watch source....
1e885b25 04/08/2013 06:38 pm Paolo Bonzini

qemu-char: really fix behavior on can_read = 0

I misread the glib manual, g_source_remove does not let you re-attach
the source later. This behavior (called "blocking" the source in glib)
is present in glib's source code, but private and not available outside...
d185c094 04/05/2013 08:53 pm Paolo Bonzini

qemu-char: eliminate busy waiting on can_read returning zero

The character backend refactoring introduced an undesirable busy wait.
The busy wait happens if can_read returns zero and there is data available
on the character device's file descriptor. Then, the I/O watch will...
4bf0bb80 04/05/2013 03:42 pm Luiz Capitulino

chardev: drop the Memory chardev driver

It's not used anymore since the last commit.

Signed-off-by: Luiz Capitulino <>
Reviewed-by: Eric Blake <>
Acked-by: Gerd Hoffmann <>
44c473de 04/05/2013 03:21 am Hans de Goede

qemu-char: Add qemu_chr_fe_claim / _release helper functions

Add qemu_chr_fe_claim / _release helper functions for properly dealing with
avail_connections.

Signed-off-by: Hans de Goede <>
Message-id: ...
456d6069 04/05/2013 03:21 am Hans de Goede

qemu-char: Call fe_claim / fe_release when not using qdev chr properties

chardev-frontends need to explictly check, increase and decrement the
avail_connections "property" of the chardev when they are not using a
qdev-chardev-property for the chardev.

This fixes things like:...
162cbbd1 04/02/2013 10:07 pm Anthony Liguori

Merge remote-tracking branch 'luiz/queue/qmp' into staging

  1. By Stefan Hajnoczi
  2. Via Luiz Capitulino
    • luiz/queue/qmp:
      chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors
      qemu-socket: set passed fd non-blocking in socket_connect()
      net: ensure "socket" backend uses non-blocking fds...
f9e8cacc 04/02/2013 06:47 pm Stefan Hajnoczi

oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock()

The fcntl(fd, F_SETFL, O_NONBLOCK) flag is not specific to sockets.
Rename to qemu_set_nonblock() just like qemu_set_cloexec().

Signed-off-by: Stefan Hajnoczi <>
Reviewed-by: Eric Blake <>...
9b938c72 04/02/2013 06:47 pm Stefan Hajnoczi

chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors

When we receive a file descriptor over a UNIX domain socket the
O_NONBLOCK flag is preserved. Clear the O_NONBLOCK flag and rely on
QEMU file descriptor users like migration, SPICE, VNC, block layer, and...
684a096e 04/02/2013 04:13 pm Anthony Liguori

qemu-char: rewrite io_channel_send_all and drop the '_all' suffix

The current code is oddly written and have equally odd semantics.
Despite the '_all' suffix, upon EAGAIN the result will be a partial
write but instead of returning the partial write, we return EAGAIN....
fee204fd 03/27/2013 05:26 pm Hans de Goede

qemu-char: Rename qemu_chr_generic_open to qemu_chr_be_generic_open

To better reflect that it is for handling a backend being opened.

Signed-off-by: Hans de Goede <>
Message-id:
Signed-off-by: Anthony Liguori <>
c0c4bd2c 03/27/2013 05:26 pm Hans de Goede

qemu-char: Add fe_open tracking

Add tracking of the fe_open state to struct CharDriverState.

Signed-off-by: Hans de Goede <>
Message-id:
Signed-off-by: Anthony Liguori <>
19083228 03/27/2013 05:26 pm Hans de Goede

qemu-char: Automatically do fe_open / fe_close on qemu_chr_add_handlers

Most frontends can't really determine if the guest actually has the frontend
side open. So lets automatically generate fe_open / fe_close as soon as a
frontend becomes ready (as signalled by calling qemu_chr_add_handlers) /...
8e25daa8 03/27/2013 05:26 pm Hans de Goede

qemu-char: Cleanup: consolidate fe_open/fe_close into fe_set_open

Signed-off-by: Hans de Goede <>
Message-id:
Signed-off-by: Anthony Liguori <>
574b711a 03/27/2013 05:26 pm Hans de Goede

qemu-char: Consolidate guest_close/guest_open into a set_fe_open callback

Signed-off-by: Hans de Goede <>
Message-id:
Signed-off-by: Anthony Liguori <>
85d91e32 03/27/2013 05:26 pm Hans de Goede

qemu-char: Move incrementing of avail_connections to qdev-properties-system

The decrement of avail_connections is done in qdev-properties-system move
the increment there too for proper balancing of the calls.

Signed-off-by: Hans de Goede <>...
a59bcd31 03/27/2013 05:26 pm Hans de Goede

qemu-char: add_handlers: Don't re-send the be_open event on unregister

Resending the be_open event only is useful when a frontend is registering, not
when it is unregistering.

Signed-off-by: Hans de Goede <>
Message-id: ...
16665b94 03/27/2013 05:26 pm Hans de Goede

qemu-char: Rename opened to be_open

Rename the opened variable to be_open to reflect that it contains the
opened state of the backend.

Signed-off-by: Hans de Goede <>
Message-id:
Signed-off-by: Anthony Liguori <>
cd18720a 03/26/2013 05:08 pm Anthony Liguori

char: introduce a blocking version of qemu_chr_fe_write

Signed-off-by: Anthony Liguori <>
2c8a5942 03/19/2013 02:56 pm Kevin Wolf

char: Fix return type of qemu_chr_fe_add_watch()

qemu_chr_fe_add_watch() can return negative errors, therefore it must
not have an unsigned return type. For consistency with other
qemu_chr_fe_* functions, this uses a standard C int instead of glib
types....
e5545854 03/13/2013 11:27 am Igor Mitsyanko

qemu-char.c: fix waiting for telnet connection message

Current colon position in "waiting for telnet connection" message template
produces messages like:
QEMU waiting for connection on: telnet::127.0.0.16666,server

After moving a colon to the right, we will get a correct messages like:...
f5a51cab 03/13/2013 11:27 am Gerd Hoffmann

chardev: add msmouse support to qapi

This patch adds 'msmouse' support to qapi and also switches over
the msmouse chardev initialization to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
2d57286d 03/13/2013 11:27 am Gerd Hoffmann

chardev: add braille support to qapi

This patch adds 'braille' support to qapi and also switches over
the braille chardev initialization to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
846e2e49 03/13/2013 11:27 am Gerd Hoffmann

chardev: switch file init to qapi

This patch switches over the 'file' chardev initialization
to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
7c358031 03/13/2013 11:27 am Gerd Hoffmann

chardev: add stdio support to qapi

This patch adds 'stdio' support to qapi and also switches over the
stdio chardev initialization to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
0f1cb51d 03/13/2013 11:27 am Gerd Hoffmann

chardev: switch serial/tty init to qapi

This patch switches over the serial chardev initialization
to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
dc375097 03/13/2013 11:27 am Gerd Hoffmann

chardev: switch parallel init to qapi

This patch switches over the parallel chardev initialization
to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
e68c5958 03/13/2013 11:27 am Gerd Hoffmann

chardev: switch pty init to qapi

This patch switches over the pty chardev initialization
to the new qapi code path.

Bonus: Taking QemuOpts out of the loop allows some nice
cleanups along the way.

Signed-off-by: Gerd Hoffmann <>
d9ac374f 03/13/2013 11:27 am Gerd Hoffmann

chardev: add console support to qapi

This patch adds 'console' support to qapi and also switches over the
console chardev initialization to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
548cbb36 03/13/2013 11:27 am Gerd Hoffmann

chardev: add pipe support to qapi

This patch adds 'pipe' support to qapi and also switches over the
pipe chardev initialization to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
cd153e2a 03/13/2013 11:27 am Gerd Hoffmann

chardev: add spice support to qapi

This patch adds 'spicevmc' and 'spiceport' support to qapi and also
switches over the spice chardev initialization to the new qapi code
path.
702ec69c 03/13/2013 11:27 am Gerd Hoffmann

chardev: add vc support to qapi

This patch adds 'vc' support to qapi and also switches over the
vc chardev initialization to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
1da48c65 03/13/2013 11:27 am Gerd Hoffmann

chardev: add memory (ringbuf) support to qapi

This patch adds 'memory' support to qapi and also switches over
the memory chardev initialization to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
3ecc059d 03/13/2013 11:27 am Gerd Hoffmann

chardev: add udp support to qapi

This patch adds 'udp' support to qapi.

Signed-off-by: Gerd Hoffmann <>
2c5f4882 03/13/2013 11:27 am Gerd Hoffmann

chardev: add support for qapi-based chardev initialization

This patch add support for a new way to initialize chardev devices.
Instead of calling a initialization function with a QemuOpts we will
now create a (qapi) ChardevBackend, optionally call a function to...
edb2fb3c 03/13/2013 11:27 am Gerd Hoffmann

chardev: add mux chardev support to qapi

This adds mux chardev support to the qapi and also makes the qapi-based
chardev creation path handle the "mux=on" option correctly.
80dca9e6 03/13/2013 11:27 am Gerd Hoffmann

chardev: switch null init to qapi

This patch switches over the 'null' chardev initialization
to the new qapi code path.

Signed-off-by: Gerd Hoffmann <>
4549a8b7 03/12/2013 08:40 pm Stefan Berger

Add a TPM Passthrough backend driver implementation

This patch is based of off version 9 of Stefan Berger's patch series
"QEMU Trusted Platform Module (TPM) integration"
and adds a new backend driver for it.

This patch adds a passthrough backend driver for passing commands sent to the...
44ab9ed4 03/11/2013 02:26 am Blue Swirl

qemu-char: fix win32 build

96c6384776d631839a9c8fe02bf135f9ba22586c did not adjust
Win32 #ifdeffery properly, breaking build in later commits. Fix.

Signed-off-by: Blue Swirl <>
Tested-by: Igor Mitsyanko <>
Message-id: ...
08744c98 03/08/2013 09:57 pm Anthony Liguori

qemu-char: move baum registration to baum.c

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
5ab8211b 03/08/2013 09:57 pm Anthony Liguori

qemu-char: move msmouse registeration to msmouse.c

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
01f45d98 03/08/2013 09:57 pm Anthony Liguori

qemu-char: move text console init to console.c

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
23673ca7 03/08/2013 09:57 pm Anthony Liguori

qemu-char: add watch support

This allows a front-end to request for a callback when the backend
is writable again.

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id: ...
e6a87ed8 03/08/2013 09:57 pm Anthony Liguori

qemu-char: add pty watch

This lets ptys support adding front end watchs.

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id: ...
d3cc5bc4 03/08/2013 09:57 pm Amit Shah

char: add gio watch fn for tcp backends

Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
8aa33caf 03/08/2013 09:57 pm Anthony Liguori

qemu-char: use a glib timeout instead of qemu-timer

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
9f939df9 03/08/2013 09:57 pm Anthony Liguori

qemu-char: remove use of QEMUTimer in favor of glib idle function

qemu-char is now independent of the QEMU main loop.

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id: ...
d654f34e 03/08/2013 09:57 pm Anthony Liguori

qemu-char: make char drivers dynamically registerable

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
26c60614 03/08/2013 09:57 pm Anthony Liguori

qemu-char: move spice registration to spice-qemu-char.c

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
2ea5a7af 03/08/2013 09:57 pm Anthony Liguori

qemu-char: tcp: make use GIOChannel

I didn't bother switching to g_io_channel_read/write because we need to use
sendmsg on Unix. No problem though since we're using an unbuffered channel.

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>...
a29753f8 03/08/2013 09:57 pm Anthony Liguori

qemu-char: convert fd_chr to use a GIOChannel

This uses the newly introduced IOWatchPoll source.

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id: ...
093d3a20 03/08/2013 09:57 pm Anthony Liguori

qemu-char: convert pty to GIOChannel

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
76a9644b 03/08/2013 09:57 pm Anthony Liguori

qemu-char: convert UDP to GIOChannel

Signed-off-by: Anthony Liguori <>
Signed-off-by: Amit Shah <>
Message-id:
Signed-off-by: Anthony Liguori <>
ed7a1540 03/08/2013 09:57 pm Anthony Liguori

qemu-char: remove dead/confusing logic with nb_stdio_clients

This code is very old dating back to 2007. What is puzzling is that
STDIO_MAX_CLIENTS was always #define to 1 meaning that all of the code to deal
with more than one client was unreachable.

Just remove the whole mess of it....
96c63847 03/08/2013 09:57 pm Anthony Liguori

char: add IOWatchPoll support

This is a special GSource that supports CharDriverState style
poll callbacks.

For reviewability and bisectability, this code is #if 0'd out in this
patch to avoid unused warnings since all of the functions are static.

Signed-off-by: Anthony Liguori <>...
bf1c852a 03/04/2013 10:54 am MORITA Kazutaka

move socket_set_nodelay to osdep.c

Signed-off-by: MORITA Kazutaka <>
Signed-off-by: Stefan Hajnoczi <>
d82831db 02/22/2013 12:34 am Anthony Liguori

console: allow VCs to be overridden by UI

We want to expose VCs using a VteTerminal widget. We need access to provide our
own CharDriverState in order to do this.

Signed-off-by: Anthony Liguori <>
Message-id:

d36b2b90 02/13/2013 07:57 pm Markus Armbruster

qapi: Flatten away ChardevPort

Simplifies the schema and the code.

QMP command

{ "execute" : "chardev-add",
      "arguments" : { "id" : "ser0",
                      "backend" : { "type" : "port",
                                    "data" : { "type": "serial",...
312fd5f2 02/11/2013 04:13 pm Markus Armbruster

error: Strip trailing '\n' from error string arguments (again)

Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming
back. Tracked down with this Coccinelle semantic patch:

r
    expression err, eno, cls, fmt;
    position p;
    @@
    (...
44f3bcd2 02/07/2013 12:35 am Markus Armbruster

qmp: Drop wasteful zero-initialization in qmp_memchar_read()

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Anthony Liguori <>
094c8c2c 02/07/2013 12:35 am Markus Armbruster

qemu-char: Fix chardev "memory" not to drop IAC characters

Undocumented misfeature, get rid of it while we can.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Anthony Liguori <>
6fd5b669 02/07/2013 12:35 am Markus Armbruster

qemu-char: Drop undocumented chardev "memory" compatibility syntax

This is a new device, so there's no compatibility to maintain, and its
use case isn't common enough to justify shorthand syntax.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>...
5c230105 02/07/2013 12:35 am Markus Armbruster

qemu-char: General chardev "memory" code cleanup

Inline trivial cirmem_chr_is_empty() into its only caller.

Rename qemu_chr_cirmem_count() to cirmem_count().

Fast ring buffer index wraparound. Without this, there's no point in
restricting size to a power two....
3949e594 02/07/2013 12:35 am Markus Armbruster

qemu-char: Saner naming of memchar stuff & doc fixes

New device, has never been released, so we can still improve things
without worrying about compatibility.

Naming is a mess. The code calls the device driver CirMemCharDriver,
the public API calls it "memory", "memchardev", or "memchar", and the...
de1cc36e 02/07/2013 12:35 am Markus Armbruster

qemu-char: Support suffixed ringbuf size arguments like "size=64K"

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Anthony Liguori <>
13289fb5 02/07/2013 12:35 am Markus Armbruster

qmp: Plug memory leaks in memchar-write, memchar-read

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Anthony Liguori <>
c287e99f 02/07/2013 12:35 am Markus Armbruster

qmp: Drop superfluous special case "empty" in qmp_memchar_read()

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Anthony Liguori <>
82e59a67 02/07/2013 12:35 am Markus Armbruster

qmp: Fix design bug and read beyond buffer in memchar-write

Command memchar-write takes data and size parameter. Begs the
question what happens when data doesn't match size.

With format base64, qmp_memchar_write() copies the full data argument,
regardless of size argument....
3ab651fc 02/07/2013 12:35 am Markus Armbruster

qmp: Clean up design of memchar-read

The data returned has a well-defined size, which makes the size
returned along with it redundant at best. Drop it.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Anthony Liguori <>
1a69278e 02/07/2013 12:35 am Markus Armbruster

qmp: Use generic errors in memchar-read, memchar-write

New errors should be generic unless there's a real use case for rich
errors.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Anthony Liguori <>
c4f331b6 02/07/2013 12:35 am Markus Armbruster

qmp: Clean up type usage in qmp_memchar_write(), qmp_memchar_read()

Const-correctness, consistently use standard C types instead of mixing
them with GLib types.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>...
6cebf7af 01/28/2013 10:41 pm Anthony Liguori

Merge remote-tracking branch 'luiz/queue/qmp' into staging

  1. By Lei Li (3) and others
  2. Via Luiz Capitulino
    • luiz/queue/qmp:
      QAPI: Introduce memchar-read QMP command
      QAPI: Introduce memchar-write QMP command
      qemu-char: Add new char backend CirMemCharDriver...
39099991 01/26/2013 03:27 pm Peter Maydell

qemu-char: Avoid unused variable warning in some configs

Avoid unused variable warnings:
qemu-char.c: In function 'qmp_chardev_open_port':
qemu-char.c:3132: warning: unused variable 'fd'
qemu-char.c:3132: warning: unused variable 'flags'

in configurations with neither HAVE_CHARDEV_TTY nor...
49b6d722 01/25/2013 03:46 pm Lei Li

QAPI: Introduce memchar-read QMP command

Signed-off-by: Lei Li <>
Signed-off-by: Luiz Capitulino <>
51767e7c 01/25/2013 03:23 pm Lei Li

qemu-char: Add new char backend CirMemCharDriver

Signed-off-by: Lei Li <>
Signed-off-by: Luiz Capitulino <>
1f590cf9 01/25/2013 03:23 pm Lei Li

QAPI: Introduce memchar-write QMP command

Signed-off-by: Lei Li <>
Signed-off-by: Luiz Capitulino <>
f1a1a356 01/16/2013 07:58 am Gerd Hoffmann

chardev: add qmp hotplug commands, with null chardev support

Add chardev-add and chardev-remove qmp commands. Hotplugging
a null chardev is supported for now, more will be added later.

Signed-off-by: Gerd Hoffmann <>
ffbdbe59 01/16/2013 07:58 am Gerd Hoffmann

chardev: add file chardev support to chardev-add (qmp)

Add support for file chardevs. Output file is mandatory,
input file is optional.

Signed-off-by: Gerd Hoffmann <>
d59044ef 01/16/2013 07:58 am Gerd Hoffmann

chardev: add serial chardev support to chardev-add (qmp)

Similar to file, except that no separate in/out files are supported
because it's pointless for direct device access. Also the special
tty ioctl hooks (pass through linespeed settings etc) are activated...
88a946d3 01/16/2013 07:58 am Gerd Hoffmann

chardev: add parallel chardev support to chardev-add (qmp)

Also alias the old parport name to parallel for -chardev.

Signed-off-by: Gerd Hoffmann <>
f6bd5d6e 01/16/2013 07:58 am Gerd Hoffmann

chardev: add socket chardev support to chardev-add (qmp)

qemu_chr_open_socket is split into two functions. All initialization
after creating the socket file handler is split away into the new
qemu_chr_open_socket_fd function.

chr->filename doesn't get filled from QemuOpts any more. Qemu gathers...
0a1a7fab 01/16/2013 07:58 am Gerd Hoffmann

chardev: add pty chardev support to chardev-add (qmp)

The ptsname is returned directly, so there is no need to
use query-chardev to figure the pty device path.

Signed-off-by: Gerd Hoffmann <>
bd2d80b2 01/16/2013 07:58 am Gerd Hoffmann

chardev: add error reporting for qemu_chr_new_from_opts

Signed-off-by: Gerd Hoffmann <>
2274ae9d 01/16/2013 07:58 am Gerd Hoffmann

chardev: fix QemuOpts lifecycle

qemu_chr_new_from_opts handles QemuOpts release now, so callers don't
have to worry. It will either be saved in CharDriverState, then
released in qemu_chr_delete, or in the error case released instantly.

Signed-off-by: Gerd Hoffmann <>
e551498e 01/16/2013 07:58 am Gerd Hoffmann

chardev: reduce chardev ifdef mess a bit

Signed-off-by: Gerd Hoffmann <>
4d454574 01/12/2013 06:17 pm Paolo Bonzini

qemu-option: move standard option definitions out of qemu-config.c

Signed-off-by: Paolo Bonzini <>
25bbf61e 01/03/2013 08:53 pm Gerd Hoffmann

pty: unbreak libvirt

Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty
support because it tried to figure the pts name from stderr output.

Fix this by moving the label to the end of the line, this way the
libvirt parser does still recognise the message. libvirt looks...
ab51b1d5 01/02/2013 09:32 pm Michael Tokarev

disallow -daemonize usage of stdio (curses display, -nographic, -serial stdio etc)

Curses display requires stdin/out to stay on the terminal,
so -daemonize makes no sense in this case. Instead of
leaving display uninitialized like is done since 995ee2bf469de6bb,...
58650218 12/23/2012 05:11 pm Lei Li

qemu-char: Inherit ptys and improve output from -serial pty

Changes since V1:
- Avoid crashing since qemu_opts_id() may return null on some
systems according to Markus's suggestion.

When controlling a qemu instance from another program, it's
hard to know which serial port or monitor device is redirected...
27dd7730 12/20/2012 01:15 am Anthony Liguori

Merge remote-tracking branch 'bonzini/header-dirs' into staging

  • bonzini/header-dirs: (45 commits)
    janitor: move remaining public headers to include/
    hw: move executable format header files to hw/
    fpu: move public header file to include/fpu
    softmmu: move remaining include files to include/ subdirectories...
927d4878 12/19/2012 09:32 am Paolo Bonzini

softmmu: move remaining include files to include/ subdirectories

Signed-off-by: Paolo Bonzini <>
9c17d615 12/19/2012 09:32 am Paolo Bonzini

softmmu: move include files to include/sysemu/

Signed-off-by: Paolo Bonzini <>
1de7afc9 12/19/2012 09:32 am Paolo Bonzini

misc: move include files to include/qemu/

Signed-off-by: Paolo Bonzini <>
83c9089e 12/19/2012 09:31 am Paolo Bonzini

monitor: move include files to include/monitor/

Signed-off-by: Paolo Bonzini <>