Statistics
| Branch: | Revision:

root @ 66aae5e1

# Date Author Comment
6033e840 08/20/2013 04:54 pm Peter Maydell

hw/cpu/a15mpcore: Wire generic timer outputs to GIC inputs

Now our A15 CPU implements the generic timers, we can wire them
up to the appropriate inputs on the GIC.

Signed-off-by: Peter Maydell <>
Tested-by: Laurent Desnogues <>...
66aae5e1 08/20/2013 04:54 pm Peter Maydell

default-configs: Fix A9MP and A15MP config names

When individual CONFIG_ switches for the A9MPcore and A15MPcore
devices were created, they were inadvertently given incorrect names
(CONFIG_ARM9MPCORE and CONFIG_ARM15MPCORE). These CPUs are
"Cortex-A9MP" and "Cortex-A15MP", and in particular the ARM9 is...
b643e4b9 08/20/2013 04:54 pm Peter Maydell

hw/arm/pic_cpu: Remove the now-unneeded arm_pic_init_cpu()

Now all the boards have been converted arm_pic_init_cpu()
is unused and can just be deleted.

Signed-off-by: Peter Maydell <>
Message-id:

22d9e1a9 08/20/2013 04:54 pm Peter Maydell

target-arm: Allow raw_read() and raw_write() to handle 64 bit regs

Extend the raw_read() and raw_write() helper accessors so that
they can be used for 64 bit registers as well as 32 bit registers.

Signed-off-by: Peter Maydell <>
Tested-by: Laurent Desnogues <>...
2452731c 08/20/2013 04:54 pm Peter Maydell

target-arm: Support coprocessor registers which do I/O

Add an ARM_CP_IO flag which an ARMCPRegInfo definition can use to
indicate that the register's implementation does I/O and thus
its accesses need to be surrounded by gen_io_start()/gen_io_end()
in order for icount to work. Most notably, cp registers which...
55d284af 08/20/2013 04:54 pm Peter Maydell

target-arm: Implement the generic timer

The ARMv7 architecture specifies a 'generic timer' which is implemented
via cp15 registers. Newer kernels will prefer to use this rather than
a devboard-level timer. Implement the generic timer for TCG; for KVM
we will already use the hardware's virtualized timer for this....
033ee5a5 08/20/2013 04:54 pm Peter Maydell

hw/arm/realview: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

4f071cf9 08/20/2013 04:54 pm Peter Maydell

hw/arm/strongarm: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

bace999f 08/20/2013 04:54 pm Peter Maydell

hw/arm/versatilepb: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

fe9120a5 08/20/2013 04:54 pm Peter Maydell

hw/arm/vexpress: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

e4a6540d 08/20/2013 04:54 pm Peter Maydell

hw/arm/xilinx_zynq: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

9188dbf7 08/20/2013 04:54 pm Peter Maydell

hw/arm/highbank: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

99d228d6 08/20/2013 04:54 pm Peter Maydell

hw/arm/integratorcp: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

2f69ba17 08/20/2013 04:54 pm Peter Maydell

hw/arm/kzm: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

fcef61ec 08/20/2013 04:54 pm Peter Maydell

hw/arm/musicpal: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

437f0f10 08/20/2013 04:54 pm Peter Maydell

hw/arm/omap*: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

3f1beaca 08/20/2013 04:54 pm Peter Maydell

target-arm: Implement 'int' loglevel

The 'int' loglevel for recording interrupts and exceptions
requires support in the target-specific code. Implement
it for ARM. This improves debug logging in some situations
that were otherwise pretty opaque, such as when we fault...
7c1840b6 08/20/2013 04:54 pm Peter Maydell

target-arm: Make IRQ and FIQ gpio lines on the CPU object

Now that ARMCPU is a subclass of DeviceState, we can make the
CPU's inbound IRQ and FIQ lines be simply gpio lines, which
means we can remove the odd arm_pic shim.

We retain the arm_pic_init_cpu() function as a backwards...
de3a658f 08/20/2013 04:54 pm Peter Maydell

hw/arm/armv7m: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

ad666d91 08/20/2013 04:54 pm Peter Maydell

hw/arm/exynos4210: Don't use arm_pic_init_cpu()

Drop the now-deprecated arm_pic_init_cpu() in favour of directly
getting the IRQ line from the ARMCPU object.

Signed-off-by: Peter Maydell <>
Message-id:

f2020398 08/15/2013 11:41 pm Anthony Liguori

Open up 1.7 development branch

Signed-off-by: Anthony Liguori <>
1ee2daeb 08/15/2013 09:41 pm Anthony Liguori

Update version for 1.6.0

Signed-off-by: Anthony Liguori <>
cc413a39 08/14/2013 05:47 pm Aurelien Jarno

mips_malta: do not raise exceptions when accessing invalid memory

Since commit c658b94f6e8c206c59d02aa6fbac285b86b53d2c, MIPS raises
exceptions when accessing invalid memory. This is not the correct
behaviour for MIPS Malta Core LV, as the GT-64120A system controller...
8b7a5415 08/14/2013 04:34 pm M. Mohan Kumar

block: Dont ignore previously set bdrv_flags

bdrv_flags is set by bdrv_parse_discard_flags(), but later it is reset
to zero.

Signed-off-by: M. Mohan Kumar <>
Message-id:
Signed-off-by: Anthony Liguori <>
3a3567d3 08/13/2013 09:24 pm James Hogan

qemu-char: fix infinite recursion connecting to monitor pty

Since commit bd5c51e (qemu-char: don't issue CHR_EVENT_OPEN in a BH), an
infinite recursion occurs when putting the monitor on a pty (-monitor
pty) and connecting a terminal to the slave port.

This is because of the qemu_chr_be_event(s, CHR_EVENT_OPENED) added to...
02653c5e 08/13/2013 05:02 pm Anthony Liguori

pvpanic: fix bad merge

Context matching caused the 'has_pvpanic = true' to be applied to
the 1.6 machine type instead of the 1.5 machine type.

Reported-by: Markus Armbruster <>
Reported-by: Michael S. Tsirkin <>
Signed-off-by: Anthony Liguori <>
328465fd 08/12/2013 11:03 pm Anthony Liguori

Update version for 1.6.0-rc3

Signed-off-by: Anthony Liguori <>
9d054ea5 08/12/2013 11:03 pm Anthony Liguori

Merge remote-tracking branch 'afaerber/tags/qom-cpu-for-anthony' into staging

QOM CPUState refactorings

  • Fix X86CPU Westmere CPUID for pc-*-1.4 and older
  • afaerber/tags/qom-cpu-for-anthony:
    pc: Remove PCLMULQDQ from Westmere on pc-*-1.4 and older

Conflicts:...
9fb7aaaf 08/12/2013 10:59 pm Anthony Liguori

pc: drop external DSDT loading

This breaks migration and is unneeded with modern SeaBIOS.

Signed-off-by: Anthony Liguori <>
Message-id:

7f3e341a 08/12/2013 07:20 pm Marcel Apfelbaum

hw/misc: don't create pvpanic device by default

This patch is based on Hu Tao's:
http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00124.html

No need to hard-code pvpanic as part of the machine.
It can be added with "-device pvpanic" from command line (The next patch)....
a5d3f640 08/12/2013 07:20 pm Marcel Apfelbaum

hw/misc: make pvpanic known to user

This patch is based on Hu Tao's:
http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg00125.html

The pvpanic device may be enabled now with "-device pvpanic"
from command line.

Signed-off-by: Marcel Apfelbaum <>...
56383703 08/12/2013 06:33 pm Eduardo Habkost

pc: Remove PCLMULQDQ from Westmere on pc-*-1.4 and older

Commit 41cb383f42d0cb51d8e3e25e3ecebc954dd4196f made a guest-visible
change by adding the PCLMULQDQ bit to Westmere without adding
compatibility code to keep the ABI for older machine-types.
Fix it by adding the missing compat code....
6470215b 08/12/2013 05:31 pm Michael R. Hines

rdma: proper getaddrinfo() handling

getaddrinfo() already knows what it's doing,
but it can potentially return multiple addresses.
We need to handle that...

Reviewed-by: Orit Wasserman <>
Signed-off-by: Michael R. Hines <>...
7fc5b13f 08/12/2013 05:31 pm Michael R. Hines

rdma: IPv6 over Ethernet (RoCE) is broken in linux - workaround

We've gotten reports from multiple testers (including Frank Yangjie
and myself) that RDMA IPv6 support over RocE (Ethernet) is broken
in linux.

A patch to Linux is still in review:

http://comments.gmane.org/gmane.linux.drivers.rdma/16448...
8f3067bd 08/12/2013 05:31 pm Michael R. Hines

rdma: remaining documentation fixes

Was missing 'setup-time' in some of the QMP documentation...

Signed-off-by: Michael R. Hines <>
Reviewed-by: Eric Blake <>
Message-id: ...
885e8f98 08/12/2013 05:31 pm Isaku Yamahata

rdma: use resp.len after validation in qemu_rdma_registration_stop

resp.len is given from remote host. So should be validated before use.
Otherwise memcpy can access beyond the buffer.

Cc: Michael R. Hines <>
Reviewed-by: Orit Wasserman <>...
6f1484ed 08/12/2013 05:31 pm Isaku Yamahata

rdma: validate RDMAControlHeader::len

RMDAControlHeader::len is provided from remote, so validate it.

Reviewed-by: Orit Wasserman <>
Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>...
88571882 08/12/2013 05:31 pm Isaku Yamahata

rdma: check if RDMAControlHeader::len match transferred byte

RDMAControlHeader::len is provided from remote, so check if the value
match the actual transferred byte_len.

Reviewed-by: Orit Wasserman <>
Reviewed-by: Michael R. Hines <>...
133bb095 08/12/2013 05:31 pm Paolo Bonzini

sysfw: remove read-only pc_sysfw_flash_vs_rom_bug_compatible

The variable is not written anymore.

This cleans up after 9e1c2ec (which accidentally left variable
pc_sysfw_flash_vs_rom_bug_compatible behind, value always zero), and
buries dead code from commit dafb82e (which resurrected the pc_sysfw...
a904410a 08/12/2013 05:31 pm Paolo Bonzini

pc_sysfw: remove the rom_only property

With the new semantics of pc_sysfw (no -pflash implies "old-style" ROM setup,
-pflash implies "new-style" ROM setup), there is no need anymore for a compat
property. Old machines simply will never use -pflash, and thus will always...
6dd2a5c9 08/12/2013 05:31 pm Paolo Bonzini

pc_sysfw: do not make it a device anymore

Move the code to hw/i386, the sole remaining property is available
as !pci_enabled.

Signed-off-by: Paolo Bonzini <>
Signed-off-by: Markus Armbruster <>
Message-id: ...
0b516ef0 08/12/2013 05:19 pm Stefan Weil

w32: Add missing version.o to all executables (fix regression)

QEMU executables for w32, w64 had included meta information built from
version.rc. These rules were changed several times some months ago.

The latest version added version.o to the tools, but not to the system...
cb77d192 08/12/2013 05:15 pm Markus Armbruster

qemu-option: Guard against qemu_opts_set_defaults() misuse

Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner
case, but broke it for another one that can't be reached in current
code.

Quote from its commit message:

I believe [opts_parse()] attempts to do the following:...
8571fa57 08/12/2013 05:15 pm Paolo Bonzini

LICENSE: clarify

1) The GPL says that "if the Program does not specify a version number
of this License, you may choose any version ever published by the Free
Software Foundation". This is not true, QEMU includes parts that are
v2-only.

2) Provide a default for files with no licensing information....
7748c1bd 08/12/2013 05:15 pm Paolo Bonzini

raw: add license header

Most of the block layer is under the BSD license, thus it is reasonable
to license block/raw.c the same way. CCed people should ACK by replying
with a Signed-off-by line.

Cc: Christoph Hellwig <>
Cc: Kevin Wolf <>...
3ee1ee80 08/12/2013 04:32 pm Anthony Liguori

Merge remote-tracking branch 'mst/tags/for_anthony' into staging

pci,virtio fixes for 1.6

This includes some last-minute bugfixes for 1.6.
All very small patches that also look very safe to me.

Signed-off-by: Michael S. Tsirkin <>

  1. gpg: Signature made Mon 12 Aug 2013 04:28:57 AM CDT using RSA key ID D28D5469...
6624fecd 08/12/2013 04:32 pm Anthony Liguori

Merge remote-tracking branch 'pmaydell/tags/pull-arm-devs-20130812' into staging

arm-devs queue

  1. gpg: Signature made Mon 12 Aug 2013 05:58:14 AM CDT using RSA key ID 14360CDE
  2. gpg: Can't check signature: public key not found
  1. By Peter Maydell
  2. Via Peter Maydell...
3bba9c11 08/12/2013 04:32 pm Anthony Liguori

Merge remote-tracking branch 'kwolf/for-anthony' into staging

  1. By Mike Qiu
  2. Via Kevin Wolf
    • kwolf/for-anthony:
      block: Bugfix 'format' and 'snapshot' used in drive option

Message-id:
Signed-off-by: Anthony Liguori <>
4a9a8876 08/12/2013 04:30 pm Anthony Liguori

Merge remote-tracking branch 'luiz/queue/qmp' into staging

  1. By Laszlo Ersek
  2. Via Luiz Capitulino
    • luiz/queue/qmp:
      dump: rebase from host-private RAMBlock offsets to guest-physical addresses
      dump: populate guest_phys_blocks
      dump: introduce GuestPhysBlockList...
283c8733 08/12/2013 04:30 pm Anthony Liguori

Merge remote-tracking branch 'kraxel/usb.87' into staging

  1. By Gerd Hoffmann
  2. Via Gerd Hoffmann
    • kraxel/usb.87:
      xhci: implement warm port reset

Message-id:
Signed-off-by: Anthony Liguori <>
2aa09da8 08/12/2013 04:28 pm Anthony Liguori

Merge remote-tracking branch 'origin/master' into staging

  • origin/master:
    mips: revert commit b332d24a8e1290954029814d09156b06ede358e2
    tcg/mips: fix invalid op definition errors

Necessary because patches got pushed by Aurelien before I pushed
the -rc2 tag....
f7b803b3 08/12/2013 01:57 pm Peter Maydell

hw/virtio/virtio-mmio: Make QueueNumMax read 0 for unavailable queues

The virtio-mmio spec says that QueueNumMax must read zero for queues
which are unavailable; implement this, rather than always returning
VIRTQUEUE_MAX_SIZE.

Signed-off-by: Peter Maydell <>...
3561ba14 08/12/2013 12:25 pm Michael S. Tsirkin

vhost: clear signalled_used_valid on vhost stop

When vhost device stops, its implementation synchronizes kernel state
back to virtio.c so we can continue emulating the device
in userspace.

This patch ensures that virtio.c's signalled_used_valid flag is reset so...
6793dfd1 08/12/2013 12:19 pm Stefan Hajnoczi

virtio: clear signalled_used_valid when switching from dataplane

When the dataplane thread stops, its vring.c implementation synchronizes
vring state back to virtio.c so we can continue emulating the virtio
device.

This patch ensures that virtio.c's signalled_used_valid flag is reset so...
4965b7f0 08/12/2013 12:07 pm Gerd Hoffmann

i82801b11: Fix i82801b11 PCI host bridge config space

pci_bridge_write_config() was not being used.

Cc:
Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Andreas Färber <>
Signed-off-by: Michael S. Tsirkin <>
9604f70f 08/12/2013 12:05 pm Michael S. Tsirkin

pc: disable pci-info for 1.6

The BIOS that we ship in 1.6 does not use pci info
from host (yet). Several issues turned up
(e.g. around winXP boot crashes). So it's safest to disable that
interface for 1.6 machine types for now, leave it on for 1.7
as we have enough time to fix issues if any....
6db5f5d6 08/09/2013 08:33 pm Mike Qiu

block: Bugfix 'format' and 'snapshot' used in drive option

When use -drive file='xxx',format=qcow2,snapshot=on the error
message "Can't use snapshot=on with driver-specific options"
can be show, and fail to start the qemu.

This should not be happened, and there is no file.driver option...
f6049f44 08/09/2013 06:50 pm Peter Maydell

hw/virtio/virtio: Don't allow guests to add/remove queues

A queue size of 0 is used to indicate a nonexistent queue, so
don't allow the guest to flip a queue between zero-size and
non-zero-size. Don't permit setting of negative queue sizes
either.

Signed-off-by: Peter Maydell <>...
2e985fe0 08/09/2013 12:06 am Aurelien Jarno

mips: revert commit b332d24a8e1290954029814d09156b06ede358e2

Now that this code path is not triggered anymore during the tests,
revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS
target without kernel nor bios doesn't really make sense. At the same...
85711e6b 08/09/2013 12:06 am James Hogan

tcg/mips: fix invalid op definition errors

tcg/mips/tcg-target.h defines various operations conditionally depending
upon the isa revision, however these operations are included in
mips_op_defs[] unconditionally resulting in the following runtime errors
if CONFIG_DEBUG_TCG is defined:...
5ee163e8 08/08/2013 06:01 pm Laszlo Ersek

dump: introduce GuestPhysBlockList

The vmcore must use physical addresses that are visible to the guest, not
addresses that point into linear RAMBlocks. As first step, introduce the
list type into which we'll collect the physical mappings in effect at the...
c5d7f60f 08/08/2013 06:01 pm Laszlo Ersek

dump: populate guest_phys_blocks

While the machine is paused, in guest_phys_blocks_append() we register a
one-shot MemoryListener, solely for the initial collection of the valid
guest-physical memory ranges that happens at listener registration time.

For each range that is reported to guest_phys_blocks_region_add(), we...
56c4bfb3 08/08/2013 06:01 pm Laszlo Ersek

dump: rebase from host-private RAMBlock offsets to guest-physical addresses

RAMBlock.offset --> GuestPhysBlock.target_start
RAMBlock.offset + RAMBlock.length --> GuestPhysBlock.target_end
RAMBlock.length --> GuestPhysBlock.target_end -...
2cac2607 08/08/2013 06:01 pm Laszlo Ersek

dump: clamp guest-provided mapping lengths to ramblock sizes

Even a trusted & clean-state guest can map more memory than what it was
given. Since the vmcore contains RAMBlocks, mapping sizes should be
clamped to RAMBlock sizes. Otherwise such oversized mappings can exceed...
dad5b9ea 08/08/2013 02:29 pm Gerd Hoffmann

xhci: implement warm port reset

Without this patch windows can't do port resets for usb3 devices.

https://bugzilla.redhat.com/show_bug.cgi?id=949514

Signed-off-by: Gerd Hoffmann <>
9b9734ef 08/07/2013 11:38 pm Anthony Liguori

Update version for 1.6.0-rc2

Signed-off-by: Anthony Liguori <>
6fdf98f2 08/07/2013 08:48 pm Paolo Bonzini

fw_cfg: the I/O port variant expects little-endian

The I/O port variant of fw_cfg is used by sparc64, which is a big-endian machine.
Firmware swaps bytes before sending them to fw_cfg, so we need to unswap them in
the device.

This is only used on sparc64 and on (little-endian) x86, so it does not affect...
e9a72359 08/07/2013 08:48 pm Stefan Weil

po: Update all *.po files

Running "make install" modified the *.po files because
they were no longer up to date.

Synchronize them with latest ui/gtk.c and modified build
rules which use paths relative to the project root.

Signed-off-by: Stefan Weil <>...
469296f1 08/07/2013 08:47 pm Andreas Färber

target-ppc: Turn POWER5gr CPU into alias for POWER5

Signed-off-by: Andreas Färber <>
Signed-off-by: Andreas Färber <>
Message-id:
Signed-off-by: Anthony Liguori <>
35ebcb2b 08/07/2013 08:47 pm Andreas Färber

target-ppc: Prepare POWER5P CPU family

It is ISA 2.03. Modelled as 970FX minus AltiVec flag.

Cc: Benjamin Herrenschmidt <>
Cc: Alexey Kardashevskiy <>
Signed-off-by: Andreas Färber <>
Signed-off-by: Andreas Färber <>...
f71d4c46 08/07/2013 08:47 pm Andreas Färber

target-ppc: Add POWER5+ v2.1 CPU model

Let's avoid -cpu host barfing at this PVR.
Linux recognizes it as "POWER5+ (gs) v2.1".

Signed-off-by: Andreas Färber <>
Signed-off-by: Andreas Färber <>
Message-id: ...
171777a4 08/07/2013 08:47 pm Andreas Färber

target-ppc: Turn POWER5gs CPU into alias for POWER5+

Signed-off-by: Andreas Färber <>
Signed-off-by: Andreas Färber <>
Message-id:
Signed-off-by: Anthony Liguori <>
a7d6b9f0 08/07/2013 08:47 pm Andreas Färber

target-ppc: Fix POWER7+ model

Commit 03a15a5436ed7723f406f15cc3798aa9991e75b5 claimed to add a POWER7+
model but instead added a "POWER7P" model, with an unhelpful "POWER7P"
description on top. Fix this to "POWER7+" as we already have "POWER3+",
"POWER4+" and "POWER5+" and there being no reason to deviate with the...
0dd5ce38 08/07/2013 08:46 pm Martijn van den Broek

Bugfix for loading multiboot kernels

This patch fixes a bug in rom_copy introduced by
commit d60fa42e8bae39440f997ebfe8fe328269a57d16.

rom_copy failed to load roms with a "datasize" of 0.
As a result, multiboot kernels were not loaded correctly
when they contain a segment with a "file size" of 0....
6c0f48f5 08/07/2013 08:43 pm Anthony Liguori

Merge remote-tracking branch 'afaerber/tags/qom-cpu-for-anthony' into staging

QOM CPUState refactorings

  • Clean up X86CPU error handling
  1. gpg: Signature made Tue 06 Aug 2013 01:57:34 PM CDT using RSA key ID 3E7E013F
  2. gpg: Can't check signature: public key not found...
cafffa54 08/07/2013 08:43 pm Anthony Liguori

Merge remote-tracking branch 'kwolf/for-anthony' into staging

  1. By Fam Zheng (8) and others
  2. Via Kevin Wolf
    • kwolf/for-anthony:
      vmdk: rename num_gtes_per_gte to num_gtes_per_gt
      vmdk: use heap allocation for whole_grain
      vmdk: check l1 size before opening image...
cd7b87ff 08/06/2013 08:27 pm Andreas Färber

target-i386: Fix X86CPU error handling

Error **errp argument is not for emitting warnings, it means an error
has occurred and the caller should not make any assumptions about the
state of other return values (unless otherwise documented).

Therefore cpu_x86_create() must unref the new X86CPU itself, and...
5d8caa54 08/06/2013 04:27 pm Fam Zheng

vmdk: Make VMDK3Header and VmdkGrainMarker QEMU_PACKED

It's best to make it consistent that all on disk structures are
QEMU_PACKED.

Signed-off-by: Fam Zheng <>
Signed-off-by: Kevin Wolf <>
e98768d4 08/06/2013 04:27 pm Fam Zheng

vmdk: use unsigned values for on disk header fields

The size and offset fields are all non-negative values, use uint64_t for
them to avoid getting negative in memory value by int overflow.

Signed-off-by: Fam Zheng <>
Signed-off-by: Kevin Wolf <>
23ea2ecc 08/06/2013 04:27 pm Stefan Hajnoczi

qemu-iotests: add poke_file utility function

The new poke_file function sets bytes at an offset in a file given a
printf-style format string. It can be used to corrupt an image file for
test coverage of error paths.

Signed-off-by: Stefan Hajnoczi <>...
ca6cbb65 08/06/2013 04:27 pm Fam Zheng

qemu-iotests: add empty test case for vmdk

Will add vmdk specific tests later here.

Signed-off-by: Fam Zheng <>
Signed-off-by: Kevin Wolf <>
8aa1331c 08/06/2013 04:27 pm Fam Zheng

vmdk: check granularity field in opening

Granularity is used to calculate the cluster size and allocate r/w
buffer. Check the value from image before using it, so we don't abort()
for unbounded memory allocation.

Signed-off-by: Fam Zheng <>...
f8ce0403 08/06/2013 04:27 pm Fam Zheng

vmdk: check l2 table size when opening

header.num_gtes_per_gte determines size for L2 table. Check for too big
value before using it. Limit to 512M entries (2GB per one L2 table).

Signed-off-by: Fam Zheng <>
Signed-off-by: Kevin Wolf <>
2c43e43c 08/06/2013 04:27 pm Fam Zheng

vmdk: check l1 size before opening image

L1 table size is calculated from capacity, granularity and l2 table
size. If capacity is too big or later two are too small, the L1 table
will be too big to allocate in memory. Limit it to a reasonable range.

Signed-off-by: Fam Zheng <>...
bf81507d 08/06/2013 04:27 pm Fam Zheng

vmdk: use heap allocation for whole_grain

We should never grow the stack beyond 1 MB, otherwise we'll fall off the
end. Thread stacks and coroutine stacks (1 MB) do not grow.
get_cluster_offset() allocates a big stack offset, it will fail for big
cluster images, change to heap allocated buffer....
ca8804ce 08/06/2013 04:27 pm Fam Zheng

vmdk: rename num_gtes_per_gte to num_gtes_per_gt

num_gtes_per_gte is a historical typo, rename it to a more sensible
name. It means "number of GrainTableEntries per GrainTable".

Signed-off-by: Fam Zheng <>
Signed-off-by: Kevin Wolf <>
a1fc6246 08/06/2013 02:09 pm Leon Alrae

target-mips: fix decoding of microMIPS POOL32Axf instructions

Fix incorrect assumption that DSP and non-DSP versions of the following
instructions have the same encoding:
MULT, MULTU, MADD, MADDU, MSUB, MSUBU, MFHI, MFLO, MTHI, MTLO.
Correct the existing (non-DSP) instructions and add DSP equivalents....
fc11eb26 08/06/2013 11:41 am Kevin Wolf

qemu-img: Error out for excess arguments

Don't silently ignore excess arguments at the end of the command line,
but error out instead. This can catch typos like 'resize test.img + 1G',
which doesn't increase the image size by 1G as intended, but truncates...
526eda14 08/06/2013 11:41 am MORITA Kazutaka

ignore SIGPIPE in qemu-img and qemu-io

This prevents the tools from being stopped when they write data to a
closed connection in the other side.

Signed-off-by: MORITA Kazutaka <>
Reviewed-by: Paolo Bonzini <>...
84004290 08/06/2013 11:41 am MORITA Kazutaka

iov: handle EOF in iov_send_recv

Without this patch, iov_send_recv() never returns when do_send_recv()
returns zero.

Signed-off-by: MORITA Kazutaka <>
Reviewed-by: Paolo Bonzini <>
Signed-off-by: Kevin Wolf <>
9580498b 08/06/2013 11:41 am Stefan Hajnoczi

qemu-iotests: filter QEMU version in monitor banner

Filter out the QEMU monitor version banner so that tests do not break
when the QEMU version number is changed.

Signed-off-by: Stefan Hajnoczi <>
Signed-off-by: Kevin Wolf <>
e4f5c1bf 08/06/2013 11:41 am Liu Yuan

sheepdog: add missing .bdrv_has_zero_init

Commit 3ac21627 changed the behaviour of bdrv_has_zero_init() to default
to 0. In the review for Sheepdog it turned out that enabling it is safe,
so that commit updated one BlockDriver definition of sheepdog to use...
79761c66 08/05/2013 07:48 pm Izumi Tsutsui

semaphore: fix a hangup problem under load on NetBSD hosts.

Fix following bugs in "fallback implementation of counting semaphores
with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976:
- waiting threads are not restarted properly if more than one threads...
66988941 08/05/2013 07:47 pm Michael R. Hines

rdma: correct newlines in error statements

Don't print newlines on the error_setg() function,
but still allow newlines on fprintf().

Signed-off-by: Michael R. Hines <>
Message-id: ...
44b59494 08/05/2013 07:47 pm Isaku Yamahata

rdma: don't use negative index to array

Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael R. Hines <>
Message-id: ...
1f22364b 08/05/2013 07:47 pm Isaku Yamahata

rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX

RDMA_WRID_CONTROL should be used. And remove related work around.

Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael R. Hines <>...
87772639 08/05/2013 07:47 pm Isaku Yamahata

rdma: use RDMA_WRID_READY

Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael R. Hines <>
Message-id: ...
e1d0fb37 08/05/2013 07:47 pm Isaku Yamahata

rdma: memory leak RDMAContext::host

It is allocated by g_strdup(), so needs to be freed.

Reviewed-by: Michael R. Hines <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael R. Hines <>...
b58c8552 08/05/2013 07:47 pm Michael R. Hines

rdma: bugfix: make IPv6 support work

RDMA does not use sockets, so we cannot use many of the socket
helper functions, but we do use inet_parse() which gives
RDMA all the necessary details of the connection parameters.

However, when testing with libvirt, a simple IPv6 migration test failed...
8cd31adc 08/05/2013 07:47 pm Michael R. Hines

rdma: forgot to turn off the debugging flag

Ooops. We forgot to turn off the flag.

Signed-off-by: Michael R. Hines <>
Message-id:
Signed-off-by: Anthony Liguori <>