Statistics
| Branch: | Revision:

root / util / qemu-option.c @ 6a1751b7

History | View | Annotate | Download (29.3 kB)

# Date Author Comment
cb77d192 08/12/2013 05:15 pm Markus Armbruster

qemu-option: Guard against qemu_opts_set_defaults() misuse

Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner
case, but broke it for another one that can't be reached in current
code.

Quote from its commit message:

I believe [opts_parse()] attempts to do the following:...
e8cd45c7 07/30/2013 03:33 am Vasilis Liaskovitis

qdev: Add SIZE type to qdev properties

This patch adds a 'SIZE' type property to qdev.

Signed-off-by: Ian Molton <>
Signed-off-by: Vasilis Liaskovitis <>
Signed-off-by: Hu Tao <>...
0dd6c526 07/26/2013 10:10 pm Kevin Wolf

QemuOpts: Add qemu_opt_unset()

Signed-off-by: Kevin Wolf <>
Reviewed-by: Eric Blake <>
6d4cd408 07/09/2013 09:38 pm Markus Armbruster

qemu-option: Fix qemu_opts_set_defaults() for corner cases

Commit 4f6dd9a changed the initialization of opts in opts_parse() to
this:

if (defaults) {
        if (!id && !QTAILQ_EMPTY(&list->head)) {
            opts = qemu_opts_find(list, NULL);
        } else {...
96bc97eb 07/09/2013 09:38 pm Markus Armbruster

qemu-option: Fix qemu_opts_find() for null id arguments

Crashes when the first list member has an ID. Admittedly nonsensical
reproducer:

$ qemu-system-x86_64 -nodefaults -machine id=foo -machine ""

Signed-off-by: Markus Armbruster <>
Reviewed-by: Peter Maydell <>...
a86b35f9 06/19/2013 10:10 pm Markus Armbruster

qemu-option: check_params() is now unused, drop it

Signed-off-by: Markus Armbruster <>
Reviewed-by: Anthony Liguori <>
Message-id:
Signed-off-by: Anthony Liguori <>
376609cc 03/15/2013 05:07 pm Kevin Wolf

qemu-option: Add qemu_opts_absorb_qdict()

This adds a function that adds all entries of a QDict to a QemuOpts if
the keys are known, and leaves only the rest in the QDict.

This way a single QDict of -drive options can be processed in multiple
places (generic block layer, block driver, backing file block driver,...
7216ae3d 02/11/2013 04:13 pm Markus Armbruster

qemu-option: Disable two helpful messages that got broken recently

commit 8be7e7e4 and commit ec7b2ccb messed up the ordering of error
message and the helpful explanation that should follow it, like this:

$ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,...
c64f50d1 01/30/2013 12:14 pm Markus Armbruster

g_strdup(NULL) returns NULL; simplify

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Signed-off-by: Stefan Hajnoczi <>
baacf047 01/12/2013 07:42 pm Paolo Bonzini

build: move libqemuutil.a components to util/

Signed-off-by: Paolo Bonzini <>