History | View | Annotate | Download (31.5 kB)
vhost: memory sync fixes
This fixes two bugs related to memory sync duringmigration: - ram address calculation was missing the chunk address, so the wrong page was dirtied - one after last was used instead of the end address of a region, which might overflow to 0...
vhost: multiqueue support
This patch lets vhost support multiqueue. The idea is simple, just launchingmultiple threads of vhost and let each of vhost thread processing a subset ofthe virtqueues of the device. After this change each emulated device can have...
g_malloc(0) and g_malloc0(0) return NULL; simplify
Once upon a time, it was decided that qemu_malloc(0) should abort.Switching to glib retired that bright idea. Some code that was addedto cope with it (e.g. in commits 702ef63, b76b6e9) is still around....
vhost: set started flag while start is in progress
This makes it possible to use started flag for sanity checkingof callbacks that happen during start/stop.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
vhost: backend masking support
Support backend guest notifier masking in vhost-net:create eventfd at device init, when masked,make vhost use that as eventfd instead ofsending an interrupt.
virtio: don't waste irqfds on control vqs
Pass nvqs to set_guest_notifiers. This makes it possible tosave on irqfds by not allocating one for the control vqfor virtio-net.
misc: move include files to include/qemu/
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
exec: move include files to include/exec/
Rename target_phys_addr_t to hwaddr
target_phys_addr_t is unwieldly, violates the C standard (_t suffixes arereserved) and its purpose doesn't match the name (most target_phys_addr_taddresses are not target specific). Replace it with a finger-friendly,...
memory: use AddressSpace for MemoryListener filtering
Using the AddressSpace type reduces confusion, as you can't accidentallysupply the MemoryRegion you're interested in.
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>Signed-off-by: Avi Kivity <avi@redhat.com>
vhost: use MemoryListener filtering to only monitor RAM address space
Instead of checking manually, let the listener filter for us. This preparesus for DMA address spaces.
Signed-off-by: Avi Kivity <avi@redhat.com>
vhost: Pass device path to vhost_dev_init()
The path to /dev/vhost-net is currently hardcoded in vhost_dev_init().This needs to be changed so that /dev/vhost-scsi can be used. Pass inthe device path instead of hardcoding it.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>...
memory: pass EventNotifier, not eventfd
Under Win32, EventNotifiers will not have event_notifier_get_fd, so wecannot call it in common code such as hw/virtio-pci.c. Pass a pointer tothe notifier, and only retrieve the file descriptor in kvm-specific code....
vhost: Fix size of dirty log sync on resize
When the vhost log is resized, we want to sync up tothe size of the old log. With that end address in place,ignore regions that start after then end rather thanhitting assert.
This also addresses the following crash report:...
vhost: readd assert statement
It's clear from the surrounding code thatstart < end so it's enough to assert end < log_size.However, it's better to make this explicit in casewe refactor the code again.
memory: allow MemoryListeners to observe a specific address space
Ignore any regions not belonging to a specified address space.
memory: support stateless memory listeners
Current memory listeners are incremental; that is, they are expected tomaintain their own state, and receive callbacks for changes to that state.
This patch adds support for stateless listeners; these work by receiving...
memory: switch memory listeners to a QTAILQ
This allows reverse iteration, which in turns allows consistent orderingamong multiple listeners:
l1->add l2->add l2->del l1->del
Signed-off-by: Avi Kivity <avi@redhat.com>Reviewed-by: Richard Henderson <rth@twiddle.net>
memory: move ioeventfd ops to MemoryListener
This way the accelerator (kvm) can handle them directly.
memory: change dirty setting APIs to take a size
Instead of each target knowing or guessing the guest page size,just pass the desired size of dirtied memory area.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
prepare for future GPLv2+ relicensing
All files under GPLv2 will get GPLv2+ changes starting tomorrow.event_notifier.c and exec-obsolete.h were only ever touched by Red Hatemployees and can be relicensed now.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>...
vhost: improve region filtering
vhost memory management doesn't care about non-memory (e.g. PIO) or non-RAMregions. Adjust the filtering to reflect that, and move it earlier so itapplies to mem_sections too.
Signed-off-by: Avi Kivity <avi@redhat.com>...
vhost: fix mem_sections memory corruption
A memset() used to delete an entry in an array did not take into accountthe array element's size.
Signed-off-by: Avi Kivity <avi@redhat.com>Acked-by: Michael S. Tsirkin <mst@redhat.com>
vhost: fix incorrect userspace address
MemoryListener::region_add() gives us a slice of a MemoryRegion, not aregion. Adjust the userspace address to reflect that.
vhost: avoid cpu_get_physical_page_desc()
This reaches into the innards of the memory core, which are beingchanged. Switch to a memory API version.
vhost: convert to MemoryListener API
Drop the use of cpu_register_phys_memory_client() in favour of the newMemoryListener API. The new API simplifies the caller, since there is noneed to deal with splitting and merging slots; however this is not exploited...
vhost-net: cleanup host notifiers at last step
When the vhost notifier is disabled, the userspace handler runsimmediately: virtio_pci_set_host_notifier_internal mightcall virtio_queue_notify_vq.Since the VQ state and the tap backend state aren'trecovered yet, this causes...
Use glib memory allocation and free functions
qemu_malloc/qemu_free no longer exist after this commit.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
vhost: remove an incorrect assert
The 'to' can go negative when the first region gets removed(it gets incremented by to 0 immediately afterward), whichmakes the assertion fail. Nothing breaks ifto < 0 here so just remove the assert.
Tested-by: David Ahern <daahern@cisco.com>...
vhost: fix double free on device stop
vhost dev stop failed to clear the log field.Typically not an issue as dev start overwrites this field,but if logging gets disabled before the following start,it doesn't so this causes a double free.
vhost: optimize out no-change assignment
Cirrus VGA (at least) calls register memory regionwith the same values again and again. Theregistration in vhost-net slows this a lot,optimize by checking that the same data is already registered.
vhost: skip memory which needs dirty logging
vhost doesn't support write logging(except for migration), anyway.
cpu: add set_memory flag to request dirty logging
Pass the flag to all cpu notifiers, doingnothing at this point. Will be used byfollow-up patches.
vhost: fix dirty page handling
vhost was passing a physical address to cpu_physical_memory_set_dirty,which is wrong: we need to translate to ram address first.
Note: this lead to crashes during migration, so the patch...
Introduce log_start/log_stop in CPUPhysMemoryClient
In order to use log_start/log_stop with Xen as well in the vga code,this two operations have been put in CPUPhysMemoryClient.
The two new functions cpu_physical_log_start,cpu_physical_log_stop areused in hw/vga.c and replace the kvm_log_start/stop. With this, vga does...
vhost: force vhost off for non-MSI guests
When MSI is off, each interrupt needs to be bounced through the iothread when it's set/cleared, so vhost-net causes more context switches andhigher CPU utilization than userspace virtio which handles networking in...
vhost: Fix address calculation in vhost_dev_sync_region()
We still need advance address even we find there's no dirty pages incurrent chunk.
Signed-off-by: Jason Wang <jasowang@redhat.com>Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
virtio: change set guest notifier to per-device
When using irqfd with vhost-net to inject interrupts,a single evenfd might inject multiple interrupts.Implementing this is much easier with a singleper-device callback to set guest notifiers.
vhost: error code
fix up errors returned to include errno, not just -1
Introduce range.h
Extract range functions from pci.h. These will be used by later patchesby non-PCI devices. Adjust current users.
Remove unused eventfd.h
This header is not present on my system and causes a buildfailure, but is also not used in these files, so remove it.
Signed-off-by: Mike McCormack <mikem@ring3k.org>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
vhost: fix miration during device start
We need to know ring layout to allocate log buffer.So init rings first.
Also fixes a theoretical memory-leak-on-error.
https://bugzilla.redhat.com/show_bug.cgi?id=615228
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>...
vhost.c: include <linux/vhost.h> last
So the userspace headers define KERNEL_STRICT_NAMES and there's noconflict on type definition for older kernels.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>Acked-by: Michael S. Tsirkin <mst@redhat.com>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
win32: Fix compiler errors from u_int64_t
u_int64_t raises compiler error messages:
CC libhw32/virtio.o/qemu/ar7/hw/virtio.c: In function ‘virtio_queue_get_avail_size’:/qemu/ar7/hw/virtio.c:776: error: ‘u_int64_t’ undeclared (first use in this function)...
vhost: vhost net support
This adds vhost net device support in qemu. Will be tied to tap deviceand virtio by following patches. Raw backend is currently missing,will be worked on/submitted separately.