qapi: fix memleak by adding implict struct functions in dealloc visitor
Otherwise member "base" is leaked in a qapi_free_STRUCTURE() call.
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>Reviewed-by: Eric Blake <eblake@redhat.com>Message-id: 1383676551-18806-2-git-send-email-xiawenc@linux.vnet.ibm.com...
qemu-ga: Add interface to traverse the qmp command list by QmpCommand
In the original code, qmp_get_command_list is used to constructa list of all commands' name. To get the information of all qgacommands, it traverses the name list and search the command info...
qemu-ga: Extend 'guest-info' command to expose flag 'success-response'
Now we have several qemu-ga commands not returning response on success.It has been documented in qga/qapi-schema.json already. This patch exposesthe 'success-response' flag by extending 'guest-info' command. With this...
OptsVisitor: don't try to flatten overlong integer ranges
Prevent mistyped command line options from incurring high memory and CPUusage at startup. 64K elements in a range should be enough for everyone(TM).
The OPTS_VISITOR_RANGE_MAX macro is public so that unit tests can...
OptsVisitor: introduce basic list modes
We're going to need more state while processing a list of repeatedoptions. This change eliminates "repeated_opts_first" and adds a new statevariable:
list_mode repeated_opts repeated_opts_first -------------- ------------- -------------------...
OptsVisitor: introduce list modes for interval flattening
The new modes are equal-rank, exclusive alternatives of LM_IN_PROGRESS.Teach opts_next_list(), opts_type_int() and opts_type_uint64() to handlethem.
Also enumerate explicitly what functions are valid to call in what modes:...
OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS
When a well-formed range value, bounded by signed integers, is encounteredwhile processing a repeated option, enter LM_SIGNED_INTERVAL and returnthe low bound.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>...
OptsVisitor: rebase opts_type_uint64() to parse_uint_full()
Simplify the code in preparation for the next patch.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>Tested-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
OptsVisitor: opts_type_uint64(): recognize intervals when LM_IN_PROGRESS
When a well-formed range value, bounded by unsigned integers, isencountered while processing a repeated option, enter LM_UNSIGNED_INTERVALand return the low bound.
qapi: make visit_type_size fallback to type_int
Currently visit_type_size checks if the visitor's type_size function pointer isNULL. If not, it calls it, otherwise it calls v->type_uint64(). But neither ofthese pointers are ever set. Fallback to calling v->type_int() in this third...
qapi: Add consume argument to qmp_input_get_object()
This allows to just look at the next element without actually consumingit.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>Reviewed-by: Eric Blake <eblake@redhat.com>
qapi: Anonymous unions
The discriminator for anonymous unions is the data type. This allows tohave a union type that allows both of these:
{ 'file': 'my_existing_block_device_id' } { 'file': { 'filename': '/tmp/mydisk.qcow2', 'read-only': true } }...
qapi: Add visitor for implicit structs
These can be used when an embedded struct is parsed and members notbelonging to the struct may be present in the input (e.g. parsing aflat namespace QMP union, where fields from both the base and oneof the alternative types are mixed in the JSON object)...
qapi: Fix unchecked strdup() by converting to g_strdup()
Note that we already free with g_free().
Signed-off-by: Markus Armbruster <armbru@redhat.com>Reviewed-by: Eric Blake <eblake@redhat.com>Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
build: move base QAPI files to libqemuutil.a
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
misc: move include files to include/qemu/
qapi: move include files to include/qobject/
qapi: move inclusions of qemu-common.h from headers to .c files
qapi: remove qapi/qapi-types-core.h
The file is only including error.h and qerror.h. Prefer explicitinclusion of whatever files are needed.Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
qapi: make struct Visitor opaque
Move its definition from qapi-visit-core.h to qapi-visit-impl.h.Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
qapi/qmp-registry.c: Include headers it needs
Include:- <glib.h> for g_malloc0()- <string.h> for strcmp()
Some of those headers were probably being included by accident becausesome other headers were including qemu-common.h, but those headersshould eventually stop including qemu-common.h....
qapi: fix qapi_dealloc_type_size parameter type
The second parameter to qapi_dealloc_type_size should be a uint64_t *,not a size_t *. This was causing our 32 bit x86 build to fail, sincewarnings are treated as errors.
Signed-off-by: Bruce Rogers <brogers@suse.com>...
qapi: handle visitor->type_size() in QapiDeallocVisitor
visit_type_size() requires either visitor->type_size() orvisitor_uint64() to be implemented, otherwise a NULL function pointer isinvoked.
It is possible to trigger this crash as follows:
$ qemu-system-x86_64 -netdev tap,sndbuf=0,id=netdev0 \...
build: opts-visitor is not really part of QAPI
It is only used by QEMU itself, do not build it into the tests.
qapi: Fix memory leak
valgrind report:
qemu-ga: switch to the new error format on the wire
IMPORTANT: this BREAKS qemu-ga compatibility for the error response.
Instead of returning something like:
{ "error": { "class": "InvalidParameterValue", "data": {"name": "mode", "expected": "halt|powerdown|reboot" } } }...
error: drop error_get_qobject()/error_set_qobject()
error_get_qobject() is unused since last commit, error_set_qobject()has never been used. Also drops error_int.h.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>Reviewed-by: Markus Armbruster <armbru@redhat.com>
qapi: fix error propagation
Don't overwrite / leak previously set errors.Make traversal cope with missing mandatory sub-structs.Don't try to end a container that could not be started.
v1->v2:- unchanged
v2->v3:- instead of examining, assert that we never overwrite errors with...
qapi: introduce "size" type
v1->v2:- fall back to uint64 rather than int
Signed-off-by: Laszlo Ersek <lersek@redhat.com>Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
qapi: introduce OptsVisitor
This visitor supports parsing
-option [type=]discriminator[,optarg1=val1][,optarg2=val2][,...]
style QemuOpts objects into "native" C structures. After defining the typetree in the qapi schema (see below), a root type traversal with this...
qapi: input_type_enum(): fix error message
The enum string is pointed to by 'enum_str' not 'name'. This bugcauses the error message to be:
{ "error": { "class": "InvalidParameter", "desc": "Invalid parameter 'null'", "data": { "name": "null" } } }...
qmp: do not include monitor.h from qapi-types-core.h
The comment is stale, monitor.h is not needed anymore (only qerror.his, because it contains the schema for errors).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
qapi: Add Visitor interfaces for uint*_t and int*_t
This adds visitor interfaces for fixed-width integers types.Implementing these in visitors is optional, otherwise we fall back tovisit_type_int() (int64_t) with some additional bounds checking to avoid...
qapi: String visitor, use %f representation for floats
Currently string-output-visitor formats floats as %g, which is nice inthat trailing 0's are automatically truncated, but otherwise this causessome issues:
- it uses 6 significant figures instead of 6 decimal places, which...
build: move qapi/ objects to nested Makefile.objs
qapi: add support for command options
Options allow for changes in commands behavior. This commit introducesthe QCO_NO_SUCCESS_RESP option, which causes a command to not emit asuccess response.
This is needed by commands such as qemu-ga's guest-shutdown, which...
qapi: QMP input visitor, handle floats parsed as ints
JSON numbers can be interpreted as either integers or floating pointvalues depending on their representation. As a result, QMP input visitormight visit a QInt when it was expecting a QFloat, so add handling to...
qemu-ga: add a whitelist for fsfreeze-safe commands
Currently we rely on fsfreeze/thaw commands disabling/enabling loggingthen having other commands check whether logging is disabled to avoidexecuting if they aren't safe for running while a filesystem is frozen....
qapi: g_hash_table_find() instead of GHashTableIter.
GHashTableIter was first introduced in glib 2.16.This patch removes it in favor of older g_hash_table_find()for better compatibility with RHEL5.
Signed-off-by: NODA, Kai <nodakai@gmail.com>Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
qapi: add strict mode to input visitor
While QMP in general is designed so that it is possible to ignoreunknown arguments, in the case of the QMP server it is better toreject them to detect bad clients. In fact, we're already doingthis at the top level in the argument checker. To extend this to...
qapi: place outermost object on qiv stack
This is a slight change in the implementation of QMPInputVisitorthat helps when adding strict mode.
Const QObjects cannot be inc/decref-ed, and that's why QMPInputVisitorrelies heavily on weak references to inner objects. I'm not removing...
qapi: untangle next_list
Right now, the semantics of next_list are complicated. The caller must:
qapi: fix memory leak on error
QmpInputVisitor would leak the malloced struct if the stack wasoverflowed. This can be easily fixed using error_propagate.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>...
qapi: fail hard on stack imbalance
QmpOutputVisitor will segfault if an imbalanced end function iscalled. So we can abort in QmpInputVisitor too.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
qapi: fix double free in qmp_output_visitor_cleanup()
Stack entries in QmpOutputVisitor are navigation links (weak references),except the bottom (ie. least recently added) entry, which owns the rootQObject [1]. Make qmp_output_visitor_cleanup() drop the stack entries,...
qapi: allow sharing enum implementation across visitors
Most visitors will use the same code for enum parsing. Move it tothe core.
qapi: drop qmp_input_end_optional
This method is optional, do not implement it if it is empty.
qapi: add string-based visitors
String based visitors provide a consistent interface for parsingstrings to C values, as well as consuming C values as strings.They will be used to parse command-line options.
qapi: protect against NULL QObject in qmp_input_get_object
A NULL qobj can occur when a parameter is fetched via qdict_get, butthe parameter is not in the command. By returning NULL, the caller canchoose whether to raise a missing parameter error, an invalid parameter...
guest agent: add RPC blacklist command-line option
This adds a command-line option, -b/--blacklist, that accepts acomma-seperated list of RPCs to disable, or prints a list ofavailable RPCs if passed "?".
In consequence this also adds general blacklisting and RPC listing...
guest agent: add supported command list to guest-info RPC
Not that there is blacklisting functionality we can no longer inferthe agent's capabilities via version. This patch extends the currentguest-info RPC to also return a list of dictionaries containing the name...
qapi: Check for negative enum values
We don't currently check for negative enum values in qmp_output_type_enum(),this will very likely generate a segfault when triggered.
However, it seems that no code in tree can trigger this today.
Acked-by: Michael Roth <mdroth@linux.vnet.ibm.com>...
qapi: add code generation support for middle mode
To get the ball rolling merging QAPI, this patch introduces a "middle mode" tothe code generator. In middle mode, the code generator generates marshallingfunctions that are compatible with the current QMP server. We absolutely need...
qapi: dealloc visitor, fix premature free and iteration logic
Currently we do 3 things wrong:
1) The list iterator, in practice, is used in a manner where the pointerwe pass in is the same as the pointer we assign the output to fromvisit_next_list(). This causes an infinite loop where we keep freeing...
qapi: dealloc visitor, support freeing of nested lists
Previously our logic for keeping track of when we're visiting the headof a list was done via a global bool. This can be overwritten if dealingwith nested lists, so use stack entries to track this instead....
qapi: modify visitor code generation for list iteration
Modify logic such that we never assign values to the list head argumentto progress through the list on subsequent iterations, instead rely onlyon having our return value passed back in as an argument on the next...
Use glib memory allocation and free functions
qemu_malloc/qemu_free no longer exist after this commit.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
qapi: add QMP command registration/lookup functions
Registration/lookup functions for that provide a lookup table fordispatching QMP commands.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>Signed-off-by: Luiz Capitulino <lcapitulino@gmail.com>
qapi: add QMP dispatch functions
Given an object recieved via QMP, this code uses the dispatch tableprovided by qmp_registry.c to call the corresponding marshalling/dispatchfunction and format return values/errors for delivery to the QMP.Currently only synchronous QMP functions are supported, but this will...
qapi: add QAPI visitor core
Base definitions/includes for Visiter interface used by generatedvisiter/marshalling code.
Includes a GenericList type. Our lists require an embedded element.Since these types are generated, if you want to use them in a different...
qapi: add QMP input visitor
A type of Visiter class that is used to walk a qobject'sstructure and assign each entry to the corresponding native C type.Command marshaling function will use this to pull out QMP commandparameters recieved over the wire and pass them as native arguments...
qapi: add QMP output visitor
Type of Visiter class that serves as the inverse of the input visitor:it takes a series of native C types and uses their values to construct acorresponding QObject. The command marshaling/dispatcher functions willuse this to convert the output of QMP functions into a QObject that can...
qapi: add QAPI dealloc visitor
Type of Visitor class that can be passed into a qapi-generated Ctype's visitor function to free() any heap-allocated data types.