Statistics
| Branch: | Revision:

root / qga @ a2623021

Name Size
Makefile.objs 317 Bytes
channel-posix.c 7.7 kB
channel-win32.c 9.5 kB
channel.h 912 Bytes
commands-posix.c 27.9 kB
commands-win32.c 7 kB
commands.c 2 kB
guest-agent-command-state.c 1.6 kB
guest-agent-core.h 1.2 kB
main.c 26.3 kB
qapi-schema.json 13.4 kB
service-win32.c 3 kB
service-win32.h 809 Bytes

Latest revisions

# Date Author Comment
e4ada482 01/19/2013 12:24 pm Stefan Weil

Replace non-portable asprintf by g_strdup_printf

g_strdup_printf already handles OOM errors, so some error handling in
QEMU code can be removed.

Signed-off-by: Stefan Weil <>
Signed-off-by: Blue Swirl <>
2fd3402d 01/16/2013 12:50 am Anthony Liguori

Merge remote-tracking branch 'mdroth/qga-pull-1-14-2013-2' into staging

  • mdroth/qga-pull-1-14-2013-2:
    qga: add missing commas in json docs

Signed-off-by: Anthony Liguori <>
01b87f6d 01/15/2013 12:15 am Eric Blake

qga: add missing commas in json docs

  • qga/qapi-schema.json: Use valid JSON.

Signed-off-by: Eric Blake <>
Signed-off-by: Michael Roth <>
7868181f 01/14/2013 08:08 pm Markus Armbruster

qemu-ga: Handle errors uniformely in ga_channel_open()

We detect errors in several places. One reports with g_error(), which
calls abort(), the others report with g_critical(). Three of them
exit(), three return false.

Always report with g_critical(), and return false....
d4f4a3ef 01/14/2013 08:07 pm Markus Armbruster

qemu-ga: Plug fd leak on ga_channel_open() error paths

Spotted by Coverity.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Reviewed-by: Michael Roth <>
Reviewed-by: Luiz Capitulino <>...
32c16620 01/14/2013 08:07 pm Markus Armbruster

qemu-ga: Plug fd leak on ga_channel_listen_accept() error path

Spotted by Coverity.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Reviewed-by: Michael Roth <>
Reviewed-by: Luiz Capitulino <>...
03ac10f1 01/14/2013 08:07 pm Markus Armbruster

qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path

Spotted by Coverity. Also document why we keep it open on success.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Reviewed-by: Michael Roth <>...
5d27f9ce 01/14/2013 08:07 pm Markus Armbruster

qemu-ga: Drop pointless lseek() from ga_open_pidfile()

After open(), the file offset is already zero, and neither lockf() nor
ftruncate() change it.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Reviewed-by: Michael Roth <>...
f5b79578 01/14/2013 08:00 pm Markus Armbruster

qemu-ga: Document intentional fall through in channel_event_cb()

For clarity, and to hush up Coverity.

Signed-off-by: Markus Armbruster <>
Reviewed-by: Eric Blake <>
Reviewed-by: Michael Roth <>...
9e92f6d4 01/14/2013 08:00 pm Luiz Capitulino

qemu-ga: add ga_open_logfile()

This function sets O_CLOEXEC on the log file fd so that it isn't
leaked to executed processes.

Signed-off-by: Luiz Capitulino <>
Reviewed-by: Eric Blake <>
Acked-by: Amos Kong <>...

View revisions

Also available in: Atom