clean up env->current_tb
There are three paths from the innermost while loop of cpu_execto the top of the outermost for loop. Two do not resetenv->current_tb. Fix this.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
add assertions about env->current_tb
By virtue of the previous patch env->current_tb will always be NULL atthe top of cpu_exec's outermost for loop, and at the end of the innermostwhile loop.
change while to if
The while loop will be executed exactly 0 or 1 times, depending onenv->exit_request.
remove assertions
avoid unreachable statement after break
raw-posix: Detect CDROM via ioctl on linux
Current CDROM detection is hardcoded based on source file name.Make this smarter on linux by attempting a CDROM specific ioctl.
This makes '-cdrom /dev/sr0' succeed with no media present.
v2: Give ioctl check higher priority than filename check....
raw-posix: Detect legacy floppy via ioctl on linux
Current legacy floppy detection is hardcoded based on source filename. Make this smarter on linux by attempting a floppy specificioctl.
v2: Give ioctl check higher priority than filename check s/IDE/legacy/...
char: Remove redundant qemu_chr_generic_open() call.
qemu_chr_open_fd() calls qemu_chr_generic_open(),so qemu_chr_open_tty() doesn't need to call it.
Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
VNC: Use 'enabled' key instead of 'status'
Currently the 'status' key is a string whose value can be"disabled" or "enabled", change it to the QMP's standard'enabled' key, which is a bool.
Note that 'status' in being dropped and this wouldn't beallowed if QMP were stable....
VNC: Make 'auth' key mandatory
There is no reason to have it as optional and the codein the server and client gets slightly simpler if thekey is mandatory.
While there also do some cleanup on how the server info iscollected.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>...
View all revisions | View revisions
Also available in: Atom