History | View | Annotate | Download (3.2 kB)
nbd-server-add: Fix the default for 'writable'
The documentation to this monitor command tells, that 'writable'argument is optional and defaults to false. However, the code setstrue as the default. But since some applications may already beenusing this, it's safer to fix the code and not documentation which...
nbd: fix nbd_server_stop crash when no server was running
This failed on the new assertion of qemu_set_fd_handler2:
qemu-system-x86_64: /home/pbonzini/work/upstream/qemu/iohandler.c:60: qemu_set_fd_handler2: Assertion `fd >= 0' failed.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
nbd: force read-only export for read-only devices
This is the desired behavior for HMP, but it is a better choice for QMP as well.
nbd: disallow nbd-server-add before nbd-server-start
It works nicely with the QMP commands, but it adds useless complicationwith HMP. In particular, see the following:
(qemu) nbd_server_add -w scsi0-hd0 (qemu) nbd_server_start -a localhost:10809...
qmp: add NBD server commands
Adding an NBD server inside QEMU is trivial, since all the logic isin nbd.c and can be shared easily between qemu-nbd and QEMU itself.The main difference is that qemu-nbd serves a single unnamed export,while QEMU serves named exports....