target-s390: Reorg exception handling
Make the user path more like the system path. Prepare for more kindsof runtime exceptions. Rename ILC to ILEN to make it clear that wewant to pass around a full instruction length, rather than a "code" that happens to be stored one bit left in a larger field....
target-s390: Convert ADD HALFWORD
Signed-off-by: Richard Henderson <rth@twiddle.net>
target-s390: Fix gdbstub
The real gdb protocol doesn't split out pc or cc as real registers.Those are pseudos that are extracted as needed from the PSW. Don'tmodify env->cc_op during read -- that way lies heisenbugs.
Fill in the XXX for the fp registers....
target-s390: Add missing temp_free in gen_op_calc_cc
target-s390: Use TCG registers for FPR
At the same time, tidy other usages of tcg_gen_deposit_i64.In some cases we can "type cast" rather than extend, and inothers we can allow tcg_gen_deposit_i64 itself to optimizethe HOST_LONG_BITS==32 case.
target-s390: Register helpers
Which highlights a lot of cc helpers that no longer exist.
target-s390: Fix SACF exit
DISAS_EXCP is exit via exception; we wanted DISAS_JUMP.This matters when we start cleaning up the TB exit paths.
target-s390: Fix BCR
There were are two exit paths for which we forgot tocopy s->cc_op back to the tcg register.
target-s390: Tidy unconditional BRCL
Yes, we're about to rewrite all of this, but having this unconditionaljump recompute cc_op is a large source of "false diff errors" whentrying to examine before and after dumps.
target-s390: Fix PSW_MASK handling
We were treating psw.mask as the 32-bit quantity it is in ESA mode.In particular, the CC field was at the wrong place.
target-s390: Add format based disassassmbly infrastructure
target-s390: Split out disas_jcc
Lots of duplicated code replaced with a couple of tables. We no longerattempt to manually invert the logic operation: the comments now matchthe code. In the fully general test, constant propagate (1 << (3 - cc))into (8 >> cc)....
target-s390: Disassemble more z10 and z196 opcodes
Also fix disassembly for COMPARE AND BRANCH. The table must besorted by primary opcode, and several were out of place.
target-s390: Fix disassembly of cpsdr
hw/i386: Fix broken build for non POSIX hosts
pc-testdev.c cannot be compiled with MinGW (and other non POSIX hosts):
CC i386-softmmu/hw/i386/../pc-testdev.oqemu/hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not foundqemu/hw/i386/../pc-testdev.c: In function ‘test_flush_page’:...
softfloat: Implement uint64_to_float128
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>Signed-off-by: Richard Henderson <rth@twiddle.net>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
softfloat: Fix uint64_to_float64
The interface to normalizeRoundAndPackFloat64 requires that thehigh bit be clear. Perform one shift-right-and-jam if needed.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>Signed-off-by: Richard Henderson <rth@twiddle.net>...
Merge remote-tracking branch 'stefanha/trivial-patches' into staging
Merge remote-tracking branch 'kraxel/testdev.1' into staging
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Merge remote-tracking branch 'kraxel/acpi.2' into staging
hw/mcf5206: Reduce size of lookup table
This typically reduces the size from 512 bytes to 128 bytes.
Signed-off-by: Stefan Weil <sw@weilnetz.de>Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
linux-user/syscall.c: remove forward declarations
instead use the correct headers that define these functions.
Requested-by: Stefan Weil <sw@weilnetz.de>Signed-off-by: John Spencer <maillist-qemu@barfooze.de>Reviewed-by: Amos Kong <kongjianjun@gmail.com>...
spice: drop incorrect vm_change_state_handler() opaque
The spice_server pointer is a global variable andvm_change_state_handler() therefore does not use its opaque parameter.
The vm change state handler is added with a pointer to the spice_serverpointer. This is useless and we probably would not want 2 levels of...
pc_sysfw: Check for qemu_find_file() failure
pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happilycreates a drive without a medium.
When pc_system_flash_init() asks for its size, bdrv_getlength() failswith -ENOMEDIUM, which isn't checked either. It fails relatively...
pseries: Remove unneeded include statement (fixes MinGW builds)
sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,so remove it.
Remove --sparc_cpu option from the configure list
commit 9b9c37c36439ee0452632253dac7a31897f27f70 always assume sparcv9,the others are no longer supported. Remove --sparc_cpu option from theconfigure list.
Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>...
pc: remove bochs bios debug ports
Prehistoric leftover, zap it. We poweroff via acpi these days.
And having a port (0x501,0x502) where any random guest write will makeqemu exit -- with no way to turn it off -- is a bad joke anyway.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw: Add test device for unittests execution
Add a test device which supports the kvmctl ioports,so one can run the KVM unittest suite.
Intended Usage:
qemu-system-x86_64 -nographic \ -device pc-testdev \ -device isa-debug-exit,iobase=0xf4,iosize=0x04 \...
switch debugcon to memory api
Also some QOM glue while being at it.
add isa-debug-exit device.
When present it makes qemu exit on any write.Mapped to port 0x501 by default.
Without this patch Anthony doesn't allow me toremove the bochs bios debug ports because histest suite uses this.
configure: also symlink *.aml files
acpi: autoload dsdt
apci: assign memory regions to piix4 acpi device
Get rid of get_system_io() usage.
apci: assign memory regions to ich9 lpc device
pty: unbreak libvirt
Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt ptysupport because it tried to figure the pts name from stderr output.
Fix this by moving the label to the end of the line, this way thelibvirt parser does still recognise the message. libvirt looks...
dataplane: use linux-headers/ for virtio includes
The hw/dataplane/vring.c code includes linux/virtio_ring.h. Ensure thatwe use linux-headers/ instead of the system-wide headers, which may beout-of-date on older distros.
This resolves the following build error on Debian 6:...
configure: Write new file "config-all-disas.mak" when running configure
Incremental builds added new lines to that file each time when configurewas run.
Now a new file with a comment line is written.
Signed-off-by: Stefan Weil <sw@weilnetz.de>Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
tci: Fix broken builds with TCG interpreter
TCI no longer compiled after commit 76cad71136b7eb371cf2a2a4e1621cfe8d9c769a.
The TCI disassembler depends on data structures which are different foreach QEMU target, so it cannot be compiled as a universal-obj today....
savevm.c: cleanup system includes
savevm.c suffers from the same problem as some other files.Some years ago savevm.c was created from vl.c, moving somecode from there into a separate file. At that time, allincludes were just copied from vl.c to savevm.c, without...
disallow -daemonize usage of stdio (curses display, -nographic, -serial stdio etc)
Curses display requires stdin/out to stay on the terminal,so -daemonize makes no sense in this case. Instead ofleaving display uninitialized like is done since 995ee2bf469de6bb,...
Merge remote-tracking branch 'stefanha/block' into staging
tcg: Remove unneeded assertion
Commit 7f6f0ae5b95adfa76e10eabe2c34424a955fd10c added two assertions.
One of these assertions is not needed:The pointer ts is never NULL because it is initialized with theaddress of an array element.
Reviewed-by: Richard Henderson <rth@twiddle.net>...
sheepdog: pass oid directly to send_pending_req()
Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>Cc: Kevin Wolf <kwolf@redhat.com>Signed-off-by: Liu Yuan <tailai.ly@taobao.com>Reviewed-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
sheepdog: don't update inode when create_and_write fails
For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmapto avoid the scenario that the object is allocated but wasn't created at theserver side. This will result in VM's IO error on the failed object....
block/raw-win32: Fix compiler warnings (wrong format specifiers)
Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statementswith wrong format specifiers.
GetLastError() returns a DWORD which is unsigned long, so %lu must be used.
Signed-off-by: Stefan Weil <sw@weilnetz.de>...
qemu-img: report size overflow error message
qemu-img will complain when qcow or qcow2size overflow for 64 bits, report the rightmessage in this condition.
$./qemu-img create -f qcow2 /tmp/foo 0x10000000000000000before change:qemu-img: Invalid image size specified! You may use k, M, G or T suffixes for...
cutils: change strtosz_suffix_unit function
if value to be translated is larger than INT64_MAX,this function will not be convenient for caller tobe aware of it, so change a little for this.
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
virtio-blk: Return UNSUPP for unknown request types
Currently, all unknown requests are treated as VIRTIO_BLK_T_IN
Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
virtio-blk: add x-data-plane=on|off performance feature
The virtio-blk-data-plane feature is easy to integrate intohw/virtio-blk.c. The data plane can be started and stopped similar tovhost-net.
Users can take advantage of the virtio-blk-data-plane feature using the...
dataplane: add virtio-blk data plane code
virtio-blk-data-plane is a subset implementation of virtio-blk. It onlyhandles read, write, and flush requests. It does this using a dedicatedthread that executes an epoll(2)-based event loop and processes I/O...
virtio-blk: restore VirtIOBlkConf->config_wce flag
Two slightly different versions of a patch to conditionally setVIRTIO_BLK_F_CONFIG_WCE through the "config-wce" qdev property have beenapplied (ea776abca and eec7f96c2). David Gibson<david@gibson.dropbear.id.au> noticed that the "config-wce"...
test-iov: add iov_discard_front/back() testcases
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
iov: add qemu_iovec_concat_iov()
The qemu_iovec_concat() function copies a subset of a QEMUIOVector. Thenew qemu_iovec_concat_iov() function does the same for a iov/cnt pair.
It is easy to define qemu_iovec_concat() in terms ofqemu_iovec_concat_iov(). The existing code is mostly unchanged, except...
iov: add iov_discard_front/back() to remove data
The iov_discard_front/back() functions remove data from the front orback of the vector. This is useful when peeling off header/footerstructs.
dataplane: add Linux AIO request queue
The IOQueue has a pool of iocb structs and a function to add newread/write requests. Multiple requests can be added before calling thesubmit function to actually tell the host kernel to begin I/O. Thisallows callers to batch requests and submit them in one go....
dataplane: add event loop
Outside the safety of the global mutex we need to poll on filedescriptors. I found epoll(2) is a convenient way to do that, althoughother options could replace this module in the future (such as anAioContext-based loop or glib's GMainLoop)....
dataplane: add virtqueue vring code
The virtio-blk-data-plane cannot access memory using the usual QEMUfunctions since it executes outside the global mutex and the memory APIsare this time are not thread-safe.
This patch introduces a virtqueue module based on the kernel's vhost...
dataplane: add host memory mapping code
The data plane thread needs to map guest physical addresses to hostpointers. Normally this is done with cpu_physical_memory_map() but thefunction assumes the global mutex is held. The data plane thread doesnot touch the global mutex and therefore needs a thread-safe memory...
raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane
The raw_get_aio_fd() function allows virtio-blk-data-plane to get thefile descriptor of a raw image file with Linux AIO enabled. Thisinterface is really a layering violation that can be resolved once the...
configure: add CONFIG_VIRTIO_BLK_DATA_PLANE
The virtio-blk-data-plane feature only works with Linux AIO. Thereforeadd a ./configure option and necessary checks to implement thisdependency.
Merge remote-tracking branch 'qemu-kvm/uq/master' into staging
Merge remote-tracking branch 'mst/tags/for_anthony' into staging
pci,virtio
This optimizes MSIX handling in virtio-pci.Also included is pci express capability bugfix.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>...
Merge remote-tracking branch 'kraxel/seabios-a810e4e' into staging
pflash_cfi01: Suppress warning when Linux probes for AMD flash
There are several ARM and MIPS boards which are manufactured witheither Intel (pflash_cfi01.c) or AMD (pflash_cfi02.c) flash memory.
The Linux kernel supports both and first probes for AMD flash which...
target-mips: Use EXCP_SC rather than a magic number
From the discussion on the ML [1], the exception limit defined bymagic number 0x100 is actually EXCP_SC defined in cpu.h. Replace themagic number with EXCP_SC. Remove "#if 1 .. #endif" as well.
[1] http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03080.html...
target-mips: Make repl_ph to sign extend to target-long
The immediate value is 9bits, should sign-extend to 16bits. The return value toregister should sign-extend to target_long, as Richard says, removing anunnecessary cast works fun.
Signed-off-by: Dongxue Zhang <elta.era@gmail.com>...
Fix my email address
Fix my email address, last time it's wrong.
Signed-off-by: Dongxue Zhang <elta.era@gmail.com>Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
target-mips: Remove semicolon from macro definition
Macro RESTORE_FLUSH_MODE is similar to RESTORE_ROUNDING_MODEbut included a semicolon.
The code which uses that macro also includes a semicolon,so the result was an empty statement.
Remove the superfluous semicolon from the macro definition....
target-mips: Fix for helpers for EXTR_* instructions
The change removes some unnecessary and incorrect code for EXTR_S.H.Further, it corrects the mask for shift value in the EXTR_ instructions. It alsoextends the existing tests so they trigger the issues corrected with the change....
target-mips: Fix incorrect reads and writes to DSPControl register
Upper 4 bits of ccond (bits 31..28 ) of DSPControl register are not used inthe MIPS32 architecture. They are used in the MIPS64 architecture. For MIPS32these bits must be written as zero, and return zero on read....
Fix semaphores fallback code
As reported in bug 1087114 the semaphores fallback code is broken whichresults in QEMU crashing and making QEMU unusable.
This patch is from Paolo.
This needs to be back ported to the 1.3 stable tree as well.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>...
tcg-hppa: Fix typo in brcond2
Reported-by: Stuart Brady <sdb@zubnet.me.uk>Signed-off-by: Richard Henderson <rth@twiddle.net>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
tcg-i386: Perform cmov detection at runtime for 32-bit.
Existing compile-time detection is spotty at best. Convertit all to runtime detection instead.
Signed-off-by: Richard Henderson <rth@twiddle.net>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
tcg: Add TCGV_IS_UNUSED_*
Cc: Aurelien Jarno <aurelien@aurel32.net>Signed-off-by: Richard Henderson <rth@twiddle.net>Reviewed-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Disable semaphores fallback code for OpenBSD
Disable the semaphores fallback code for OpenBSD as modern OpenBSDreleases now have sem_timedwait().
Signed-off-by: Brad Smith <brad@comstyle.com>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
usb/redirect.c: unbreak compilation due to include/char/char.h
Broken since:
commit 927d4878b0ff319ed87fed9363f314613b0a5ed9Author: Paolo Bonzini <pbonzini@redhat.com>Date: Mon Dec 17 18:20:05 2012 +0100
softmmu: move remaining include files to include/ subdirectories...
Merge branch 'qom-cpu' of git://repo.or.cz/qemu/afaerber
msix: expose access to masked/pending state
For use by poll handler.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
virtio-pci: don't poll masked vectors
At the moment, when irqfd is in use but a vector is masked,qemu will poll it and handle vector masks in userspace.Since almost no one ever looks at the pending bits,it is better to defer this until pending bitsare actually read....
pcie: Fix bug in pcie_ext_cap_set_next
Upper 16 bits of the PCIe Extended Capability Header was truncated during update,also breaking pcie_add_capability.
Signed-off-by: Knut Omang <knut.omang@oracle.com>Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
msi: add API to get notified about pending bit poll
Update all users.
qemu-kvm/pci-assign: 64 bits bar emulation
Enable 64 bits bar emulation.
Test pass with the current seabios which already support 64bit pci bars.
Signed-off-by: Xudong Hao <xudong.hao@intel.com>Reviewed-by: Alex Williamson <alex.williamson@redhat.com>...
MAINTAINERS: Take over kvm maintenance
Replace Avi with myself as kvm maintainer.
Signed-off-by: Gleb Natapov <gleb@redhat.com>Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
configure: allow disabling pixman if not needed
When we build neither any system emulation targets nor the tools thereis actually no need for pixman library. In that case do not enforcepresence of that library on the system.
Reviewed-by: Andreas F=E4rber <afaerber@suse.de>...
tmp105: Create API for TMP105 temperature sensor.
Reviewed-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Alex Horn <alex.horn@cs.ox.ac.uk>...
build: Use separate makefile for "trace/"
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>--Changes in v2:
win32: Switch thread abstraction to us TLS variable internally
We already depend on working __thread support for coroutines, so thiscomplication here is no longer needed.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>...
target-i386: CPUID: return highest basic leaf if eax > cpuid_xlevel
This fixes a subtle bug. A bug that probably won't cause trouble for anyexisting OS, but a bug anyway:
Intel SDM Volume 2, CPUID Instruction states:
Two types of information are returned: basic and extended function...
qemu-char: Inherit ptys and improve output from -serial pty
Changes since V1: - Avoid crashing since qemu_opts_id() may return null on some systems according to Markus's suggestion.
When controlling a qemu instance from another program, it'shard to know which serial port or monitor device is redirected...
Merge branch 'master' of git://git.qemu.org/qemu into qom-cpu
Adapt header include paths.
Signed-off-by: Andreas Färber <afaerber@suse.de>
target-xtensa: fix search_pc for the last TB opcode
Zero out tcg_ctx.gen_opc_instr_start for instructions representing thelast guest opcode in the TB.
Cc: qemu-stable@nongnu.orgSigned-off-by: Max Filippov <jcmvbkbc@gmail.com>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
net: add missing include file
To fix building error:
CC net/vde.onet/vde.c: In function ‘vde_cleanup’:net/vde.c:65:5: error: implicit declaration of function ‘qemu_set_fd_handler’ [-Werror=implicit-function-declaration]net/vde.c:65:5: error: nested extern declaration of ‘qemu_set_fd_handler’ [-Werror=nested-externs]...
translate-all.c: Use tb1->phys_hash_next directly in tb_remove
When tb_remove was first commited at fd6ce8f6, there were three differentcalls pass different names to offsetof. In current codebase, the other twocalls are replaced with tb_page_remove. There is no need to have a general...
net: Add missing include statement (fix compiler warnings for MinGW)
These and some more compiler warnings were caused by a recent commit:
net/tap-win32.c:724: warning: no previous prototype for ‘tap_has_ufo’net/tap-win32.c:729: warning: no previous prototype for ‘tap_has_vnet_hdr’...
xen: add missing include
xen-all needs to access CharDeviceState's filename field, soit needs to include char/char.h.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Tested-by: Andreas Färber <afaerber@suse.de>Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
build: fix includes for VNC
vnc-tls.h is included by vnc.h, and it includes gnutls/gnutls.h.Hence, GnuTLS header files are needed by all files that includevnc.h, most notably qmp.c. Move these flags to QEMU_CFLAGS forsimplicity.
Reported-by: Peter Maydell <peter.maydell@linaro.org>...
Merge remote-tracking branch 'quintela/thread-20121220.next' into staging
ram: refactor ram_save_block() return value
It could only return 0 if we only found dirty xbzrle pages that hadn'tchanged (i.e. they were written with the same content). We don't careabout that case, it is the same than nothing dirty.
So now the return of the function is how much have it written, nothing...
migration: fix qemu_get_fd for BufferedFile
Not really used, but nice to have it correct. :)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Signed-off-by: Juan Quintela <quintela@redhat.com>
migration: merge QEMUFileBuffered into MigrationState
Avoid splitting the state of outgoing migration, more or less arbitrarily,between two data structures. QEMUFileBuffered anyway is used only duringmigration.