Statistics
| Branch: | Revision:

root / block @ de7890db

Name Size
bochs.c 7.3 kB
cloop.c 5 kB
cow.c 8.9 kB
curl.c 14.8 kB
dmg.c 8.2 kB
nbd.c 4.7 kB
parallels.c 4.8 kB
qcow.c 29.9 kB
qcow2-cluster.c 25.5 kB
qcow2-refcount.c 35.4 kB
qcow2-snapshot.c 12.4 kB
qcow2.c 38.4 kB
qcow2.h 6.7 kB
raw-posix-aio.h 1.3 kB
raw-posix.c 35.9 kB
raw-win32.c 11 kB
vdi.c 28.9 kB
vmdk.c 26.9 kB
vpc.c 17.2 kB
vvfat.c 80.1 kB

Latest revisions

# Date Author Comment
05121aed 02/23/2010 09:23 pm Kevin Wolf

qcow2: Factor next_refcount_table_size out

When the refcount table grows, it doesn't only grow by one entry but reserves
some space for future refcount blocks. The algorithm to calculate the number of
entries stays the same with the fixes, so factor it out before replacing the...
92dcb59f 02/23/2010 09:23 pm Kevin Wolf

qcow2: Rewrite alloc_refcount_block/grow_refcount_table

The current implementation of alloc_refcount_block and grow_refcount_table has
fundamental problems regarding error handling. There are some places where an
I/O error means that the image is going to be corrupted. I have found that the...
746c3cb5 02/23/2010 09:23 pm Kevin Wolf

qcow2: More checks for qemu-img check

Implement some more refcount block related checks

Signed-off-by: Kevin Wolf <>
Signed-off-by: Anthony Liguori <>
6f745bda 02/23/2010 09:23 pm Kevin Wolf

qcow2: Fix image creation regression

When checking for errors, commit db89119d compares with the wrong values,
failing image creation even when there was no error. Additionally, if an
error has occured, we can't preallocate the image (it's likely broken)....
4805bb66 02/19/2010 11:53 pm Kevin Wolf

qcow2: Fix access after end of array

If a write requests crosses a L2 table boundary and all clusters until the
end of the L2 table are usable for the request, we must not look at the next
L2 entry because we already have arrived at the end of the array....
6265eb26 02/10/2010 10:00 pm Jim Meyering

don't dereference NULL after failed strdup

Most of these are obvious NULL-deref bug fixes, for example,
the ones in these files:

block/curl.c
  net.c
  slirp/misc.c

and the first one in block/vvfat.c.
The others in block/vvfat.c may not lead to an immediate segfault, but I...
f4f0d391 02/10/2010 07:56 pm Kevin Wolf

qcow2: Fix signedness bugs

Checking for return codes < 0 isn't really going to work with unsigned
types. Use signed types instead.

Signed-off-by: Kevin Wolf <>
Signed-off-by: Anthony Liguori <>
48a402e6 02/08/2010 11:44 am malc

block/curl: %Z is not a valid conversion specifier

Signed-off-by: malc <>
d0f2c4c6 02/07/2010 01:03 am malc

Do not use dprintf

dprintf is already claimed by POSIX1, and on at least one system
is implemented as a macro

[1] http://www.opengroup.org/onlinepubs/9699919799/functions/dprintf.html

Signed-off-by: malc <>
053965c7 01/27/2010 12:41 am Kevin Wolf

block/raw-posix: Abort on pread beyond end of non-growable file

This shouldn't happen under any normal circumstances. However, it looks like
it's possible to achieve this with corrupted images. Without this patch
raw_pread is hanging in an endless loop in such cases....

View revisions

Also available in: Atom