hw/usb-net.c: Fix precedence bug when checking rndis_state
"!X == 2" is always false (spotted by Coverity), so the checksfor whether rndis is in the correct state would never fire.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
Merge remote-tracking branch 'kwolf/block-stable' into staging
hw/tc58128.c: Remove unnecessary check for g_malloc failure
Remove a check for g_malloc failing: this never happens.Also use g_malloc rather than g_malloc0 as we immediatelymemset the entire region and so zero-initialising it is pointless.Spotted by Coverity (see bug 887883)....
hw/pl061: Remove pointless comparison of array to null
Remove a pointless comparison of an array to null. (There isno need to check whether s->out[i] is non-null as qemu_set_irqwill do that for us.) Spotted by Coverity (see bug 887883).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>...
hw/pxa2xx.c: Fix handling of R/WC bits in PMCR
Fix a bug in handling the write-one-to-clear bits in the PMCRwhich meant that we would always clear the bit even if thevalue written was a zero. Spotted by Coverity (see bug 887883).
hw/arm_timer.c: Fix bounds check for Integrator timer accesses
There are only three counter/timers on the integrator board:correct the bounds check to avoid an array overrun. (Spottedby Coverity, see bug 887883).
hw/omap_intc.c: Avoid crash on access to nonexistent banked registers
Avoid a crash due to null pointer dereference if a guest attemptsto access banked registers for a nonexistent bank. Spotted byCoverity (see bug 887883).
hw/pc.c: Fix use-while-uninitialized of fd_type[]
Fix a use-while-uninitialized of the fd_type[] array (introducedin commit 34d4260e1, noticed by Coverity). This is more theoreticalthan practical, since it's quite hard to get here with floppy==NULL(the qdev_try_create() of the isa-fdc device has to fail)....
atapi: implement eject requests
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
scsi-disk: implement eject requests
View revisions
Also available in: Atom