History | View | Annotate | Download (7.8 kB)
pc_sysfw: Check for qemu_find_file() failure
pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happilycreates a drive without a medium.
When pc_system_flash_init() asks for its size, bdrv_getlength() failswith -ENOMEDIUM, which isn't checked either. It fails relatively...
softmmu: move include files to include/sysemu/
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Support default block interfaces per QEMUMachine
There are QEMUMachines that have neither IF_IDE nor IF_SCSI as adefault/standard interface to their block devices / drives. Therefore,this patch introduces a new field default_block_type per QEMUMachinestruct. The prior use_scsi field becomes thereby obsolete and is...
pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path
Harmless, because we the error inevitably leads to another, fatal onein pc_system_flash_init(): PC system firmware (pflash) not available.Fix it anyway.
Signed-off-by: Markus Armbruster <armbru@redhat.com>...
Rename target_phys_addr_t to hwaddr
target_phys_addr_t is unwieldly, violates the C standard (_t suffixes arereserved) and its purpose doesn't match the name (most target_phys_addr_taddresses are not target specific). Replace it with a finger-friendly,...
Un-inline fdctrl_init_isa()
Signed-off-by: Markus Armbruster <armbru@redhat.com>Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/pc_sysfw: Fix memory leak
Valgrind reported this memory leak which occured a few times.
Test scenario:
qemu-system-i386 (no arguments), only BIOS started, terminate withmonitor command (quit).
Signed-off-by: Stefan Weil <sw@weilnetz.de>Reviewed-by: Andreas Färber <afaerber@suse.de>
pc-sysfw: make sure to call qdev_init
We're not actually calling qdev_init for the pc-sysfw device. Since we createthe canonical path during realize, this was causing an assert to trigger whenattempting to read a link pointing to pc-sysfw.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/pc_sysfw: enable pc-sysfw as a qdev
Setup a pc-sysfw device type. It contains a singleproperty of 'rom_only' which is defaulted to enabled.
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/pc_sysfw: support system flash memory with pflash
Flash can be enabled by calling pc_system_firmware_initwith the system_flash_enabled parameter being non-zero.If system_flash_enabled is zero, then the older qemurom creation method will be used.
If flash is enabled and a pflash image is found, then...
pc_piix/pc_sysfw: enable flash by default
Now, the pc-sysfw:rom_only property will defaultto false which enables flash by default.
All pc types below pc-1.1 set rom_only to true.This prevents flash from being enabled on thesepc machine types.
For pc-1.1 rom_only will use the default (false),...
hw/pc: move rom init to pc_sysfw.c