Bump new upstream version
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Merge branch 'stable-2.6-ippool-hotplug-esi-nolvm-netxen' into debian-2.6
Fix vif-ganeti link
Take Makefile and configure magic from master
Add SHELL_ENV_INIT and XEN_CONFIG_DIR
Refactor NIC configuration scripts
Add new script vif-ganeti that could be used instead ofdefault vif-bridge in order NIC customization can be moreflexible.
Extract common code from kvm-ifup and insert it in a newfile net-common that is being sourced by kvm-ifup and...
Make NIC setup more flexible in case of Xen
For every NIC write down a file that contains NIC'sinfo (MAC, mode, link, network details), that canbe sourced by any vif script. The file location is:/var/run/ganeti/xen-hypervisor/nic/<domname>/<nicidx>....
Fix --no-lvm-support
Return -1 and not None for vg_size and vg_free and makevolume_group_name optional in cluster config object in Haskell.
Bump new version
Merge branch 'stable-2.6-ippool-hotplug-esi' into debian-2.6
Add KVM machine version as hv param
This is needed in case an instance must be booted with an exact type ofmachine version (due to e.g. outdated drivers). If this hv paramexplicitly defined (during instance creation/modification) then the kvmprocess will be started having this version for the -M option. Otherwise...
Merge remote branch 'google/stable-2.6' into stable-2.6-ippool-hotplug-esi
Add utility to format dictionary as key=value strings
This will be used in QA to format network interface parameters.
This is a cherry-pick of master commit eac9b7b8
Signed-off-by: Michael Hanselmann <hansmi@google.com>Reviewed-by: Guido Trotter <ultrotter@google.com>
Remove fixed FIXME
This was fixed in stable-2.6, commit 053c356
Signed-off-by: Guido Trotter <ultrotter@google.com>Reviewed-by: Iustin Pop <iustin@google.com>
QA: Support master-netdev and default NIC parameters
Requested in issue 337.
The parameter “bridge” was not documented and is therefore silentlyreplaced with “master-netdev”. A note is added to “qa-sample.json”describing how comments work.
This is a cherry-pick of master commit...
QA: Do not pass "--bridge" to "gnt-cluster init"
Commit ec0652a (June 2009) removed the option.
This is a cherry-pick of master commit784537390cd5b1c4f5f8fb9401a62eb23acce39b
Signed-off-by: Michael Hanselmann <hansmi@google.com>Reviewed-by: Iustin Pop <iustin@google.com>
Add machine version in kvm runtime file
kvm -M ? returns the supported machines (e.g. pc-1.1).Add _GetDefaultMachineVersion() function to get the default value.
Upon kvm runtime file creation (this is in _GenerateKVMRuntime() invokedonly in StartInstance()) append this info in kvm_cmd. During...
Merge branch 'stable-2.6' into stable-2.6-ippool-hotplug-esi
Final update of NEWS file for 2.6.2 and version bump
I'm already setting this to a release date of tomorrow, since QA onthe 2.6 branch has been clean.
Signed-off-by: Iustin Pop <iustin@google.com>Reviewed-by: Michael Hanselmann <hansmi@google.com>
Fix job completion with big job queues
Accidentally stumbled upon this while testing unrelated code on amachine with ~3K active jobs - the bash completion unittest washanging.
Upon investigation, it turns out that bash's ${var//pattern/repl/} isprobably quadratic in the size of input (or worse, even):...
confd: reduce noise during normal config reload
During a normal configuration update, done via write to temp file andrename, this is what confd logs (slightly edited for clarity):
2012-12-14 01:05:53: ganeti-confd INFO Loaded new config, serial 218662012-12-14 01:06:18: ganeti-confd INFO File lost, trying to re-establish notifier...
Change hbal handling of !auto_balance instances
Note: I'll add tests for this on the master branch, but not here.
Signed-off-by: Iustin Pop <iustin@google.com>Reviewed-by: Guido Trotter <ultrotter@google.com>
Small corrections in man pages
The only semantic change is the fix of the spelling of the option--ipolicy-disk-templates.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>Reviewed-by: Guido Trotter <ultrotter@google.com>
Fix gnt-instance(8) w.r.t. growable disk templates
This fixes Issue 257.
Signed-off-by: Iustin Pop <iustin@google.com>Reviewed-by: Helga Velroyen <helgav@google.com>
Stop verifying opcode results in dry_run mode
Commit 1ce03fb1 (“Add ht-based result checks to opcodes”) introducedinfrastructure for checking opcode results, and subsequent commitsimproved the list of opcodes which do declare a result, however thiswas not tested for dry-run mode operation....
Update NEWS for 2.6.2
This is in preparation for a 2.6.2 release.
Fix TypeError when unsetting OS parameters
When all OS parameters should be unset (“gnt-os modify -H -xen-pvmfoo”), a TypeError was raised. This fixes issue 311.
Update changelog to latest version
Support newstyple rbd commangd output
This patch is taken from ganeti mailing list: http://goo.gl/LgukY
Fix a bug introduced by resolving a conflict
In _GenerateDiskTemplate() we make use of params variable in caseof ExtStorage. Hotplug code conflicts here.
Merge branch 'stable-2.6-hotplug' into stable-2.6-ippool-hotplug-esi
Fix a minor bug in hypervisor
Conflicts: lib/cmdlib.py tools/cfgupgrade
Refactor hotplug implementation
Remove pci_pool from hotplug_info. Hypervisor decides the pci slotbased on current occupations.
cmdlib.py: don't use GetHypervisor
In cmdlib we must only use the hypervisor class, and never instantiateit. As such we have to call GetHypervisorClass instead, to avoidgetting an instance of it.
This fixes Issue 316, because init is not called from masterd...
Fix opcode validation for OpOobCommand.command
The 'command' attribute of the OpOobCommand command is defined with adefault value of None, but its validation requires a member ofconstants.OOB_COMMANDS, which doesn't accept None. This result in thefollowing error when submitting an opcode without the command:...
Fix typo in manpage for gnt-os
s/exists/exist/
Signed-off-by: Michael Hanselmann <hansmi@google.com>Reviewed-by: Michele Tartara <mtartara@google.com>
Remove unused code in cfgupgrade
gnt-instance.8: Add index to disk and nic removal
The text of the manpage explains that an index can be prepended to"remove" but the short help doesn't mention it. Adding it helps makingthe syntax clear.
Signed-off-by: Guido Trotter <ultrotter@google.com>...
Improve error message when migration status fail
Commit 6a1434d7 (“Make migration RPC non-blocking”) changed the APIfor reporting migration status, but has a small cosmetic bug: if themigration status if failure, but the RPC itself to get the statusdidn't fail, it shows the following error message:...
Fix type error in kvm/GetMigrationStatus
Commit 6a1434d7 (“Make migration RPC non-blocking”) changed fromraising HypervisorErrors to returning MigrationStatusobjects. However, these objects don't have an "info" attribute, sothey can't pass a reason back (which is in itself a bug); but the KVM...
Fix PID file writing in Haskell daemons
Currently, the code uses createFile, which has the effect of alwaystruncating the file. This is bad, as the content of the PID file iswiped even when we wouldn't be able to lock it!
We switch to openFd (createFile is just a wrapper over that), and we...
http/__init__.py: Remove extraneous argument
pylint complained, I fixed it, and unfortunately pushed too early.
rapi.testutils: Add utility to format HTTP headers
Once again this will be used by forthcoming RAPI test.
rapi.testutils: Return headers from mock utility
A newly added test for RAPI will also verify the returned headers. Atest in ganeti.rapi.client_unittest.py is split into smaller stand-alonetests.
http: Add wrapper for mimetools.Message
A newly added piece of code will also have to parse headers, so havingthis wrapper saves us from copying this part of code.
Add missing tests for commit f0d2286
Commit f0d2286 changed the logic ofgnt_instance._ConvertNicDiskModifications to also allow a parameternamed “modify”. Unfortunately the corresponding unittest was notupdated. An “if”/“else” condition is also merged....
Fix compatibility with newer Haskell libraries
This small patch fixes compatibility with a few newer Haskell libraries:
- base 4.6, included with ghc 7.6, removed the deprecated 'catch' function from Prelude, so our "import Prelude hiding (catch)" is now...
Hotplug: do not allow disk/0 to be hotplug-able
BIOS boots from first disk. If we enable hotplug in disk/0it will added at the end of PCI address space (slot 31). Ifanother disk gets added then it will be added just before andBIOS will try to boot from an non bootable device and the...
Fix gnt-instance console with xl
- Rename xm-console-wrapper to xen-console-wrapper- Pass the xen command to use as a parameter
Update debian/changelog
Add debian tree
Disable E1101 on ganeti/http/server.py:424
Fix live migration under xl
Until now the only way to make live migration work in conjunction with"xl" was to add ssh known_hosts keys for every node's secondary ip onevery other node.
With this command we remove the target key verification: this is not...
Don't check for xend port when using xl
If the toolstack is set to "xl" we shouldn't ping xend for livenessbefore attempting a live migration.
Signed-off-by: Guido Trotter <ultrotter@google.com>Reviewed-by: Michael Hanselmann <hansmi@google.com>Reviewed-by: Iustin Pop <iustin@google.com>
Conflicts: lib/cmdlib.py
Fix typo in gnt-instance man page
jqueue: Return jobs to queue when shutting down
When a job is still waiting for locks and the queue is shutting down,they should be returned and not actually start processing. Until nowjobs which transitioned from “queued” to “waiting” were alreadyconsidered to be running as far as the shutdown code was concerned....
gnt-debug delay: Add "--submit" option
Make hostname checks uniform between instance rename and add
Currently, we have instance rename doing extra checks on the hostname, to prevent accidental wrong renames; however, instance createdoesn't do these checks (issue 291), which (if DNS is misconfigured)...
Improve logging of new job submissions
This addresses issue 290: when receiving new jobs, logging isincomplete, and we don't have the job ID and/or summarieslogged. Only later, when the job is queried for or being processed, weknow more.
This is not good when troubleshooting, so let's improve the initial...
Improve handling of lock exceptions
There are two issues with lock exceptions right now:
- first, we don't log the original error; this is fine for now (locking.py always returns the same error here), but in general is brittle: if locking.py would start returning more information, we'd...
Add note about developing on a production machine
This is the bit of documentation missing for issue 170. Doingdevelopment on a machine which already has Ganeti installed kind ofworks, but only when the installed and the developed version are verysimilar, and even then it can be problematic....
Merge branch 'stable-2.6-ippool' into stable-2.6-ippool-hotplug-esi
Fix a bug intruduced when refactoring GenerateFree
Fix a typo in OpNetworkSetParams
Conflicts: lib/network.py
Introduce new basic type TStringNone
Check if a certain value is "none". This is used by opcodes thatunset an object's attribute (set it to None), for instanceOpNetworkSetParams.
Fix runtime memory increases
Commit 2c0af7da which added the runtime memory changes functionalityhad a small typo (wrong name); I've rewritten this to only compute thedelta once, for simplicity.
Use bitarray 0.8 interface
Simplify GenerateFree in network module
GenerateFree now returns the first available IP in the networkor raises AddressPoolError if it is full.
Replace string values with proper constants
_UnlockedCommitIp is used either for releasing or reserving anIP inside a network. New constants RELEASE_ACTION/RESERVE_ACTIONare used to decide which is the case.
Simplify mac generation funtions
Introduce new config method _UnlockedGetNetworkMACPrefix and refactororiginal _GenerateOneMAC so that it takes prefix as an optional argumentand returns a function that actually generates a MAC. If prefix is notgiven or None it uses the cluster level default....
Fix validation of vgname in OpClusterSetParams
This variable can be empty, when we want to disable LVM, so we can'tuse TMaybeString.
Fixes issue 285.
Fix removal of storage directory on shared file storage
This patch makes _RemoveDisks symmetric to _CreateDisks with respectto file-based storage: _CreateDisks uses "in constants.DTS_FILEBASED",whereas _RemoveDisks was not update and only uses "==constants.DT_FILE". This results in stale directories left on the...
Switch non-redundant check to disk template-based
Currently, the warning/notice about non-redundant instances in clusterverify is based non empty secondaries list (how old is this?); theproper way to check this nowadays is via DTS_MIRRORED.
Signed-off-by: Iustin Pop <iustin@google.com>...
Document the new --yes-do-it option for master-failover
Sorry, this should have gone in the previous commit, I forgot aboutit.
Signed-off-by: Iustin Pop <iustin@google.com>Reviewed-by: Bernardo Dal Seno <bdalseno@google.com>
Add option to force master-failover without voting
This fixes issue 282.
Update instance modify message
Currently the message does not say explicitly that instance-initiatedreboots are useless to trigger the use of new parameters, per thethread on the user mailing list. Let's improve it a bit.
Conflicts: lib/config.py
Hotplug: rpc only if instance is running
Intruduce new function _InstanceRunning().Fix *PCIInfo config methods to hold exclusively _config_lock andtake instance object as an argument.
Force tap's MAC prefix to "fe"
Setting a high prefix discourages the bridge from adopting the tap'sMAC. Xen is not affected by this since the MAC is forced to"fe:ff:ff:ff:ff:ff".
This addresses issue #217.
Fix a bug in LUNetworkAdd concering needed_locks
Fix network client to pass conflicts_check to the opcode.
Fix disk adoption interaction with ipolicy checks
In Ganeti 2.6, disk adoption is broken due to the ipolicy checks beingdone before we read volume size from remote nodes. We fix this bysimply moving these checks to after the disk adoption code whichupdates the disk size; it's not that nice that we fail a (almost)...
Better NEWS file for 2.6.1
Better formatting of text, past tense used when appropriate.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>Reviewed-by: Iustin Pop <iustin@google.com>Reviewed-by: Michael Hanselmann <hansmi@google.com>
Fix OP_RESULT for OP_NETWORK_QUERY
Allow passing 'none' for network_type option
Fixes to pass unittests (make check)
Conflicts:
doc/rapi.rst lib/ovf.py