Statistics
| Branch: | Revision:

root / hw / vmware_vga.c @ 1f56e32a

History | View | Annotate | Download (36.6 kB)

# Date Author Comment
5c81e4ca 02/12/2011 10:27 am Blue Swirl

vmware_vga: refactor device creation

Turn vmsvga_init into an inline function.

Signed-off-by: Blue Swirl <>
be92bbf7 01/10/2011 01:29 pm Gerd Hoffmann

vga: tag as not hotplugable.

This patch tags all vga cards as not hotpluggable. The qemu
standard vga will never ever be hotpluggable. For cirrus + vmware
it might be possible to get that work some day. Todays we can't
handle that for a number of reasons though....
2507c12a 12/11/2010 05:24 pm Alexander Graf

Add endianness as io mem parameter

As stated before, devices can be little, big or native endian. The
target endianness is not of their concern, so we need to push things
down a level.

This patch adds a parameter to cpu_register_io_memory that allows a
device to choose its endianness. For now, all devices simply choose...
281a26b1 11/21/2010 05:16 pm Gerd Hoffmann

vgabios update: handle compatibility with older qemu versions

As pointed out by avi the vgabios update is guest-visible and thus has
migration implications.

One change is that the vga has a valid pci rom bar now. We already have
a pci bus property to enable/disable the rom bar and we'll load the bios...
4eccfec4 11/16/2010 04:40 pm Gerd Hoffmann

switch vmware_vga to pci vgabios

Signed-off-by: Gerd Hoffmann <>
9f810beb 09/10/2010 03:30 am Andrzej Zaborowski

vmware_vga: Replace the few tab-indents with spaces (clean-up).

Use 4 spaces instead of 2, too.
4dedc07f 09/10/2010 03:23 am Andrzej Zaborowski

vmware_vga: Add checks to deal with non-atomic fifo writes.

Janne Huttunen noticed that the FIFO end pointer is updated by the
guest after writing each word to the FIFO, at least the X.org driver
which is open does this. This means that there's no way for the...
bd57ce8c 07/11/2010 11:15 pm Michael S. Tsirkin

vmware_vga: fix reset value for command register

Make init value for this register match the spec.
BAR address is 0 at init, so enabling it
only works by chance.

Signed-off-by: Michael S. Tsirkin <>
b80d4a98 07/11/2010 08:00 pm Isaku Yamahata

pci: don't overwrite multi functio bit in pci header type.

Don't overwrite pci header type.
Otherwise, multi function bit which pci_init_header_type() sets
appropriately is lost.
Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero
which is already zero cleared....
0be71e32 07/06/2010 06:36 pm Alex Williamson

savevm: Add DeviceState param

When available, we'd like to be able to access the DeviceState
when registering a savevm. For buses with a get_dev_path()
function, this will allow us to create more unique savevm
id strings.

Signed-off-by: Alex Williamson <>...
1724f049 07/06/2010 06:36 pm Alex Williamson

qemu_ram_alloc: Add DeviceState and name parameters

These will be used to generate unique id strings for ramblocks. The name
field is required, the device pointer is optional as most callers don't
have a device. When there's no device or the device isn't a child of...
fbe6d7a4 05/24/2010 11:18 pm Gerd Hoffmann

use new cursor struct + functions for vmware vga and sdl.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>
f2d928d4 01/11/2010 05:56 pm Roland Dreier

vmware_vga: Check cursor dimensions passed from guest to avoid buffer overflow

Check that the cursor dimensions passed from the guest for the
DEFINE_CURSOR command don't overflow the available space in the
cursor.image[] or cursor.mask[] arrays before copying data from the...
3fa0f955 12/23/2009 04:35 pm Michael S. Tsirkin

vmware_vga: symbolic names for pci registers

No functional changes. I verified that the generated binary
does not change.

Signed-off-by: Michael S. Tsirkin <>
Acked-by: Juan Quintela <>
Acked-by: Glauber Costa <>
b5cc6e32 12/18/2009 07:26 pm Anthony Liguori

VMware VGA: Only enable dirty log tracking when fifo is disabled

This patch enables dirty log tracking whenever it's needed and disables it
when it is not.

We unconditionally enable dirty log tracking on reset, restart dirty log
tracking when PCI IO regions are remapped, and disable/enable it based on...
8095cb3e 12/18/2009 07:26 pm Dave Airlie

vmware: increase cursor buffer size.

The cursor pixmap size we calculate later ends up being 4096 dwords
long by the looks of it. This boots an F12 LiveCD now.

Signed-off-by: Dave Airlie <>
Signed-off-by: Anthony Liguori <>
ee3e41a9 12/18/2009 07:26 pm Anthony Liguori

Make sure to enable dirty log tracking for VMware VGA

This is needed for VMware VGA to work properly under KVM.

Signed-off-by: Anthony Liguori <>
a6109ff1 12/18/2009 07:26 pm Anthony Liguori

Fix VMware VGA depth computation

VMware VGA requires that the depth presented to the guest is the same as the
DisplaySurface that it renders to. This is because it performs a very simple
memcpy() to blit from one surface to another.

We currently hardcode a 24-bit depth. The surface allocator for SDL may, and...
f351d050 12/18/2009 07:26 pm Dave Airlie

vmware: setup PCI BAR 2 for FIFO as per vmware spec

Signed-off-by: Anthony Liguori <>
f0138a63 12/18/2009 07:26 pm Anthony Liguori

Make sure to enable dirty tracking of VBE vram mapping

Apparently, VBE maps the VGA vram to a fixed physical location. KVM requires
that all mappings of the VGA vram have dirty tracking enabled on them. Any
access to the VGA vram through the VBE mapping currently fails to result in...
556cd098 12/12/2009 03:59 pm Markus Armbruster

qdev: Replace device names containing whitespace

Device names with whitespace require quoting in the shell and in the
monitor. Some of the offenders are also overly long. Some have a
more convenient alias, some don't.

The place for verbose device names is DeviceInfo member desc. The...
b3c3f123 12/12/2009 03:59 pm Dave Airlie

vmware_vga: add rom file so that it boots.

This just adds the rom file to the vmware SVGA chipset so it boots.

Signed-off-by: Dave Airlie <>
Signed-off-by: Anthony Liguori <>
d05ac8fa 12/04/2009 10:44 pm Blue Swirl

Add "static" to please Sparse

Signed-off-by: Blue Swirl <>
be73cfe2 12/03/2009 06:05 pm Juan Quintela

savevm: Port to qdev.vmsd all devices that have qdev

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
18e08a55 12/01/2009 05:51 pm Michael S. Tsirkin

pci: pci.h cleanup: move out stuff not in pci.c

pci.h declares some functions which aren't
defined in pci.h. Clean up moving things
to appropriate headers, and update all users.

Signed-off-by: Michael S. Tsirkin <>
6e355d90 11/09/2009 04:43 pm Isaku Yamahata

pci: introduce pcibus_t to represent pci bus address/size instead of uint32_t

This patch is preliminary for 64 bit BAR support.
Introduce dedicated type, pcibus_t, to represent pci bus address/size
instead of uint32_t.
Later this type will be changed to uint64_t....
0392a017 11/09/2009 04:43 pm Isaku Yamahata

pci: s/PCI_ADDRESS_SPACE_/PCI_BASE_ADDRESS_SPACE_/ to match pci_regs.h

make constants for pci base address match pci_regs.h by
renaming PCI_ADDRESS_SPACE_xxx to PCI_BASE_ADDRESS_SPACE_xxx.

Signed-off-by: Isaku Yamahata <>
Acked-by: Michael S. Tsirkin <>...
bacbe284 10/27/2009 07:28 pm Juan Quintela

vmware_vga: port to vmstate

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
467d44b2 10/27/2009 07:28 pm Juan Quintela

vmware_vga: Remove uselss casts from void *

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
fe740c43 10/27/2009 07:28 pm Juan Quintela

vmware_vga: qemu_malloc() returns void *

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
83ef8fe0 10/27/2009 07:28 pm Juan Quintela

vmware_vga: remove !EMBED_STDVGA code

It don't compile. And the trivial fixes (change vga.foo field to foo field
don't work either. No output

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
0c681322 10/27/2009 07:28 pm Juan Quintela

vmware_vga: scratch is really an array of uint32_t

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
3b1297f5 10/27/2009 07:28 pm Juan Quintela

vmware_vga: the support to change dinamically depth is not there

For a start bypp is not changed after vmsvga_reset() and it depends on depth

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
f74599c4 10/27/2009 07:28 pm Juan Quintela

vga: port vmware std vga to vmstate

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
c89507f7 10/27/2009 07:28 pm Juan Quintela

vmware_vga: Pass pci_vmsga_state_t arg no VGACommonState

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
c227f099 10/02/2009 12:12 am Anthony Liguori

Revert "Get rid of _t suffix"

In the very least, a change like this requires discussion on the list.

The naming convention is goofy and it causes a massive merge problem. Something
like this must be presented on the list first so people can provide input...
99a0949b 10/01/2009 09:45 pm malc

Get rid of _t suffix

Some not so obvious bits, slirp and Xen were left alone for the time
being.

Signed-off-by: malc <>
0d65ddc3 09/09/2009 10:55 pm Juan Quintela

vga: split vga_{load, save} into pci and common parts

Once there adjust VGAState <-> VGACommonState
Export vga_common_save/vga_common_load (nreeded by wmvare_vga
Remove vga.pci_dev field, it is not needed anymore

Signed-off-by: Juan Quintela <>...
a4a2f59c 08/28/2009 04:46 am Juan Quintela

Everything outside of vga.c should use VGACommonState

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>
81a322d4 08/28/2009 04:43 am Gerd Hoffmann

qdev: add return value to init() callbacks.

Sorry folks, but it has to be. One more of these invasive qdev patches.

We have a serious design bug in the qdev interface: device init
callbacks can't signal failure because the init() callback has no
return value. This patch fixes it....
d60efc6b 08/25/2009 09:29 pm Blue Swirl

Make CPURead/WriteFunc structure 'const'

Signed-off-by: Blue Swirl <>
4445b0a6 08/23/2009 08:00 pm Andrzej Zaborowski

Revert my commit c00a9de060124a988bd9847c095e5836488c6f01

was incorrect.
c00a9de0 08/23/2009 07:00 pm Reimar Döffinger

Use corect depth from DisplaySurface in vmware_vga.c

Hello,
for what I can tell, there is no way for vmware_vga to work correctly
right now. It assumes that the framebuffer bits-per-pixel and the one
from the DisplaySurface are identical (it uses directly the VRAM from...
a414c306 07/30/2009 05:50 pm Gerd Hoffmann

qdev: convert all vga devices.

Signed-off-by: Gerd Hoffmann <>
Signed-off-by: Anthony Liguori <>
9391e4b8 06/22/2009 06:15 pm Isaku Yamahata

vmware_vga: clean up

use NULL instead of 0 for pci_register_device() argument
for consistency. Any other caller uses NULL.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Anthony Liguori <>
28c2c264 06/16/2009 11:18 pm Avi Kivity

Rename pci_register_io_region() to pci_register_bar()

This function is used to manage a PCI BAR, so make the more generic
pci_register_io_region() available to other uses.

Signed-off-by: Avi Kivity <>
Signed-off-by: Anthony Liguori <>
1eed09cb 06/16/2009 11:18 pm Avi Kivity

Remove io_index argument from cpu_register_io_memory()

The parameter is always zero except when registering the three internal
io regions (ROM, unassigned, notdirty). Remove the parameter to reduce
the API's power, thus facilitating future change.

Signed-off-by: Avi Kivity <>...
fbe1b595 05/13/2009 07:56 pm Paul Brook

Remove vga_ram_size

The vga_ram_size argument to machine init functions always has the same
value, and is ignored by many machines (including SPARC32 which has an
obsolete ifdef for VGA_RAM_SIZE).

Remove it and push VGA_RAM_SIZE into vga_int.h.

Signed-off-by: Paul Brook <>
4e12cd94 05/09/2009 12:11 am Avi Kivity

vga: Replace VGA_COMMON with a structure

All VGA devices share a common field subset; currently they do so by
a macro which defines the common fields inline their state structures,
relying on the the common state being placed at offset 0 in the structure....
6407f373 05/03/2009 10:03 pm Isaku Yamahata

use PCI_HEADER_TYPE.

use symbolic value instead of 0x0e and related value.

Signed-off-by: Isaku Yamahata <>
b584726d 04/10/2009 05:24 am pbrook

Clean up VGA ram allocation.

Signed-off-by: Paul Brook <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@7063 c046a42c-6fe2-441c-8c8c-71466251a162
511d2b14 03/07/2009 05:32 pm blueswir1

Sparse fixes: NULL use, header order, ANSI prototypes, static

Fix Sparse warnings: * use NULL instead of plain 0 * rearrange header include order to avoid redefining types accidentally * ANSIfy SLIRP * avoid "restrict" keyword * add static

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6736 c046a42c-6fe2-441c-8c8c-71466251a162
173a543b 02/01/2009 09:26 pm blueswir1

Add and use #defines for PCI device classes

This patch adds and uses #defines for PCI device classes and subclases,
using a new pci_config_set_class() function, similar to the recently
added pci_config_set_vendor_id() and pci_config_set_device_id().

Change since v1: fixed compilation of hw/sun4u.c...
deb54399 01/26/2009 05:37 pm aliguori

Define PCI vendor and device IDs in pci.h (Stuart Brady)

This patch defines PCI vendor and device IDs in pci.h (matching those
from Linux's pci_ids.h), and uses those definitions where appropriate.

Change from v1:
Introduces pci_config_set_vendor_id() / pci_config_set_device_id()...
e07d630a 01/16/2009 09:07 pm aliguori

fix screendump (Stefano Stabellini)

this patch fixes the screendump functionality that was recently broken;
it must be applied after PATCH 5, 6 and 7 of the original displaystate
change patch series.
In fact the other patches make much easier to solve the screendump...
3023f332 01/16/2009 09:04 pm aliguori

graphical_console_init change (Stefano Stabellini)

Patch 5/7

This patch changes the graphical_console_init function to return an
allocated DisplayState instead of a QEMUConsole.

This patch contains just the graphical_console_init change and few other
modifications mainly in console.c and vl.c....
b1503cda 12/22/2008 10:33 pm malc

Use the ARRAY_SIZE() macro where appropriate.

Change from v1:
Avoid changing the existing coding style in certain files.

Signed-off-by: Stuart Brady <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6120 c046a42c-6fe2-441c-8c8c-71466251a162
8da3ff18 12/01/2008 08:59 pm pbrook

Change MMIO callbacks to use offsets, not absolute addresses.

Signed-off-by: Paul Brook <>

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5849 c046a42c-6fe2-441c-8c8c-71466251a162
0e1f5a0c 11/24/2008 09:29 pm aliguori

Introduce accessors for DisplayState (Stefano Stabellini)

Introducing some accessors:

ds_get_linesize
ds_get_bits_per_pixel
ds_get_width
ds_get_height
ds_get_data

Signed-off-by: Stefano Stabellini <>
Signed-off-by: Anthony Liguori <>...
38334f76 09/24/2008 05:21 am balrog

Don't use ds->dpy_copy directly from hw/ (Jan Niehusmann).

I left a TODO in the code because this still doesn't definitely
fix all issues.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5308 c046a42c-6fe2-441c-8c8c-71466251a162
ff9cf2cb 07/16/2008 07:45 am balrog

Properly byte-swap values in VMware SVGA (malc).

Makes PPC host happy. Also use the right type for a memory offset.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4874 c046a42c-6fe2-441c-8c8c-71466251a162
931ea435 07/16/2008 07:38 am balrog

Make Bochs VBE work with VMWare SVGA (malc).

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4873 c046a42c-6fe2-441c-8c8c-71466251a162
4fb3fbc2 07/16/2008 07:36 am balrog

Don't overwrite VMwareSVGA's memory region start addresses (malc).

This was correct also in the Anthony Liguori's patch, but not in mine.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4872 c046a42c-6fe2-441c-8c8c-71466251a162
e93a5f4f 07/16/2008 07:31 am balrog

Initialize the VMware VGA console after vga_init (Alexander Graf).

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4871 c046a42c-6fe2-441c-8c8c-71466251a162
c60e08d9 07/01/2008 07:24 pm pbrook

Implement resolution switching in common console code.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4812 c046a42c-6fe2-441c-8c8c-71466251a162
6f9bc132 04/13/2008 02:49 am balrog

Allocate the -vmwarevga framebuffer in the right place in RAM.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4200 c046a42c-6fe2-441c-8c8c-71466251a162
2408b77b 04/04/2008 08:16 pm aurel32

vmwarevga: fix PCI IO region registration

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4161 c046a42c-6fe2-441c-8c8c-71466251a162
a8fbaf96 03/06/2008 10:43 pm balrog

Check for out of range update regions (original patch from Anthony Liguori).

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4024 c046a42c-6fe2-441c-8c8c-71466251a162
3016d80b 03/06/2008 10:28 pm balrog

Register VMware SVGA's memory io region with PCI framework.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@4023 c046a42c-6fe2-441c-8c8c-71466251a162
4d3b6f6e 02/10/2008 06:33 pm balrog

Add an ncurses UI.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3976 c046a42c-6fe2-441c-8c8c-71466251a162
1492a3c4 01/14/2008 03:52 am balrog

Register io ports as selected by PCI config in VMware SVGA.
Should prevent segfaults with RTL8139.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3905 c046a42c-6fe2-441c-8c8c-71466251a162
bee8d684 12/17/2007 01:41 am ths

qemu_put signedness fixes, by Andre Przywara.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3824 c046a42c-6fe2-441c-8c8c-71466251a162
87ecb68b 11/17/2007 07:14 pm pbrook

Break up vl.h.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3674 c046a42c-6fe2-441c-8c8c-71466251a162
f707cfba 05/13/2007 04:26 pm balrog

Allow VMware-SVGA operation enable before command FIFO is configured. Implement "screendump" for 32 bit colour depth.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@2808 c046a42c-6fe2-441c-8c8c-71466251a162
1f72aae5 05/03/2007 01:09 pm balrog

Change the PCI IO region start to that hardcoded in VBE bios (reported by Jeremy Katz)

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@2768 c046a42c-6fe2-441c-8c8c-71466251a162
d34cab9f 04/02/2007 04:10 am ths

VMware SVGA II emulation, by Andrzej Zaborowski.

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@2579 c046a42c-6fe2-441c-8c8c-71466251a162